[INFO] crate integrity-checker 0.1.0 is already in cache [INFO] extracting crate integrity-checker 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/integrity-checker/0.1.0 [INFO] extracting crate integrity-checker 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/integrity-checker/0.1.0 [INFO] validating manifest of integrity-checker-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of integrity-checker-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing integrity-checker-0.1.0 [INFO] finished frobbing integrity-checker-0.1.0 [INFO] frobbed toml for integrity-checker-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/integrity-checker/0.1.0/Cargo.toml [INFO] started frobbing integrity-checker-0.1.0 [INFO] finished frobbing integrity-checker-0.1.0 [INFO] frobbed toml for integrity-checker-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/integrity-checker/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting integrity-checker-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/integrity-checker/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e24911b4341f78539553bf22aca75b1865a7f9b072ec9123de6201db81a73d26 [INFO] running `"docker" "start" "-a" "e24911b4341f78539553bf22aca75b1865a7f9b072ec9123de6201db81a73d26"` [INFO] [stderr] Checking jsonway v2.0.0 [INFO] [stderr] Checking publicsuffix v1.5.2 [INFO] [stderr] Checking criterion v0.2.9 [INFO] [stderr] Checking integrity-checker v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Compiling valico v2.4.1 [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/database.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | changed [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/database.rs:64:23 [INFO] [stderr] | [INFO] [stderr] 64 | let changed = changed || [INFO] [stderr] | _______________________^ [INFO] [stderr] 65 | | (self.blake2b.is_some() && new.blake2b.is_some() && self.blake2b != new.blake2b); [INFO] [stderr] | |____________________________________________________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/database.rs:216:40 [INFO] [stderr] | [INFO] [stderr] 216 | self.entry(key).or_insert_with(|| V::default()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `V::default` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/database.rs:238:21 [INFO] [stderr] | [INFO] [stderr] 238 | / match entries.insert(first, file) { [INFO] [stderr] 239 | | Some(_) => unreachable!(), // See above [INFO] [stderr] 240 | | None => (), [INFO] [stderr] 241 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Some(_) = entries.insert(first, file) { unreachable!() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/database.rs:506:17 [INFO] [stderr] | [INFO] [stderr] 506 | let ref mut total_bytes = *total_bytes.lock().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^-------------------------------- help: try: `let total_bytes = &mut (*total_bytes.lock().unwrap());` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/database.rs:507:17 [INFO] [stderr] | [INFO] [stderr] 507 | let ref mut database = *database.lock().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^----------------------------- help: try: `let database = &mut (*database.lock().unwrap());` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/database.rs:532:13 [INFO] [stderr] | [INFO] [stderr] 532 | let ref database = *database.lock().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^----------------------------- help: try: `let database = &(*database.lock().unwrap());` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:96:16 [INFO] [stderr] | [INFO] [stderr] 96 | Features { sha2: sha2, blake2b: blake2b } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sha2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:96:28 [INFO] [stderr] | [INFO] [stderr] 96 | Features { sha2: sha2, blake2b: blake2b } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `blake2b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:96:16 [INFO] [stderr] | [INFO] [stderr] 96 | Features { sha2: sha2, blake2b: blake2b } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sha2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:96:28 [INFO] [stderr] | [INFO] [stderr] 96 | Features { sha2: sha2, blake2b: blake2b } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `blake2b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:237:12 [INFO] [stderr] | [INFO] [stderr] 237 | writeln!(io::stderr(), "error: {:?}", err).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/database.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | changed [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/database.rs:64:23 [INFO] [stderr] | [INFO] [stderr] 64 | let changed = changed || [INFO] [stderr] | _______________________^ [INFO] [stderr] 65 | | (self.blake2b.is_some() && new.blake2b.is_some() && self.blake2b != new.blake2b); [INFO] [stderr] | |____________________________________________________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/database.rs:216:40 [INFO] [stderr] | [INFO] [stderr] 216 | self.entry(key).or_insert_with(|| V::default()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `V::default` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/database.rs:238:21 [INFO] [stderr] | [INFO] [stderr] 238 | / match entries.insert(first, file) { [INFO] [stderr] 239 | | Some(_) => unreachable!(), // See above [INFO] [stderr] 240 | | None => (), [INFO] [stderr] 241 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Some(_) = entries.insert(first, file) { unreachable!() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/database.rs:506:17 [INFO] [stderr] | [INFO] [stderr] 506 | let ref mut total_bytes = *total_bytes.lock().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^-------------------------------- help: try: `let total_bytes = &mut (*total_bytes.lock().unwrap());` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/database.rs:507:17 [INFO] [stderr] | [INFO] [stderr] 507 | let ref mut database = *database.lock().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^----------------------------- help: try: `let database = &mut (*database.lock().unwrap());` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/database.rs:532:13 [INFO] [stderr] | [INFO] [stderr] 532 | let ref database = *database.lock().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^----------------------------- help: try: `let database = &(*database.lock().unwrap());` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:237:12 [INFO] [stderr] | [INFO] [stderr] 237 | writeln!(io::stderr(), "error: {:?}", err).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.27s [INFO] running `"docker" "inspect" "e24911b4341f78539553bf22aca75b1865a7f9b072ec9123de6201db81a73d26"` [INFO] running `"docker" "rm" "-f" "e24911b4341f78539553bf22aca75b1865a7f9b072ec9123de6201db81a73d26"` [INFO] [stdout] e24911b4341f78539553bf22aca75b1865a7f9b072ec9123de6201db81a73d26