[INFO] crate integer-encoding 1.0.5 is already in cache [INFO] extracting crate integer-encoding 1.0.5 into work/ex/clippy-test-run/sources/stable/reg/integer-encoding/1.0.5 [INFO] extracting crate integer-encoding 1.0.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/integer-encoding/1.0.5 [INFO] validating manifest of integer-encoding-1.0.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of integer-encoding-1.0.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing integer-encoding-1.0.5 [INFO] finished frobbing integer-encoding-1.0.5 [INFO] frobbed toml for integer-encoding-1.0.5 written to work/ex/clippy-test-run/sources/stable/reg/integer-encoding/1.0.5/Cargo.toml [INFO] started frobbing integer-encoding-1.0.5 [INFO] finished frobbing integer-encoding-1.0.5 [INFO] frobbed toml for integer-encoding-1.0.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/integer-encoding/1.0.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting integer-encoding-1.0.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/integer-encoding/1.0.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 305e5958fe567e2a7341bb6120a9871853fd2ac9e984ad370dfbaac4a4552c65 [INFO] running `"docker" "start" "-a" "305e5958fe567e2a7341bb6120a9871853fd2ac9e984ad370dfbaac4a4552c65"` [INFO] [stderr] Checking integer-encoding v1.0.5 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/varint.rs:2:21 [INFO] [stderr] | [INFO] [stderr] 2 | pub const MSB: u8 = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/varint.rs:3:22 [INFO] [stderr] | [INFO] [stderr] 3 | const DROP_MSB: u8 = 0b01111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/varint.rs:2:21 [INFO] [stderr] | [INFO] [stderr] 2 | pub const MSB: u8 = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/varint.rs:3:22 [INFO] [stderr] | [INFO] [stderr] 3 | const DROP_MSB: u8 = 0b01111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/varint_tests.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | assert_eq!((2097151 as u32).required_space(), 3); [INFO] [stderr] | ^^^^^^^ help: consider: `2_097_151` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/varint_tests.rs:14:21 [INFO] [stderr] | [INFO] [stderr] 14 | assert_eq!((2097152 as u32).required_space(), 4); [INFO] [stderr] | ^^^^^^^ help: consider: `2_097_152` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/varint_tests.rs:19:54 [INFO] [stderr] | [INFO] [stderr] 19 | assert_eq!((0 as u32).encode_var_vec(), vec![0b00000000]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/varint_tests.rs:20:56 [INFO] [stderr] | [INFO] [stderr] 20 | assert_eq!((300 as u32).encode_var_vec(), vec![0b10101100, 0b00000010]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/varint_tests.rs:20:68 [INFO] [stderr] | [INFO] [stderr] 20 | assert_eq!((300 as u32).encode_var_vec(), vec![0b10101100, 0b00000010]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/varint_tests.rs:45:22 [INFO] [stderr] | [INFO] [stderr] 45 | assert_eq!((-2147483648 as i64).encode_var_vec(), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/varint_tests.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | (4294967295 as u64).encode_var_vec()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/varint_tests.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | let i3: u32 = 4200123456; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_200_123_456` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/fixed.rs:22:28 [INFO] [stderr] | [INFO] [stderr] 22 | fn decode_fixed_vec(v: &Vec) -> Self { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:36:40 [INFO] [stderr] | [INFO] [stderr] 36 | let encoded = unsafe { transmute::<&$t, &[u8; $sz]>(&self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self as *const usize as *const [u8; 8])` [INFO] [stderr] ... [INFO] [stderr] 52 | impl_fixedint!(usize, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | let cast = unsafe { transmute::<&mut $t, &mut [u8; $sz]>(&mut decoded) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut decoded as *mut usize as *mut [u8; 8])` [INFO] [stderr] ... [INFO] [stderr] 52 | impl_fixedint!(usize, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/fixed.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | for i in 0..$sz { [INFO] [stderr] | ^ help: try replacing the loop by: `cast[..8].clone_from_slice(&src[..8])` [INFO] [stderr] ... [INFO] [stderr] 52 | impl_fixedint!(usize, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:36:40 [INFO] [stderr] | [INFO] [stderr] 36 | let encoded = unsafe { transmute::<&$t, &[u8; $sz]>(&self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self as *const u64 as *const [u8; 8])` [INFO] [stderr] ... [INFO] [stderr] 53 | impl_fixedint!(u64, 8); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | let cast = unsafe { transmute::<&mut $t, &mut [u8; $sz]>(&mut decoded) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut decoded as *mut u64 as *mut [u8; 8])` [INFO] [stderr] ... [INFO] [stderr] 53 | impl_fixedint!(u64, 8); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/fixed.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | for i in 0..$sz { [INFO] [stderr] | ^ help: try replacing the loop by: `cast[..8].clone_from_slice(&src[..8])` [INFO] [stderr] ... [INFO] [stderr] 53 | impl_fixedint!(u64, 8); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:36:40 [INFO] [stderr] | [INFO] [stderr] 36 | let encoded = unsafe { transmute::<&$t, &[u8; $sz]>(&self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self as *const u32 as *const [u8; 4])` [INFO] [stderr] ... [INFO] [stderr] 54 | impl_fixedint!(u32, 4); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | let cast = unsafe { transmute::<&mut $t, &mut [u8; $sz]>(&mut decoded) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut decoded as *mut u32 as *mut [u8; 4])` [INFO] [stderr] ... [INFO] [stderr] 54 | impl_fixedint!(u32, 4); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/fixed.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | for i in 0..$sz { [INFO] [stderr] | ^ help: try replacing the loop by: `cast[..4].clone_from_slice(&src[..4])` [INFO] [stderr] ... [INFO] [stderr] 54 | impl_fixedint!(u32, 4); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:36:40 [INFO] [stderr] | [INFO] [stderr] 36 | let encoded = unsafe { transmute::<&$t, &[u8; $sz]>(&self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self as *const u16 as *const [u8; 2])` [INFO] [stderr] ... [INFO] [stderr] 55 | impl_fixedint!(u16, 2); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | let cast = unsafe { transmute::<&mut $t, &mut [u8; $sz]>(&mut decoded) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut decoded as *mut u16 as *mut [u8; 2])` [INFO] [stderr] ... [INFO] [stderr] 55 | impl_fixedint!(u16, 2); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/fixed.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | for i in 0..$sz { [INFO] [stderr] | ^ help: try replacing the loop by: `cast[..2].clone_from_slice(&src[..2])` [INFO] [stderr] ... [INFO] [stderr] 55 | impl_fixedint!(u16, 2); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:36:40 [INFO] [stderr] | [INFO] [stderr] 36 | let encoded = unsafe { transmute::<&$t, &[u8; $sz]>(&self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self as *const isize as *const [u8; 8])` [INFO] [stderr] ... [INFO] [stderr] 56 | impl_fixedint!(isize, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | let cast = unsafe { transmute::<&mut $t, &mut [u8; $sz]>(&mut decoded) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut decoded as *mut isize as *mut [u8; 8])` [INFO] [stderr] ... [INFO] [stderr] 56 | impl_fixedint!(isize, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/fixed.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | for i in 0..$sz { [INFO] [stderr] | ^ help: try replacing the loop by: `cast[..8].clone_from_slice(&src[..8])` [INFO] [stderr] ... [INFO] [stderr] 56 | impl_fixedint!(isize, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:36:40 [INFO] [stderr] | [INFO] [stderr] 36 | let encoded = unsafe { transmute::<&$t, &[u8; $sz]>(&self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self as *const i64 as *const [u8; 8])` [INFO] [stderr] ... [INFO] [stderr] 57 | impl_fixedint!(i64, 8); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | let cast = unsafe { transmute::<&mut $t, &mut [u8; $sz]>(&mut decoded) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut decoded as *mut i64 as *mut [u8; 8])` [INFO] [stderr] ... [INFO] [stderr] 57 | impl_fixedint!(i64, 8); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/fixed.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | for i in 0..$sz { [INFO] [stderr] | ^ help: try replacing the loop by: `cast[..8].clone_from_slice(&src[..8])` [INFO] [stderr] ... [INFO] [stderr] 57 | impl_fixedint!(i64, 8); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:36:40 [INFO] [stderr] | [INFO] [stderr] 36 | let encoded = unsafe { transmute::<&$t, &[u8; $sz]>(&self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self as *const i32 as *const [u8; 4])` [INFO] [stderr] ... [INFO] [stderr] 58 | impl_fixedint!(i32, 4); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | let cast = unsafe { transmute::<&mut $t, &mut [u8; $sz]>(&mut decoded) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut decoded as *mut i32 as *mut [u8; 4])` [INFO] [stderr] ... [INFO] [stderr] 58 | impl_fixedint!(i32, 4); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/fixed.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | for i in 0..$sz { [INFO] [stderr] | ^ help: try replacing the loop by: `cast[..4].clone_from_slice(&src[..4])` [INFO] [stderr] ... [INFO] [stderr] 58 | impl_fixedint!(i32, 4); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:36:40 [INFO] [stderr] | [INFO] [stderr] 36 | let encoded = unsafe { transmute::<&$t, &[u8; $sz]>(&self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self as *const i16 as *const [u8; 2])` [INFO] [stderr] ... [INFO] [stderr] 59 | impl_fixedint!(i16, 2); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | let cast = unsafe { transmute::<&mut $t, &mut [u8; $sz]>(&mut decoded) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut decoded as *mut i16 as *mut [u8; 2])` [INFO] [stderr] ... [INFO] [stderr] 59 | impl_fixedint!(i16, 2); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/fixed.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | for i in 0..$sz { [INFO] [stderr] | ^ help: try replacing the loop by: `cast[..2].clone_from_slice(&src[..2])` [INFO] [stderr] ... [INFO] [stderr] 59 | impl_fixedint!(i16, 2); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/varint.rs:38:26 [INFO] [stderr] | [INFO] [stderr] 38 | fn decode_var_vec(v: &Vec) -> (Self, usize) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:67:49 [INFO] [stderr] | [INFO] [stderr] 67 | required_encoded_space_unsigned(self as u64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 99 | impl_varint!(u32, unsigned); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | (self as u64).encode_var(dst) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 99 | impl_varint!(u32, unsigned); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:67:49 [INFO] [stderr] | [INFO] [stderr] 67 | required_encoded_space_unsigned(self as u64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 100 | impl_varint!(u16, unsigned); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | (self as u64).encode_var(dst) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 100 | impl_varint!(u16, unsigned); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:67:49 [INFO] [stderr] | [INFO] [stderr] 67 | required_encoded_space_unsigned(self as u64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 101 | impl_varint!(u8, unsigned); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | (self as u64).encode_var(dst) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 101 | impl_varint!(u8, unsigned); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:83:47 [INFO] [stderr] | [INFO] [stderr] 83 | required_encoded_space_signed(self as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 104 | impl_varint!(i32, signed); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | (self as i64).encode_var(dst) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 104 | impl_varint!(i32, signed); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:83:47 [INFO] [stderr] | [INFO] [stderr] 83 | required_encoded_space_signed(self as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 105 | impl_varint!(i16, signed); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | (self as i64).encode_var(dst) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 105 | impl_varint!(i16, signed); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:83:47 [INFO] [stderr] | [INFO] [stderr] 83 | required_encoded_space_signed(self as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 106 | impl_varint!(i8, signed); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | (self as i64).encode_var(dst) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 106 | impl_varint!(i8, signed); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:122:23 [INFO] [stderr] | [INFO] [stderr] 122 | result |= (msb_dropped as u64) << shift; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(msb_dropped)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/varint.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | dst[i - 1] = DROP_MSB & dst[i - 1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dst[i - 1] &= DROP_MSB` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:164:23 [INFO] [stderr] | [INFO] [stderr] 164 | result |= (msb_dropped as u64) << shift; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(msb_dropped)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/varint.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | dst[i - 1] = DROP_MSB & dst[i - 1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dst[i - 1] &= DROP_MSB` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/reader.rs:32:48 [INFO] [stderr] | [INFO] [stderr] 32 | let read = try!(self.read(&mut buf[i..i + 1])); [INFO] [stderr] | ^^^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/reader.rs:46:47 [INFO] [stderr] | [INFO] [stderr] 46 | let (result, _) = VI::decode_var(&buf[0..i + 1]); [INFO] [stderr] | ^^^^^^^^ help: use: `0..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/fixed.rs:22:28 [INFO] [stderr] | [INFO] [stderr] 22 | fn decode_fixed_vec(v: &Vec) -> Self { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:36:40 [INFO] [stderr] | [INFO] [stderr] 36 | let encoded = unsafe { transmute::<&$t, &[u8; $sz]>(&self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self as *const usize as *const [u8; 8])` [INFO] [stderr] ... [INFO] [stderr] 52 | impl_fixedint!(usize, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | let cast = unsafe { transmute::<&mut $t, &mut [u8; $sz]>(&mut decoded) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut decoded as *mut usize as *mut [u8; 8])` [INFO] [stderr] ... [INFO] [stderr] 52 | impl_fixedint!(usize, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/fixed.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | for i in 0..$sz { [INFO] [stderr] | ^ help: try replacing the loop by: `cast[..8].clone_from_slice(&src[..8])` [INFO] [stderr] ... [INFO] [stderr] 52 | impl_fixedint!(usize, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:36:40 [INFO] [stderr] | [INFO] [stderr] 36 | let encoded = unsafe { transmute::<&$t, &[u8; $sz]>(&self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self as *const u64 as *const [u8; 8])` [INFO] [stderr] ... [INFO] [stderr] 53 | impl_fixedint!(u64, 8); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | let cast = unsafe { transmute::<&mut $t, &mut [u8; $sz]>(&mut decoded) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut decoded as *mut u64 as *mut [u8; 8])` [INFO] [stderr] ... [INFO] [stderr] 53 | impl_fixedint!(u64, 8); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/fixed.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | for i in 0..$sz { [INFO] [stderr] | ^ help: try replacing the loop by: `cast[..8].clone_from_slice(&src[..8])` [INFO] [stderr] ... [INFO] [stderr] 53 | impl_fixedint!(u64, 8); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:36:40 [INFO] [stderr] | [INFO] [stderr] 36 | let encoded = unsafe { transmute::<&$t, &[u8; $sz]>(&self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self as *const u32 as *const [u8; 4])` [INFO] [stderr] ... [INFO] [stderr] 54 | impl_fixedint!(u32, 4); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | let cast = unsafe { transmute::<&mut $t, &mut [u8; $sz]>(&mut decoded) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut decoded as *mut u32 as *mut [u8; 4])` [INFO] [stderr] ... [INFO] [stderr] 54 | impl_fixedint!(u32, 4); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/fixed.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | for i in 0..$sz { [INFO] [stderr] | ^ help: try replacing the loop by: `cast[..4].clone_from_slice(&src[..4])` [INFO] [stderr] ... [INFO] [stderr] 54 | impl_fixedint!(u32, 4); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:36:40 [INFO] [stderr] | [INFO] [stderr] 36 | let encoded = unsafe { transmute::<&$t, &[u8; $sz]>(&self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self as *const u16 as *const [u8; 2])` [INFO] [stderr] ... [INFO] [stderr] 55 | impl_fixedint!(u16, 2); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | let cast = unsafe { transmute::<&mut $t, &mut [u8; $sz]>(&mut decoded) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut decoded as *mut u16 as *mut [u8; 2])` [INFO] [stderr] ... [INFO] [stderr] 55 | impl_fixedint!(u16, 2); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/fixed.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | for i in 0..$sz { [INFO] [stderr] | ^ help: try replacing the loop by: `cast[..2].clone_from_slice(&src[..2])` [INFO] [stderr] ... [INFO] [stderr] 55 | impl_fixedint!(u16, 2); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:36:40 [INFO] [stderr] | [INFO] [stderr] 36 | let encoded = unsafe { transmute::<&$t, &[u8; $sz]>(&self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self as *const isize as *const [u8; 8])` [INFO] [stderr] ... [INFO] [stderr] 56 | impl_fixedint!(isize, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | let cast = unsafe { transmute::<&mut $t, &mut [u8; $sz]>(&mut decoded) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut decoded as *mut isize as *mut [u8; 8])` [INFO] [stderr] ... [INFO] [stderr] 56 | impl_fixedint!(isize, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/fixed.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | for i in 0..$sz { [INFO] [stderr] | ^ help: try replacing the loop by: `cast[..8].clone_from_slice(&src[..8])` [INFO] [stderr] ... [INFO] [stderr] 56 | impl_fixedint!(isize, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:36:40 [INFO] [stderr] | [INFO] [stderr] 36 | let encoded = unsafe { transmute::<&$t, &[u8; $sz]>(&self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self as *const i64 as *const [u8; 8])` [INFO] [stderr] ... [INFO] [stderr] 57 | impl_fixedint!(i64, 8); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | let cast = unsafe { transmute::<&mut $t, &mut [u8; $sz]>(&mut decoded) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut decoded as *mut i64 as *mut [u8; 8])` [INFO] [stderr] ... [INFO] [stderr] 57 | impl_fixedint!(i64, 8); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/fixed.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | for i in 0..$sz { [INFO] [stderr] | ^ help: try replacing the loop by: `cast[..8].clone_from_slice(&src[..8])` [INFO] [stderr] ... [INFO] [stderr] 57 | impl_fixedint!(i64, 8); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:36:40 [INFO] [stderr] | [INFO] [stderr] 36 | let encoded = unsafe { transmute::<&$t, &[u8; $sz]>(&self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self as *const i32 as *const [u8; 4])` [INFO] [stderr] ... [INFO] [stderr] 58 | impl_fixedint!(i32, 4); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | let cast = unsafe { transmute::<&mut $t, &mut [u8; $sz]>(&mut decoded) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut decoded as *mut i32 as *mut [u8; 4])` [INFO] [stderr] ... [INFO] [stderr] 58 | impl_fixedint!(i32, 4); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/fixed.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | for i in 0..$sz { [INFO] [stderr] | ^ help: try replacing the loop by: `cast[..4].clone_from_slice(&src[..4])` [INFO] [stderr] ... [INFO] [stderr] 58 | impl_fixedint!(i32, 4); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:36:40 [INFO] [stderr] | [INFO] [stderr] 36 | let encoded = unsafe { transmute::<&$t, &[u8; $sz]>(&self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self as *const i16 as *const [u8; 2])` [INFO] [stderr] ... [INFO] [stderr] 59 | impl_fixedint!(i16, 2); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/fixed.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | let cast = unsafe { transmute::<&mut $t, &mut [u8; $sz]>(&mut decoded) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut decoded as *mut i16 as *mut [u8; 2])` [INFO] [stderr] ... [INFO] [stderr] 59 | impl_fixedint!(i16, 2); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/fixed.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | for i in 0..$sz { [INFO] [stderr] | ^ help: try replacing the loop by: `cast[..2].clone_from_slice(&src[..2])` [INFO] [stderr] ... [INFO] [stderr] 59 | impl_fixedint!(i16, 2); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/varint.rs:38:26 [INFO] [stderr] | [INFO] [stderr] 38 | fn decode_var_vec(v: &Vec) -> (Self, usize) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:67:49 [INFO] [stderr] | [INFO] [stderr] 67 | required_encoded_space_unsigned(self as u64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 99 | impl_varint!(u32, unsigned); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | (self as u64).encode_var(dst) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 99 | impl_varint!(u32, unsigned); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:67:49 [INFO] [stderr] | [INFO] [stderr] 67 | required_encoded_space_unsigned(self as u64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 100 | impl_varint!(u16, unsigned); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | (self as u64).encode_var(dst) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 100 | impl_varint!(u16, unsigned); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:67:49 [INFO] [stderr] | [INFO] [stderr] 67 | required_encoded_space_unsigned(self as u64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 101 | impl_varint!(u8, unsigned); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | (self as u64).encode_var(dst) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 101 | impl_varint!(u8, unsigned); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:83:47 [INFO] [stderr] | [INFO] [stderr] 83 | required_encoded_space_signed(self as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 104 | impl_varint!(i32, signed); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | (self as i64).encode_var(dst) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 104 | impl_varint!(i32, signed); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:83:47 [INFO] [stderr] | [INFO] [stderr] 83 | required_encoded_space_signed(self as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 105 | impl_varint!(i16, signed); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | (self as i64).encode_var(dst) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 105 | impl_varint!(i16, signed); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:83:47 [INFO] [stderr] | [INFO] [stderr] 83 | required_encoded_space_signed(self as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 106 | impl_varint!(i8, signed); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | (self as i64).encode_var(dst) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 106 | impl_varint!(i8, signed); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:122:23 [INFO] [stderr] | [INFO] [stderr] 122 | result |= (msb_dropped as u64) << shift; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(msb_dropped)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/varint.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | dst[i - 1] = DROP_MSB & dst[i - 1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dst[i - 1] &= DROP_MSB` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:164:23 [INFO] [stderr] | [INFO] [stderr] 164 | result |= (msb_dropped as u64) << shift; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(msb_dropped)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/varint.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | dst[i - 1] = DROP_MSB & dst[i - 1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dst[i - 1] &= DROP_MSB` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/varint_tests.rs:79:23 [INFO] [stderr] | [INFO] [stderr] 79 | let i4: i64 = i3 as i64 * 1000; [INFO] [stderr] | ^^^^^^^^^ help: try: `i64::from(i3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/reader.rs:32:48 [INFO] [stderr] | [INFO] [stderr] 32 | let read = try!(self.read(&mut buf[i..i + 1])); [INFO] [stderr] | ^^^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/reader.rs:46:47 [INFO] [stderr] | [INFO] [stderr] 46 | let (result, _) = VI::decode_var(&buf[0..i + 1]); [INFO] [stderr] | ^^^^^^^^ help: use: `0..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.47s [INFO] running `"docker" "inspect" "305e5958fe567e2a7341bb6120a9871853fd2ac9e984ad370dfbaac4a4552c65"` [INFO] running `"docker" "rm" "-f" "305e5958fe567e2a7341bb6120a9871853fd2ac9e984ad370dfbaac4a4552c65"` [INFO] [stdout] 305e5958fe567e2a7341bb6120a9871853fd2ac9e984ad370dfbaac4a4552c65