[INFO] crate instrument 0.2.0 is already in cache [INFO] extracting crate instrument 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/instrument/0.2.0 [INFO] extracting crate instrument 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/instrument/0.2.0 [INFO] validating manifest of instrument-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of instrument-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing instrument-0.2.0 [INFO] finished frobbing instrument-0.2.0 [INFO] frobbed toml for instrument-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/instrument/0.2.0/Cargo.toml [INFO] started frobbing instrument-0.2.0 [INFO] finished frobbing instrument-0.2.0 [INFO] frobbed toml for instrument-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/instrument/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting instrument-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/instrument/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 81839a8db61a59cc848daa0242a0f224f5147f99ebdd94e77e8781a1fdf334e3 [INFO] running `"docker" "start" "-a" "81839a8db61a59cc848daa0242a0f224f5147f99ebdd94e77e8781a1fdf334e3"` [INFO] [stderr] Checking pitch_calc v0.11.1 [INFO] [stderr] Checking time_calc v0.11.1 [INFO] [stderr] Checking instrument v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instrument.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instrument.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | note_freq_gen: note_freq_gen, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `note_freq_gen` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/voice.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | hz: hz, [INFO] [stderr] | ^^^^^^ help: replace it with: `hz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/voice.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | vel: vel, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/voice.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | freq: freq, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `freq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instrument.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instrument.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | note_freq_gen: note_freq_gen, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `note_freq_gen` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/voice.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | hz: hz, [INFO] [stderr] | ^^^^^^ help: replace it with: `hz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/voice.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | vel: vel, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/voice.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | freq: freq, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `freq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/instrument.rs:226:44 [INFO] [stderr] | [INFO] [stderr] 226 | pub fn next_voice_vel_hz(&mut self) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: The function/method `does_voice_match` doesn't need a mutable reference [INFO] [stderr] --> src/mode.rs:167:29 [INFO] [stderr] | [INFO] [stderr] 167 | if does_voice_match(&mut voices[0], note_hz) { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/note_freq.rs:142:40 [INFO] [stderr] | [INFO] [stderr] 142 | let perc_diff_mel = perc * diff_mel as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(diff_mel)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `voice::Voice` [INFO] [stderr] --> src/voice.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / pub fn new() -> Self { [INFO] [stderr] 45 | | Voice { [INFO] [stderr] 46 | | note: None, [INFO] [stderr] 47 | | playhead: 0, [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/instrument.rs:226:44 [INFO] [stderr] | [INFO] [stderr] 226 | pub fn next_voice_vel_hz(&mut self) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: The function/method `does_voice_match` doesn't need a mutable reference [INFO] [stderr] --> src/mode.rs:167:29 [INFO] [stderr] | [INFO] [stderr] 167 | if does_voice_match(&mut voices[0], note_hz) { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/note_freq.rs:142:40 [INFO] [stderr] | [INFO] [stderr] 142 | let perc_diff_mel = perc * diff_mel as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(diff_mel)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `voice::Voice` [INFO] [stderr] --> src/voice.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / pub fn new() -> Self { [INFO] [stderr] 45 | | Voice { [INFO] [stderr] 46 | | note: None, [INFO] [stderr] 47 | | playhead: 0, [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.13s [INFO] running `"docker" "inspect" "81839a8db61a59cc848daa0242a0f224f5147f99ebdd94e77e8781a1fdf334e3"` [INFO] running `"docker" "rm" "-f" "81839a8db61a59cc848daa0242a0f224f5147f99ebdd94e77e8781a1fdf334e3"` [INFO] [stdout] 81839a8db61a59cc848daa0242a0f224f5147f99ebdd94e77e8781a1fdf334e3