[INFO] crate input_manager 0.1.0 is already in cache [INFO] extracting crate input_manager 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/input_manager/0.1.0 [INFO] extracting crate input_manager 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/input_manager/0.1.0 [INFO] validating manifest of input_manager-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of input_manager-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing input_manager-0.1.0 [INFO] finished frobbing input_manager-0.1.0 [INFO] frobbed toml for input_manager-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/input_manager/0.1.0/Cargo.toml [INFO] started frobbing input_manager-0.1.0 [INFO] finished frobbing input_manager-0.1.0 [INFO] frobbed toml for input_manager-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/input_manager/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting input_manager-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/input_manager/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5aadf6c4ba63e6404ec7074b5236193b85412923ac3620251a5fad0a99adb511 [INFO] running `"docker" "start" "-a" "5aadf6c4ba63e6404ec7074b5236193b85412923ac3620251a5fad0a99adb511"` [INFO] [stderr] Checking input_manager v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/axis/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod axis; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/axis/axis.rs:58:16 [INFO] [stderr] | [INFO] [stderr] 58 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 59 | | if self.position > 1.0 { [INFO] [stderr] 60 | | 1.0 [INFO] [stderr] 61 | | } else if self.position < -1.0 { [INFO] [stderr] ... | [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 58 | } else if self.position > 1.0 { [INFO] [stderr] 59 | 1.0 [INFO] [stderr] 60 | } else if self.position < -1.0 { [INFO] [stderr] 61 | -1.0 [INFO] [stderr] 62 | } else { [INFO] [stderr] 63 | self.position [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/button/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod button; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/change/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod change; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/manager/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | mod manager; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/axis/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod axis; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/axis/axis.rs:58:16 [INFO] [stderr] | [INFO] [stderr] 58 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 59 | | if self.position > 1.0 { [INFO] [stderr] 60 | | 1.0 [INFO] [stderr] 61 | | } else if self.position < -1.0 { [INFO] [stderr] ... | [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 58 | } else if self.position > 1.0 { [INFO] [stderr] 59 | 1.0 [INFO] [stderr] 60 | } else if self.position < -1.0 { [INFO] [stderr] 61 | -1.0 [INFO] [stderr] 62 | } else { [INFO] [stderr] 63 | self.position [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/button/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod button; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/change/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod change; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/manager/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | mod manager; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/axis/axis.rs:50:44 [INFO] [stderr] | [INFO] [stderr] 50 | dx * (delta.as_secs() * 1000 + (delta.subsec_millis() as u64)) as f64 / 500.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(delta.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/manager/manager.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / if !self.states.contains_key(&binding) { [INFO] [stderr] 92 | | self.states.insert(binding, State::Axis(Axis::default())); [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________^ help: consider using: `self.states.entry(binding).or_insert(State::Axis(Axis::default()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/manager/manager.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | / if !self.states.contains_key(&binding) { [INFO] [stderr] 111 | | self.states [INFO] [stderr] 112 | | .insert(binding, State::Button(Button::default())); [INFO] [stderr] 113 | | } [INFO] [stderr] | |_________^ help: consider using: `self.states.entry(binding).or_insert(State::Button(Button::default()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Left` [INFO] [stderr] --> src/manager/manager.rs:197:9 [INFO] [stderr] | [INFO] [stderr] 197 | Left, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Right` [INFO] [stderr] --> src/manager/manager.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | Right, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Gamepad` [INFO] [stderr] --> src/manager/manager.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | Gamepad(GamePadInput), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/axis/axis.rs:50:44 [INFO] [stderr] | [INFO] [stderr] 50 | dx * (delta.as_secs() * 1000 + (delta.subsec_millis() as u64)) as f64 / 500.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(delta.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/axis/axis.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | assert_eq!(axis.position, 0.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/axis/axis.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | assert_eq!(axis.position, 0.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/axis/axis.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | assert_eq!(axis.position, 0.2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/axis/axis.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | assert_eq!(axis.position, 0.2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/axis/axis.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | assert_eq!(axis.position, -0.2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/axis/axis.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | assert_eq!(axis.position, -0.2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/axis/axis.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | assert_eq!(axis.position, 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/axis/axis.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | assert_eq!(axis.position, 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/axis/axis.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | assert_eq!(axis.position, -1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/axis/axis.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | assert_eq!(axis.position, -1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/axis/axis.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | assert_eq!(axis.position, 0.3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/axis/axis.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | assert_eq!(axis.position, 0.3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/axis/axis.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | assert_eq!(axis.position, 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/axis/axis.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | assert_eq!(axis.position, 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/manager/manager.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / if !self.states.contains_key(&binding) { [INFO] [stderr] 92 | | self.states.insert(binding, State::Axis(Axis::default())); [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________^ help: consider using: `self.states.entry(binding).or_insert(State::Axis(Axis::default()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/manager/manager.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | / if !self.states.contains_key(&binding) { [INFO] [stderr] 111 | | self.states [INFO] [stderr] 112 | | .insert(binding, State::Button(Button::default())); [INFO] [stderr] 113 | | } [INFO] [stderr] | |_________^ help: consider using: `self.states.entry(binding).or_insert(State::Button(Button::default()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/manager/manager.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | assert_eq!(manager.get_axis(Axes::Vertical).unwrap().position, 0.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/manager/manager.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | assert_eq!(manager.get_axis(Axes::Vertical).unwrap().position, 0.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 8 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `input_manager`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5aadf6c4ba63e6404ec7074b5236193b85412923ac3620251a5fad0a99adb511"` [INFO] running `"docker" "rm" "-f" "5aadf6c4ba63e6404ec7074b5236193b85412923ac3620251a5fad0a99adb511"` [INFO] [stdout] 5aadf6c4ba63e6404ec7074b5236193b85412923ac3620251a5fad0a99adb511