[INFO] crate initrs 0.1.1 is already in cache [INFO] extracting crate initrs 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/initrs/0.1.1 [INFO] extracting crate initrs 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/initrs/0.1.1 [INFO] validating manifest of initrs-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of initrs-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing initrs-0.1.1 [INFO] finished frobbing initrs-0.1.1 [INFO] frobbed toml for initrs-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/initrs/0.1.1/Cargo.toml [INFO] started frobbing initrs-0.1.1 [INFO] finished frobbing initrs-0.1.1 [INFO] frobbed toml for initrs-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/initrs/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting initrs-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/initrs/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8c6f8401307f4d7ba5469ee6f63a11180c03436781a517869791a6063b50690b [INFO] running `"docker" "start" "-a" "8c6f8401307f4d7ba5469ee6f63a11180c03436781a517869791a6063b50690b"` [INFO] [stderr] Checking nix v0.8.1 [INFO] [stderr] Checking clap v2.23.3 [INFO] [stderr] Checking initrs v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `needless_return` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:20:43 [INFO] [stderr] | [INFO] [stderr] 20 | #![cfg_attr(feature="cargo-clippy", allow(needless_return))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_return` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_return` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:20:43 [INFO] [stderr] | [INFO] [stderr] 20 | #![cfg_attr(feature="cargo-clippy", allow(needless_return))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_return` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_return` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:20:43 [INFO] [stderr] | [INFO] [stderr] 20 | #![cfg_attr(feature="cargo-clippy", allow(needless_return))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_return` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_return` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:20:43 [INFO] [stderr] | [INFO] [stderr] 20 | #![cfg_attr(feature="cargo-clippy", allow(needless_return))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_return` [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:111:38 [INFO] [stderr] | [INFO] [stderr] 111 | let siginfo = sfd.read_signal()?.ok_or(Error::new( [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 112 | | ErrorKind::Other, [INFO] [stderr] 113 | | "no signals read", [INFO] [stderr] 114 | | ))?; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 111 | let siginfo = sfd.read_signal()?.ok_or_else(|| Error::new( [INFO] [stderr] 112 | ErrorKind::Other, [INFO] [stderr] 113 | "no signals read", [INFO] [stderr] 114 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:111:38 [INFO] [stderr] | [INFO] [stderr] 111 | let siginfo = sfd.read_signal()?.ok_or(Error::new( [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 112 | | ErrorKind::Other, [INFO] [stderr] 113 | | "no signals read", [INFO] [stderr] 114 | | ))?; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 111 | let siginfo = sfd.read_signal()?.ok_or_else(|| Error::new( [INFO] [stderr] 112 | ErrorKind::Other, [INFO] [stderr] 113 | "no signals read", [INFO] [stderr] 114 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.24s [INFO] running `"docker" "inspect" "8c6f8401307f4d7ba5469ee6f63a11180c03436781a517869791a6063b50690b"` [INFO] running `"docker" "rm" "-f" "8c6f8401307f4d7ba5469ee6f63a11180c03436781a517869791a6063b50690b"` [INFO] [stdout] 8c6f8401307f4d7ba5469ee6f63a11180c03436781a517869791a6063b50690b