[INFO] crate indy-crypto 0.5.0-rc-24 is already in cache [INFO] extracting crate indy-crypto 0.5.0-rc-24 into work/ex/clippy-test-run/sources/stable/reg/indy-crypto/0.5.0-rc-24 [INFO] extracting crate indy-crypto 0.5.0-rc-24 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/indy-crypto/0.5.0-rc-24 [INFO] validating manifest of indy-crypto-0.5.0-rc-24 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of indy-crypto-0.5.0-rc-24 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing indy-crypto-0.5.0-rc-24 [INFO] finished frobbing indy-crypto-0.5.0-rc-24 [INFO] frobbed toml for indy-crypto-0.5.0-rc-24 written to work/ex/clippy-test-run/sources/stable/reg/indy-crypto/0.5.0-rc-24/Cargo.toml [INFO] started frobbing indy-crypto-0.5.0-rc-24 [INFO] finished frobbing indy-crypto-0.5.0-rc-24 [INFO] frobbed toml for indy-crypto-0.5.0-rc-24 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/indy-crypto/0.5.0-rc-24/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting indy-crypto-0.5.0-rc-24 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/indy-crypto/0.5.0-rc-24:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 91fa22fd352ce09699902dc43474cbce3792515e35be9e70f8cd89014a5d569d [INFO] running `"docker" "start" "-a" "91fa22fd352ce09699902dc43474cbce3792515e35be9e70f8cd89014a5d569d"` [INFO] [stderr] Compiling indy-crypto v0.5.0-rc-24 (/opt/crater/workdir) [INFO] [stderr] Checking int_traits v0.1.1 [INFO] [stderr] Checking amcl v0.1.3 [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cl/issuer.rs:607:17 [INFO] [stderr] | [INFO] [stderr] 607 | let mut r = HashMap::new(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/cl/issuer.rs:612:13 [INFO] [stderr] | [INFO] [stderr] 612 | let z = s.mod_exp(&xz, &n, Some(&mut ctx))?; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cl/issuer.rs:645:13 [INFO] [stderr] | [INFO] [stderr] 645 | let y = h_cap.mul(&x)?; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cl/issuer.rs:900:13 [INFO] [stderr] | [INFO] [stderr] 900 | let a = q.mod_exp(&e_inverse, &p_pub_key.n, Some(&mut context))?; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cl/prover.rs:1508:13 [INFO] [stderr] | [INFO] [stderr] 1508 | let w = witness.omega [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/cl/prover.rs:1513:13 [INFO] [stderr] | [INFO] [stderr] 1513 | let s = r_cred.witness_signature.sigma_i [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/cl/prover.rs:1518:13 [INFO] [stderr] | [INFO] [stderr] 1518 | let u = r_cred.witness_signature.u_i [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bls/mod.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | point: point, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bls/mod.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | group_order_element: group_order_element, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `group_order_element` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bls/mod.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | point: point, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bls/mod.rs:206:13 [INFO] [stderr] | [INFO] [stderr] 206 | point: point, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bls/mod.rs:344:17 [INFO] [stderr] | [INFO] [stderr] 344 | point: point, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pair/amcl.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | point: point [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pair/amcl.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | point: point [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pair/amcl.rs:265:13 [INFO] [stderr] | [INFO] [stderr] 265 | point: point [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pair/amcl.rs:275:13 [INFO] [stderr] | [INFO] [stderr] 275 | point: point [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pair/amcl.rs:459:13 [INFO] [stderr] | [INFO] [stderr] 459 | bn: bn [INFO] [stderr] | ^^^^^^ help: replace it with: `bn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cl/issuer.rs:607:17 [INFO] [stderr] | [INFO] [stderr] 607 | let mut r = HashMap::new(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/cl/issuer.rs:612:13 [INFO] [stderr] | [INFO] [stderr] 612 | let z = s.mod_exp(&xz, &n, Some(&mut ctx))?; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cl/issuer.rs:645:13 [INFO] [stderr] | [INFO] [stderr] 645 | let y = h_cap.mul(&x)?; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cl/issuer.rs:900:13 [INFO] [stderr] | [INFO] [stderr] 900 | let a = q.mod_exp(&e_inverse, &p_pub_key.n, Some(&mut context))?; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cl/prover.rs:1508:13 [INFO] [stderr] | [INFO] [stderr] 1508 | let w = witness.omega [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/cl/prover.rs:1513:13 [INFO] [stderr] | [INFO] [stderr] 1513 | let s = r_cred.witness_signature.sigma_i [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/cl/prover.rs:1518:13 [INFO] [stderr] | [INFO] [stderr] 1518 | let u = r_cred.witness_signature.u_i [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bls/mod.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | point: point, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bls/mod.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | group_order_element: group_order_element, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `group_order_element` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bls/mod.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | point: point, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bls/mod.rs:206:13 [INFO] [stderr] | [INFO] [stderr] 206 | point: point, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bls/mod.rs:344:17 [INFO] [stderr] | [INFO] [stderr] 344 | point: point, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pair/amcl.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | point: point [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pair/amcl.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | point: point [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pair/amcl.rs:265:13 [INFO] [stderr] | [INFO] [stderr] 265 | point: point [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pair/amcl.rs:275:13 [INFO] [stderr] | [INFO] [stderr] 275 | point: point [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pair/amcl.rs:459:13 [INFO] [stderr] | [INFO] [stderr] 459 | bn: bn [INFO] [stderr] | ^^^^^^ help: replace it with: `bn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/cl/helpers.rs:268:22 [INFO] [stderr] | [INFO] [stderr] 268 | result.push((x >> i * 8) as u8); [INFO] [stderr] | ^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (i * 8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/cl/prover.rs:470:21 [INFO] [stderr] | [INFO] [stderr] 470 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/cl/prover.rs:489:21 [INFO] [stderr] | [INFO] [stderr] 489 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/cl/prover.rs:520:21 [INFO] [stderr] | [INFO] [stderr] 520 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/cl/prover.rs:531:21 [INFO] [stderr] | [INFO] [stderr] 531 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cl/prover.rs:2015:28 [INFO] [stderr] | [INFO] [stderr] 2015 | pub const PROVER_DID: &'static str = "CnEDk9HrMnmiHXEV1WFgbVCRteYnPqsJwrTdcZaNhFVW"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cl/helpers.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | return *use_mocks.borrow(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*use_mocks.borrow()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/cl/helpers.rs:268:22 [INFO] [stderr] | [INFO] [stderr] 268 | result.push((x >> i * 8) as u8); [INFO] [stderr] | ^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (i * 8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cl/helpers.rs:601:32 [INFO] [stderr] | [INFO] [stderr] 601 | let res = four_squares(1506099439 as i32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_506_099_439` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cl/helpers.rs:612:19 [INFO] [stderr] | [INFO] [stderr] 612 | let int = 0x74BA7445; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x74BA_7445` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/cl/prover.rs:470:21 [INFO] [stderr] | [INFO] [stderr] 470 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/cl/prover.rs:489:21 [INFO] [stderr] | [INFO] [stderr] 489 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/cl/prover.rs:520:21 [INFO] [stderr] | [INFO] [stderr] 520 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/cl/prover.rs:531:21 [INFO] [stderr] | [INFO] [stderr] 531 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cl/prover.rs:2015:28 [INFO] [stderr] | [INFO] [stderr] 2015 | pub const PROVER_DID: &'static str = "CnEDk9HrMnmiHXEV1WFgbVCRteYnPqsJwrTdcZaNhFVW"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bn/openssl.rs:511:47 [INFO] [stderr] | [INFO] [stderr] 511 | let primes:Vec = vec![2, 23, 31, 42885908609, 24473809133, 47055833459]; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `42_885_908_609` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bn/openssl.rs:511:60 [INFO] [stderr] | [INFO] [stderr] 511 | let primes:Vec = vec![2, 23, 31, 42885908609, 24473809133, 47055833459]; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `24_473_809_133` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bn/openssl.rs:511:73 [INFO] [stderr] | [INFO] [stderr] 511 | let primes:Vec = vec![2, 23, 31, 42885908609, 24473809133, 47055833459]; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `47_055_833_459` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pair/amcl.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | return *use_mocks.borrow(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*use_mocks.borrow()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:16:34 [INFO] [stderr] | [INFO] [stderr] 16 | match CStr::from_ptr(cstr).to_str() { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utils/rsa.rs:38:65 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn generate_witness(initial_witness: &BigNumber, exponents: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[BigNumber]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/utils/rsa.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | for ref e in exponents.iter() { [INFO] [stderr] | ^^^^^ ---------------- help: try: `let e = &exponents.iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/utils/logger.rs:104:31 [INFO] [stderr] | [INFO] [stderr] 104 | let pattern = pattern.or(env::var("RUST_LOG").ok()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| env::var("RUST_LOG").ok())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utils/mod.rs:11:30 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn get_hash_as_int(nums: &Vec>) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/helpers.rs:306:14 [INFO] [stderr] | [INFO] [stderr] 306 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in pk.r", k)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in pk.r", k)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/helpers.rs:308:14 [INFO] [stderr] | [INFO] [stderr] 308 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in m_tilde", k)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in m_tilde", k)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/helpers.rs:341:14 [INFO] [stderr] | [INFO] [stderr] 341 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in u", i)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in u", i)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/helpers.rs:343:14 [INFO] [stderr] | [INFO] [stderr] 343 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in r", i)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in r", i)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/helpers.rs:356:10 [INFO] [stderr] | [INFO] [stderr] 356 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in r", "DELTA")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in r", "DELTA")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/helpers.rs:371:14 [INFO] [stderr] | [INFO] [stderr] 371 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in t", i)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in t", i)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/helpers.rs:373:14 [INFO] [stderr] | [INFO] [stderr] 373 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in u", i)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in u", i)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cl/helpers.rs:407:22 [INFO] [stderr] | [INFO] [stderr] 407 | 'outer: for i in (1..roots[0] + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(1..=roots[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cl/helpers.rs:416:18 [INFO] [stderr] | [INFO] [stderr] 416 | for j in (1..roots[1] + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(1..=roots[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cl/helpers.rs:424:22 [INFO] [stderr] | [INFO] [stderr] 424 | for k in (1..roots[2] + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(1..=roots[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/issuer.rs:127:14 [INFO] [stderr] | [INFO] [stderr] 127 | .ok_or(IndyCryptoError::InvalidStructure(format!("There are not revocation keys in the credential public key.")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("There are not revocation keys in the credential public key.")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/issuer.rs:127:54 [INFO] [stderr] | [INFO] [stderr] 127 | .ok_or(IndyCryptoError::InvalidStructure(format!("There are not revocation keys in the credential public key.")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"There are not revocation keys in the credential public key.".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cl/issuer.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | rev_key_priv.gamma.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rev_key_priv.gamma` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cl/issuer.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | cred_rev_pub_key.g_dash.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `cred_rev_pub_key.g_dash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/cl/issuer.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | / pub fn sign_credential(prover_id: &str, [INFO] [stderr] 218 | | blinded_credential_secrets: &BlindedCredentialSecrets, [INFO] [stderr] 219 | | blinded_credential_secrets_correctness_proof: &BlindedCredentialSecretsCorrectnessProof, [INFO] [stderr] 220 | | credential_nonce: &Nonce, [INFO] [stderr] ... | [INFO] [stderr] 268 | | Ok((cred_signature, signature_correctness_proof)) [INFO] [stderr] 269 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> src/cl/issuer.rs:339:5 [INFO] [stderr] | [INFO] [stderr] 339 | / pub fn sign_credential_with_revoc(prover_id: &str, [INFO] [stderr] 340 | | blinded_credential_secrets: &BlindedCredentialSecrets, [INFO] [stderr] 341 | | blinded_credential_secrets_correctness_proof: &BlindedCredentialSecretsCorrectnessProof, [INFO] [stderr] 342 | | credential_nonce: &Nonce, [INFO] [stderr] ... | [INFO] [stderr] 398 | | Ok((cred_signature, signature_correctness_proof, rev_reg_delta)) [INFO] [stderr] 399 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cl/issuer.rs:467:26 [INFO] [stderr] | [INFO] [stderr] 467 | let prev_accum = rev_reg.accum.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rev_reg.accum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cl/issuer.rs:477:20 [INFO] [stderr] | [INFO] [stderr] 477 | accum: rev_reg.accum.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rev_reg.accum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cl/issuer.rs:555:26 [INFO] [stderr] | [INFO] [stderr] 555 | let prev_accum = rev_reg.accum.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rev_reg.accum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cl/issuer.rs:565:20 [INFO] [stderr] | [INFO] [stderr] 565 | accum: rev_reg.accum.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rev_reg.accum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cl/issuer.rs:584:12 [INFO] [stderr] | [INFO] [stderr] 584 | if credential_schema.attrs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `credential_schema.attrs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/issuer.rs:585:58 [INFO] [stderr] | [INFO] [stderr] 585 | return Err(IndyCryptoError::InvalidStructure(format!("List of attributes is empty"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"List of attributes is empty".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_hash_as_int` doesn't need a mutable reference [INFO] [stderr] --> src/cl/issuer.rs:690:33 [INFO] [stderr] | [INFO] [stderr] 690 | let c = get_hash_as_int(&mut vec![values])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cl/issuer.rs:722:22 [INFO] [stderr] | [INFO] [stderr] 722 | for i in 1..max_cred_num + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `1..=max_cred_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/issuer.rs:780:70 [INFO] [stderr] | [INFO] [stderr] 780 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in cred_pr_pub_key.r", attr)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in cred_pr_pub_key.r", attr)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/issuer.rs:809:58 [INFO] [stderr] | [INFO] [stderr] 809 | return Err(IndyCryptoError::InvalidStructure(format!("Invalid BlindedCredentialSecrets correctness proof"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid BlindedCredentialSecrets correctness proof".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/issuer.rs:889:18 [INFO] [stderr] | [INFO] [stderr] 889 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in pk.r", key)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in pk.r", key)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_hash_as_int` doesn't need a mutable reference [INFO] [stderr] --> src/cl/issuer.rs:928:33 [INFO] [stderr] | [INFO] [stderr] 928 | let c = get_hash_as_int(&mut vec![values])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/cl/issuer.rs:947:5 [INFO] [stderr] | [INFO] [stderr] 947 | / fn _new_non_revocation_credential(rev_idx: u32, [INFO] [stderr] 948 | | cred_context: &BigNumber, [INFO] [stderr] 949 | | blinded_credential_secrets: &BlindedCredentialSecrets, [INFO] [stderr] 950 | | cred_pub_key: &CredentialPublicKey, [INFO] [stderr] ... | [INFO] [stderr] 1040 | | Ok((non_revocation_cred_sig, rev_reg_delta)) [INFO] [stderr] 1041 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/issuer.rs:964:14 [INFO] [stderr] | [INFO] [stderr] 964 | .ok_or(IndyCryptoError::InvalidStructure(format!("No revocation part present in blinded master secret.")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("No revocation part present in blinded master secret.")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/issuer.rs:964:54 [INFO] [stderr] | [INFO] [stderr] 964 | .ok_or(IndyCryptoError::InvalidStructure(format!("No revocation part present in blinded master secret.")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"No revocation part present in blinded master secret.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/issuer.rs:968:14 [INFO] [stderr] | [INFO] [stderr] 968 | .ok_or(IndyCryptoError::InvalidStructure(format!("No revocation part present in credential revocation public key.")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("No revocation part present in credential revocation public key.")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/issuer.rs:968:54 [INFO] [stderr] | [INFO] [stderr] 968 | .ok_or(IndyCryptoError::InvalidStructure(format!("No revocation part present in credential revocation public key.")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"No revocation part present in credential revocation public key.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/issuer.rs:972:14 [INFO] [stderr] | [INFO] [stderr] 972 | .ok_or(IndyCryptoError::InvalidStructure(format!("No revocation part present in credential revocation private key.")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("No revocation part present in credential revocation private key.")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/issuer.rs:972:54 [INFO] [stderr] | [INFO] [stderr] 972 | .ok_or(IndyCryptoError::InvalidStructure(format!("No revocation part present in credential revocation private key.")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"No revocation part present in credential revocation private key.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cl/issuer.rs:1007:28 [INFO] [stderr] | [INFO] [stderr] 1007 | let prev_acc = rev_reg.accum.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rev_reg.accum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cl/issuer.rs:1015:24 [INFO] [stderr] | [INFO] [stderr] 1015 | accum: rev_reg.accum.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rev_reg.accum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cl/issuer.rs:1024:18 [INFO] [stderr] | [INFO] [stderr] 1024 | g_i: g_i.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `g_i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cl/issuer.rs:1032:18 [INFO] [stderr] | [INFO] [stderr] 1032 | g_i: g_i.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `g_i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/cl/prover.rs:185:5 [INFO] [stderr] | [INFO] [stderr] 185 | / pub fn process_credential_signature(credential_signature: &mut CredentialSignature, [INFO] [stderr] 186 | | credential_values: &CredentialValues, [INFO] [stderr] 187 | | signature_correctness_proof: &SignatureCorrectnessProof, [INFO] [stderr] 188 | | credential_secrets_blinding_factors: &CredentialSecretsBlindingFactors, [INFO] [stderr] ... | [INFO] [stderr] 239 | | Ok(()) [INFO] [stderr] 240 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_hash_as_int` doesn't need a mutable reference [INFO] [stderr] --> src/cl/prover.rs:324:33 [INFO] [stderr] | [INFO] [stderr] 324 | let c = get_hash_as_int(&mut vec![values])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/prover.rs:329:58 [INFO] [stderr] | [INFO] [stderr] 329 | return Err(IndyCryptoError::InvalidStructure(format!("Invalid Credential key correctness proof"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid Credential key correctness proof".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/prover.rs:361:59 [INFO] [stderr] | [INFO] [stderr] 361 | let pk_r = p_pub_key.r.get(&attr.clone()).ok_or( [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 362 | | IndyCryptoError::InvalidStructure( [INFO] [stderr] 363 | | format!("Value by key '{}' not found in pk.r", attr), [INFO] [stderr] 364 | | ), [INFO] [stderr] 365 | | )?; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 361 | let pk_r = p_pub_key.r.get(&attr.clone()).ok_or_else(|| IndyCryptoError::InvalidStructure( [INFO] [stderr] 362 | format!("Value by key '{}' not found in pk.r", attr), [INFO] [stderr] 363 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cl/prover.rs:383:13 [INFO] [stderr] | [INFO] [stderr] 383 | / if let &CredentialValue::Commitment { ref value, ref blinding_factor } = cv { [INFO] [stderr] 384 | | committed_attributes.insert( [INFO] [stderr] 385 | | attr.clone(), [INFO] [stderr] 386 | | get_pedersen_commitment( [INFO] [stderr] ... | [INFO] [stderr] 394 | | ); [INFO] [stderr] 395 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 383 | if let CredentialValue::Commitment { ref value, ref blinding_factor } = *cv { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/prover.rs:454:46 [INFO] [stderr] | [INFO] [stderr] 454 | let pk_r = p_pub_key.r.get(attr).ok_or( [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 455 | | IndyCryptoError::InvalidStructure( [INFO] [stderr] 456 | | format!( [INFO] [stderr] 457 | | "Value by key '{}' not found in pk.r", [INFO] [stderr] ... | [INFO] [stderr] 460 | | ), [INFO] [stderr] 461 | | )?; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 454 | let pk_r = p_pub_key.r.get(attr).ok_or_else(|| IndyCryptoError::InvalidStructure( [INFO] [stderr] 455 | format!( [INFO] [stderr] 456 | "Value by key '{}' not found in pk.r", [INFO] [stderr] 457 | attr [INFO] [stderr] 458 | ), [INFO] [stderr] 459 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/prover.rs:487:26 [INFO] [stderr] | [INFO] [stderr] 487 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in primary_blinded_cred_secrets.committed_attributes", attr)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in primary_blinded_cred_secrets.committed_attributes", attr)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/prover.rs:509:63 [INFO] [stderr] | [INFO] [stderr] 509 | let ca = credential_values.attrs_values.get(attr).ok_or( [INFO] [stderr] | _______________________________________________________________^ [INFO] [stderr] 510 | | IndyCryptoError::InvalidStructure(format!( [INFO] [stderr] 511 | | "Value by key '{}' not found in cred_values.committed_attributes", [INFO] [stderr] 512 | | attr [INFO] [stderr] 513 | | )), [INFO] [stderr] 514 | | )?; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 509 | let ca = credential_values.attrs_values.get(attr).ok_or_else(|| IndyCryptoError::InvalidStructure(format!( [INFO] [stderr] 510 | "Value by key '{}' not found in cred_values.committed_attributes", [INFO] [stderr] 511 | attr [INFO] [stderr] 512 | )))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cl/prover.rs:516:13 [INFO] [stderr] | [INFO] [stderr] 516 | / match ca { [INFO] [stderr] 517 | | &CredentialValue::Hidden { ref value } => { [INFO] [stderr] 518 | | let m_cap = m_tilde.add(&c.mul(value, Some(&mut ctx))?)?; [INFO] [stderr] 519 | | m_caps.insert(attr.clone(), m_cap); [INFO] [stderr] ... | [INFO] [stderr] 533 | | _ => (), [INFO] [stderr] 534 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 516 | match *ca { [INFO] [stderr] 517 | CredentialValue::Hidden { ref value } => { [INFO] [stderr] 518 | let m_cap = m_tilde.add(&c.mul(value, Some(&mut ctx))?)?; [INFO] [stderr] 519 | m_caps.insert(attr.clone(), m_cap); [INFO] [stderr] 520 | () [INFO] [stderr] 521 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/prover.rs:600:58 [INFO] [stderr] | [INFO] [stderr] 600 | return Err(IndyCryptoError::InvalidStructure(format!("Invalid Signature correctness proof"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid Signature correctness proof".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/cl/prover.rs:606:86 [INFO] [stderr] | [INFO] [stderr] 606 | (value.is_known() || value.is_hidden()) && !p_pub_key.r.contains_key(attr.clone())) { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 606 | (value.is_known() || value.is_hidden()) && !p_pub_key.r.contains_key(&(*attr).clone())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 606 | (value.is_known() || value.is_hidden()) && !p_pub_key.r.contains_key(&std::string::String::clone(attr))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/cl/prover.rs:614:85 [INFO] [stderr] | [INFO] [stderr] 614 | (value.is_known() || value.is_hidden()) && p_pub_key.r.contains_key(attr.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 614 | (value.is_known() || value.is_hidden()) && p_pub_key.r.contains_key(&(*attr).clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 614 | (value.is_known() || value.is_hidden()) && p_pub_key.r.contains_key(&std::string::String::clone(attr)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/prover.rs:643:58 [INFO] [stderr] | [INFO] [stderr] 643 | return Err(IndyCryptoError::InvalidStructure(format!("Invalid Signature correctness proof q != q'"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid Signature correctness proof q != q'".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/prover.rs:663:58 [INFO] [stderr] | [INFO] [stderr] 663 | return Err(IndyCryptoError::InvalidStructure(format!("Invalid Signature correctness proof c != c'"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid Signature correctness proof c != c'".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/cl/prover.rs:804:5 [INFO] [stderr] | [INFO] [stderr] 804 | / pub fn add_sub_proof_request(&mut self, [INFO] [stderr] 805 | | sub_proof_request: &SubProofRequest, [INFO] [stderr] 806 | | credential_schema: &CredentialSchema, [INFO] [stderr] 807 | | non_credential_schema: &NonCredentialSchema, [INFO] [stderr] ... | [INFO] [stderr] 878 | | Ok(()) [INFO] [stderr] 879 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/prover.rs:1018:58 [INFO] [stderr] | [INFO] [stderr] 1018 | return Err(IndyCryptoError::InvalidStructure(format!("Credential doesn't correspond to credential schema"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Credential doesn't correspond to credential schema".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/prover.rs:1027:21 [INFO] [stderr] | [INFO] [stderr] 1027 | format!("Credential doesn't contain requested attribute"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Credential doesn't contain requested attribute".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/prover.rs:1038:58 [INFO] [stderr] | [INFO] [stderr] 1038 | return Err(IndyCryptoError::InvalidStructure(format!("Credential doesn't contain attribute requested in predicate"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Credential doesn't contain attribute requested in predicate".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/cl/prover.rs:1046:5 [INFO] [stderr] | [INFO] [stderr] 1046 | / fn _init_primary_proof(common_attributes: &HashMap, [INFO] [stderr] 1047 | | issuer_pub_key: &CredentialPrimaryPublicKey, [INFO] [stderr] 1048 | | c1: &PrimaryCredentialSignature, [INFO] [stderr] 1049 | | cred_values: &CredentialValues, [INFO] [stderr] ... | [INFO] [stderr] 1089 | | Ok(primary_init_proof) [INFO] [stderr] 1090 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/prover.rs:1191:14 [INFO] [stderr] | [INFO] [stderr] 1191 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in cred_values", k)))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in cred_values", k)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/prover.rs:1211:18 [INFO] [stderr] | [INFO] [stderr] 1211 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in u1", i)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in u1", i)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/prover.rs:1243:14 [INFO] [stderr] | [INFO] [stderr] 1243 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in eq_proof.mtilde", k)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in eq_proof.mtilde", k)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/prover.rs:1303:18 [INFO] [stderr] | [INFO] [stderr] 1303 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in init_proof.mtilde", k)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in init_proof.mtilde", k)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/prover.rs:1306:18 [INFO] [stderr] | [INFO] [stderr] 1306 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in attributes_values", k)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in attributes_values", k)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/prover.rs:1326:22 [INFO] [stderr] | [INFO] [stderr] 1326 | .ok_or(IndyCryptoError::InvalidStructure(format!("Encoded value not found")))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Encoded value not found")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/prover.rs:1326:62 [INFO] [stderr] | [INFO] [stderr] 1326 | .ok_or(IndyCryptoError::InvalidStructure(format!("Encoded value not found")))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Encoded value not found".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/verifier.rs:260:58 [INFO] [stderr] | [INFO] [stderr] 260 | return Err(IndyCryptoError::InvalidStructure(format!("Credential doesn't contain requested attribute"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Credential doesn't contain requested attribute".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/verifier.rs:269:58 [INFO] [stderr] | [INFO] [stderr] 269 | return Err(IndyCryptoError::InvalidStructure(format!("Credential doesn't contain attribute requested in predicate"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Credential doesn't contain attribute requested in predicate".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cl/verifier.rs:277:54 [INFO] [stderr] | [INFO] [stderr] 277 | fn _check_verify_params_consistency(credentials: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[VerifiableCredential]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is used to index `credentials` [INFO] [stderr] --> src/cl/verifier.rs:282:20 [INFO] [stderr] | [INFO] [stderr] 282 | for idx in 0..proof.proofs.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 282 | for (idx, ) in credentials.iter().enumerate().take(proof.proofs.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/verifier.rs:289:68 [INFO] [stderr] | [INFO] [stderr] 289 | return Err(IndyCryptoError::AnoncredsProofRejected(format!("Proof revealed attributes not correspond to requested attributes"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Proof revealed attributes not correspond to requested attributes".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/verifier.rs:298:68 [INFO] [stderr] | [INFO] [stderr] 298 | return Err(IndyCryptoError::AnoncredsProofRejected(format!("Proof predicates not correspond to requested predicates"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Proof predicates not correspond to requested predicates".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/verifier.rs:359:18 [INFO] [stderr] | [INFO] [stderr] 359 | .ok_or(IndyCryptoError::AnoncredsProofRejected(format!("Value by key '{}' not found in pk.r", attr)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::AnoncredsProofRejected(format!("Value by key '{}' not found in pk.r", attr)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `tau_list` [INFO] [stderr] --> src/cl/verifier.rs:387:18 [INFO] [stderr] | [INFO] [stderr] 387 | for i in 0..ITERATION { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 387 | for (i, ) in tau_list.iter_mut().enumerate().take(ITERATION) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/verifier.rs:389:18 [INFO] [stderr] | [INFO] [stderr] 389 | .ok_or(IndyCryptoError::AnoncredsProofRejected(format!("Value by key '{}' not found in proof.t", i)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::AnoncredsProofRejected(format!("Value by key '{}' not found in proof.t", i)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/verifier.rs:398:14 [INFO] [stderr] | [INFO] [stderr] 398 | .ok_or(IndyCryptoError::AnoncredsProofRejected(format!("Value by key '{}' not found in proof.t", "DELTA")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::AnoncredsProofRejected(format!("Value by key '{}' not found in proof.t", "DELTA")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/cl/mod.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / pub fn clone(&self) -> Result { [INFO] [stderr] 96 | | Ok(match *self { [INFO] [stderr] 97 | | CredentialValue::Known { ref value } => CredentialValue::Known { [INFO] [stderr] 98 | | value: value.clone()?, [INFO] [stderr] ... | [INFO] [stderr] 110 | | }) [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/cl/mod.rs:150:5 [INFO] [stderr] | [INFO] [stderr] 150 | / pub fn clone(&self) -> Result { [INFO] [stderr] 151 | | Ok(CredentialValues { [INFO] [stderr] 152 | | attrs_values: clone_credential_value_map(&self.attrs_values)? [INFO] [stderr] 153 | | }) [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/cl/mod.rs:256:5 [INFO] [stderr] | [INFO] [stderr] 256 | / pub fn clone(&self) -> Result { [INFO] [stderr] 257 | | Ok(CredentialPublicKey { [INFO] [stderr] 258 | | p_key: self.p_key.clone()?, [INFO] [stderr] 259 | | r_key: self.r_key.clone() [INFO] [stderr] 260 | | }) [INFO] [stderr] 261 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/cl/mod.rs:274:20 [INFO] [stderr] | [INFO] [stderr] 274 | r_key: r_key.map(|key| key.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `r_key.cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/cl/mod.rs:298:5 [INFO] [stderr] | [INFO] [stderr] 298 | / pub fn clone(&self) -> Result { [INFO] [stderr] 299 | | Ok(CredentialPrimaryPublicKey { [INFO] [stderr] 300 | | n: self.n.clone()?, [INFO] [stderr] 301 | | s: self.s.clone()?, [INFO] [stderr] ... | [INFO] [stderr] 305 | | }) [INFO] [stderr] 306 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cl/mod.rs:420:20 [INFO] [stderr] | [INFO] [stderr] 420 | accum: rev_reg_to.accum.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rev_reg_to.accum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/mod.rs:428:58 [INFO] [stderr] | [INFO] [stderr] 428 | return Err(IndyCryptoError::InvalidStructure(format!("Deltas can not be merged."))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Deltas can not be merged.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/cl/mod.rs:499:5 [INFO] [stderr] | [INFO] [stderr] 499 | / pub fn next(&mut self) -> Result, IndyCryptoError> { [INFO] [stderr] 500 | | if self.current_index >= self.size { [INFO] [stderr] 501 | | return Ok(None); [INFO] [stderr] 502 | | } [INFO] [stderr] ... | [INFO] [stderr] 508 | | Ok(Some(tail)) [INFO] [stderr] 509 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/cl/mod.rs:524:12 [INFO] [stderr] | [INFO] [stderr] 524 | Ok(accessor(&self.tails[tail_id as usize])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 524 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cl/mod.rs:596:13 [INFO] [stderr] | [INFO] [stderr] 596 | (1..max_cred_num + 1).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=max_cred_num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/cl/mod.rs:673:5 [INFO] [stderr] | [INFO] [stderr] 673 | / pub fn clone(&self) -> Result { [INFO] [stderr] 674 | | Ok(MasterSecret { ms: self.ms.clone()? }) [INFO] [stderr] 675 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cl/mod.rs:1132:51 [INFO] [stderr] | [INFO] [stderr] 1132 | fn append_vec(&mut self, other: &Vec) -> Result<(), IndyCryptoError>; [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/bn/openssl.rs:404:5 [INFO] [stderr] | [INFO] [stderr] 404 | / pub fn clone(&self) -> Result { [INFO] [stderr] 405 | | Ok(BigNumber { [INFO] [stderr] 406 | | openssl_bn: BigNum::from_slice(&self.openssl_bn.to_vec()[..])? [INFO] [stderr] 407 | | }) [INFO] [stderr] 408 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bn/openssl.rs:410:29 [INFO] [stderr] | [INFO] [stderr] 410 | pub fn hash_array(nums: &Vec>) -> Result, IndyCryptoError> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:71:18 [INFO] [stderr] | [INFO] [stderr] 71 | *credential_pub_key_p = Box::into_raw(Box::new(credential_pub_key)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:72:18 [INFO] [stderr] | [INFO] [stderr] 72 | *credential_priv_key_p = Box::into_raw(Box::new(credential_priv_key)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:73:18 [INFO] [stderr] | [INFO] [stderr] 73 | *credential_key_correctness_proof_p = Box::into_raw(Box::new(credential_key_correctness_proof)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:75:25 [INFO] [stderr] | [INFO] [stderr] 75 | *credential_pub_key_p, *credential_priv_key_p, *credential_key_correctness_proof_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:75:48 [INFO] [stderr] | [INFO] [stderr] 75 | *credential_pub_key_p, *credential_priv_key_p, *credential_key_correctness_proof_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:75:72 [INFO] [stderr] | [INFO] [stderr] 75 | *credential_pub_key_p, *credential_priv_key_p, *credential_key_correctness_proof_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:106:18 [INFO] [stderr] | [INFO] [stderr] 106 | *credential_pub_key_json_p = issuer_pub_key_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:107:107 [INFO] [stderr] | [INFO] [stderr] 107 | trace!("indy_crypto_cl_credential_private_key_to_json: credential_pub_key_json_p: {:?}", *credential_pub_key_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:140:18 [INFO] [stderr] | [INFO] [stderr] 140 | *credential_pub_key_p = Box::into_raw(Box::new(credential_pub_key)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:141:104 [INFO] [stderr] | [INFO] [stderr] 141 | trace!("indy_crypto_cl_credential_public_key_from_json: *credential_pub_key_p: {:?}", *credential_pub_key_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let credential_pub_key =` [INFO] [stderr] --> src/ffi/cl/issuer.rs:162:5 [INFO] [stderr] | [INFO] [stderr] 162 | let credential_pub_key = unsafe { Box::from_raw(credential_pub_key as *mut CredentialPublicKey); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:191:18 [INFO] [stderr] | [INFO] [stderr] 191 | *credential_priv_key_json_p = credential_priv_key_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:192:108 [INFO] [stderr] | [INFO] [stderr] 192 | trace!("indy_crypto_cl_credential_private_key_to_json: credential_priv_key_json_p: {:?}", *credential_priv_key_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:225:18 [INFO] [stderr] | [INFO] [stderr] 225 | *credential_priv_key_p = Box::into_raw(Box::new(credential_priv_key)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:226:106 [INFO] [stderr] | [INFO] [stderr] 226 | trace!("indy_crypto_cl_credential_private_key_from_json: *credential_priv_key_p: {:?}", *credential_priv_key_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _credential_priv_key =` [INFO] [stderr] --> src/ffi/cl/issuer.rs:247:5 [INFO] [stderr] | [INFO] [stderr] 247 | let _credential_priv_key = unsafe { Box::from_raw(credential_priv_key as *mut CredentialPrivateKey); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:277:18 [INFO] [stderr] | [INFO] [stderr] 277 | *credential_key_correctness_proof_json_p = credential_key_correctness_proof_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:278:131 [INFO] [stderr] | [INFO] [stderr] 278 | trace!("indy_crypto_cl_credential_key_correctness_proof_to_json: credential_key_correctness_proof_json_p: {:?}", *credential_key_correctness_proof_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:312:18 [INFO] [stderr] | [INFO] [stderr] 312 | *credential_key_correctness_proof_p = Box::into_raw(Box::new(credential_key_correctness_proof)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:313:129 [INFO] [stderr] | [INFO] [stderr] 313 | trace!("indy_crypto_cl_credential_key_correctness_proof_from_json: *credential_key_correctness_proof_p: {:?}", *credential_key_correctness_proof_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let credential_key_correctness_proof =` [INFO] [stderr] --> src/ffi/cl/issuer.rs:334:5 [INFO] [stderr] | [INFO] [stderr] 334 | let credential_key_correctness_proof = unsafe { Box::from_raw(credential_key_correctness_proof as *mut CredentialKeyCorrectnessProof); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:390:18 [INFO] [stderr] | [INFO] [stderr] 390 | *rev_key_pub_p = Box::into_raw(Box::new(rev_key_pub)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:391:18 [INFO] [stderr] | [INFO] [stderr] 391 | *rev_key_priv_p = Box::into_raw(Box::new(rev_key_priv)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:392:18 [INFO] [stderr] | [INFO] [stderr] 392 | *rev_reg_p = Box::into_raw(Box::new(rev_reg)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:393:18 [INFO] [stderr] | [INFO] [stderr] 393 | *rev_tails_generator_p = Box::into_raw(Box::new(rev_tails_generator)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:395:25 [INFO] [stderr] | [INFO] [stderr] 395 | *rev_key_pub_p, *rev_key_priv_p, *rev_reg_p, *rev_tails_generator_p); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:395:41 [INFO] [stderr] | [INFO] [stderr] 395 | *rev_key_pub_p, *rev_key_priv_p, *rev_reg_p, *rev_tails_generator_p); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:395:58 [INFO] [stderr] | [INFO] [stderr] 395 | *rev_key_pub_p, *rev_key_priv_p, *rev_reg_p, *rev_tails_generator_p); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:395:70 [INFO] [stderr] | [INFO] [stderr] 395 | *rev_key_pub_p, *rev_key_priv_p, *rev_reg_p, *rev_tails_generator_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:427:18 [INFO] [stderr] | [INFO] [stderr] 427 | *rev_key_pub_json_p = rev_reg_def_pub_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:428:99 [INFO] [stderr] | [INFO] [stderr] 428 | trace!("indy_crypto_cl_revocation_key_public_to_json: rev_key_pub_json_p: {:?}", *rev_key_pub_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:461:18 [INFO] [stderr] | [INFO] [stderr] 461 | *rev_key_pub_p = Box::into_raw(Box::new(rev_key_pub)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:462:97 [INFO] [stderr] | [INFO] [stderr] 462 | trace!("indy_crypto_cl_revocation_key_public_from_json: *rev_key_pub_p: {:?}", *rev_key_pub_p); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let rev_key_pub =` [INFO] [stderr] --> src/ffi/cl/issuer.rs:482:5 [INFO] [stderr] | [INFO] [stderr] 482 | let rev_key_pub = unsafe { Box::from_raw(rev_key_pub as *mut RevocationKeyPublic); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:512:18 [INFO] [stderr] | [INFO] [stderr] 512 | *rev_key_priv_json_p = rev_reg_def_priv_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:513:101 [INFO] [stderr] | [INFO] [stderr] 513 | trace!("indy_crypto_cl_revocation_key_private_to_json: rev_key_priv_json_p: {:?}", *rev_key_priv_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:547:18 [INFO] [stderr] | [INFO] [stderr] 547 | *rev_key_priv_p = Box::into_raw(Box::new(rev_key_priv)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:548:99 [INFO] [stderr] | [INFO] [stderr] 548 | trace!("indy_crypto_cl_revocation_key_private_from_json: *rev_key_priv_p: {:?}", *rev_key_priv_p); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _rev_key_priv =` [INFO] [stderr] --> src/ffi/cl/issuer.rs:569:5 [INFO] [stderr] | [INFO] [stderr] 569 | let _rev_key_priv = unsafe { Box::from_raw(rev_key_priv as *mut RevocationKeyPrivate); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:599:18 [INFO] [stderr] | [INFO] [stderr] 599 | *rev_reg_json_p = rev_reg_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:600:93 [INFO] [stderr] | [INFO] [stderr] 600 | trace!("indy_crypto_cl_revocation_registry_to_json: rev_reg_json_p: {:?}", *rev_reg_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:634:18 [INFO] [stderr] | [INFO] [stderr] 634 | *rev_reg_p = Box::into_raw(Box::new(rev_reg)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:635:91 [INFO] [stderr] | [INFO] [stderr] 635 | trace!("indy_crypto_cl_revocation_registry_from_json: *rev_reg_p: {:?}", *rev_reg_p); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let rev_reg =` [INFO] [stderr] --> src/ffi/cl/issuer.rs:656:5 [INFO] [stderr] | [INFO] [stderr] 656 | let rev_reg = unsafe { Box::from_raw(rev_reg as *mut RevocationRegistry); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:686:18 [INFO] [stderr] | [INFO] [stderr] 686 | *rev_tails_generator_json_p = rev_tails_generator_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:687:112 [INFO] [stderr] | [INFO] [stderr] 687 | trace!("indy_crypto_cl_revocation_tails_generator_to_json: rev_tails_generator_json_p: {:?}", *rev_tails_generator_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:721:18 [INFO] [stderr] | [INFO] [stderr] 721 | *rev_tails_generator_p = Box::into_raw(Box::new(rev_tails_generator)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:722:110 [INFO] [stderr] | [INFO] [stderr] 722 | trace!("indy_crypto_cl_revocation_tails_generator_from_json: *rev_tails_generator_p: {:?}", *rev_tails_generator_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let rev_tails_generator =` [INFO] [stderr] --> src/ffi/cl/issuer.rs:743:5 [INFO] [stderr] | [INFO] [stderr] 743 | let rev_tails_generator = unsafe { Box::from_raw(rev_tails_generator as *mut RevocationTailsGenerator); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:817:18 [INFO] [stderr] | [INFO] [stderr] 817 | *credential_signature_p = Box::into_raw(Box::new(credential_signature)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:818:18 [INFO] [stderr] | [INFO] [stderr] 818 | *credential_signature_correctness_proof_p = Box::into_raw(Box::new(credential_signature_correctness_proof)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:820:25 [INFO] [stderr] | [INFO] [stderr] 820 | *credential_signature_p, *credential_signature_correctness_proof_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:820:50 [INFO] [stderr] | [INFO] [stderr] 820 | *credential_signature_p, *credential_signature_correctness_proof_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:924:18 [INFO] [stderr] | [INFO] [stderr] 924 | *credential_signature_p = Box::into_raw(Box::new(credential_signature)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:925:18 [INFO] [stderr] | [INFO] [stderr] 925 | *credential_signature_correctness_proof_p = Box::into_raw(Box::new(credential_signature_correctness_proof)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:926:18 [INFO] [stderr] | [INFO] [stderr] 926 | *revocation_registry_delta_p = if let Some(delta) = delta { Box::into_raw(Box::new(delta)) as *const c_void } else { null() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:928:25 [INFO] [stderr] | [INFO] [stderr] 928 | *credential_signature_p, *credential_signature_correctness_proof_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:928:50 [INFO] [stderr] | [INFO] [stderr] 928 | *credential_signature_p, *credential_signature_correctness_proof_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:960:18 [INFO] [stderr] | [INFO] [stderr] 960 | *credential_signature_json_p = credential_signature_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:961:107 [INFO] [stderr] | [INFO] [stderr] 961 | trace!("indy_crypto_cl_credential_signature_to_json: credential_signature_json_p: {:?}", *credential_signature_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:995:18 [INFO] [stderr] | [INFO] [stderr] 995 | *credential_signature_p = Box::into_raw(Box::new(credential_signature)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:996:105 [INFO] [stderr] | [INFO] [stderr] 996 | trace!("indy_crypto_cl_credential_signature_from_json: *credential_signature_p: {:?}", *credential_signature_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _credential_signature =` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1017:5 [INFO] [stderr] | [INFO] [stderr] 1017 | let _credential_signature = unsafe { Box::from_raw(credential_signature as *mut CredentialSignature); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1046:18 [INFO] [stderr] | [INFO] [stderr] 1046 | *signature_correctness_proof_json_p = signature_correctness_proof_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1047:121 [INFO] [stderr] | [INFO] [stderr] 1047 | trace!("indy_crypto_cl_signature_correctness_proof_to_json: signature_correctness_proof_json_p: {:?}", *signature_correctness_proof_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1081:18 [INFO] [stderr] | [INFO] [stderr] 1081 | *signature_correctness_proof_p = Box::into_raw(Box::new(signature_correctness_proof)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1082:119 [INFO] [stderr] | [INFO] [stderr] 1082 | trace!("indy_crypto_cl_signature_correctness_proof_from_json: *signature_correctness_proof_p: {:?}", *signature_correctness_proof_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let signature_correctness_proof =` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1103:5 [INFO] [stderr] | [INFO] [stderr] 1103 | let signature_correctness_proof = unsafe { Box::from_raw(signature_correctness_proof as *mut SignatureCorrectnessProof); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1132:18 [INFO] [stderr] | [INFO] [stderr] 1132 | *revocation_registry_delta_json_p = revocation_registry_delta_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1133:117 [INFO] [stderr] | [INFO] [stderr] 1133 | trace!("indy_crypto_cl_revocation_registry_delta_to_json: revocation_registry_delta_json_p: {:?}", *revocation_registry_delta_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1167:18 [INFO] [stderr] | [INFO] [stderr] 1167 | *revocation_registry_delta_p = Box::into_raw(Box::new(revocation_registry_delta)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1168:115 [INFO] [stderr] | [INFO] [stderr] 1168 | trace!("indy_crypto_cl_revocation_registry_delta_from_json: *revocation_registry_delta_p: {:?}", *revocation_registry_delta_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let revocation_registry_delta =` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1189:5 [INFO] [stderr] | [INFO] [stderr] 1189 | let revocation_registry_delta = unsafe { Box::from_raw(revocation_registry_delta as *mut RevocationRegistryDelta); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:110:72 [INFO] [stderr] | [INFO] [stderr] 110 | let $ptr = HashSet::from_iter( unsafe { slice::from_raw_parts($ptr, $len) }.iter().cloned()); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/cl/issuer.rs:1209:5 [INFO] [stderr] | [INFO] [stderr] 1209 | check_useful_hashset!(issued, issued_len, ErrorCode::CommonInvalidParam3, ErrorCode::CommonInvalidParam4); [INFO] [stderr] | ---------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:110:72 [INFO] [stderr] | [INFO] [stderr] 110 | let $ptr = HashSet::from_iter( unsafe { slice::from_raw_parts($ptr, $len) }.iter().cloned()); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/cl/issuer.rs:1210:5 [INFO] [stderr] | [INFO] [stderr] 1210 | check_useful_hashset!(revoked, revoked_len, ErrorCode::CommonInvalidParam5, ErrorCode::CommonInvalidParam6); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1221:10 [INFO] [stderr] | [INFO] [stderr] 1221 | *rev_reg_delta_p = Box::into_raw(Box::new(rev_reg_delta)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1222:93 [INFO] [stderr] | [INFO] [stderr] 1222 | trace!("indy_crypto_revocation_registry_delta_from_parts: *rev_reg_delta_p: {:?}", *rev_reg_delta_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1257:18 [INFO] [stderr] | [INFO] [stderr] 1257 | *rev_reg_delta_p = Box::into_raw(Box::new(rev_reg_delta)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1258:92 [INFO] [stderr] | [INFO] [stderr] 1258 | trace!("indy_crypto_cl_issuer_revoke_credential: *rev_reg_delta_p: {:?}", *rev_reg_delta_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1295:18 [INFO] [stderr] | [INFO] [stderr] 1295 | *rev_reg_delta_p = Box::into_raw(Box::new(rev_reg_delta)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1296:94 [INFO] [stderr] | [INFO] [stderr] 1296 | trace!("indy_crypto_cl_issuer_recovery_credential: *rev_reg_delta_p: {:?}", *rev_reg_delta_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1324:18 [INFO] [stderr] | [INFO] [stderr] 1324 | *merged_revoc_reg_delta_p = Box::into_raw(Box::new(merged_revoc_reg_delta)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1325:116 [INFO] [stderr] | [INFO] [stderr] 1325 | trace!("indy_crypto_cl_issuer_merge_revocation_registry_deltas: *merged_revoc_reg_delta_p: {:?}", *merged_revoc_reg_delta_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ffi/cl/issuer.rs:1324:68 [INFO] [stderr] | [INFO] [stderr] 1324 | *merged_revoc_reg_delta_p = Box::into_raw(Box::new(merged_revoc_reg_delta)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 1324 | *merged_revoc_reg_delta_p = Box::into_raw(Box::new(())) as *const c_void; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/ffi/cl/issuer.rs:2122:5 [INFO] [stderr] | [INFO] [stderr] 2122 | / pub fn _credential_signature_with_revoc(blinded_credential_secrets: *const c_void, [INFO] [stderr] 2123 | | blinded_credential_secrets_correctness_proof: *const c_void, [INFO] [stderr] 2124 | | credential_nonce: *const c_void, [INFO] [stderr] 2125 | | credential_issuance_nonce: *const c_void, [INFO] [stderr] ... | [INFO] [stderr] 2164 | | (credential_signature_p, credential_signature_correctness_proof_p, revocation_registry_delta_p) [INFO] [stderr] 2165 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | *master_secret_p = Box::into_raw(Box::new(master_secret)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:29:92 [INFO] [stderr] | [INFO] [stderr] 29 | trace!("indy_crypto_cl_prover_new_master_secret: *master_secret_p: {:?}", *master_secret_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | *master_secret_json_p = master_secret_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:61:93 [INFO] [stderr] | [INFO] [stderr] 61 | trace!("indy_crypto_cl_master_secret_to_json: master_secret_json_p: {:?}", *master_secret_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:94:18 [INFO] [stderr] | [INFO] [stderr] 94 | *master_secret_p = Box::into_raw(Box::new(master_secret)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:95:91 [INFO] [stderr] | [INFO] [stderr] 95 | trace!("indy_crypto_cl_master_secret_from_json: *master_secret_p: {:?}", *master_secret_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let master_secret =` [INFO] [stderr] --> src/ffi/cl/prover.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | let master_secret = unsafe { Box::from_raw(master_secret as *mut MasterSecret); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:196:18 [INFO] [stderr] | [INFO] [stderr] 196 | *blinded_credential_secrets_p = Box::into_raw(Box::new(blinded_credential_secrets)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:197:18 [INFO] [stderr] | [INFO] [stderr] 197 | *credential_secrets_blinding_factors_p = Box::into_raw(Box::new(credential_secrets_blinding_factors)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:198:18 [INFO] [stderr] | [INFO] [stderr] 198 | *blinded_credential_secrets_correctness_proof_p = Box::into_raw(Box::new(blinded_credential_secrets_correctness_proof)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:202:74 [INFO] [stderr] | [INFO] [stderr] 202 | *blinded_credential_secrets_p, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:203:74 [INFO] [stderr] | [INFO] [stderr] 203 | *credential_secrets_blinding_factors_p, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:204:74 [INFO] [stderr] | [INFO] [stderr] 204 | *blinded_credential_secrets_correctness_proof_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:236:18 [INFO] [stderr] | [INFO] [stderr] 236 | *blinded_credential_secrets_json_p = blinded_credential_secrets_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:238:119 [INFO] [stderr] | [INFO] [stderr] 238 | trace!("indy_crypto_cl_blinded_credential_secrets_to_json: blinded_credential_secrets_json_p: {:?}", *blinded_credential_secrets_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:271:18 [INFO] [stderr] | [INFO] [stderr] 271 | *blinded_credential_secrets_p = Box::into_raw(Box::new(blinded_credential_secrets)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:272:117 [INFO] [stderr] | [INFO] [stderr] 272 | trace!("indy_crypto_cl_blinded_credential_secrets_from_json: *blinded_credential_secrets_p: {:?}", *blinded_credential_secrets_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let blinded_credential_secrets =` [INFO] [stderr] --> src/ffi/cl/prover.rs:293:5 [INFO] [stderr] | [INFO] [stderr] 293 | let blinded_credential_secrets = unsafe { Box::from_raw(blinded_credential_secrets as *mut BlindedCredentialSecrets); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:323:18 [INFO] [stderr] | [INFO] [stderr] 323 | *credential_secrets_blinding_factors_json_p = credential_secrets_blinding_factors_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:324:136 [INFO] [stderr] | [INFO] [stderr] 324 | trace!("indy_crypto_cl_credential_secret_blinding_factors_to_json: credential_secrets_blinding_factors_json_p: {:?}", *credential_secrets_blinding_factors_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:358:18 [INFO] [stderr] | [INFO] [stderr] 358 | *credential_secrets_blinding_factors_p = Box::into_raw(Box::new(credential_secrets_blinding_factors)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:359:135 [INFO] [stderr] | [INFO] [stderr] 359 | trace!("indy_crypto_cl_credential_secrets_blinding_factors_from_json: *credential_secrets_blinding_factors_p: {:?}", *credential_secrets_blinding_factors_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let credential_secrets_blinding_factors =` [INFO] [stderr] --> src/ffi/cl/prover.rs:380:5 [INFO] [stderr] | [INFO] [stderr] 380 | let credential_secrets_blinding_factors = unsafe { Box::from_raw(credential_secrets_blinding_factors as *mut CredentialSecretsBlindingFactors); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:412:18 [INFO] [stderr] | [INFO] [stderr] 412 | *blinded_credential_secrets_correctness_proof_json_p = blinded_credential_secrets_correctness_proof_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:414:25 [INFO] [stderr] | [INFO] [stderr] 414 | *blinded_credential_secrets_correctness_proof_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:450:18 [INFO] [stderr] | [INFO] [stderr] 450 | *blinded_credential_secrets_correctness_proof_p = Box::into_raw(Box::new(blinded_credential_secrets_correctness_proof)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:452:25 [INFO] [stderr] | [INFO] [stderr] 452 | *blinded_credential_secrets_correctness_proof_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let blinded_credential_secrets_correctness_proof =` [INFO] [stderr] --> src/ffi/cl/prover.rs:474:5 [INFO] [stderr] | [INFO] [stderr] 474 | let blinded_credential_secrets_correctness_proof = unsafe { Box::from_raw(blinded_credential_secrets_correctness_proof as *mut BlindedCredentialSecretsCorrectnessProof); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:576:18 [INFO] [stderr] | [INFO] [stderr] 576 | *cred_rev_indx = index; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:607:18 [INFO] [stderr] | [INFO] [stderr] 607 | *proof_builder_p = Box::into_raw(Box::new(proof_builder)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:608:92 [INFO] [stderr] | [INFO] [stderr] 608 | trace!("indy_crypto_cl_prover_new_proof_builder: *proof_builder_p: {:?}", *proof_builder_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:735:18 [INFO] [stderr] | [INFO] [stderr] 735 | *proof_p = Box::into_raw(Box::new(proof)) as *const c_void; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:736:82 [INFO] [stderr] | [INFO] [stderr] 736 | trace!("indy_crypto_cl_proof_builder_finalize: *proof_p: {:?}", *proof_p); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:767:18 [INFO] [stderr] | [INFO] [stderr] 767 | *proof_json_p = proof_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:768:77 [INFO] [stderr] | [INFO] [stderr] 768 | trace!("indy_crypto_cl_proof_to_json: proof_json_p: {:?}", *proof_json_p); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:800:18 [INFO] [stderr] | [INFO] [stderr] 800 | *proof_p = Box::into_raw(Box::new(proof)) as *const c_void; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:801:75 [INFO] [stderr] | [INFO] [stderr] 801 | trace!("indy_crypto_cl_proof_from_json: *proof_p: {:?}", *proof_p); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let proof =` [INFO] [stderr] --> src/ffi/cl/prover.rs:822:5 [INFO] [stderr] | [INFO] [stderr] 822 | let proof = unsafe { Box::from_raw(proof as *mut Proof); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/ffi/cl/prover.rs:1509:5 [INFO] [stderr] | [INFO] [stderr] 1509 | / pub fn _process_credential_signature(credential_signature: *const c_void, [INFO] [stderr] 1510 | | signature_correctness_proof: *const c_void, [INFO] [stderr] 1511 | | credential_secrets_blinding_factors: *const c_void, [INFO] [stderr] 1512 | | credential_values: *const c_void, [INFO] [stderr] ... | [INFO] [stderr] 1526 | | assert_eq!(err_code, ErrorCode::Success); [INFO] [stderr] 1527 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/verifier.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | *proof_verifier_p = Box::into_raw(Box::new(proof_verifier)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/verifier.rs:26:96 [INFO] [stderr] | [INFO] [stderr] 26 | trace!("indy_crypto_cl_verifier_new_proof_verifier: *proof_verifier_p: {:?}", *proof_verifier_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/verifier.rs:108:18 [INFO] [stderr] | [INFO] [stderr] 108 | *valid_p = valid; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/verifier.rs:109:81 [INFO] [stderr] | [INFO] [stderr] 109 | trace!("indy_crypto_cl_proof_verifier_verify: *valid_p: {:?}", *valid_p); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:33:22 [INFO] [stderr] | [INFO] [stderr] 33 | *tail_p = Box::into_raw(Box::new(tail)) as *const c_void; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:35:22 [INFO] [stderr] | [INFO] [stderr] 35 | *tail_p = ptr::null(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:37:79 [INFO] [stderr] | [INFO] [stderr] 37 | trace!("indy_crypto_cl_tails_generator_next: *tail_p: {:?}", *tail_p); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:59:10 [INFO] [stderr] | [INFO] [stderr] 59 | *count_p = cnt; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:60:73 [INFO] [stderr] | [INFO] [stderr] 60 | trace!("indy_crypto_cl_tails_generator_count: *count_p: {:?}", *count_p); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let tail =` [INFO] [stderr] --> src/ffi/cl/mod.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | let tail = unsafe { Box::from_raw(tail as *mut Tail); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | *witness_p = Box::into_raw(Box::new(witness)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:103:73 [INFO] [stderr] | [INFO] [stderr] 103 | trace!("indy_crypto_cl_witness_new: *witness_p: {:?}", *witness_p); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let witness =` [INFO] [stderr] --> src/ffi/cl/mod.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | let witness = unsafe { Box::from_raw(witness as *mut Witness); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:173:18 [INFO] [stderr] | [INFO] [stderr] 173 | *credential_schema_builder_p = Box::into_raw(Box::new(credential_schema_builder)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:174:109 [INFO] [stderr] | [INFO] [stderr] 174 | trace!("indy_crypto_cl_credential_schema_builder_new: *credential_schema_builder_p: {:?}", *credential_schema_builder_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:233:18 [INFO] [stderr] | [INFO] [stderr] 233 | *credential_schema_p = Box::into_raw(Box::new(credential_schema)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:234:106 [INFO] [stderr] | [INFO] [stderr] 234 | trace!("indy_crypto_cl_credential_schema_builder_finalize: *credential_schema_p: {:?}", *credential_schema_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let credential_schema =` [INFO] [stderr] --> src/ffi/cl/mod.rs:255:5 [INFO] [stderr] | [INFO] [stderr] 255 | let credential_schema = unsafe { Box::from_raw(credential_schema as *mut CredentialSchema); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:284:18 [INFO] [stderr] | [INFO] [stderr] 284 | *non_credential_schema_builder_p = Box::into_raw(Box::new(non_credential_schema_builder)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:285:109 [INFO] [stderr] | [INFO] [stderr] 285 | trace!("indy_crypto_cl_credential_schema_builder_new: *credential_schema_builder_p: {:?}", *non_credential_schema_builder_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:344:18 [INFO] [stderr] | [INFO] [stderr] 344 | *non_credential_schema_p = Box::into_raw(Box::new(non_credential_schema)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:345:110 [INFO] [stderr] | [INFO] [stderr] 345 | trace!("indy_crypto_cl_non_credential_schema_builder_finalize: *credential_schema_p: {:?}", *non_credential_schema_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let non_credential_schema =` [INFO] [stderr] --> src/ffi/cl/mod.rs:366:5 [INFO] [stderr] | [INFO] [stderr] 366 | let non_credential_schema = unsafe { Box::from_raw(non_credential_schema as *mut NonCredentialSchema); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:395:18 [INFO] [stderr] | [INFO] [stderr] 395 | *credential_values_builder_p = Box::into_raw(Box::new(credential_values_builder)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:396:109 [INFO] [stderr] | [INFO] [stderr] 396 | trace!("indy_crypto_cl_credential_values_builder_new: *credential_values_builder_p: {:?}", *credential_values_builder_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:518:18 [INFO] [stderr] | [INFO] [stderr] 518 | *credential_values_p = Box::into_raw(Box::new(credential_values)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:519:106 [INFO] [stderr] | [INFO] [stderr] 519 | trace!("indy_crypto_cl_credential_values_builder_finalize: *credential_values_p: {:?}", *credential_values_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let credential_values =` [INFO] [stderr] --> src/ffi/cl/mod.rs:540:5 [INFO] [stderr] | [INFO] [stderr] 540 | let credential_values = unsafe { Box::from_raw(credential_values as *mut CredentialValues); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:569:18 [INFO] [stderr] | [INFO] [stderr] 569 | *sub_proof_request_builder_p = Box::into_raw(Box::new(sub_proof_request_builder)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:570:109 [INFO] [stderr] | [INFO] [stderr] 570 | trace!("indy_crypto_cl_sub_proof_request_builder_new: *sub_proof_request_builder_p: {:?}", *sub_proof_request_builder_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:663:18 [INFO] [stderr] | [INFO] [stderr] 663 | *sub_proof_request_p = Box::into_raw(Box::new(sub_proof_request)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:664:106 [INFO] [stderr] | [INFO] [stderr] 664 | trace!("indy_crypto_cl_sub_proof_request_builder_finalize: *sub_proof_request_p: {:?}", *sub_proof_request_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let sub_proof_request =` [INFO] [stderr] --> src/ffi/cl/mod.rs:685:5 [INFO] [stderr] | [INFO] [stderr] 685 | let sub_proof_request = unsafe { Box::from_raw(sub_proof_request as *mut SubProofRequest); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:710:18 [INFO] [stderr] | [INFO] [stderr] 710 | *nonce_p = Box::into_raw(Box::new(nonce)) as *const c_void; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:711:69 [INFO] [stderr] | [INFO] [stderr] 711 | trace!("indy_crypto_cl_new_nonce: *nonce_p: {:?}", *nonce_p); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:742:18 [INFO] [stderr] | [INFO] [stderr] 742 | *nonce_json_p = nonce_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:743:77 [INFO] [stderr] | [INFO] [stderr] 743 | trace!("indy_crypto_cl_nonce_to_json: nonce_json_p: {:?}", *nonce_json_p); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:775:18 [INFO] [stderr] | [INFO] [stderr] 775 | *nonce_p = Box::into_raw(Box::new(nonce)) as *const c_void; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:776:75 [INFO] [stderr] | [INFO] [stderr] 776 | trace!("indy_crypto_cl_nonce_from_json: *nonce_p: {:?}", *nonce_p); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let nonce =` [INFO] [stderr] --> src/ffi/cl/mod.rs:797:5 [INFO] [stderr] | [INFO] [stderr] 797 | let nonce = unsafe { Box::from_raw(nonce as *mut Nonce); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/ffi/cl/mod.rs:1410:16 [INFO] [stderr] | [INFO] [stderr] 1410 | tails: Box> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::box_vec)] on by default [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:1446:23 [INFO] [stderr] | [INFO] [stderr] 1446 | unsafe { *tail_p = tail }; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ffi/cl/mod.rs:1444:40 [INFO] [stderr] | [INFO] [stderr] 1444 | let tail: *const c_void = *tails.get(idx as usize).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `tails[idx as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | *gen_p = Box::into_raw(Box::new(gen)) as *const c_void; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:28:72 [INFO] [stderr] | [INFO] [stderr] 28 | trace!("indy_crypto_bls_generator_new: *gen_p: {:?}", *gen_p); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | let $ptr = unsafe { slice::from_raw_parts($ptr, $len) }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/bls.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / check_useful_c_byte_array!(bytes, bytes_len, [INFO] [stderr] 53 | | ErrorCode::CommonInvalidParam1, ErrorCode::CommonInvalidParam2); [INFO] [stderr] | |_______________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:62:18 [INFO] [stderr] | [INFO] [stderr] 62 | *gen_p = Box::into_raw(Box::new(gen)) as *const c_void; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:63:79 [INFO] [stderr] | [INFO] [stderr] 63 | trace!("indy_crypto_bls_generator_from_bytes: *gen_p: {:?}", *gen_p); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:94:10 [INFO] [stderr] | [INFO] [stderr] 94 | *bytes_p = gen.as_bytes().as_ptr(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:95:10 [INFO] [stderr] | [INFO] [stderr] 95 | *bytes_len_p = gen.as_bytes().len(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:51:49 [INFO] [stderr] | [INFO] [stderr] 51 | unsafe { Some(slice::from_raw_parts($ptr, $len)) } [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/bls.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | / check_useful_opt_c_byte_array!(seed, seed_len, [INFO] [stderr] 136 | | ErrorCode::CommonInvalidParam1, ErrorCode::CommonInvalidParam2); [INFO] [stderr] | |___________________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:144:18 [INFO] [stderr] | [INFO] [stderr] 144 | *sign_key_p = Box::into_raw(Box::new(sign_key)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:145:76 [INFO] [stderr] | [INFO] [stderr] 145 | trace!("indy_crypto_bls_sign_key_new: *sign_key_p: {:?}", *sign_key_p); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | let $ptr = unsafe { slice::from_raw_parts($ptr, $len) }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/bls.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | / check_useful_c_byte_array!(bytes, bytes_len, [INFO] [stderr] 170 | | ErrorCode::CommonInvalidParam1, ErrorCode::CommonInvalidParam2); [INFO] [stderr] | |_______________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:179:18 [INFO] [stderr] | [INFO] [stderr] 179 | *sign_key_p = Box::into_raw(Box::new(sign_key)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:180:83 [INFO] [stderr] | [INFO] [stderr] 180 | trace!("indy_crypto_bls_sign_key_from_bytes: *sign_key_p: {:?}", *sign_key_p); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:211:10 [INFO] [stderr] | [INFO] [stderr] 211 | *bytes_p = sign_key.as_bytes().as_ptr(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:212:10 [INFO] [stderr] | [INFO] [stderr] 212 | *bytes_len_p = sign_key.as_bytes().len(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:261:18 [INFO] [stderr] | [INFO] [stderr] 261 | *ver_key_p = Box::into_raw(Box::new(ver_key)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:262:74 [INFO] [stderr] | [INFO] [stderr] 262 | trace!("indy_crypto_bls_ver_key_new: *ver_key_p: {:?}", *ver_key_p); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | let $ptr = unsafe { slice::from_raw_parts($ptr, $len) }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/bls.rs:286:5 [INFO] [stderr] | [INFO] [stderr] 286 | / check_useful_c_byte_array!(bytes, bytes_len, [INFO] [stderr] 287 | | ErrorCode::CommonInvalidParam1, ErrorCode::CommonInvalidParam2); [INFO] [stderr] | |_______________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:296:18 [INFO] [stderr] | [INFO] [stderr] 296 | *ver_key_p = Box::into_raw(Box::new(ver_key)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:297:81 [INFO] [stderr] | [INFO] [stderr] 297 | trace!("indy_crypto_bls_ver_key_from_bytes: *ver_key_p: {:?}", *ver_key_p); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:328:10 [INFO] [stderr] | [INFO] [stderr] 328 | *bytes_p = ver_key.as_bytes().as_ptr(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:329:10 [INFO] [stderr] | [INFO] [stderr] 329 | *bytes_len_p = ver_key.as_bytes().len(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:378:18 [INFO] [stderr] | [INFO] [stderr] 378 | *pop_p = Box::into_raw(Box::new(pop)) as *const c_void; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:379:66 [INFO] [stderr] | [INFO] [stderr] 379 | trace!("indy_crypto_bls_pop_new: *pop_p: {:?}", *pop_p); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | let $ptr = unsafe { slice::from_raw_parts($ptr, $len) }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/bls.rs:403:5 [INFO] [stderr] | [INFO] [stderr] 403 | / check_useful_c_byte_array!(bytes, bytes_len, [INFO] [stderr] 404 | | ErrorCode::CommonInvalidParam1, ErrorCode::CommonInvalidParam2); [INFO] [stderr] | |_______________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:413:18 [INFO] [stderr] | [INFO] [stderr] 413 | *pop_p = Box::into_raw(Box::new(pop)) as *const c_void; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:414:73 [INFO] [stderr] | [INFO] [stderr] 414 | trace!("indy_crypto_bls_pop_from_bytes: *pop_p: {:?}", *pop_p); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:445:10 [INFO] [stderr] | [INFO] [stderr] 445 | *bytes_p = pop.as_bytes().as_ptr(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:446:10 [INFO] [stderr] | [INFO] [stderr] 446 | *bytes_len_p = pop.as_bytes().len(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | let $ptr = unsafe { slice::from_raw_parts($ptr, $len) }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/bls.rs:485:5 [INFO] [stderr] | [INFO] [stderr] 485 | / check_useful_c_byte_array!(bytes, bytes_len, [INFO] [stderr] 486 | | ErrorCode::CommonInvalidParam1, ErrorCode::CommonInvalidParam2); [INFO] [stderr] | |_______________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:495:18 [INFO] [stderr] | [INFO] [stderr] 495 | *signature_p = Box::into_raw(Box::new(signature)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:496:85 [INFO] [stderr] | [INFO] [stderr] 496 | trace!("indy_crypto_bls_signature_from_bytes: *signature_p: {:?}", *signature_p); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:527:10 [INFO] [stderr] | [INFO] [stderr] 527 | *bytes_p = signature.as_bytes().as_ptr(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:528:10 [INFO] [stderr] | [INFO] [stderr] 528 | *bytes_len_p = signature.as_bytes().len(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:97:44 [INFO] [stderr] | [INFO] [stderr] 97 | unsafe { slice::from_raw_parts($ptrs, $ptrs_len) } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/bls.rs:568:5 [INFO] [stderr] | [INFO] [stderr] 568 | check_useful_c_reference_array!(signatures, signatures_len, Signature, ErrorCode::CommonInvalidParam1, ErrorCode::CommonInvalidParam2); [INFO] [stderr] | --------------------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:577:18 [INFO] [stderr] | [INFO] [stderr] 577 | *multi_sig_p = Box::into_raw(Box::new(multi_sig)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:578:84 [INFO] [stderr] | [INFO] [stderr] 578 | trace!("indy_crypto_bls_multi_signature_new: *multi_sig_p: {:?}", *multi_sig_p); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | let $ptr = unsafe { slice::from_raw_parts($ptr, $len) }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/bls.rs:602:5 [INFO] [stderr] | [INFO] [stderr] 602 | / check_useful_c_byte_array!(bytes, bytes_len, [INFO] [stderr] 603 | | ErrorCode::CommonInvalidParam1, ErrorCode::CommonInvalidParam2); [INFO] [stderr] | |_______________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:612:18 [INFO] [stderr] | [INFO] [stderr] 612 | *multi_sig_p = Box::into_raw(Box::new(multi_sig)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:613:91 [INFO] [stderr] | [INFO] [stderr] 613 | trace!("indy_crypto_bls_multi_signature_from_bytes: *multi_sig_p: {:?}", *multi_sig_p); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:645:10 [INFO] [stderr] | [INFO] [stderr] 645 | *bytes_p = multi_sig.as_bytes().as_ptr(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:646:10 [INFO] [stderr] | [INFO] [stderr] 646 | *bytes_len_p = multi_sig.as_bytes().len(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | let $ptr = unsafe { slice::from_raw_parts($ptr, $len) }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/bls.rs:690:5 [INFO] [stderr] | [INFO] [stderr] 690 | / check_useful_c_byte_array!(message, message_len, [INFO] [stderr] 691 | | ErrorCode::CommonInvalidParam1, ErrorCode::CommonInvalidParam2); [INFO] [stderr] | |_______________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:701:18 [INFO] [stderr] | [INFO] [stderr] 701 | *signature_p = Box::into_raw(Box::new(signature)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:702:69 [INFO] [stderr] | [INFO] [stderr] 702 | trace!("indy_crypto_bls_sign: *signature_p: {:?}", *signature_p); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | let $ptr = unsafe { slice::from_raw_parts($ptr, $len) }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/bls.rs:733:5 [INFO] [stderr] | [INFO] [stderr] 733 | / check_useful_c_byte_array!(message, message_len, [INFO] [stderr] 734 | | ErrorCode::CommonInvalidParam2, ErrorCode::CommonInvalidParam3); [INFO] [stderr] | |_______________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:744:23 [INFO] [stderr] | [INFO] [stderr] 744 | unsafe { *valid_p = valid; } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | let $ptr = unsafe { slice::from_raw_parts($ptr, $len) }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/bls.rs:776:5 [INFO] [stderr] | [INFO] [stderr] 776 | check_useful_c_byte_array!(message, message_len, ErrorCode::CommonInvalidParam2, ErrorCode::CommonInvalidParam3); [INFO] [stderr] | ----------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:97:44 [INFO] [stderr] | [INFO] [stderr] 97 | unsafe { slice::from_raw_parts($ptrs, $ptrs_len) } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/bls.rs:777:5 [INFO] [stderr] | [INFO] [stderr] 777 | check_useful_c_reference_array!(ver_keys, ver_keys_len, VerKey, ErrorCode::CommonInvalidParam4, ErrorCode::CommonInvalidParam5); [INFO] [stderr] | -------------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:786:23 [INFO] [stderr] | [INFO] [stderr] 786 | unsafe { *valid_p = valid; } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:821:23 [INFO] [stderr] | [INFO] [stderr] 821 | unsafe { *valid_p = valid; } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to 194 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `indy-crypto`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:16:34 [INFO] [stderr] | [INFO] [stderr] 16 | match CStr::from_ptr(cstr).to_str() { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utils/rsa.rs:38:65 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn generate_witness(initial_witness: &BigNumber, exponents: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[BigNumber]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/utils/rsa.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | for ref e in exponents.iter() { [INFO] [stderr] | ^^^^^ ---------------- help: try: `let e = &exponents.iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/utils/logger.rs:104:31 [INFO] [stderr] | [INFO] [stderr] 104 | let pattern = pattern.or(env::var("RUST_LOG").ok()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| env::var("RUST_LOG").ok())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utils/mod.rs:11:30 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn get_hash_as_int(nums: &Vec>) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_hash_as_int` doesn't need a mutable reference [INFO] [stderr] --> src/utils/mod.rs:86:35 [INFO] [stderr] | [INFO] [stderr] 86 | let res = get_hash_as_int(&mut nums); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/helpers.rs:306:14 [INFO] [stderr] | [INFO] [stderr] 306 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in pk.r", k)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in pk.r", k)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/helpers.rs:308:14 [INFO] [stderr] | [INFO] [stderr] 308 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in m_tilde", k)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in m_tilde", k)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/helpers.rs:341:14 [INFO] [stderr] | [INFO] [stderr] 341 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in u", i)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in u", i)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/helpers.rs:343:14 [INFO] [stderr] | [INFO] [stderr] 343 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in r", i)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in r", i)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/helpers.rs:356:10 [INFO] [stderr] | [INFO] [stderr] 356 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in r", "DELTA")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in r", "DELTA")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/helpers.rs:371:14 [INFO] [stderr] | [INFO] [stderr] 371 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in t", i)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in t", i)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/helpers.rs:373:14 [INFO] [stderr] | [INFO] [stderr] 373 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in u", i)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in u", i)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cl/helpers.rs:407:22 [INFO] [stderr] | [INFO] [stderr] 407 | 'outer: for i in (1..roots[0] + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(1..=roots[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cl/helpers.rs:416:18 [INFO] [stderr] | [INFO] [stderr] 416 | for j in (1..roots[1] + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(1..=roots[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cl/helpers.rs:424:22 [INFO] [stderr] | [INFO] [stderr] 424 | for k in (1..roots[2] + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(1..=roots[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cl/helpers.rs:579:37 [INFO] [stderr] | [INFO] [stderr] 579 | assert_eq!("9".to_string(), res_data.get("0").unwrap().to_dec().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res_data["0"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cl/helpers.rs:580:37 [INFO] [stderr] | [INFO] [stderr] 580 | assert_eq!("5".to_string(), res_data.get("1").unwrap().to_dec().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res_data["1"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cl/helpers.rs:581:37 [INFO] [stderr] | [INFO] [stderr] 581 | assert_eq!("1".to_string(), res_data.get("2").unwrap().to_dec().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res_data["2"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cl/helpers.rs:582:37 [INFO] [stderr] | [INFO] [stderr] 582 | assert_eq!("0".to_string(), res_data.get("3").unwrap().to_dec().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res_data["3"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cl/helpers.rs:587:38 [INFO] [stderr] | [INFO] [stderr] 587 | assert_eq!("10".to_string(), res_data.get("0").unwrap().to_dec().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res_data["0"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cl/helpers.rs:588:37 [INFO] [stderr] | [INFO] [stderr] 588 | assert_eq!("2".to_string(), res_data.get("1").unwrap().to_dec().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res_data["1"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cl/helpers.rs:589:37 [INFO] [stderr] | [INFO] [stderr] 589 | assert_eq!("2".to_string(), res_data.get("2").unwrap().to_dec().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res_data["2"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cl/helpers.rs:590:37 [INFO] [stderr] | [INFO] [stderr] 590 | assert_eq!("2".to_string(), res_data.get("3").unwrap().to_dec().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res_data["3"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cl/helpers.rs:596:38 [INFO] [stderr] | [INFO] [stderr] 596 | assert_eq!("14".to_string(), res_data.get("0").unwrap().to_dec().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res_data["0"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cl/helpers.rs:597:37 [INFO] [stderr] | [INFO] [stderr] 597 | assert_eq!("7".to_string(), res_data.get("1").unwrap().to_dec().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res_data["1"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cl/helpers.rs:598:37 [INFO] [stderr] | [INFO] [stderr] 598 | assert_eq!("2".to_string(), res_data.get("2").unwrap().to_dec().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res_data["2"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cl/helpers.rs:599:37 [INFO] [stderr] | [INFO] [stderr] 599 | assert_eq!("2".to_string(), res_data.get("3").unwrap().to_dec().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res_data["3"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cl/helpers.rs:604:41 [INFO] [stderr] | [INFO] [stderr] 604 | assert_eq!("38807".to_string(), res_data.get("0").unwrap().to_dec().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res_data["0"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cl/helpers.rs:605:39 [INFO] [stderr] | [INFO] [stderr] 605 | assert_eq!("337".to_string(), res_data.get("1").unwrap().to_dec().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res_data["1"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cl/helpers.rs:606:38 [INFO] [stderr] | [INFO] [stderr] 606 | assert_eq!("50".to_string(), res_data.get("2").unwrap().to_dec().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res_data["2"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cl/helpers.rs:607:38 [INFO] [stderr] | [INFO] [stderr] 607 | assert_eq!("11".to_string(), res_data.get("3").unwrap().to_dec().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res_data["3"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/issuer.rs:127:14 [INFO] [stderr] | [INFO] [stderr] 127 | .ok_or(IndyCryptoError::InvalidStructure(format!("There are not revocation keys in the credential public key.")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("There are not revocation keys in the credential public key.")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/issuer.rs:127:54 [INFO] [stderr] | [INFO] [stderr] 127 | .ok_or(IndyCryptoError::InvalidStructure(format!("There are not revocation keys in the credential public key.")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"There are not revocation keys in the credential public key.".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cl/issuer.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | rev_key_priv.gamma.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rev_key_priv.gamma` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cl/issuer.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | cred_rev_pub_key.g_dash.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `cred_rev_pub_key.g_dash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/cl/issuer.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | / pub fn sign_credential(prover_id: &str, [INFO] [stderr] 218 | | blinded_credential_secrets: &BlindedCredentialSecrets, [INFO] [stderr] 219 | | blinded_credential_secrets_correctness_proof: &BlindedCredentialSecretsCorrectnessProof, [INFO] [stderr] 220 | | credential_nonce: &Nonce, [INFO] [stderr] ... | [INFO] [stderr] 268 | | Ok((cred_signature, signature_correctness_proof)) [INFO] [stderr] 269 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> src/cl/issuer.rs:339:5 [INFO] [stderr] | [INFO] [stderr] 339 | / pub fn sign_credential_with_revoc(prover_id: &str, [INFO] [stderr] 340 | | blinded_credential_secrets: &BlindedCredentialSecrets, [INFO] [stderr] 341 | | blinded_credential_secrets_correctness_proof: &BlindedCredentialSecretsCorrectnessProof, [INFO] [stderr] 342 | | credential_nonce: &Nonce, [INFO] [stderr] ... | [INFO] [stderr] 398 | | Ok((cred_signature, signature_correctness_proof, rev_reg_delta)) [INFO] [stderr] 399 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cl/issuer.rs:467:26 [INFO] [stderr] | [INFO] [stderr] 467 | let prev_accum = rev_reg.accum.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rev_reg.accum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cl/issuer.rs:477:20 [INFO] [stderr] | [INFO] [stderr] 477 | accum: rev_reg.accum.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rev_reg.accum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cl/issuer.rs:555:26 [INFO] [stderr] | [INFO] [stderr] 555 | let prev_accum = rev_reg.accum.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rev_reg.accum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cl/issuer.rs:565:20 [INFO] [stderr] | [INFO] [stderr] 565 | accum: rev_reg.accum.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rev_reg.accum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cl/issuer.rs:584:12 [INFO] [stderr] | [INFO] [stderr] 584 | if credential_schema.attrs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `credential_schema.attrs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/issuer.rs:585:58 [INFO] [stderr] | [INFO] [stderr] 585 | return Err(IndyCryptoError::InvalidStructure(format!("List of attributes is empty"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"List of attributes is empty".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_hash_as_int` doesn't need a mutable reference [INFO] [stderr] --> src/cl/issuer.rs:690:33 [INFO] [stderr] | [INFO] [stderr] 690 | let c = get_hash_as_int(&mut vec![values])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cl/issuer.rs:722:22 [INFO] [stderr] | [INFO] [stderr] 722 | for i in 1..max_cred_num + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `1..=max_cred_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/issuer.rs:780:70 [INFO] [stderr] | [INFO] [stderr] 780 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in cred_pr_pub_key.r", attr)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in cred_pr_pub_key.r", attr)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/issuer.rs:809:58 [INFO] [stderr] | [INFO] [stderr] 809 | return Err(IndyCryptoError::InvalidStructure(format!("Invalid BlindedCredentialSecrets correctness proof"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid BlindedCredentialSecrets correctness proof".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/issuer.rs:889:18 [INFO] [stderr] | [INFO] [stderr] 889 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in pk.r", key)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in pk.r", key)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_hash_as_int` doesn't need a mutable reference [INFO] [stderr] --> src/cl/issuer.rs:928:33 [INFO] [stderr] | [INFO] [stderr] 928 | let c = get_hash_as_int(&mut vec![values])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/cl/issuer.rs:947:5 [INFO] [stderr] | [INFO] [stderr] 947 | / fn _new_non_revocation_credential(rev_idx: u32, [INFO] [stderr] 948 | | cred_context: &BigNumber, [INFO] [stderr] 949 | | blinded_credential_secrets: &BlindedCredentialSecrets, [INFO] [stderr] 950 | | cred_pub_key: &CredentialPublicKey, [INFO] [stderr] ... | [INFO] [stderr] 1040 | | Ok((non_revocation_cred_sig, rev_reg_delta)) [INFO] [stderr] 1041 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/issuer.rs:964:14 [INFO] [stderr] | [INFO] [stderr] 964 | .ok_or(IndyCryptoError::InvalidStructure(format!("No revocation part present in blinded master secret.")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("No revocation part present in blinded master secret.")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/issuer.rs:964:54 [INFO] [stderr] | [INFO] [stderr] 964 | .ok_or(IndyCryptoError::InvalidStructure(format!("No revocation part present in blinded master secret.")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"No revocation part present in blinded master secret.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/issuer.rs:968:14 [INFO] [stderr] | [INFO] [stderr] 968 | .ok_or(IndyCryptoError::InvalidStructure(format!("No revocation part present in credential revocation public key.")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("No revocation part present in credential revocation public key.")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/issuer.rs:968:54 [INFO] [stderr] | [INFO] [stderr] 968 | .ok_or(IndyCryptoError::InvalidStructure(format!("No revocation part present in credential revocation public key.")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"No revocation part present in credential revocation public key.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/issuer.rs:972:14 [INFO] [stderr] | [INFO] [stderr] 972 | .ok_or(IndyCryptoError::InvalidStructure(format!("No revocation part present in credential revocation private key.")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("No revocation part present in credential revocation private key.")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/issuer.rs:972:54 [INFO] [stderr] | [INFO] [stderr] 972 | .ok_or(IndyCryptoError::InvalidStructure(format!("No revocation part present in credential revocation private key.")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"No revocation part present in credential revocation private key.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cl/issuer.rs:1007:28 [INFO] [stderr] | [INFO] [stderr] 1007 | let prev_acc = rev_reg.accum.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rev_reg.accum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cl/issuer.rs:1015:24 [INFO] [stderr] | [INFO] [stderr] 1015 | accum: rev_reg.accum.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rev_reg.accum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cl/issuer.rs:1024:18 [INFO] [stderr] | [INFO] [stderr] 1024 | g_i: g_i.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `g_i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cl/issuer.rs:1032:18 [INFO] [stderr] | [INFO] [stderr] 1032 | g_i: g_i.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `g_i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/cl/prover.rs:185:5 [INFO] [stderr] | [INFO] [stderr] 185 | / pub fn process_credential_signature(credential_signature: &mut CredentialSignature, [INFO] [stderr] 186 | | credential_values: &CredentialValues, [INFO] [stderr] 187 | | signature_correctness_proof: &SignatureCorrectnessProof, [INFO] [stderr] 188 | | credential_secrets_blinding_factors: &CredentialSecretsBlindingFactors, [INFO] [stderr] ... | [INFO] [stderr] 239 | | Ok(()) [INFO] [stderr] 240 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_hash_as_int` doesn't need a mutable reference [INFO] [stderr] --> src/cl/prover.rs:324:33 [INFO] [stderr] | [INFO] [stderr] 324 | let c = get_hash_as_int(&mut vec![values])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/prover.rs:329:58 [INFO] [stderr] | [INFO] [stderr] 329 | return Err(IndyCryptoError::InvalidStructure(format!("Invalid Credential key correctness proof"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid Credential key correctness proof".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/prover.rs:361:59 [INFO] [stderr] | [INFO] [stderr] 361 | let pk_r = p_pub_key.r.get(&attr.clone()).ok_or( [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 362 | | IndyCryptoError::InvalidStructure( [INFO] [stderr] 363 | | format!("Value by key '{}' not found in pk.r", attr), [INFO] [stderr] 364 | | ), [INFO] [stderr] 365 | | )?; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 361 | let pk_r = p_pub_key.r.get(&attr.clone()).ok_or_else(|| IndyCryptoError::InvalidStructure( [INFO] [stderr] 362 | format!("Value by key '{}' not found in pk.r", attr), [INFO] [stderr] 363 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cl/prover.rs:383:13 [INFO] [stderr] | [INFO] [stderr] 383 | / if let &CredentialValue::Commitment { ref value, ref blinding_factor } = cv { [INFO] [stderr] 384 | | committed_attributes.insert( [INFO] [stderr] 385 | | attr.clone(), [INFO] [stderr] 386 | | get_pedersen_commitment( [INFO] [stderr] ... | [INFO] [stderr] 394 | | ); [INFO] [stderr] 395 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 383 | if let CredentialValue::Commitment { ref value, ref blinding_factor } = *cv { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/prover.rs:454:46 [INFO] [stderr] | [INFO] [stderr] 454 | let pk_r = p_pub_key.r.get(attr).ok_or( [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 455 | | IndyCryptoError::InvalidStructure( [INFO] [stderr] 456 | | format!( [INFO] [stderr] 457 | | "Value by key '{}' not found in pk.r", [INFO] [stderr] ... | [INFO] [stderr] 460 | | ), [INFO] [stderr] 461 | | )?; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 454 | let pk_r = p_pub_key.r.get(attr).ok_or_else(|| IndyCryptoError::InvalidStructure( [INFO] [stderr] 455 | format!( [INFO] [stderr] 456 | "Value by key '{}' not found in pk.r", [INFO] [stderr] 457 | attr [INFO] [stderr] 458 | ), [INFO] [stderr] 459 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/prover.rs:487:26 [INFO] [stderr] | [INFO] [stderr] 487 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in primary_blinded_cred_secrets.committed_attributes", attr)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in primary_blinded_cred_secrets.committed_attributes", attr)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/prover.rs:509:63 [INFO] [stderr] | [INFO] [stderr] 509 | let ca = credential_values.attrs_values.get(attr).ok_or( [INFO] [stderr] | _______________________________________________________________^ [INFO] [stderr] 510 | | IndyCryptoError::InvalidStructure(format!( [INFO] [stderr] 511 | | "Value by key '{}' not found in cred_values.committed_attributes", [INFO] [stderr] 512 | | attr [INFO] [stderr] 513 | | )), [INFO] [stderr] 514 | | )?; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 509 | let ca = credential_values.attrs_values.get(attr).ok_or_else(|| IndyCryptoError::InvalidStructure(format!( [INFO] [stderr] 510 | "Value by key '{}' not found in cred_values.committed_attributes", [INFO] [stderr] 511 | attr [INFO] [stderr] 512 | )))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cl/prover.rs:516:13 [INFO] [stderr] | [INFO] [stderr] 516 | / match ca { [INFO] [stderr] 517 | | &CredentialValue::Hidden { ref value } => { [INFO] [stderr] 518 | | let m_cap = m_tilde.add(&c.mul(value, Some(&mut ctx))?)?; [INFO] [stderr] 519 | | m_caps.insert(attr.clone(), m_cap); [INFO] [stderr] ... | [INFO] [stderr] 533 | | _ => (), [INFO] [stderr] 534 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 516 | match *ca { [INFO] [stderr] 517 | CredentialValue::Hidden { ref value } => { [INFO] [stderr] 518 | let m_cap = m_tilde.add(&c.mul(value, Some(&mut ctx))?)?; [INFO] [stderr] 519 | m_caps.insert(attr.clone(), m_cap); [INFO] [stderr] 520 | () [INFO] [stderr] 521 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/prover.rs:600:58 [INFO] [stderr] | [INFO] [stderr] 600 | return Err(IndyCryptoError::InvalidStructure(format!("Invalid Signature correctness proof"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid Signature correctness proof".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/cl/prover.rs:606:86 [INFO] [stderr] | [INFO] [stderr] 606 | (value.is_known() || value.is_hidden()) && !p_pub_key.r.contains_key(attr.clone())) { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 606 | (value.is_known() || value.is_hidden()) && !p_pub_key.r.contains_key(&(*attr).clone())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 606 | (value.is_known() || value.is_hidden()) && !p_pub_key.r.contains_key(&std::string::String::clone(attr))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/cl/prover.rs:614:85 [INFO] [stderr] | [INFO] [stderr] 614 | (value.is_known() || value.is_hidden()) && p_pub_key.r.contains_key(attr.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 614 | (value.is_known() || value.is_hidden()) && p_pub_key.r.contains_key(&(*attr).clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 614 | (value.is_known() || value.is_hidden()) && p_pub_key.r.contains_key(&std::string::String::clone(attr)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/prover.rs:643:58 [INFO] [stderr] | [INFO] [stderr] 643 | return Err(IndyCryptoError::InvalidStructure(format!("Invalid Signature correctness proof q != q'"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid Signature correctness proof q != q'".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/prover.rs:663:58 [INFO] [stderr] | [INFO] [stderr] 663 | return Err(IndyCryptoError::InvalidStructure(format!("Invalid Signature correctness proof c != c'"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid Signature correctness proof c != c'".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/cl/prover.rs:804:5 [INFO] [stderr] | [INFO] [stderr] 804 | / pub fn add_sub_proof_request(&mut self, [INFO] [stderr] 805 | | sub_proof_request: &SubProofRequest, [INFO] [stderr] 806 | | credential_schema: &CredentialSchema, [INFO] [stderr] 807 | | non_credential_schema: &NonCredentialSchema, [INFO] [stderr] ... | [INFO] [stderr] 878 | | Ok(()) [INFO] [stderr] 879 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/prover.rs:1018:58 [INFO] [stderr] | [INFO] [stderr] 1018 | return Err(IndyCryptoError::InvalidStructure(format!("Credential doesn't correspond to credential schema"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Credential doesn't correspond to credential schema".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/prover.rs:1027:21 [INFO] [stderr] | [INFO] [stderr] 1027 | format!("Credential doesn't contain requested attribute"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Credential doesn't contain requested attribute".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/prover.rs:1038:58 [INFO] [stderr] | [INFO] [stderr] 1038 | return Err(IndyCryptoError::InvalidStructure(format!("Credential doesn't contain attribute requested in predicate"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Credential doesn't contain attribute requested in predicate".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/cl/prover.rs:1046:5 [INFO] [stderr] | [INFO] [stderr] 1046 | / fn _init_primary_proof(common_attributes: &HashMap, [INFO] [stderr] 1047 | | issuer_pub_key: &CredentialPrimaryPublicKey, [INFO] [stderr] 1048 | | c1: &PrimaryCredentialSignature, [INFO] [stderr] 1049 | | cred_values: &CredentialValues, [INFO] [stderr] ... | [INFO] [stderr] 1089 | | Ok(primary_init_proof) [INFO] [stderr] 1090 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/prover.rs:1191:14 [INFO] [stderr] | [INFO] [stderr] 1191 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in cred_values", k)))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in cred_values", k)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/prover.rs:1211:18 [INFO] [stderr] | [INFO] [stderr] 1211 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in u1", i)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in u1", i)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/prover.rs:1243:14 [INFO] [stderr] | [INFO] [stderr] 1243 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in eq_proof.mtilde", k)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in eq_proof.mtilde", k)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/prover.rs:1303:18 [INFO] [stderr] | [INFO] [stderr] 1303 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in init_proof.mtilde", k)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in init_proof.mtilde", k)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/prover.rs:1306:18 [INFO] [stderr] | [INFO] [stderr] 1306 | .ok_or(IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in attributes_values", k)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Value by key '{}' not found in attributes_values", k)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/prover.rs:1326:22 [INFO] [stderr] | [INFO] [stderr] 1326 | .ok_or(IndyCryptoError::InvalidStructure(format!("Encoded value not found")))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::InvalidStructure(format!("Encoded value not found")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/prover.rs:1326:62 [INFO] [stderr] | [INFO] [stderr] 1326 | .ok_or(IndyCryptoError::InvalidStructure(format!("Encoded value not found")))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Encoded value not found".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/verifier.rs:260:58 [INFO] [stderr] | [INFO] [stderr] 260 | return Err(IndyCryptoError::InvalidStructure(format!("Credential doesn't contain requested attribute"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Credential doesn't contain requested attribute".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/verifier.rs:269:58 [INFO] [stderr] | [INFO] [stderr] 269 | return Err(IndyCryptoError::InvalidStructure(format!("Credential doesn't contain attribute requested in predicate"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Credential doesn't contain attribute requested in predicate".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cl/verifier.rs:277:54 [INFO] [stderr] | [INFO] [stderr] 277 | fn _check_verify_params_consistency(credentials: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[VerifiableCredential]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is used to index `credentials` [INFO] [stderr] --> src/cl/verifier.rs:282:20 [INFO] [stderr] | [INFO] [stderr] 282 | for idx in 0..proof.proofs.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 282 | for (idx, ) in credentials.iter().enumerate().take(proof.proofs.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/verifier.rs:289:68 [INFO] [stderr] | [INFO] [stderr] 289 | return Err(IndyCryptoError::AnoncredsProofRejected(format!("Proof revealed attributes not correspond to requested attributes"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Proof revealed attributes not correspond to requested attributes".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/verifier.rs:298:68 [INFO] [stderr] | [INFO] [stderr] 298 | return Err(IndyCryptoError::AnoncredsProofRejected(format!("Proof predicates not correspond to requested predicates"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Proof predicates not correspond to requested predicates".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/verifier.rs:359:18 [INFO] [stderr] | [INFO] [stderr] 359 | .ok_or(IndyCryptoError::AnoncredsProofRejected(format!("Value by key '{}' not found in pk.r", attr)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::AnoncredsProofRejected(format!("Value by key '{}' not found in pk.r", attr)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `tau_list` [INFO] [stderr] --> src/cl/verifier.rs:387:18 [INFO] [stderr] | [INFO] [stderr] 387 | for i in 0..ITERATION { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 387 | for (i, ) in tau_list.iter_mut().enumerate().take(ITERATION) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/verifier.rs:389:18 [INFO] [stderr] | [INFO] [stderr] 389 | .ok_or(IndyCryptoError::AnoncredsProofRejected(format!("Value by key '{}' not found in proof.t", i)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::AnoncredsProofRejected(format!("Value by key '{}' not found in proof.t", i)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cl/verifier.rs:398:14 [INFO] [stderr] | [INFO] [stderr] 398 | .ok_or(IndyCryptoError::AnoncredsProofRejected(format!("Value by key '{}' not found in proof.t", "DELTA")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IndyCryptoError::AnoncredsProofRejected(format!("Value by key '{}' not found in proof.t", "DELTA")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/cl/mod.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / pub fn clone(&self) -> Result { [INFO] [stderr] 96 | | Ok(match *self { [INFO] [stderr] 97 | | CredentialValue::Known { ref value } => CredentialValue::Known { [INFO] [stderr] 98 | | value: value.clone()?, [INFO] [stderr] ... | [INFO] [stderr] 110 | | }) [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/cl/mod.rs:150:5 [INFO] [stderr] | [INFO] [stderr] 150 | / pub fn clone(&self) -> Result { [INFO] [stderr] 151 | | Ok(CredentialValues { [INFO] [stderr] 152 | | attrs_values: clone_credential_value_map(&self.attrs_values)? [INFO] [stderr] 153 | | }) [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/cl/mod.rs:256:5 [INFO] [stderr] | [INFO] [stderr] 256 | / pub fn clone(&self) -> Result { [INFO] [stderr] 257 | | Ok(CredentialPublicKey { [INFO] [stderr] 258 | | p_key: self.p_key.clone()?, [INFO] [stderr] 259 | | r_key: self.r_key.clone() [INFO] [stderr] 260 | | }) [INFO] [stderr] 261 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/cl/mod.rs:274:20 [INFO] [stderr] | [INFO] [stderr] 274 | r_key: r_key.map(|key| key.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `r_key.cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/cl/mod.rs:298:5 [INFO] [stderr] | [INFO] [stderr] 298 | / pub fn clone(&self) -> Result { [INFO] [stderr] 299 | | Ok(CredentialPrimaryPublicKey { [INFO] [stderr] 300 | | n: self.n.clone()?, [INFO] [stderr] 301 | | s: self.s.clone()?, [INFO] [stderr] ... | [INFO] [stderr] 305 | | }) [INFO] [stderr] 306 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cl/mod.rs:420:20 [INFO] [stderr] | [INFO] [stderr] 420 | accum: rev_reg_to.accum.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rev_reg_to.accum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cl/mod.rs:428:58 [INFO] [stderr] | [INFO] [stderr] 428 | return Err(IndyCryptoError::InvalidStructure(format!("Deltas can not be merged."))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Deltas can not be merged.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/cl/mod.rs:499:5 [INFO] [stderr] | [INFO] [stderr] 499 | / pub fn next(&mut self) -> Result, IndyCryptoError> { [INFO] [stderr] 500 | | if self.current_index >= self.size { [INFO] [stderr] 501 | | return Ok(None); [INFO] [stderr] 502 | | } [INFO] [stderr] ... | [INFO] [stderr] 508 | | Ok(Some(tail)) [INFO] [stderr] 509 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/cl/mod.rs:524:12 [INFO] [stderr] | [INFO] [stderr] 524 | Ok(accessor(&self.tails[tail_id as usize])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 524 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cl/mod.rs:596:13 [INFO] [stderr] | [INFO] [stderr] 596 | (1..max_cred_num + 1).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=max_cred_num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/cl/mod.rs:673:5 [INFO] [stderr] | [INFO] [stderr] 673 | / pub fn clone(&self) -> Result { [INFO] [stderr] 674 | | Ok(MasterSecret { ms: self.ms.clone()? }) [INFO] [stderr] 675 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cl/mod.rs:1132:51 [INFO] [stderr] | [INFO] [stderr] 1132 | fn append_vec(&mut self, other: &Vec) -> Result<(), IndyCryptoError>; [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/bn/openssl.rs:404:5 [INFO] [stderr] | [INFO] [stderr] 404 | / pub fn clone(&self) -> Result { [INFO] [stderr] 405 | | Ok(BigNumber { [INFO] [stderr] 406 | | openssl_bn: BigNum::from_slice(&self.openssl_bn.to_vec()[..])? [INFO] [stderr] 407 | | }) [INFO] [stderr] 408 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bn/openssl.rs:410:29 [INFO] [stderr] | [INFO] [stderr] 410 | pub fn hash_array(nums: &Vec>) -> Result, IndyCryptoError> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:71:18 [INFO] [stderr] | [INFO] [stderr] 71 | *credential_pub_key_p = Box::into_raw(Box::new(credential_pub_key)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:72:18 [INFO] [stderr] | [INFO] [stderr] 72 | *credential_priv_key_p = Box::into_raw(Box::new(credential_priv_key)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:73:18 [INFO] [stderr] | [INFO] [stderr] 73 | *credential_key_correctness_proof_p = Box::into_raw(Box::new(credential_key_correctness_proof)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:75:25 [INFO] [stderr] | [INFO] [stderr] 75 | *credential_pub_key_p, *credential_priv_key_p, *credential_key_correctness_proof_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:75:48 [INFO] [stderr] | [INFO] [stderr] 75 | *credential_pub_key_p, *credential_priv_key_p, *credential_key_correctness_proof_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:75:72 [INFO] [stderr] | [INFO] [stderr] 75 | *credential_pub_key_p, *credential_priv_key_p, *credential_key_correctness_proof_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:106:18 [INFO] [stderr] | [INFO] [stderr] 106 | *credential_pub_key_json_p = issuer_pub_key_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:107:107 [INFO] [stderr] | [INFO] [stderr] 107 | trace!("indy_crypto_cl_credential_private_key_to_json: credential_pub_key_json_p: {:?}", *credential_pub_key_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:140:18 [INFO] [stderr] | [INFO] [stderr] 140 | *credential_pub_key_p = Box::into_raw(Box::new(credential_pub_key)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:141:104 [INFO] [stderr] | [INFO] [stderr] 141 | trace!("indy_crypto_cl_credential_public_key_from_json: *credential_pub_key_p: {:?}", *credential_pub_key_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let credential_pub_key =` [INFO] [stderr] --> src/ffi/cl/issuer.rs:162:5 [INFO] [stderr] | [INFO] [stderr] 162 | let credential_pub_key = unsafe { Box::from_raw(credential_pub_key as *mut CredentialPublicKey); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:191:18 [INFO] [stderr] | [INFO] [stderr] 191 | *credential_priv_key_json_p = credential_priv_key_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:192:108 [INFO] [stderr] | [INFO] [stderr] 192 | trace!("indy_crypto_cl_credential_private_key_to_json: credential_priv_key_json_p: {:?}", *credential_priv_key_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:225:18 [INFO] [stderr] | [INFO] [stderr] 225 | *credential_priv_key_p = Box::into_raw(Box::new(credential_priv_key)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:226:106 [INFO] [stderr] | [INFO] [stderr] 226 | trace!("indy_crypto_cl_credential_private_key_from_json: *credential_priv_key_p: {:?}", *credential_priv_key_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _credential_priv_key =` [INFO] [stderr] --> src/ffi/cl/issuer.rs:247:5 [INFO] [stderr] | [INFO] [stderr] 247 | let _credential_priv_key = unsafe { Box::from_raw(credential_priv_key as *mut CredentialPrivateKey); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:277:18 [INFO] [stderr] | [INFO] [stderr] 277 | *credential_key_correctness_proof_json_p = credential_key_correctness_proof_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:278:131 [INFO] [stderr] | [INFO] [stderr] 278 | trace!("indy_crypto_cl_credential_key_correctness_proof_to_json: credential_key_correctness_proof_json_p: {:?}", *credential_key_correctness_proof_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:312:18 [INFO] [stderr] | [INFO] [stderr] 312 | *credential_key_correctness_proof_p = Box::into_raw(Box::new(credential_key_correctness_proof)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:313:129 [INFO] [stderr] | [INFO] [stderr] 313 | trace!("indy_crypto_cl_credential_key_correctness_proof_from_json: *credential_key_correctness_proof_p: {:?}", *credential_key_correctness_proof_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let credential_key_correctness_proof =` [INFO] [stderr] --> src/ffi/cl/issuer.rs:334:5 [INFO] [stderr] | [INFO] [stderr] 334 | let credential_key_correctness_proof = unsafe { Box::from_raw(credential_key_correctness_proof as *mut CredentialKeyCorrectnessProof); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:390:18 [INFO] [stderr] | [INFO] [stderr] 390 | *rev_key_pub_p = Box::into_raw(Box::new(rev_key_pub)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:391:18 [INFO] [stderr] | [INFO] [stderr] 391 | *rev_key_priv_p = Box::into_raw(Box::new(rev_key_priv)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:392:18 [INFO] [stderr] | [INFO] [stderr] 392 | *rev_reg_p = Box::into_raw(Box::new(rev_reg)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:393:18 [INFO] [stderr] | [INFO] [stderr] 393 | *rev_tails_generator_p = Box::into_raw(Box::new(rev_tails_generator)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:395:25 [INFO] [stderr] | [INFO] [stderr] 395 | *rev_key_pub_p, *rev_key_priv_p, *rev_reg_p, *rev_tails_generator_p); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:395:41 [INFO] [stderr] | [INFO] [stderr] 395 | *rev_key_pub_p, *rev_key_priv_p, *rev_reg_p, *rev_tails_generator_p); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:395:58 [INFO] [stderr] | [INFO] [stderr] 395 | *rev_key_pub_p, *rev_key_priv_p, *rev_reg_p, *rev_tails_generator_p); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:395:70 [INFO] [stderr] | [INFO] [stderr] 395 | *rev_key_pub_p, *rev_key_priv_p, *rev_reg_p, *rev_tails_generator_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:427:18 [INFO] [stderr] | [INFO] [stderr] 427 | *rev_key_pub_json_p = rev_reg_def_pub_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:428:99 [INFO] [stderr] | [INFO] [stderr] 428 | trace!("indy_crypto_cl_revocation_key_public_to_json: rev_key_pub_json_p: {:?}", *rev_key_pub_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:461:18 [INFO] [stderr] | [INFO] [stderr] 461 | *rev_key_pub_p = Box::into_raw(Box::new(rev_key_pub)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:462:97 [INFO] [stderr] | [INFO] [stderr] 462 | trace!("indy_crypto_cl_revocation_key_public_from_json: *rev_key_pub_p: {:?}", *rev_key_pub_p); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let rev_key_pub =` [INFO] [stderr] --> src/ffi/cl/issuer.rs:482:5 [INFO] [stderr] | [INFO] [stderr] 482 | let rev_key_pub = unsafe { Box::from_raw(rev_key_pub as *mut RevocationKeyPublic); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:512:18 [INFO] [stderr] | [INFO] [stderr] 512 | *rev_key_priv_json_p = rev_reg_def_priv_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:513:101 [INFO] [stderr] | [INFO] [stderr] 513 | trace!("indy_crypto_cl_revocation_key_private_to_json: rev_key_priv_json_p: {:?}", *rev_key_priv_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:547:18 [INFO] [stderr] | [INFO] [stderr] 547 | *rev_key_priv_p = Box::into_raw(Box::new(rev_key_priv)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:548:99 [INFO] [stderr] | [INFO] [stderr] 548 | trace!("indy_crypto_cl_revocation_key_private_from_json: *rev_key_priv_p: {:?}", *rev_key_priv_p); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _rev_key_priv =` [INFO] [stderr] --> src/ffi/cl/issuer.rs:569:5 [INFO] [stderr] | [INFO] [stderr] 569 | let _rev_key_priv = unsafe { Box::from_raw(rev_key_priv as *mut RevocationKeyPrivate); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:599:18 [INFO] [stderr] | [INFO] [stderr] 599 | *rev_reg_json_p = rev_reg_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:600:93 [INFO] [stderr] | [INFO] [stderr] 600 | trace!("indy_crypto_cl_revocation_registry_to_json: rev_reg_json_p: {:?}", *rev_reg_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:634:18 [INFO] [stderr] | [INFO] [stderr] 634 | *rev_reg_p = Box::into_raw(Box::new(rev_reg)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:635:91 [INFO] [stderr] | [INFO] [stderr] 635 | trace!("indy_crypto_cl_revocation_registry_from_json: *rev_reg_p: {:?}", *rev_reg_p); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let rev_reg =` [INFO] [stderr] --> src/ffi/cl/issuer.rs:656:5 [INFO] [stderr] | [INFO] [stderr] 656 | let rev_reg = unsafe { Box::from_raw(rev_reg as *mut RevocationRegistry); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:686:18 [INFO] [stderr] | [INFO] [stderr] 686 | *rev_tails_generator_json_p = rev_tails_generator_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:687:112 [INFO] [stderr] | [INFO] [stderr] 687 | trace!("indy_crypto_cl_revocation_tails_generator_to_json: rev_tails_generator_json_p: {:?}", *rev_tails_generator_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:721:18 [INFO] [stderr] | [INFO] [stderr] 721 | *rev_tails_generator_p = Box::into_raw(Box::new(rev_tails_generator)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:722:110 [INFO] [stderr] | [INFO] [stderr] 722 | trace!("indy_crypto_cl_revocation_tails_generator_from_json: *rev_tails_generator_p: {:?}", *rev_tails_generator_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let rev_tails_generator =` [INFO] [stderr] --> src/ffi/cl/issuer.rs:743:5 [INFO] [stderr] | [INFO] [stderr] 743 | let rev_tails_generator = unsafe { Box::from_raw(rev_tails_generator as *mut RevocationTailsGenerator); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:817:18 [INFO] [stderr] | [INFO] [stderr] 817 | *credential_signature_p = Box::into_raw(Box::new(credential_signature)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:818:18 [INFO] [stderr] | [INFO] [stderr] 818 | *credential_signature_correctness_proof_p = Box::into_raw(Box::new(credential_signature_correctness_proof)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:820:25 [INFO] [stderr] | [INFO] [stderr] 820 | *credential_signature_p, *credential_signature_correctness_proof_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:820:50 [INFO] [stderr] | [INFO] [stderr] 820 | *credential_signature_p, *credential_signature_correctness_proof_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:924:18 [INFO] [stderr] | [INFO] [stderr] 924 | *credential_signature_p = Box::into_raw(Box::new(credential_signature)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:925:18 [INFO] [stderr] | [INFO] [stderr] 925 | *credential_signature_correctness_proof_p = Box::into_raw(Box::new(credential_signature_correctness_proof)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:926:18 [INFO] [stderr] | [INFO] [stderr] 926 | *revocation_registry_delta_p = if let Some(delta) = delta { Box::into_raw(Box::new(delta)) as *const c_void } else { null() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:928:25 [INFO] [stderr] | [INFO] [stderr] 928 | *credential_signature_p, *credential_signature_correctness_proof_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:928:50 [INFO] [stderr] | [INFO] [stderr] 928 | *credential_signature_p, *credential_signature_correctness_proof_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:960:18 [INFO] [stderr] | [INFO] [stderr] 960 | *credential_signature_json_p = credential_signature_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:961:107 [INFO] [stderr] | [INFO] [stderr] 961 | trace!("indy_crypto_cl_credential_signature_to_json: credential_signature_json_p: {:?}", *credential_signature_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:995:18 [INFO] [stderr] | [INFO] [stderr] 995 | *credential_signature_p = Box::into_raw(Box::new(credential_signature)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:996:105 [INFO] [stderr] | [INFO] [stderr] 996 | trace!("indy_crypto_cl_credential_signature_from_json: *credential_signature_p: {:?}", *credential_signature_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _credential_signature =` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1017:5 [INFO] [stderr] | [INFO] [stderr] 1017 | let _credential_signature = unsafe { Box::from_raw(credential_signature as *mut CredentialSignature); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1046:18 [INFO] [stderr] | [INFO] [stderr] 1046 | *signature_correctness_proof_json_p = signature_correctness_proof_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1047:121 [INFO] [stderr] | [INFO] [stderr] 1047 | trace!("indy_crypto_cl_signature_correctness_proof_to_json: signature_correctness_proof_json_p: {:?}", *signature_correctness_proof_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1081:18 [INFO] [stderr] | [INFO] [stderr] 1081 | *signature_correctness_proof_p = Box::into_raw(Box::new(signature_correctness_proof)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1082:119 [INFO] [stderr] | [INFO] [stderr] 1082 | trace!("indy_crypto_cl_signature_correctness_proof_from_json: *signature_correctness_proof_p: {:?}", *signature_correctness_proof_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let signature_correctness_proof =` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1103:5 [INFO] [stderr] | [INFO] [stderr] 1103 | let signature_correctness_proof = unsafe { Box::from_raw(signature_correctness_proof as *mut SignatureCorrectnessProof); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1132:18 [INFO] [stderr] | [INFO] [stderr] 1132 | *revocation_registry_delta_json_p = revocation_registry_delta_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1133:117 [INFO] [stderr] | [INFO] [stderr] 1133 | trace!("indy_crypto_cl_revocation_registry_delta_to_json: revocation_registry_delta_json_p: {:?}", *revocation_registry_delta_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1167:18 [INFO] [stderr] | [INFO] [stderr] 1167 | *revocation_registry_delta_p = Box::into_raw(Box::new(revocation_registry_delta)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1168:115 [INFO] [stderr] | [INFO] [stderr] 1168 | trace!("indy_crypto_cl_revocation_registry_delta_from_json: *revocation_registry_delta_p: {:?}", *revocation_registry_delta_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let revocation_registry_delta =` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1189:5 [INFO] [stderr] | [INFO] [stderr] 1189 | let revocation_registry_delta = unsafe { Box::from_raw(revocation_registry_delta as *mut RevocationRegistryDelta); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:110:72 [INFO] [stderr] | [INFO] [stderr] 110 | let $ptr = HashSet::from_iter( unsafe { slice::from_raw_parts($ptr, $len) }.iter().cloned()); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/cl/issuer.rs:1209:5 [INFO] [stderr] | [INFO] [stderr] 1209 | check_useful_hashset!(issued, issued_len, ErrorCode::CommonInvalidParam3, ErrorCode::CommonInvalidParam4); [INFO] [stderr] | ---------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:110:72 [INFO] [stderr] | [INFO] [stderr] 110 | let $ptr = HashSet::from_iter( unsafe { slice::from_raw_parts($ptr, $len) }.iter().cloned()); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/cl/issuer.rs:1210:5 [INFO] [stderr] | [INFO] [stderr] 1210 | check_useful_hashset!(revoked, revoked_len, ErrorCode::CommonInvalidParam5, ErrorCode::CommonInvalidParam6); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1221:10 [INFO] [stderr] | [INFO] [stderr] 1221 | *rev_reg_delta_p = Box::into_raw(Box::new(rev_reg_delta)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1222:93 [INFO] [stderr] | [INFO] [stderr] 1222 | trace!("indy_crypto_revocation_registry_delta_from_parts: *rev_reg_delta_p: {:?}", *rev_reg_delta_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1257:18 [INFO] [stderr] | [INFO] [stderr] 1257 | *rev_reg_delta_p = Box::into_raw(Box::new(rev_reg_delta)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1258:92 [INFO] [stderr] | [INFO] [stderr] 1258 | trace!("indy_crypto_cl_issuer_revoke_credential: *rev_reg_delta_p: {:?}", *rev_reg_delta_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1295:18 [INFO] [stderr] | [INFO] [stderr] 1295 | *rev_reg_delta_p = Box::into_raw(Box::new(rev_reg_delta)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1296:94 [INFO] [stderr] | [INFO] [stderr] 1296 | trace!("indy_crypto_cl_issuer_recovery_credential: *rev_reg_delta_p: {:?}", *rev_reg_delta_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1324:18 [INFO] [stderr] | [INFO] [stderr] 1324 | *merged_revoc_reg_delta_p = Box::into_raw(Box::new(merged_revoc_reg_delta)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/issuer.rs:1325:116 [INFO] [stderr] | [INFO] [stderr] 1325 | trace!("indy_crypto_cl_issuer_merge_revocation_registry_deltas: *merged_revoc_reg_delta_p: {:?}", *merged_revoc_reg_delta_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ffi/cl/issuer.rs:1324:68 [INFO] [stderr] | [INFO] [stderr] 1324 | *merged_revoc_reg_delta_p = Box::into_raw(Box::new(merged_revoc_reg_delta)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 1324 | *merged_revoc_reg_delta_p = Box::into_raw(Box::new(())) as *const c_void; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/ffi/cl/issuer.rs:2122:5 [INFO] [stderr] | [INFO] [stderr] 2122 | / pub fn _credential_signature_with_revoc(blinded_credential_secrets: *const c_void, [INFO] [stderr] 2123 | | blinded_credential_secrets_correctness_proof: *const c_void, [INFO] [stderr] 2124 | | credential_nonce: *const c_void, [INFO] [stderr] 2125 | | credential_issuance_nonce: *const c_void, [INFO] [stderr] ... | [INFO] [stderr] 2164 | | (credential_signature_p, credential_signature_correctness_proof_p, revocation_registry_delta_p) [INFO] [stderr] 2165 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | *master_secret_p = Box::into_raw(Box::new(master_secret)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:29:92 [INFO] [stderr] | [INFO] [stderr] 29 | trace!("indy_crypto_cl_prover_new_master_secret: *master_secret_p: {:?}", *master_secret_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | *master_secret_json_p = master_secret_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:61:93 [INFO] [stderr] | [INFO] [stderr] 61 | trace!("indy_crypto_cl_master_secret_to_json: master_secret_json_p: {:?}", *master_secret_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:94:18 [INFO] [stderr] | [INFO] [stderr] 94 | *master_secret_p = Box::into_raw(Box::new(master_secret)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:95:91 [INFO] [stderr] | [INFO] [stderr] 95 | trace!("indy_crypto_cl_master_secret_from_json: *master_secret_p: {:?}", *master_secret_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let master_secret =` [INFO] [stderr] --> src/ffi/cl/prover.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | let master_secret = unsafe { Box::from_raw(master_secret as *mut MasterSecret); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:196:18 [INFO] [stderr] | [INFO] [stderr] 196 | *blinded_credential_secrets_p = Box::into_raw(Box::new(blinded_credential_secrets)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:197:18 [INFO] [stderr] | [INFO] [stderr] 197 | *credential_secrets_blinding_factors_p = Box::into_raw(Box::new(credential_secrets_blinding_factors)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:198:18 [INFO] [stderr] | [INFO] [stderr] 198 | *blinded_credential_secrets_correctness_proof_p = Box::into_raw(Box::new(blinded_credential_secrets_correctness_proof)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:202:74 [INFO] [stderr] | [INFO] [stderr] 202 | *blinded_credential_secrets_p, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:203:74 [INFO] [stderr] | [INFO] [stderr] 203 | *credential_secrets_blinding_factors_p, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:204:74 [INFO] [stderr] | [INFO] [stderr] 204 | *blinded_credential_secrets_correctness_proof_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:236:18 [INFO] [stderr] | [INFO] [stderr] 236 | *blinded_credential_secrets_json_p = blinded_credential_secrets_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:238:119 [INFO] [stderr] | [INFO] [stderr] 238 | trace!("indy_crypto_cl_blinded_credential_secrets_to_json: blinded_credential_secrets_json_p: {:?}", *blinded_credential_secrets_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:271:18 [INFO] [stderr] | [INFO] [stderr] 271 | *blinded_credential_secrets_p = Box::into_raw(Box::new(blinded_credential_secrets)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:272:117 [INFO] [stderr] | [INFO] [stderr] 272 | trace!("indy_crypto_cl_blinded_credential_secrets_from_json: *blinded_credential_secrets_p: {:?}", *blinded_credential_secrets_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let blinded_credential_secrets =` [INFO] [stderr] --> src/ffi/cl/prover.rs:293:5 [INFO] [stderr] | [INFO] [stderr] 293 | let blinded_credential_secrets = unsafe { Box::from_raw(blinded_credential_secrets as *mut BlindedCredentialSecrets); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:323:18 [INFO] [stderr] | [INFO] [stderr] 323 | *credential_secrets_blinding_factors_json_p = credential_secrets_blinding_factors_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:324:136 [INFO] [stderr] | [INFO] [stderr] 324 | trace!("indy_crypto_cl_credential_secret_blinding_factors_to_json: credential_secrets_blinding_factors_json_p: {:?}", *credential_secrets_blinding_factors_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:358:18 [INFO] [stderr] | [INFO] [stderr] 358 | *credential_secrets_blinding_factors_p = Box::into_raw(Box::new(credential_secrets_blinding_factors)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:359:135 [INFO] [stderr] | [INFO] [stderr] 359 | trace!("indy_crypto_cl_credential_secrets_blinding_factors_from_json: *credential_secrets_blinding_factors_p: {:?}", *credential_secrets_blinding_factors_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let credential_secrets_blinding_factors =` [INFO] [stderr] --> src/ffi/cl/prover.rs:380:5 [INFO] [stderr] | [INFO] [stderr] 380 | let credential_secrets_blinding_factors = unsafe { Box::from_raw(credential_secrets_blinding_factors as *mut CredentialSecretsBlindingFactors); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:412:18 [INFO] [stderr] | [INFO] [stderr] 412 | *blinded_credential_secrets_correctness_proof_json_p = blinded_credential_secrets_correctness_proof_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:414:25 [INFO] [stderr] | [INFO] [stderr] 414 | *blinded_credential_secrets_correctness_proof_json_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:450:18 [INFO] [stderr] | [INFO] [stderr] 450 | *blinded_credential_secrets_correctness_proof_p = Box::into_raw(Box::new(blinded_credential_secrets_correctness_proof)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:452:25 [INFO] [stderr] | [INFO] [stderr] 452 | *blinded_credential_secrets_correctness_proof_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let blinded_credential_secrets_correctness_proof =` [INFO] [stderr] --> src/ffi/cl/prover.rs:474:5 [INFO] [stderr] | [INFO] [stderr] 474 | let blinded_credential_secrets_correctness_proof = unsafe { Box::from_raw(blinded_credential_secrets_correctness_proof as *mut BlindedCredentialSecretsCorrectnessProof); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:576:18 [INFO] [stderr] | [INFO] [stderr] 576 | *cred_rev_indx = index; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:607:18 [INFO] [stderr] | [INFO] [stderr] 607 | *proof_builder_p = Box::into_raw(Box::new(proof_builder)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:608:92 [INFO] [stderr] | [INFO] [stderr] 608 | trace!("indy_crypto_cl_prover_new_proof_builder: *proof_builder_p: {:?}", *proof_builder_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:735:18 [INFO] [stderr] | [INFO] [stderr] 735 | *proof_p = Box::into_raw(Box::new(proof)) as *const c_void; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:736:82 [INFO] [stderr] | [INFO] [stderr] 736 | trace!("indy_crypto_cl_proof_builder_finalize: *proof_p: {:?}", *proof_p); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:767:18 [INFO] [stderr] | [INFO] [stderr] 767 | *proof_json_p = proof_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:768:77 [INFO] [stderr] | [INFO] [stderr] 768 | trace!("indy_crypto_cl_proof_to_json: proof_json_p: {:?}", *proof_json_p); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:800:18 [INFO] [stderr] | [INFO] [stderr] 800 | *proof_p = Box::into_raw(Box::new(proof)) as *const c_void; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/prover.rs:801:75 [INFO] [stderr] | [INFO] [stderr] 801 | trace!("indy_crypto_cl_proof_from_json: *proof_p: {:?}", *proof_p); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let proof =` [INFO] [stderr] --> src/ffi/cl/prover.rs:822:5 [INFO] [stderr] | [INFO] [stderr] 822 | let proof = unsafe { Box::from_raw(proof as *mut Proof); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/ffi/cl/prover.rs:1509:5 [INFO] [stderr] | [INFO] [stderr] 1509 | / pub fn _process_credential_signature(credential_signature: *const c_void, [INFO] [stderr] 1510 | | signature_correctness_proof: *const c_void, [INFO] [stderr] 1511 | | credential_secrets_blinding_factors: *const c_void, [INFO] [stderr] 1512 | | credential_values: *const c_void, [INFO] [stderr] ... | [INFO] [stderr] 1526 | | assert_eq!(err_code, ErrorCode::Success); [INFO] [stderr] 1527 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/verifier.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | *proof_verifier_p = Box::into_raw(Box::new(proof_verifier)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/verifier.rs:26:96 [INFO] [stderr] | [INFO] [stderr] 26 | trace!("indy_crypto_cl_verifier_new_proof_verifier: *proof_verifier_p: {:?}", *proof_verifier_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/verifier.rs:108:18 [INFO] [stderr] | [INFO] [stderr] 108 | *valid_p = valid; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/verifier.rs:109:81 [INFO] [stderr] | [INFO] [stderr] 109 | trace!("indy_crypto_cl_proof_verifier_verify: *valid_p: {:?}", *valid_p); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:33:22 [INFO] [stderr] | [INFO] [stderr] 33 | *tail_p = Box::into_raw(Box::new(tail)) as *const c_void; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:35:22 [INFO] [stderr] | [INFO] [stderr] 35 | *tail_p = ptr::null(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:37:79 [INFO] [stderr] | [INFO] [stderr] 37 | trace!("indy_crypto_cl_tails_generator_next: *tail_p: {:?}", *tail_p); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:59:10 [INFO] [stderr] | [INFO] [stderr] 59 | *count_p = cnt; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:60:73 [INFO] [stderr] | [INFO] [stderr] 60 | trace!("indy_crypto_cl_tails_generator_count: *count_p: {:?}", *count_p); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let tail =` [INFO] [stderr] --> src/ffi/cl/mod.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | let tail = unsafe { Box::from_raw(tail as *mut Tail); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | *witness_p = Box::into_raw(Box::new(witness)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:103:73 [INFO] [stderr] | [INFO] [stderr] 103 | trace!("indy_crypto_cl_witness_new: *witness_p: {:?}", *witness_p); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let witness =` [INFO] [stderr] --> src/ffi/cl/mod.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | let witness = unsafe { Box::from_raw(witness as *mut Witness); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:173:18 [INFO] [stderr] | [INFO] [stderr] 173 | *credential_schema_builder_p = Box::into_raw(Box::new(credential_schema_builder)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:174:109 [INFO] [stderr] | [INFO] [stderr] 174 | trace!("indy_crypto_cl_credential_schema_builder_new: *credential_schema_builder_p: {:?}", *credential_schema_builder_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:233:18 [INFO] [stderr] | [INFO] [stderr] 233 | *credential_schema_p = Box::into_raw(Box::new(credential_schema)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:234:106 [INFO] [stderr] | [INFO] [stderr] 234 | trace!("indy_crypto_cl_credential_schema_builder_finalize: *credential_schema_p: {:?}", *credential_schema_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let credential_schema =` [INFO] [stderr] --> src/ffi/cl/mod.rs:255:5 [INFO] [stderr] | [INFO] [stderr] 255 | let credential_schema = unsafe { Box::from_raw(credential_schema as *mut CredentialSchema); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:284:18 [INFO] [stderr] | [INFO] [stderr] 284 | *non_credential_schema_builder_p = Box::into_raw(Box::new(non_credential_schema_builder)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:285:109 [INFO] [stderr] | [INFO] [stderr] 285 | trace!("indy_crypto_cl_credential_schema_builder_new: *credential_schema_builder_p: {:?}", *non_credential_schema_builder_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:344:18 [INFO] [stderr] | [INFO] [stderr] 344 | *non_credential_schema_p = Box::into_raw(Box::new(non_credential_schema)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:345:110 [INFO] [stderr] | [INFO] [stderr] 345 | trace!("indy_crypto_cl_non_credential_schema_builder_finalize: *credential_schema_p: {:?}", *non_credential_schema_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let non_credential_schema =` [INFO] [stderr] --> src/ffi/cl/mod.rs:366:5 [INFO] [stderr] | [INFO] [stderr] 366 | let non_credential_schema = unsafe { Box::from_raw(non_credential_schema as *mut NonCredentialSchema); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:395:18 [INFO] [stderr] | [INFO] [stderr] 395 | *credential_values_builder_p = Box::into_raw(Box::new(credential_values_builder)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:396:109 [INFO] [stderr] | [INFO] [stderr] 396 | trace!("indy_crypto_cl_credential_values_builder_new: *credential_values_builder_p: {:?}", *credential_values_builder_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:518:18 [INFO] [stderr] | [INFO] [stderr] 518 | *credential_values_p = Box::into_raw(Box::new(credential_values)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:519:106 [INFO] [stderr] | [INFO] [stderr] 519 | trace!("indy_crypto_cl_credential_values_builder_finalize: *credential_values_p: {:?}", *credential_values_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let credential_values =` [INFO] [stderr] --> src/ffi/cl/mod.rs:540:5 [INFO] [stderr] | [INFO] [stderr] 540 | let credential_values = unsafe { Box::from_raw(credential_values as *mut CredentialValues); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:569:18 [INFO] [stderr] | [INFO] [stderr] 569 | *sub_proof_request_builder_p = Box::into_raw(Box::new(sub_proof_request_builder)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:570:109 [INFO] [stderr] | [INFO] [stderr] 570 | trace!("indy_crypto_cl_sub_proof_request_builder_new: *sub_proof_request_builder_p: {:?}", *sub_proof_request_builder_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:663:18 [INFO] [stderr] | [INFO] [stderr] 663 | *sub_proof_request_p = Box::into_raw(Box::new(sub_proof_request)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:664:106 [INFO] [stderr] | [INFO] [stderr] 664 | trace!("indy_crypto_cl_sub_proof_request_builder_finalize: *sub_proof_request_p: {:?}", *sub_proof_request_p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let sub_proof_request =` [INFO] [stderr] --> src/ffi/cl/mod.rs:685:5 [INFO] [stderr] | [INFO] [stderr] 685 | let sub_proof_request = unsafe { Box::from_raw(sub_proof_request as *mut SubProofRequest); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:710:18 [INFO] [stderr] | [INFO] [stderr] 710 | *nonce_p = Box::into_raw(Box::new(nonce)) as *const c_void; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:711:69 [INFO] [stderr] | [INFO] [stderr] 711 | trace!("indy_crypto_cl_new_nonce: *nonce_p: {:?}", *nonce_p); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:742:18 [INFO] [stderr] | [INFO] [stderr] 742 | *nonce_json_p = nonce_json.into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:743:77 [INFO] [stderr] | [INFO] [stderr] 743 | trace!("indy_crypto_cl_nonce_to_json: nonce_json_p: {:?}", *nonce_json_p); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:775:18 [INFO] [stderr] | [INFO] [stderr] 775 | *nonce_p = Box::into_raw(Box::new(nonce)) as *const c_void; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:776:75 [INFO] [stderr] | [INFO] [stderr] 776 | trace!("indy_crypto_cl_nonce_from_json: *nonce_p: {:?}", *nonce_p); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let nonce =` [INFO] [stderr] --> src/ffi/cl/mod.rs:797:5 [INFO] [stderr] | [INFO] [stderr] 797 | let nonce = unsafe { Box::from_raw(nonce as *mut Nonce); }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/ffi/cl/mod.rs:1410:16 [INFO] [stderr] | [INFO] [stderr] 1410 | tails: Box> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::box_vec)] on by default [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/cl/mod.rs:1446:23 [INFO] [stderr] | [INFO] [stderr] 1446 | unsafe { *tail_p = tail }; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ffi/cl/mod.rs:1444:40 [INFO] [stderr] | [INFO] [stderr] 1444 | let tail: *const c_void = *tails.get(idx as usize).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `tails[idx as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | *gen_p = Box::into_raw(Box::new(gen)) as *const c_void; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:28:72 [INFO] [stderr] | [INFO] [stderr] 28 | trace!("indy_crypto_bls_generator_new: *gen_p: {:?}", *gen_p); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | let $ptr = unsafe { slice::from_raw_parts($ptr, $len) }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/bls.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / check_useful_c_byte_array!(bytes, bytes_len, [INFO] [stderr] 53 | | ErrorCode::CommonInvalidParam1, ErrorCode::CommonInvalidParam2); [INFO] [stderr] | |_______________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:62:18 [INFO] [stderr] | [INFO] [stderr] 62 | *gen_p = Box::into_raw(Box::new(gen)) as *const c_void; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:63:79 [INFO] [stderr] | [INFO] [stderr] 63 | trace!("indy_crypto_bls_generator_from_bytes: *gen_p: {:?}", *gen_p); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:94:10 [INFO] [stderr] | [INFO] [stderr] 94 | *bytes_p = gen.as_bytes().as_ptr(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:95:10 [INFO] [stderr] | [INFO] [stderr] 95 | *bytes_len_p = gen.as_bytes().len(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:51:49 [INFO] [stderr] | [INFO] [stderr] 51 | unsafe { Some(slice::from_raw_parts($ptr, $len)) } [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/bls.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | / check_useful_opt_c_byte_array!(seed, seed_len, [INFO] [stderr] 136 | | ErrorCode::CommonInvalidParam1, ErrorCode::CommonInvalidParam2); [INFO] [stderr] | |___________________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:144:18 [INFO] [stderr] | [INFO] [stderr] 144 | *sign_key_p = Box::into_raw(Box::new(sign_key)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:145:76 [INFO] [stderr] | [INFO] [stderr] 145 | trace!("indy_crypto_bls_sign_key_new: *sign_key_p: {:?}", *sign_key_p); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | let $ptr = unsafe { slice::from_raw_parts($ptr, $len) }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/bls.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | / check_useful_c_byte_array!(bytes, bytes_len, [INFO] [stderr] 170 | | ErrorCode::CommonInvalidParam1, ErrorCode::CommonInvalidParam2); [INFO] [stderr] | |_______________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:179:18 [INFO] [stderr] | [INFO] [stderr] 179 | *sign_key_p = Box::into_raw(Box::new(sign_key)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:180:83 [INFO] [stderr] | [INFO] [stderr] 180 | trace!("indy_crypto_bls_sign_key_from_bytes: *sign_key_p: {:?}", *sign_key_p); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:211:10 [INFO] [stderr] | [INFO] [stderr] 211 | *bytes_p = sign_key.as_bytes().as_ptr(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:212:10 [INFO] [stderr] | [INFO] [stderr] 212 | *bytes_len_p = sign_key.as_bytes().len(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:261:18 [INFO] [stderr] | [INFO] [stderr] 261 | *ver_key_p = Box::into_raw(Box::new(ver_key)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:262:74 [INFO] [stderr] | [INFO] [stderr] 262 | trace!("indy_crypto_bls_ver_key_new: *ver_key_p: {:?}", *ver_key_p); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | let $ptr = unsafe { slice::from_raw_parts($ptr, $len) }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/bls.rs:286:5 [INFO] [stderr] | [INFO] [stderr] 286 | / check_useful_c_byte_array!(bytes, bytes_len, [INFO] [stderr] 287 | | ErrorCode::CommonInvalidParam1, ErrorCode::CommonInvalidParam2); [INFO] [stderr] | |_______________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:296:18 [INFO] [stderr] | [INFO] [stderr] 296 | *ver_key_p = Box::into_raw(Box::new(ver_key)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:297:81 [INFO] [stderr] | [INFO] [stderr] 297 | trace!("indy_crypto_bls_ver_key_from_bytes: *ver_key_p: {:?}", *ver_key_p); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:328:10 [INFO] [stderr] | [INFO] [stderr] 328 | *bytes_p = ver_key.as_bytes().as_ptr(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:329:10 [INFO] [stderr] | [INFO] [stderr] 329 | *bytes_len_p = ver_key.as_bytes().len(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:378:18 [INFO] [stderr] | [INFO] [stderr] 378 | *pop_p = Box::into_raw(Box::new(pop)) as *const c_void; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:379:66 [INFO] [stderr] | [INFO] [stderr] 379 | trace!("indy_crypto_bls_pop_new: *pop_p: {:?}", *pop_p); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | let $ptr = unsafe { slice::from_raw_parts($ptr, $len) }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/bls.rs:403:5 [INFO] [stderr] | [INFO] [stderr] 403 | / check_useful_c_byte_array!(bytes, bytes_len, [INFO] [stderr] 404 | | ErrorCode::CommonInvalidParam1, ErrorCode::CommonInvalidParam2); [INFO] [stderr] | |_______________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:413:18 [INFO] [stderr] | [INFO] [stderr] 413 | *pop_p = Box::into_raw(Box::new(pop)) as *const c_void; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:414:73 [INFO] [stderr] | [INFO] [stderr] 414 | trace!("indy_crypto_bls_pop_from_bytes: *pop_p: {:?}", *pop_p); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:445:10 [INFO] [stderr] | [INFO] [stderr] 445 | *bytes_p = pop.as_bytes().as_ptr(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:446:10 [INFO] [stderr] | [INFO] [stderr] 446 | *bytes_len_p = pop.as_bytes().len(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | let $ptr = unsafe { slice::from_raw_parts($ptr, $len) }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/bls.rs:485:5 [INFO] [stderr] | [INFO] [stderr] 485 | / check_useful_c_byte_array!(bytes, bytes_len, [INFO] [stderr] 486 | | ErrorCode::CommonInvalidParam1, ErrorCode::CommonInvalidParam2); [INFO] [stderr] | |_______________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:495:18 [INFO] [stderr] | [INFO] [stderr] 495 | *signature_p = Box::into_raw(Box::new(signature)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:496:85 [INFO] [stderr] | [INFO] [stderr] 496 | trace!("indy_crypto_bls_signature_from_bytes: *signature_p: {:?}", *signature_p); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:527:10 [INFO] [stderr] | [INFO] [stderr] 527 | *bytes_p = signature.as_bytes().as_ptr(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:528:10 [INFO] [stderr] | [INFO] [stderr] 528 | *bytes_len_p = signature.as_bytes().len(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:97:44 [INFO] [stderr] | [INFO] [stderr] 97 | unsafe { slice::from_raw_parts($ptrs, $ptrs_len) } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/bls.rs:568:5 [INFO] [stderr] | [INFO] [stderr] 568 | check_useful_c_reference_array!(signatures, signatures_len, Signature, ErrorCode::CommonInvalidParam1, ErrorCode::CommonInvalidParam2); [INFO] [stderr] | --------------------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:577:18 [INFO] [stderr] | [INFO] [stderr] 577 | *multi_sig_p = Box::into_raw(Box::new(multi_sig)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:578:84 [INFO] [stderr] | [INFO] [stderr] 578 | trace!("indy_crypto_bls_multi_signature_new: *multi_sig_p: {:?}", *multi_sig_p); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | let $ptr = unsafe { slice::from_raw_parts($ptr, $len) }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/bls.rs:602:5 [INFO] [stderr] | [INFO] [stderr] 602 | / check_useful_c_byte_array!(bytes, bytes_len, [INFO] [stderr] 603 | | ErrorCode::CommonInvalidParam1, ErrorCode::CommonInvalidParam2); [INFO] [stderr] | |_______________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:612:18 [INFO] [stderr] | [INFO] [stderr] 612 | *multi_sig_p = Box::into_raw(Box::new(multi_sig)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:613:91 [INFO] [stderr] | [INFO] [stderr] 613 | trace!("indy_crypto_bls_multi_signature_from_bytes: *multi_sig_p: {:?}", *multi_sig_p); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:645:10 [INFO] [stderr] | [INFO] [stderr] 645 | *bytes_p = multi_sig.as_bytes().as_ptr(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:646:10 [INFO] [stderr] | [INFO] [stderr] 646 | *bytes_len_p = multi_sig.as_bytes().len(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | let $ptr = unsafe { slice::from_raw_parts($ptr, $len) }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/bls.rs:690:5 [INFO] [stderr] | [INFO] [stderr] 690 | / check_useful_c_byte_array!(message, message_len, [INFO] [stderr] 691 | | ErrorCode::CommonInvalidParam1, ErrorCode::CommonInvalidParam2); [INFO] [stderr] | |_______________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:701:18 [INFO] [stderr] | [INFO] [stderr] 701 | *signature_p = Box::into_raw(Box::new(signature)) as *const c_void; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:702:69 [INFO] [stderr] | [INFO] [stderr] 702 | trace!("indy_crypto_bls_sign: *signature_p: {:?}", *signature_p); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | let $ptr = unsafe { slice::from_raw_parts($ptr, $len) }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/bls.rs:733:5 [INFO] [stderr] | [INFO] [stderr] 733 | / check_useful_c_byte_array!(message, message_len, [INFO] [stderr] 734 | | ErrorCode::CommonInvalidParam2, ErrorCode::CommonInvalidParam3); [INFO] [stderr] | |_______________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:744:23 [INFO] [stderr] | [INFO] [stderr] 744 | unsafe { *valid_p = valid; } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | let $ptr = unsafe { slice::from_raw_parts($ptr, $len) }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/bls.rs:776:5 [INFO] [stderr] | [INFO] [stderr] 776 | check_useful_c_byte_array!(message, message_len, ErrorCode::CommonInvalidParam2, ErrorCode::CommonInvalidParam3); [INFO] [stderr] | ----------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/utils/ctypes.rs:97:44 [INFO] [stderr] | [INFO] [stderr] 97 | unsafe { slice::from_raw_parts($ptrs, $ptrs_len) } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/ffi/bls.rs:777:5 [INFO] [stderr] | [INFO] [stderr] 777 | check_useful_c_reference_array!(ver_keys, ver_keys_len, VerKey, ErrorCode::CommonInvalidParam4, ErrorCode::CommonInvalidParam5); [INFO] [stderr] | -------------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:786:23 [INFO] [stderr] | [INFO] [stderr] 786 | unsafe { *valid_p = valid; } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ffi/bls.rs:821:23 [INFO] [stderr] | [INFO] [stderr] 821 | unsafe { *valid_p = valid; } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/pair/amcl.rs:786:25 [INFO] [stderr] | [INFO] [stderr] 786 | let mut big_2 = big.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `big` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to 194 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `indy-crypto`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "91fa22fd352ce09699902dc43474cbce3792515e35be9e70f8cd89014a5d569d"` [INFO] running `"docker" "rm" "-f" "91fa22fd352ce09699902dc43474cbce3792515e35be9e70f8cd89014a5d569d"` [INFO] [stdout] 91fa22fd352ce09699902dc43474cbce3792515e35be9e70f8cd89014a5d569d