[INFO] crate industrial-io 0.1.0 is already in cache [INFO] extracting crate industrial-io 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/industrial-io/0.1.0 [INFO] extracting crate industrial-io 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/industrial-io/0.1.0 [INFO] validating manifest of industrial-io-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of industrial-io-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing industrial-io-0.1.0 [INFO] finished frobbing industrial-io-0.1.0 [INFO] frobbed toml for industrial-io-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/industrial-io/0.1.0/Cargo.toml [INFO] started frobbing industrial-io-0.1.0 [INFO] finished frobbing industrial-io-0.1.0 [INFO] frobbed toml for industrial-io-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/industrial-io/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting industrial-io-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/industrial-io/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eca11651d32d91314d2fd55d35cd1099af6e85144832e2e61dc9ebcfbea06097 [INFO] running `"docker" "start" "-a" "eca11651d32d91314d2fd55d35cd1099af6e85144832e2e61dc9ebcfbea06097"` [INFO] [stderr] Compiling libiio-sys v0.1.0 [INFO] [stderr] Checking schedule_recv v0.1.0 [INFO] [stderr] Checking industrial-io v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `errors::*` [INFO] [stderr] --> src/context.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | use errors::*; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `device::*` [INFO] [stderr] --> src/context.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | use device::*; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `CStr` [INFO] [stderr] --> src/device.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | use std::ffi::{CString, CStr}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `errors::*` [INFO] [stderr] --> src/device.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | use errors::*; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `channel::*` [INFO] [stderr] --> src/device.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | use channel::*; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `CStr` [INFO] [stderr] --> src/channel.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | use std::ffi::{CString, CStr}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `errors::*` [INFO] [stderr] --> src/context.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | use errors::*; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `device::*` [INFO] [stderr] --> src/context.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | use device::*; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `CStr` [INFO] [stderr] --> src/device.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | use std::ffi::{CString, CStr}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `errors::*` [INFO] [stderr] --> src/device.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | use errors::*; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `channel::*` [INFO] [stderr] --> src/device.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | use channel::*; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `CStr` [INFO] [stderr] --> src/channel.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | use std::ffi::{CString, CStr}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/context.rs:56:58 [INFO] [stderr] | [INFO] [stderr] 56 | let timeout_ms: u64 = 1000 * timeout.as_secs() + timeout.subsec_millis() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(timeout.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/device.rs:73:27 [INFO] [stderr] | [INFO] [stderr] 73 | cstring_opt(pstr).ok_or("Invalid index".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Invalid index".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/channel.rs:64:27 [INFO] [stderr] | [INFO] [stderr] 64 | cstring_opt(pstr).ok_or("Invalid index".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Invalid index".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/context.rs:56:58 [INFO] [stderr] | [INFO] [stderr] 56 | let timeout_ms: u64 = 1000 * timeout.as_secs() + timeout.subsec_millis() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(timeout.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/device.rs:73:27 [INFO] [stderr] | [INFO] [stderr] 73 | cstring_opt(pstr).ok_or("Invalid index".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Invalid index".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/iio_readraw.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/channel.rs:64:27 [INFO] [stderr] | [INFO] [stderr] 64 | cstring_opt(pstr).ok_or("Invalid index".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Invalid index".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/iio_info_rs.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/iio_info_rs.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/bin/iio_info_rs.rs:30:29 [INFO] [stderr] | [INFO] [stderr] 30 | dev.name().unwrap_or("".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/bin/iio_info_rs.rs:30:29 [INFO] [stderr] | [INFO] [stderr] 30 | dev.name().unwrap_or("".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> examples/iio_readraw.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | else { [INFO] [stderr] | __________________^ [INFO] [stderr] 29 | | if let Ok(val) = chan.attr_read_int("raw") { [INFO] [stderr] 30 | | print!(" {:6}", val); [INFO] [stderr] 31 | | } [INFO] [stderr] ... | [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 28 | else if let Ok(val) = chan.attr_read_int("raw") { [INFO] [stderr] 29 | print!(" {:6}", val); [INFO] [stderr] 30 | } [INFO] [stderr] 31 | else { [INFO] [stderr] 32 | print!(" xxxxxx"); [INFO] [stderr] 33 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/iio_free_scan.rs:17:23 [INFO] [stderr] | [INFO] [stderr] 17 | const DFLT_DEV_NAME: &'static str = "44e0d000.tscadc:adc"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/iio_readraw.rs:18:37 [INFO] [stderr] | [INFO] [stderr] 18 | print!("{} ", chan.id().unwrap_or(unknown.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| unknown.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.48s [INFO] running `"docker" "inspect" "eca11651d32d91314d2fd55d35cd1099af6e85144832e2e61dc9ebcfbea06097"` [INFO] running `"docker" "rm" "-f" "eca11651d32d91314d2fd55d35cd1099af6e85144832e2e61dc9ebcfbea06097"` [INFO] [stdout] eca11651d32d91314d2fd55d35cd1099af6e85144832e2e61dc9ebcfbea06097