[INFO] crate indradb-postgres 0.1.0 is already in cache [INFO] extracting crate indradb-postgres 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/indradb-postgres/0.1.0 [INFO] extracting crate indradb-postgres 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/indradb-postgres/0.1.0 [INFO] validating manifest of indradb-postgres-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of indradb-postgres-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing indradb-postgres-0.1.0 [INFO] finished frobbing indradb-postgres-0.1.0 [INFO] frobbed toml for indradb-postgres-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/indradb-postgres/0.1.0/Cargo.toml [INFO] started frobbing indradb-postgres-0.1.0 [INFO] finished frobbing indradb-postgres-0.1.0 [INFO] frobbed toml for indradb-postgres-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/indradb-postgres/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting indradb-postgres-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/indradb-postgres/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 63fc2911278b8418ec196660bb1d6ef2c8b5aa22cc171b17a4d8c60da1d8d38a [INFO] running `"docker" "start" "-a" "63fc2911278b8418ec196660bb1d6ef2c8b5aa22cc171b17a4d8c60da1d8d38a"` [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking postgres-shared v0.4.2 [INFO] [stderr] Checking indradb-lib v0.15.0 [INFO] [stderr] Checking postgres v0.15.2 [INFO] [stderr] Checking r2d2_postgres v0.14.0 [INFO] [stderr] Checking indradb-postgres v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datastore.rs:45:32 [INFO] [stderr] | [INFO] [stderr] 45 | Ok(PostgresDatastore { pool: pool }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datastore.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | conn: conn, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datastore.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | trans: trans, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `trans` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datastore.rs:45:32 [INFO] [stderr] | [INFO] [stderr] 45 | Ok(PostgresDatastore { pool: pool }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datastore.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | conn: conn, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datastore.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | trans: trans, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `trans` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/schema.rs:1:20 [INFO] [stderr] | [INFO] [stderr] 1 | pub const SCHEMA: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/datastore.rs:56:47 [INFO] [stderr] | [INFO] [stderr] 56 | for statement in schema::SCHEMA.split(";") { [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/datastore.rs:57:37 [INFO] [stderr] | [INFO] [stderr] 57 | conn.execute(statement, &vec![]).chain_err(|| "Could not execute statement")?; [INFO] [stderr] | ^^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/schema.rs:1:20 [INFO] [stderr] | [INFO] [stderr] 1 | pub const SCHEMA: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/datastore.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / match q { [INFO] [stderr] 98 | | &VertexQuery::All { [INFO] [stderr] 99 | | ref start_id, [INFO] [stderr] 100 | | ref limit, [INFO] [stderr] ... | [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 97 | match *q { [INFO] [stderr] 98 | VertexQuery::All { [INFO] [stderr] 99 | ref start_id, [INFO] [stderr] 100 | ref limit, [INFO] [stderr] 101 | } => match start_id { [INFO] [stderr] 102 | &Some(start_id) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/datastore.rs:101:18 [INFO] [stderr] | [INFO] [stderr] 101 | } => match start_id { [INFO] [stderr] | __________________^ [INFO] [stderr] 102 | | &Some(start_id) => { [INFO] [stderr] 103 | | let query_template = "SELECT id, type FROM %t WHERE id > %p ORDER BY id LIMIT %p"; [INFO] [stderr] 104 | | let params: Vec> = vec![Box::new(start_id), Box::new(*limit as i64)]; [INFO] [stderr] ... | [INFO] [stderr] 111 | | } [INFO] [stderr] 112 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 101 | } => match *start_id { [INFO] [stderr] 102 | Some(start_id) => { [INFO] [stderr] 103 | let query_template = "SELECT id, type FROM %t WHERE id > %p ORDER BY id LIMIT %p"; [INFO] [stderr] 104 | let params: Vec> = vec![Box::new(start_id), Box::new(*limit as i64)]; [INFO] [stderr] 105 | sql_query_builder.push(query_template, "vertices", params); [INFO] [stderr] 106 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/datastore.rs:104:85 [INFO] [stderr] | [INFO] [stderr] 104 | let params: Vec> = vec![Box::new(start_id), Box::new(*limit as i64)]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(*limit)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/datastore.rs:109:65 [INFO] [stderr] | [INFO] [stderr] 109 | let params: Vec> = vec![Box::new(*limit as i64)]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(*limit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/datastore.rs:134:61 [INFO] [stderr] | [INFO] [stderr] 134 | let params: Vec> = vec![Box::new(*limit as i64)]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(*limit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/datastore.rs:136:38 [INFO] [stderr] | [INFO] [stderr] 136 | let query_template = match converter { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 137 | | &EdgeDirection::Outbound => { [INFO] [stderr] 138 | | "SELECT id, type FROM vertices WHERE id IN (SELECT outbound_id FROM %t) ORDER BY id LIMIT %p" [INFO] [stderr] 139 | | } [INFO] [stderr] ... | [INFO] [stderr] 142 | | } [INFO] [stderr] 143 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 136 | let query_template = match *converter { [INFO] [stderr] 137 | EdgeDirection::Outbound => { [INFO] [stderr] 138 | "SELECT id, type FROM vertices WHERE id IN (SELECT outbound_id FROM %t) ORDER BY id LIMIT %p" [INFO] [stderr] 139 | } [INFO] [stderr] 140 | EdgeDirection::Inbound => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/datastore.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | / match q { [INFO] [stderr] 152 | | &EdgeQuery::Edges { ref keys } => { [INFO] [stderr] 153 | | let mut params_template_builder = vec![]; [INFO] [stderr] 154 | | let mut params: Vec> = vec![]; [INFO] [stderr] ... | [INFO] [stderr] 222 | | } [INFO] [stderr] 223 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 151 | match *q { [INFO] [stderr] 152 | EdgeQuery::Edges { ref keys } => { [INFO] [stderr] 153 | let mut params_template_builder = vec![]; [INFO] [stderr] 154 | let mut params: Vec> = vec![]; [INFO] [stderr] 155 | [INFO] [stderr] 156 | for key in keys { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/datastore.rs:182:17 [INFO] [stderr] | [INFO] [stderr] 182 | / if let &Some(ref type_filter) = type_filter { [INFO] [stderr] 183 | | where_clause_template_builder.push("type = %p"); [INFO] [stderr] 184 | | params.push(Box::new(type_filter.0.to_string())); [INFO] [stderr] 185 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 182 | if let Some(ref type_filter) = *type_filter { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/datastore.rs:197:38 [INFO] [stderr] | [INFO] [stderr] 197 | params.push(Box::new(limit as i64)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(limit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/datastore.rs:281:9 [INFO] [stderr] | [INFO] [stderr] 281 | / for row in &results { [INFO] [stderr] 282 | | let count: i64 = row.get(0); [INFO] [stderr] 283 | | return Ok(count as u64); [INFO] [stderr] 284 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/datastore.rs:374:9 [INFO] [stderr] | [INFO] [stderr] 374 | / for row in &results { [INFO] [stderr] 375 | | let count: i64 = row.get(0); [INFO] [stderr] 376 | | return Ok(count as u64); [INFO] [stderr] 377 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/util.rs:15:14 [INFO] [stderr] | [INFO] [stderr] 15 | for i in 1..cur_params_length + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=cur_params_length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `indradb-postgres`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/datastore.rs:56:47 [INFO] [stderr] | [INFO] [stderr] 56 | for statement in schema::SCHEMA.split(";") { [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/datastore.rs:57:37 [INFO] [stderr] | [INFO] [stderr] 57 | conn.execute(statement, &vec![]).chain_err(|| "Could not execute statement")?; [INFO] [stderr] | ^^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/datastore.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / match q { [INFO] [stderr] 98 | | &VertexQuery::All { [INFO] [stderr] 99 | | ref start_id, [INFO] [stderr] 100 | | ref limit, [INFO] [stderr] ... | [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 97 | match *q { [INFO] [stderr] 98 | VertexQuery::All { [INFO] [stderr] 99 | ref start_id, [INFO] [stderr] 100 | ref limit, [INFO] [stderr] 101 | } => match start_id { [INFO] [stderr] 102 | &Some(start_id) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/datastore.rs:101:18 [INFO] [stderr] | [INFO] [stderr] 101 | } => match start_id { [INFO] [stderr] | __________________^ [INFO] [stderr] 102 | | &Some(start_id) => { [INFO] [stderr] 103 | | let query_template = "SELECT id, type FROM %t WHERE id > %p ORDER BY id LIMIT %p"; [INFO] [stderr] 104 | | let params: Vec> = vec![Box::new(start_id), Box::new(*limit as i64)]; [INFO] [stderr] ... | [INFO] [stderr] 111 | | } [INFO] [stderr] 112 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 101 | } => match *start_id { [INFO] [stderr] 102 | Some(start_id) => { [INFO] [stderr] 103 | let query_template = "SELECT id, type FROM %t WHERE id > %p ORDER BY id LIMIT %p"; [INFO] [stderr] 104 | let params: Vec> = vec![Box::new(start_id), Box::new(*limit as i64)]; [INFO] [stderr] 105 | sql_query_builder.push(query_template, "vertices", params); [INFO] [stderr] 106 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/datastore.rs:104:85 [INFO] [stderr] | [INFO] [stderr] 104 | let params: Vec> = vec![Box::new(start_id), Box::new(*limit as i64)]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(*limit)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/datastore.rs:109:65 [INFO] [stderr] | [INFO] [stderr] 109 | let params: Vec> = vec![Box::new(*limit as i64)]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(*limit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/datastore.rs:134:61 [INFO] [stderr] | [INFO] [stderr] 134 | let params: Vec> = vec![Box::new(*limit as i64)]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(*limit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/datastore.rs:136:38 [INFO] [stderr] | [INFO] [stderr] 136 | let query_template = match converter { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 137 | | &EdgeDirection::Outbound => { [INFO] [stderr] 138 | | "SELECT id, type FROM vertices WHERE id IN (SELECT outbound_id FROM %t) ORDER BY id LIMIT %p" [INFO] [stderr] 139 | | } [INFO] [stderr] ... | [INFO] [stderr] 142 | | } [INFO] [stderr] 143 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 136 | let query_template = match *converter { [INFO] [stderr] 137 | EdgeDirection::Outbound => { [INFO] [stderr] 138 | "SELECT id, type FROM vertices WHERE id IN (SELECT outbound_id FROM %t) ORDER BY id LIMIT %p" [INFO] [stderr] 139 | } [INFO] [stderr] 140 | EdgeDirection::Inbound => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/datastore.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | / match q { [INFO] [stderr] 152 | | &EdgeQuery::Edges { ref keys } => { [INFO] [stderr] 153 | | let mut params_template_builder = vec![]; [INFO] [stderr] 154 | | let mut params: Vec> = vec![]; [INFO] [stderr] ... | [INFO] [stderr] 222 | | } [INFO] [stderr] 223 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 151 | match *q { [INFO] [stderr] 152 | EdgeQuery::Edges { ref keys } => { [INFO] [stderr] 153 | let mut params_template_builder = vec![]; [INFO] [stderr] 154 | let mut params: Vec> = vec![]; [INFO] [stderr] 155 | [INFO] [stderr] 156 | for key in keys { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/datastore.rs:182:17 [INFO] [stderr] | [INFO] [stderr] 182 | / if let &Some(ref type_filter) = type_filter { [INFO] [stderr] 183 | | where_clause_template_builder.push("type = %p"); [INFO] [stderr] 184 | | params.push(Box::new(type_filter.0.to_string())); [INFO] [stderr] 185 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 182 | if let Some(ref type_filter) = *type_filter { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/datastore.rs:197:38 [INFO] [stderr] | [INFO] [stderr] 197 | params.push(Box::new(limit as i64)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(limit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/datastore.rs:281:9 [INFO] [stderr] | [INFO] [stderr] 281 | / for row in &results { [INFO] [stderr] 282 | | let count: i64 = row.get(0); [INFO] [stderr] 283 | | return Ok(count as u64); [INFO] [stderr] 284 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/datastore.rs:374:9 [INFO] [stderr] | [INFO] [stderr] 374 | / for row in &results { [INFO] [stderr] 375 | | let count: i64 = row.get(0); [INFO] [stderr] 376 | | return Ok(count as u64); [INFO] [stderr] 377 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/util.rs:15:14 [INFO] [stderr] | [INFO] [stderr] 15 | for i in 1..cur_params_length + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=cur_params_length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `indradb-postgres`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "63fc2911278b8418ec196660bb1d6ef2c8b5aa22cc171b17a4d8c60da1d8d38a"` [INFO] running `"docker" "rm" "-f" "63fc2911278b8418ec196660bb1d6ef2c8b5aa22cc171b17a4d8c60da1d8d38a"` [INFO] [stdout] 63fc2911278b8418ec196660bb1d6ef2c8b5aa22cc171b17a4d8c60da1d8d38a