[INFO] crate index-pool 1.0.11 is already in cache [INFO] extracting crate index-pool 1.0.11 into work/ex/clippy-test-run/sources/stable/reg/index-pool/1.0.11 [INFO] extracting crate index-pool 1.0.11 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/index-pool/1.0.11 [INFO] validating manifest of index-pool-1.0.11 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of index-pool-1.0.11 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing index-pool-1.0.11 [INFO] finished frobbing index-pool-1.0.11 [INFO] frobbed toml for index-pool-1.0.11 written to work/ex/clippy-test-run/sources/stable/reg/index-pool/1.0.11/Cargo.toml [INFO] started frobbing index-pool-1.0.11 [INFO] finished frobbing index-pool-1.0.11 [INFO] frobbed toml for index-pool-1.0.11 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/index-pool/1.0.11/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting index-pool-1.0.11 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/index-pool/1.0.11:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 91560e0fa50570e2b5fdcd16bcdf5946a26c96165c0d25d57519e671a63f7801 [INFO] running `"docker" "start" "-a" "91560e0fa50570e2b5fdcd16bcdf5946a26c96165c0d25d57519e671a63f7801"` [INFO] [stderr] Checking free-ranges v1.0.7 [INFO] [stderr] Checking index-pool v1.0.11 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return id; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return id; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 38 [INFO] [stderr] --> tests/basic_test.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | / fn basic_test() { [INFO] [stderr] 6 | | let mut pool = IndexPool::new(); [INFO] [stderr] 7 | | [INFO] [stderr] 8 | | assert!(pool.is_free(0)); [INFO] [stderr] ... | [INFO] [stderr] 73 | | assert!(pool.all_indices().eq([0, 1, 2].iter().cloned())); [INFO] [stderr] 74 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.49s [INFO] running `"docker" "inspect" "91560e0fa50570e2b5fdcd16bcdf5946a26c96165c0d25d57519e671a63f7801"` [INFO] running `"docker" "rm" "-f" "91560e0fa50570e2b5fdcd16bcdf5946a26c96165c0d25d57519e671a63f7801"` [INFO] [stdout] 91560e0fa50570e2b5fdcd16bcdf5946a26c96165c0d25d57519e671a63f7801