[INFO] crate index 0.15.4 is already in cache [INFO] extracting crate index 0.15.4 into work/ex/clippy-test-run/sources/stable/reg/index/0.15.4 [INFO] extracting crate index 0.15.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/index/0.15.4 [INFO] validating manifest of index-0.15.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of index-0.15.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing index-0.15.4 [INFO] finished frobbing index-0.15.4 [INFO] frobbed toml for index-0.15.4 written to work/ex/clippy-test-run/sources/stable/reg/index/0.15.4/Cargo.toml [INFO] started frobbing index-0.15.4 [INFO] finished frobbing index-0.15.4 [INFO] frobbed toml for index-0.15.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/index/0.15.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting index-0.15.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/index/0.15.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eddae9e27fe0b2382252c78470200fc0776f7117551f55e762516dc8a55c99e4 [INFO] running `"docker" "start" "-a" "eddae9e27fe0b2382252c78470200fc0776f7117551f55e762516dc8a55c99e4"` [INFO] [stderr] Checking crossbeam-utils v0.3.2 [INFO] [stderr] Checking crossbeam-epoch v0.4.3 [INFO] [stderr] Checking pagecache v0.2.7 [INFO] [stderr] Checking index v0.15.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/node.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/tree/node.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mod.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mod.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mod.rs:342:13 [INFO] [stderr] | [INFO] [stderr] 342 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mod.rs:345:13 [INFO] [stderr] | [INFO] [stderr] 345 | broken: broken, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `broken` [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mod.rs:342:13 [INFO] [stderr] | [INFO] [stderr] 342 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/tree/mod.rs:345:13 [INFO] [stderr] | [INFO] [stderr] 345 | broken: broken, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `broken` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `index`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/tree/data.rs:42:68 [INFO] [stderr] | [INFO] [stderr] 42 | Data::Index(ref mut ptrs) => ptrs.retain(|&(ref k, _)| k < &bound), [INFO] [stderr] | ^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `bound` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/tree/data.rs:43:69 [INFO] [stderr] | [INFO] [stderr] 43 | Data::Leaf(ref mut items) => items.retain(|&(ref k, _)| k < &bound), [INFO] [stderr] | ^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `bound` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/tree/iter.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | / if node.next.is_none() { [INFO] [stderr] 48 | | return None; [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____________^ help: replace_it_with: `node.next?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tree/materializer.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / match *frag { [INFO] [stderr] 38 | | Frag::Base(ref node, prev_root) => { [INFO] [stderr] 39 | | if let Some(prev_root) = prev_root { [INFO] [stderr] 40 | | let mut roots = self.roots.lock().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 47 | | _ => (), [INFO] [stderr] 48 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | if let Frag::Base(ref node, prev_root) = *frag { [INFO] [stderr] 38 | if let Some(prev_root) = prev_root { [INFO] [stderr] 39 | let mut roots = self.roots.lock().unwrap(); [INFO] [stderr] 40 | if !roots.contains(&(node.id, prev_root)) { [INFO] [stderr] 41 | roots.push((node.id, prev_root)); [INFO] [stderr] 42 | return Some(roots.clone()); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/tree/mod.rs:36:12 [INFO] [stderr] | [INFO] [stderr] 36 | pages: Arc>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/tree/mod.rs:560:10 [INFO] [stderr] | [INFO] [stderr] 560 | ) -> DbResult<(Vec<(Node, TreePtr<'g>)>, Option), ()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/tree/mod.rs:670:28 [INFO] [stderr] | [INFO] [stderr] 670 | if &**sep_k <= key { [INFO] [stderr] | --------^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**sep_k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "eddae9e27fe0b2382252c78470200fc0776f7117551f55e762516dc8a55c99e4"` [INFO] running `"docker" "rm" "-f" "eddae9e27fe0b2382252c78470200fc0776f7117551f55e762516dc8a55c99e4"` [INFO] [stdout] eddae9e27fe0b2382252c78470200fc0776f7117551f55e762516dc8a55c99e4