[INFO] crate indep 0.1.1 is already in cache [INFO] extracting crate indep 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/indep/0.1.1 [INFO] extracting crate indep 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/indep/0.1.1 [INFO] validating manifest of indep-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of indep-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing indep-0.1.1 [INFO] finished frobbing indep-0.1.1 [INFO] frobbed toml for indep-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/indep/0.1.1/Cargo.toml [INFO] started frobbing indep-0.1.1 [INFO] finished frobbing indep-0.1.1 [INFO] frobbed toml for indep-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/indep/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting indep-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/indep/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d95ffb36494767bb3b27cfc68c7ded09d7eef2816d4691505ba769a27cb2ee6f [INFO] running `"docker" "start" "-a" "d95ffb36494767bb3b27cfc68c7ded09d7eef2816d4691505ba769a27cb2ee6f"` [INFO] [stderr] Checking indep v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::rc::Rc` [INFO] [stderr] --> src/sync.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | use std::rc::Rc; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cell::RefCell` [INFO] [stderr] --> src/sync.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | use std::cell::RefCell; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::Arc` [INFO] [stderr] --> src/async.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | use std::sync::Arc; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::RwLock` [INFO] [stderr] --> src/async.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | use std::sync::RwLock; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/sync.rs:219:17 [INFO] [stderr] | [INFO] [stderr] 219 | format!("Impl1 says 'Trait2'") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Impl1 says 'Trait2'".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/sync.rs:265:17 [INFO] [stderr] | [INFO] [stderr] 265 | format!("Impl2 says 'Trait2'") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Impl2 says 'Trait2'".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/sync.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | / match i { [INFO] [stderr] 132 | | $( [INFO] [stderr] 133 | | &Implementation::$tra(ref tr) => { [INFO] [stderr] 134 | | $( [INFO] [stderr] ... | [INFO] [stderr] 149 | | _ => {} [INFO] [stderr] 150 | | } [INFO] [stderr] | |_________________^ help: try this: `if let &Implementation::$tra(ref tr) = i { indep_reqs_sync!{Impl2, [Trait1: [t1]]} }` [INFO] [stderr] ... [INFO] [stderr] 275 | indep_reqs_sync!{Impl2, [Trait1: [t1]]} [INFO] [stderr] | --------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sync.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | / match i { [INFO] [stderr] 132 | | $( [INFO] [stderr] 133 | | &Implementation::$tra(ref tr) => { [INFO] [stderr] 134 | | $( [INFO] [stderr] ... | [INFO] [stderr] 149 | | _ => {} [INFO] [stderr] 150 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 275 | indep_reqs_sync!{Impl2, [Trait1: [t1]]} [INFO] [stderr] | --------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sync.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | / match i { [INFO] [stderr] 132 | | $( [INFO] [stderr] 133 | | &Implementation::$tra(ref tr) => { [INFO] [stderr] 134 | | $( [INFO] [stderr] ... | [INFO] [stderr] 149 | | _ => {} [INFO] [stderr] 150 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 330 | indep_reqs_sync!{Impl3, [Trait1: [t1_1], Trait2: [t2_1,t2_2]]} [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sync.rs:12:17 [INFO] [stderr] | [INFO] [stderr] 12 | / match self { [INFO] [stderr] 13 | | $(&Implementation::$tra(_) => write!(f, "{}", stringify!($tra))),* [INFO] [stderr] 14 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 340 | indep_pool_sync!{Base, Trait1,Trait2,Trait3} [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sync.rs:26:48 [INFO] [stderr] | [INFO] [stderr] 26 | fn set(&mut self, &Implementation, &Vec); [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] ... [INFO] [stderr] 340 | indep_pool_sync!{Base, Trait1,Trait2,Trait3} [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/sync.rs:53:25 [INFO] [stderr] | [INFO] [stderr] 53 | for ref pimp in pd.impls() { [INFO] [stderr] | ^^^^^^^^ ---------- help: try: `let pimp = &pd.impls();` [INFO] [stderr] ... [INFO] [stderr] 340 | indep_pool_sync!{Base, Trait1,Trait2,Trait3} [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/sync.rs:76:25 [INFO] [stderr] | [INFO] [stderr] 76 | for ref aimp in ad.impls() { [INFO] [stderr] | ^^^^^^^^ ---------- help: try: `let aimp = &ad.impls();` [INFO] [stderr] ... [INFO] [stderr] 340 | indep_pool_sync!{Base, Trait1,Trait2,Trait3} [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/sync.rs:80:25 [INFO] [stderr] | [INFO] [stderr] 80 | for ref pimp in pd.impls() { [INFO] [stderr] | ^^^^^^^^ ---------- help: try: `let pimp = &pd.impls();` [INFO] [stderr] ... [INFO] [stderr] 340 | indep_pool_sync!{Base, Trait1,Trait2,Trait3} [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/async.rs:219:17 [INFO] [stderr] | [INFO] [stderr] 219 | format!("Impl1 says 'Trait2'") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Impl1 says 'Trait2'".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/async.rs:265:17 [INFO] [stderr] | [INFO] [stderr] 265 | format!("Impl2 says 'Trait2'") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Impl2 says 'Trait2'".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/async.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | / match i { [INFO] [stderr] 132 | | $( [INFO] [stderr] 133 | | &Implementation::$tra(ref tr) => { [INFO] [stderr] 134 | | $( [INFO] [stderr] ... | [INFO] [stderr] 149 | | _ => {} [INFO] [stderr] 150 | | } [INFO] [stderr] | |_________________^ help: try this: `if let &Implementation::$tra(ref tr) = i { indep_reqs_async!{Impl2, [Trait1: [t1]]} }` [INFO] [stderr] ... [INFO] [stderr] 275 | indep_reqs_async!{Impl2, [Trait1: [t1]]} [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/async.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | / match i { [INFO] [stderr] 132 | | $( [INFO] [stderr] 133 | | &Implementation::$tra(ref tr) => { [INFO] [stderr] 134 | | $( [INFO] [stderr] ... | [INFO] [stderr] 149 | | _ => {} [INFO] [stderr] 150 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 275 | indep_reqs_async!{Impl2, [Trait1: [t1]]} [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/async.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | / match i { [INFO] [stderr] 132 | | $( [INFO] [stderr] 133 | | &Implementation::$tra(ref tr) => { [INFO] [stderr] 134 | | $( [INFO] [stderr] ... | [INFO] [stderr] 149 | | _ => {} [INFO] [stderr] 150 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 330 | indep_reqs_async!{Impl3, [Trait1: [t1_1], Trait2: [t2_1,t2_2]]} [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/async.rs:12:17 [INFO] [stderr] | [INFO] [stderr] 12 | / match self { [INFO] [stderr] 13 | | $(&Implementation::$tra(_) => write!(f, "{}", stringify!($tra))),* [INFO] [stderr] 14 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 340 | indep_pool_async!{Base, Trait1,Trait2,Trait3} [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/async.rs:26:48 [INFO] [stderr] | [INFO] [stderr] 26 | fn set(&mut self, &Implementation, &Vec); [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] ... [INFO] [stderr] 340 | indep_pool_async!{Base, Trait1,Trait2,Trait3} [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/async.rs:53:25 [INFO] [stderr] | [INFO] [stderr] 53 | for ref pimp in pd.impls() { [INFO] [stderr] | ^^^^^^^^ ---------- help: try: `let pimp = &pd.impls();` [INFO] [stderr] ... [INFO] [stderr] 340 | indep_pool_async!{Base, Trait1,Trait2,Trait3} [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/async.rs:76:25 [INFO] [stderr] | [INFO] [stderr] 76 | for ref aimp in ad.impls() { [INFO] [stderr] | ^^^^^^^^ ---------- help: try: `let aimp = &ad.impls();` [INFO] [stderr] ... [INFO] [stderr] 340 | indep_pool_async!{Base, Trait1,Trait2,Trait3} [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/async.rs:80:25 [INFO] [stderr] | [INFO] [stderr] 80 | for ref pimp in pd.impls() { [INFO] [stderr] | ^^^^^^^^ ---------- help: try: `let pimp = &pd.impls();` [INFO] [stderr] ... [INFO] [stderr] 340 | indep_pool_async!{Base, Trait1,Trait2,Trait3} [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::Arc` [INFO] [stderr] --> examples/async.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | use std::sync::Arc; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::RwLock` [INFO] [stderr] --> examples/async.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | use std::sync::RwLock; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::rc::Rc` [INFO] [stderr] --> examples/sync.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | use std::rc::Rc; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cell::RefCell` [INFO] [stderr] --> examples/sync.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | use std::cell::RefCell; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `i1::Impl1` [INFO] [stderr] --> examples/sync.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | / pub fn new() -> Impl1 { [INFO] [stderr] 56 | | Impl1 [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | #[derive(Default)] [INFO] [stderr] 49 | struct Impl1; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `i1::Impl1` [INFO] [stderr] --> examples/async.rs:55:6 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn new() -> Impl1 { [INFO] [stderr] | _________^ [INFO] [stderr] 56 | | Impl1 [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | #[derive(Default)] [INFO] [stderr] 49 | struct Impl1; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> examples/sync.rs:68:13 [INFO] [stderr] --> examples/async.rs:68:10 [INFO] [stderr] | [INFO] [stderr] 68 | format!("Impl1 says 'Trait2'") [INFO] [stderr] | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Impl1 says 'Trait2'".to_string()` [INFO] [stderr] 68 | format!("Impl1 says 'Trait2'") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Impl1 says 'Trait2'".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `i2::Impl2` [INFO] [stderr] --> examples/sync.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | / pub fn new() -> Impl2 { [INFO] [stderr] 118 | | Impl2 { [INFO] [stderr] 119 | | t1:None [INFO] [stderr] 120 | | } [INFO] [stderr] 121 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 105 | #[derive(Default)] [INFO] [stderr] 106 | struct Impl2 { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> examples/sync.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | format!("Impl2 says 'Trait2'") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Impl2 says 'Trait2'".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `i2::Impl2` [INFO] [stderr] --> examples/async.rs:117:6 [INFO] [stderr] | [INFO] [stderr] 117 | pub fn new() -> Impl2 { [INFO] [stderr] | _________^ [INFO] [stderr] 118 | | Impl2 { [INFO] [stderr] 119 | | t1:None [INFO] [stderr] 120 | | } [INFO] [stderr] 121 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 105 | #[derive(Default)] [INFO] [stderr] 106 | struct Impl2 { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> examples/async.rs:127:10 [INFO] [stderr] | [INFO] [stderr] 127 | format!("Impl2 says 'Trait2'") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Impl2 says 'Trait2'".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `i3::Impl3` [INFO] [stderr] --> examples/sync.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | / pub fn new() -> Impl3 { [INFO] [stderr] 180 | | Impl3 { [INFO] [stderr] 181 | | t1_1: None, [INFO] [stderr] 182 | | t2_1: None, [INFO] [stderr] 183 | | t2_2: None, [INFO] [stderr] 184 | | } [INFO] [stderr] 185 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 161 | #[derive(Default)] [INFO] [stderr] 162 | struct Impl3 { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `i3::Impl3` [INFO] [stderr] --> examples/async.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | / pub fn new() -> Impl3 { [INFO] [stderr] 180 | | Impl3 { [INFO] [stderr] 181 | | t1_1: None, [INFO] [stderr] 182 | | t2_1: None, [INFO] [stderr] 183 | | t2_2: None, [INFO] [stderr] 184 | | } [INFO] [stderr] 185 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 161 | #[derive(Default)] [INFO] [stderr] 162 | struct Impl3 { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> examples/sync.rs:217:1 [INFO] [stderr] | [INFO] [stderr] 217 | indep_pool_sync!{Base, Trait1,Trait2,Trait3} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/sync.rs:217:1 [INFO] [stderr] | [INFO] [stderr] 217 | indep_pool_sync!{Base, Trait1,Trait2,Trait3} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/sync.rs:217:1 [INFO] [stderr] | [INFO] [stderr] 217 | indep_pool_sync!{Base, Trait1,Trait2,Trait3} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/sync.rs:217:1 [INFO] [stderr] | [INFO] [stderr] 217 | indep_pool_sync!{Base, Trait1,Trait2,Trait3} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> examples/async.rs:216:1 [INFO] [stderr] | [INFO] [stderr] 216 | indep_pool_async!{Base, Trait1,Trait2,Trait3} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/async.rs:216:1 [INFO] [stderr] | [INFO] [stderr] 216 | indep_pool_async!{Base, Trait1,Trait2,Trait3} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/async.rs:216:1 [INFO] [stderr] | [INFO] [stderr] 216 | indep_pool_async!{Base, Trait1,Trait2,Trait3} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/async.rs:216:1 [INFO] [stderr] | [INFO] [stderr] 216 | indep_pool_async!{Base, Trait1,Trait2,Trait3} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.64s [INFO] running `"docker" "inspect" "d95ffb36494767bb3b27cfc68c7ded09d7eef2816d4691505ba769a27cb2ee6f"` [INFO] running `"docker" "rm" "-f" "d95ffb36494767bb3b27cfc68c7ded09d7eef2816d4691505ba769a27cb2ee6f"` [INFO] [stdout] d95ffb36494767bb3b27cfc68c7ded09d7eef2816d4691505ba769a27cb2ee6f