[INFO] crate in-situ 0.3.0 is already in cache [INFO] extracting crate in-situ 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/in-situ/0.3.0 [INFO] extracting crate in-situ 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/in-situ/0.3.0 [INFO] validating manifest of in-situ-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of in-situ-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing in-situ-0.3.0 [INFO] finished frobbing in-situ-0.3.0 [INFO] frobbed toml for in-situ-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/in-situ/0.3.0/Cargo.toml [INFO] started frobbing in-situ-0.3.0 [INFO] finished frobbing in-situ-0.3.0 [INFO] frobbed toml for in-situ-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/in-situ/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting in-situ-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/in-situ/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9f3fd841c0fa991b96651c14f58a25141305bfce0ccb0b1a60bbdcc0afb09937 [INFO] running `"docker" "start" "-a" "9f3fd841c0fa991b96651c14f58a25141305bfce0ccb0b1a60bbdcc0afb09937"` [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Checking bytes v0.4.11 [INFO] [stderr] Checking in-situ v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:89:16 [INFO] [stderr] | [INFO] [stderr] 89 | let padding = -(offset as isize) as usize & align - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `-(offset as isize) as usize & (align - 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:97:16 [INFO] [stderr] | [INFO] [stderr] 97 | let aligned = offset + align - 1 & -(align as isize) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(offset + align - 1) & -(align as isize) as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:137:22 [INFO] [stderr] | [INFO] [stderr] 137 | { offset } else { offset ^ self.swap_size() - word_size } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `offset ^ (self.swap_size() - word_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:89:16 [INFO] [stderr] | [INFO] [stderr] 89 | let padding = -(offset as isize) as usize & align - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `-(offset as isize) as usize & (align - 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:97:16 [INFO] [stderr] | [INFO] [stderr] 97 | let aligned = offset + align - 1 & -(align as isize) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(offset + align - 1) & -(align as isize) as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:137:22 [INFO] [stderr] | [INFO] [stderr] 137 | { offset } else { offset ^ self.swap_size() - word_size } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `offset ^ (self.swap_size() - word_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:128:3 [INFO] [stderr] | [INFO] [stderr] 128 | match self.is_be() [INFO] [stderr] | _________^ [INFO] [stderr] 129 | | { true => Order::BE, false => Order::LE } [INFO] [stderr] | |_____________________________________________________^ help: consider using an if/else expression: `if self.is_be() { Order::BE } else { Order::LE }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:128:3 [INFO] [stderr] | [INFO] [stderr] 128 | match self.is_be() [INFO] [stderr] | _________^ [INFO] [stderr] 129 | | { true => Order::BE, false => Order::LE } [INFO] [stderr] | |_____________________________________________________^ help: consider using an if/else expression: `if self.is_be() { Order::BE } else { Order::LE }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.63s [INFO] running `"docker" "inspect" "9f3fd841c0fa991b96651c14f58a25141305bfce0ccb0b1a60bbdcc0afb09937"` [INFO] running `"docker" "rm" "-f" "9f3fd841c0fa991b96651c14f58a25141305bfce0ccb0b1a60bbdcc0afb09937"` [INFO] [stdout] 9f3fd841c0fa991b96651c14f58a25141305bfce0ccb0b1a60bbdcc0afb09937