[INFO] crate immutable_arena 0.1.1 is already in cache [INFO] extracting crate immutable_arena 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/immutable_arena/0.1.1 [INFO] extracting crate immutable_arena 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/immutable_arena/0.1.1 [INFO] validating manifest of immutable_arena-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of immutable_arena-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing immutable_arena-0.1.1 [INFO] finished frobbing immutable_arena-0.1.1 [INFO] frobbed toml for immutable_arena-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/immutable_arena/0.1.1/Cargo.toml [INFO] started frobbing immutable_arena-0.1.1 [INFO] finished frobbing immutable_arena-0.1.1 [INFO] frobbed toml for immutable_arena-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/immutable_arena/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting immutable_arena-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/immutable_arena/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 42ede728850b4162b9039d4bc7aa76a87686c7eb9a873df55a71edf042fa6e78 [INFO] running `"docker" "start" "-a" "42ede728850b4162b9039d4bc7aa76a87686c7eb9a873df55a71edf042fa6e78"` [INFO] [stderr] Checking immutable_arena v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Arena` [INFO] [stderr] --> src/lib.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / pub fn new() -> Arena { [INFO] [stderr] 61 | | Arena { arena: typed_arena::Arena::new() } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | impl Default for Arena { [INFO] [stderr] 59 | fn default() -> Self { [INFO] [stderr] 60 | Self::new() [INFO] [stderr] 61 | } [INFO] [stderr] 62 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:88:33 [INFO] [stderr] | [INFO] [stderr] 88 | ptr: AtomicPtr::new(0 as *mut T), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:107:38 [INFO] [stderr] | [INFO] [stderr] 107 | if self.ptr.compare_and_swap(0 as *mut T, ptr, Ordering::Relaxed) != 0 as *mut T { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:107:78 [INFO] [stderr] | [INFO] [stderr] 107 | if self.ptr.compare_and_swap(0 as *mut T, ptr, Ordering::Relaxed) != 0 as *mut T { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&T`) [INFO] [stderr] --> src/lib.rs:118:18 [INFO] [stderr] | [INFO] [stderr] 118 | unsafe { mem::transmute(self.ptr.load(Ordering::Relaxed)) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*self.ptr.load(Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Arena` [INFO] [stderr] --> src/lib.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / pub fn new() -> Arena { [INFO] [stderr] 61 | | Arena { arena: typed_arena::Arena::new() } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | impl Default for Arena { [INFO] [stderr] 59 | fn default() -> Self { [INFO] [stderr] 60 | Self::new() [INFO] [stderr] 61 | } [INFO] [stderr] 62 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:88:33 [INFO] [stderr] | [INFO] [stderr] 88 | ptr: AtomicPtr::new(0 as *mut T), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:107:38 [INFO] [stderr] | [INFO] [stderr] 107 | if self.ptr.compare_and_swap(0 as *mut T, ptr, Ordering::Relaxed) != 0 as *mut T { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:107:78 [INFO] [stderr] | [INFO] [stderr] 107 | if self.ptr.compare_and_swap(0 as *mut T, ptr, Ordering::Relaxed) != 0 as *mut T { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&T`) [INFO] [stderr] --> src/lib.rs:118:18 [INFO] [stderr] | [INFO] [stderr] 118 | unsafe { mem::transmute(self.ptr.load(Ordering::Relaxed)) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*self.ptr.load(Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.78s [INFO] running `"docker" "inspect" "42ede728850b4162b9039d4bc7aa76a87686c7eb9a873df55a71edf042fa6e78"` [INFO] running `"docker" "rm" "-f" "42ede728850b4162b9039d4bc7aa76a87686c7eb9a873df55a71edf042fa6e78"` [INFO] [stdout] 42ede728850b4162b9039d4bc7aa76a87686c7eb9a873df55a71edf042fa6e78