[INFO] crate immutable-seq 0.1.2 is already in cache [INFO] extracting crate immutable-seq 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/immutable-seq/0.1.2 [INFO] extracting crate immutable-seq 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/immutable-seq/0.1.2 [INFO] validating manifest of immutable-seq-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of immutable-seq-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing immutable-seq-0.1.2 [INFO] finished frobbing immutable-seq-0.1.2 [INFO] frobbed toml for immutable-seq-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/immutable-seq/0.1.2/Cargo.toml [INFO] started frobbing immutable-seq-0.1.2 [INFO] finished frobbing immutable-seq-0.1.2 [INFO] frobbed toml for immutable-seq-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/immutable-seq/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting immutable-seq-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/immutable-seq/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 311b59edd8eb64e5cead56d54ba721c344e646be29244967921df2887b9d717e [INFO] running `"docker" "start" "-a" "311b59edd8eb64e5cead56d54ba721c344e646be29244967921df2887b9d717e"` [INFO] [stderr] Checking immutable-seq v0.1.2 (/opt/crater/workdir) [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/lazy.rs:126:24 [INFO] [stderr] | [INFO] [stderr] 126 | fn inner(&self) -> &mut Inner { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/lazy.rs:126:14 [INFO] [stderr] | [INFO] [stderr] 126 | fn inner(&self) -> &mut Inner { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/lazy.rs:134:21 [INFO] [stderr] | [INFO] [stderr] 134 | fn rc(&self) -> &mut Rc>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/lazy.rs:134:11 [INFO] [stderr] | [INFO] [stderr] 134 | fn rc(&self) -> &mut Rc>> { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/node.rs:123:24 [INFO] [stderr] | [INFO] [stderr] 123 | -> (Option>, &'a Lazy>, Option>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/node.rs:156:5 [INFO] [stderr] | [INFO] [stderr] 156 | / pub fn iter<'a>(&'a self) -> Iter<'a,T,M> { [INFO] [stderr] 157 | | Iter::new(self) [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/node.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | / match self { [INFO] [stderr] 177 | | &Leaf(ref value) => value.measure(), [INFO] [stderr] 178 | | &Node2(measure, _, _) => measure, [INFO] [stderr] 179 | | &Node3(measure, _, _, _) => measure, [INFO] [stderr] 180 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 176 | match *self { [INFO] [stderr] 177 | Leaf(ref value) => value.measure(), [INFO] [stderr] 178 | Node2(measure, _, _) => measure, [INFO] [stderr] 179 | Node3(measure, _, _, _) => measure, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/digit.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn iter<'a>(&'a self) -> Iter<'a, T, M> { [INFO] [stderr] 23 | | Iter::new(self) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/digit.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | / match self.inner.next() { [INFO] [stderr] 124 | | Some(x) => return Some(x), [INFO] [stderr] 125 | | None => {} [INFO] [stderr] 126 | | }; [INFO] [stderr] | |_____________^ help: try this: `if let Some(x) = self.inner.next() { return Some(x) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/digit.rs:306:24 [INFO] [stderr] | [INFO] [stderr] 306 | -> (Option>,&'a Lazy>,Option>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/finger_tree.rs:318:53 [INFO] [stderr] | [INFO] [stderr] 318 | fn viewl_node(tree: &Lazy>) -> (Option<&Node>, Lazy>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/finger_tree.rs:356:53 [INFO] [stderr] | [INFO] [stderr] 356 | fn viewr_node(tree: &Lazy>) -> (Lazy>, Option<&Node>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/finger_tree.rs:476:25 [INFO] [stderr] | [INFO] [stderr] 476 | -> (Lazy>,&'a Lazy>,Lazy>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/seq.rs:296:29 [INFO] [stderr] | [INFO] [stderr] 296 | while let Some(x) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for x in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `immutable-seq`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/lazy.rs:126:24 [INFO] [stderr] | [INFO] [stderr] 126 | fn inner(&self) -> &mut Inner { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/lazy.rs:126:14 [INFO] [stderr] | [INFO] [stderr] 126 | fn inner(&self) -> &mut Inner { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/lazy.rs:134:21 [INFO] [stderr] | [INFO] [stderr] 134 | fn rc(&self) -> &mut Rc>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/lazy.rs:134:11 [INFO] [stderr] | [INFO] [stderr] 134 | fn rc(&self) -> &mut Rc>> { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/lazy.rs:255:9 [INFO] [stderr] | [INFO] [stderr] 255 | *val; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/lazy.rs:256:9 [INFO] [stderr] | [INFO] [stderr] 256 | *val; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/node.rs:123:24 [INFO] [stderr] | [INFO] [stderr] 123 | -> (Option>, &'a Lazy>, Option>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/node.rs:156:5 [INFO] [stderr] | [INFO] [stderr] 156 | / pub fn iter<'a>(&'a self) -> Iter<'a,T,M> { [INFO] [stderr] 157 | | Iter::new(self) [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/node.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | / match self { [INFO] [stderr] 177 | | &Leaf(ref value) => value.measure(), [INFO] [stderr] 178 | | &Node2(measure, _, _) => measure, [INFO] [stderr] 179 | | &Node3(measure, _, _, _) => measure, [INFO] [stderr] 180 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 176 | match *self { [INFO] [stderr] 177 | Leaf(ref value) => value.measure(), [INFO] [stderr] 178 | Node2(measure, _, _) => measure, [INFO] [stderr] 179 | Node3(measure, _, _, _) => measure, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/digit.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn iter<'a>(&'a self) -> Iter<'a, T, M> { [INFO] [stderr] 23 | | Iter::new(self) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/digit.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | / match self.inner.next() { [INFO] [stderr] 124 | | Some(x) => return Some(x), [INFO] [stderr] 125 | | None => {} [INFO] [stderr] 126 | | }; [INFO] [stderr] | |_____________^ help: try this: `if let Some(x) = self.inner.next() { return Some(x) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/digit.rs:306:24 [INFO] [stderr] | [INFO] [stderr] 306 | -> (Option>,&'a Lazy>,Option>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/digit.rs:335:31 [INFO] [stderr] | [INFO] [stderr] 335 | let result:Vec = digit.iter().map(|x| *x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `digit.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/finger_tree.rs:318:53 [INFO] [stderr] | [INFO] [stderr] 318 | fn viewl_node(tree: &Lazy>) -> (Option<&Node>, Lazy>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/finger_tree.rs:356:53 [INFO] [stderr] | [INFO] [stderr] 356 | fn viewr_node(tree: &Lazy>) -> (Lazy>, Option<&Node>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/finger_tree.rs:476:25 [INFO] [stderr] | [INFO] [stderr] 476 | -> (Lazy>,&'a Lazy>,Lazy>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/seq.rs:296:29 [INFO] [stderr] | [INFO] [stderr] 296 | while let Some(x) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for x in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `immutable-seq`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "311b59edd8eb64e5cead56d54ba721c344e646be29244967921df2887b9d717e"` [INFO] running `"docker" "rm" "-f" "311b59edd8eb64e5cead56d54ba721c344e646be29244967921df2887b9d717e"` [INFO] [stdout] 311b59edd8eb64e5cead56d54ba721c344e646be29244967921df2887b9d717e