[INFO] crate immortal 0.1.0 is already in cache [INFO] extracting crate immortal 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/immortal/0.1.0 [INFO] extracting crate immortal 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/immortal/0.1.0 [INFO] validating manifest of immortal-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of immortal-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing immortal-0.1.0 [INFO] finished frobbing immortal-0.1.0 [INFO] frobbed toml for immortal-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/immortal/0.1.0/Cargo.toml [INFO] started frobbing immortal-0.1.0 [INFO] finished frobbing immortal-0.1.0 [INFO] frobbed toml for immortal-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/immortal/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting immortal-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/immortal/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8c0d93a75607b0ab867b02128b9f5174b825d5a97b903310768d5f37497b20bb [INFO] running `"docker" "start" "-a" "8c0d93a75607b0ab867b02128b9f5174b825d5a97b903310768d5f37497b20bb"` [INFO] [stderr] Checking immortal v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scan.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scan.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/scan.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | / let mut is_exec: bool = false; [INFO] [stderr] 35 | | if !file.file_type().unwrap().is_dir() { [INFO] [stderr] 36 | | is_exec = mode & 0o111 != 0; [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let is_exec = if !file.file_type().unwrap().is_dir() { mode & 0o111 != 0 } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/scan.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | / let mut is_exec: bool = false; [INFO] [stderr] 35 | | if !file.file_type().unwrap().is_dir() { [INFO] [stderr] 36 | | is_exec = mode & 0o111 != 0; [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let is_exec = if !file.file_type().unwrap().is_dir() { mode & 0o111 != 0 } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: unused import: `immortal::daemon` [INFO] [stderr] --> src/bin/immortal.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use immortal::daemon; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/bin/immortal.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `SubCommand` [INFO] [stderr] --> src/bin/immortal.rs:6:22 [INFO] [stderr] | [INFO] [stderr] 6 | use clap::{Arg, App, SubCommand}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `immortal::daemon` [INFO] [stderr] --> src/bin/immortal.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use immortal::daemon; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/bin/immortal.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `SubCommand` [INFO] [stderr] --> src/bin/immortal.rs:6:22 [INFO] [stderr] | [INFO] [stderr] 6 | use clap::{Arg, App, SubCommand}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.22s [INFO] running `"docker" "inspect" "8c0d93a75607b0ab867b02128b9f5174b825d5a97b903310768d5f37497b20bb"` [INFO] running `"docker" "rm" "-f" "8c0d93a75607b0ab867b02128b9f5174b825d5a97b903310768d5f37497b20bb"` [INFO] [stdout] 8c0d93a75607b0ab867b02128b9f5174b825d5a97b903310768d5f37497b20bb