[INFO] crate immi 1.0.4 is already in cache [INFO] extracting crate immi 1.0.4 into work/ex/clippy-test-run/sources/stable/reg/immi/1.0.4 [INFO] extracting crate immi 1.0.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/immi/1.0.4 [INFO] validating manifest of immi-1.0.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of immi-1.0.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing immi-1.0.4 [INFO] finished frobbing immi-1.0.4 [INFO] frobbed toml for immi-1.0.4 written to work/ex/clippy-test-run/sources/stable/reg/immi/1.0.4/Cargo.toml [INFO] started frobbing immi-1.0.4 [INFO] finished frobbing immi-1.0.4 [INFO] frobbed toml for immi-1.0.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/immi/1.0.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting immi-1.0.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/immi/1.0.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 28b0a534764f699bcaf8d37ac7fc500231d43a2e835fa2c884807be18960aeb1 [INFO] running `"docker" "start" "-a" "28b0a534764f699bcaf8d37ac7fc500231d43a2e835fa2c884807be18960aeb1"` [INFO] [stderr] Checking immi v1.0.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layout.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layout.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layout.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | cursor: cursor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layout.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | cursor_was_pressed: cursor_was_pressed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cursor_was_pressed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layout.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | cursor_was_released: cursor_was_released, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cursor_was_released` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layout.rs:475:13 [INFO] [stderr] | [INFO] [stderr] 475 | weights: weights, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `weights` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layout.rs:476:13 [INFO] [stderr] | [INFO] [stderr] 476 | total_weight_inverse: total_weight_inverse, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_weight_inverse` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layout.rs:478:13 [INFO] [stderr] | [INFO] [stderr] 478 | vertical: vertical, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertical` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/matrix.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | let e = me[0][1] * other[1][0] + me[1][1] * other[1][1]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/matrix.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | let f = me[0][1] * other[2][0] + me[1][1] * other[2][1] + me[2][1]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/animations/mod.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | factor: factor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `factor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/animations/mod.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/animations/mod.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/animations/mod.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layout.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layout.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layout.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | cursor: cursor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layout.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | cursor_was_pressed: cursor_was_pressed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cursor_was_pressed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layout.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | cursor_was_released: cursor_was_released, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cursor_was_released` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layout.rs:475:13 [INFO] [stderr] | [INFO] [stderr] 475 | weights: weights, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `weights` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layout.rs:476:13 [INFO] [stderr] | [INFO] [stderr] 476 | total_weight_inverse: total_weight_inverse, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_weight_inverse` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layout.rs:478:13 [INFO] [stderr] | [INFO] [stderr] 478 | vertical: vertical, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertical` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/matrix.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | let e = me[0][1] * other[1][0] + me[1][1] * other[1][1]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/matrix.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | let f = me[0][1] * other[2][0] + me[1][1] * other[2][1] + me[2][1]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/animations/mod.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | factor: factor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `factor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/animations/mod.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/animations/mod.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/animations/mod.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/animations/mod.rs:36:46 [INFO] [stderr] | [INFO] [stderr] 36 | let val = dur.as_secs() as f64 * 1000000.0 + dur.subsec_nanos() as f64 / 1000.0; [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/animations/mod.rs:40:55 [INFO] [stderr] | [INFO] [stderr] 40 | let duration_ms = duration.as_secs() as f64 * 1000000.0 + [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/widgets/circular_progress_bar.rs:68:57 [INFO] [stderr] | [INFO] [stderr] 68 | let local_matrix = Matrix::rotate(num as f32 * -3.141592 * 0.5) * local_matrix; [INFO] [stderr] | ^^^^^^^^ help: consider: `3.141_592` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/widgets/circular_progress_bar.rs:89:44 [INFO] [stderr] | [INFO] [stderr] 89 | let local_matrix = Matrix::skew_x(-3.141592 / 4.0) * local_matrix; [INFO] [stderr] | ^^^^^^^^ help: consider: `3.141_592` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/widgets/circular_progress_bar.rs:90:63 [INFO] [stderr] | [INFO] [stderr] 90 | let local_matrix = Matrix::rotate((num + 1) as f32 * -3.141592 * 0.5) * local_matrix; [INFO] [stderr] | ^^^^^^^^ help: consider: `3.141_592` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/widgets/image.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / if !draw.cursor_hovered_widget() { [INFO] [stderr] 29 | | if draw.is_cursor_hovering() { [INFO] [stderr] 30 | | draw.set_cursor_hovered_widget(); [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 28 | if !draw.cursor_hovered_widget() && draw.is_cursor_hovering() { [INFO] [stderr] 29 | draw.set_cursor_hovered_widget(); [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/widgets/image9.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | / if !draw.cursor_hovered_widget() { [INFO] [stderr] 112 | | if draw.is_cursor_hovering() { [INFO] [stderr] 113 | | draw.set_cursor_hovered_widget(); [INFO] [stderr] 114 | | } [INFO] [stderr] 115 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 111 | if !draw.cursor_hovered_widget() && draw.is_cursor_hovering() { [INFO] [stderr] 112 | draw.set_cursor_hovered_widget(); [INFO] [stderr] 113 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/widgets/label.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / if !draw.cursor_hovered_widget() { [INFO] [stderr] 35 | | if draw.is_cursor_hovering() { [INFO] [stderr] 36 | | draw.set_cursor_hovered_widget(); [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 34 | if !draw.cursor_hovered_widget() && draw.is_cursor_hovering() { [INFO] [stderr] 35 | draw.set_cursor_hovered_widget(); [INFO] [stderr] 36 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/widgets/label.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / if !draw.cursor_hovered_widget() { [INFO] [stderr] 54 | | if draw.is_cursor_hovering() { [INFO] [stderr] 55 | | draw.set_cursor_hovered_widget(); [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 53 | if !draw.cursor_hovered_widget() && draw.is_cursor_hovering() { [INFO] [stderr] 54 | draw.set_cursor_hovered_widget(); [INFO] [stderr] 55 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/widgets/label.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / if !draw.cursor_hovered_widget() { [INFO] [stderr] 73 | | if draw.is_cursor_hovering() { [INFO] [stderr] 74 | | draw.set_cursor_hovered_widget(); [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 72 | if !draw.cursor_hovered_widget() && draw.is_cursor_hovering() { [INFO] [stderr] 73 | draw.set_cursor_hovered_widget(); [INFO] [stderr] 74 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/animations/mod.rs:36:46 [INFO] [stderr] | [INFO] [stderr] 36 | let val = dur.as_secs() as f64 * 1000000.0 + dur.subsec_nanos() as f64 / 1000.0; [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/animations/mod.rs:40:55 [INFO] [stderr] | [INFO] [stderr] 40 | let duration_ms = duration.as_secs() as f64 * 1000000.0 + [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/widgets/circular_progress_bar.rs:68:57 [INFO] [stderr] | [INFO] [stderr] 68 | let local_matrix = Matrix::rotate(num as f32 * -3.141592 * 0.5) * local_matrix; [INFO] [stderr] | ^^^^^^^^ help: consider: `3.141_592` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/widgets/circular_progress_bar.rs:89:44 [INFO] [stderr] | [INFO] [stderr] 89 | let local_matrix = Matrix::skew_x(-3.141592 / 4.0) * local_matrix; [INFO] [stderr] | ^^^^^^^^ help: consider: `3.141_592` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/widgets/circular_progress_bar.rs:90:63 [INFO] [stderr] | [INFO] [stderr] 90 | let local_matrix = Matrix::rotate((num + 1) as f32 * -3.141592 * 0.5) * local_matrix; [INFO] [stderr] | ^^^^^^^^ help: consider: `3.141_592` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/widgets/image.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / if !draw.cursor_hovered_widget() { [INFO] [stderr] 29 | | if draw.is_cursor_hovering() { [INFO] [stderr] 30 | | draw.set_cursor_hovered_widget(); [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 28 | if !draw.cursor_hovered_widget() && draw.is_cursor_hovering() { [INFO] [stderr] 29 | draw.set_cursor_hovered_widget(); [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/widgets/image9.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | / if !draw.cursor_hovered_widget() { [INFO] [stderr] 112 | | if draw.is_cursor_hovering() { [INFO] [stderr] 113 | | draw.set_cursor_hovered_widget(); [INFO] [stderr] 114 | | } [INFO] [stderr] 115 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 111 | if !draw.cursor_hovered_widget() && draw.is_cursor_hovering() { [INFO] [stderr] 112 | draw.set_cursor_hovered_widget(); [INFO] [stderr] 113 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/widgets/label.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / if !draw.cursor_hovered_widget() { [INFO] [stderr] 35 | | if draw.is_cursor_hovering() { [INFO] [stderr] 36 | | draw.set_cursor_hovered_widget(); [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 34 | if !draw.cursor_hovered_widget() && draw.is_cursor_hovering() { [INFO] [stderr] 35 | draw.set_cursor_hovered_widget(); [INFO] [stderr] 36 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/widgets/label.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / if !draw.cursor_hovered_widget() { [INFO] [stderr] 54 | | if draw.is_cursor_hovering() { [INFO] [stderr] 55 | | draw.set_cursor_hovered_widget(); [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 53 | if !draw.cursor_hovered_widget() && draw.is_cursor_hovering() { [INFO] [stderr] 54 | draw.set_cursor_hovered_widget(); [INFO] [stderr] 55 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/widgets/label.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / if !draw.cursor_hovered_widget() { [INFO] [stderr] 73 | | if draw.is_cursor_hovering() { [INFO] [stderr] 74 | | draw.set_cursor_hovered_widget(); [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 72 | if !draw.cursor_hovered_widget() && draw.is_cursor_hovering() { [INFO] [stderr] 73 | draw.set_cursor_hovered_widget(); [INFO] [stderr] 74 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/layout.rs:196:41 [INFO] [stderr] | [INFO] [stderr] 196 | fn test(matrix: &Matrix, point: &[f32; 2]) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[f32; 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/layout.rs:281:63 [INFO] [stderr] | [INFO] [stderr] 281 | if output_mouse[0] < -1.0 || output_mouse[0] > 1.0 || output_mouse[0] != output_mouse[0] || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/layout.rs:281:63 [INFO] [stderr] | [INFO] [stderr] 281 | if output_mouse[0] < -1.0 || output_mouse[0] > 1.0 || output_mouse[0] != output_mouse[0] || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(output_mouse[0] - output_mouse[0]).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/layout.rs:281:63 [INFO] [stderr] | [INFO] [stderr] 281 | if output_mouse[0] < -1.0 || output_mouse[0] > 1.0 || output_mouse[0] != output_mouse[0] || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/layout.rs:282:63 [INFO] [stderr] | [INFO] [stderr] 282 | output_mouse[1] < -1.0 || output_mouse[1] > 1.0 || output_mouse[1] != output_mouse[1] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/layout.rs:282:63 [INFO] [stderr] | [INFO] [stderr] 282 | output_mouse[1] < -1.0 || output_mouse[1] > 1.0 || output_mouse[1] != output_mouse[1] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(output_mouse[1] - output_mouse[1]).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/layout.rs:282:63 [INFO] [stderr] | [INFO] [stderr] 282 | output_mouse[1] < -1.0 || output_mouse[1] > 1.0 || output_mouse[1] != output_mouse[1] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/layout.rs:340:84 [INFO] [stderr] | [INFO] [stderr] 340 | pub fn enforce_aspect_ratio_downscale(&self, width_per_height: f32, alignment: &Alignment) [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Alignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/layout.rs:360:82 [INFO] [stderr] | [INFO] [stderr] 360 | pub fn enforce_aspect_ratio_upscale(&self, width_per_height: f32, alignment: &Alignment) [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Alignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/layout.rs:381:59 [INFO] [stderr] | [INFO] [stderr] 381 | pub fn vertical_rescale(&self, scale: f32, alignment: &VerticalAlignment) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `VerticalAlignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/layout.rs:384:17 [INFO] [stderr] | [INFO] [stderr] 384 | let y = match alignment { [INFO] [stderr] | _________________^ [INFO] [stderr] 385 | | &VerticalAlignment::Center => 0.0, [INFO] [stderr] 386 | | &VerticalAlignment::Bottom => scale - 1.0, [INFO] [stderr] 387 | | &VerticalAlignment::Top => 1.0 - scale, [INFO] [stderr] 388 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 384 | let y = match *alignment { [INFO] [stderr] 385 | VerticalAlignment::Center => 0.0, [INFO] [stderr] 386 | VerticalAlignment::Bottom => scale - 1.0, [INFO] [stderr] 387 | VerticalAlignment::Top => 1.0 - scale, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/layout.rs:409:61 [INFO] [stderr] | [INFO] [stderr] 409 | pub fn horizontal_rescale(&self, scale: f32, alignment: &HorizontalAlignment) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `HorizontalAlignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/layout.rs:412:17 [INFO] [stderr] | [INFO] [stderr] 412 | let x = match alignment { [INFO] [stderr] | _________________^ [INFO] [stderr] 413 | | &HorizontalAlignment::Center => 0.0, [INFO] [stderr] 414 | | &HorizontalAlignment::Left => scale - 1.0, [INFO] [stderr] 415 | | &HorizontalAlignment::Right => 1.0 - scale, [INFO] [stderr] 416 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 412 | let x = match *alignment { [INFO] [stderr] 413 | HorizontalAlignment::Center => 0.0, [INFO] [stderr] 414 | HorizontalAlignment::Left => scale - 1.0, [INFO] [stderr] 415 | HorizontalAlignment::Right => 1.0 - scale, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/layout.rs:489:79 [INFO] [stderr] | [INFO] [stderr] 489 | pub fn rescale(&self, width_percent: f32, height_percent: f32, alignment: &Alignment) [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Alignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/layout.rs:571:21 [INFO] [stderr] | [INFO] [stderr] 571 | matrix: self.matrix.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.matrix` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/layout.rs:572:20 [INFO] [stderr] | [INFO] [stderr] 572 | width: self.width.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/layout.rs:573:21 [INFO] [stderr] | [INFO] [stderr] 573 | height: self.height.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/layout.rs:574:24 [INFO] [stderr] | [INFO] [stderr] 574 | animation: self.animation.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.animation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/layout.rs:577:21 [INFO] [stderr] | [INFO] [stderr] 577 | cursor: self.cursor.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/matrix.rs:87:26 [INFO] [stderr] | [INFO] [stderr] 87 | if det == 0.0 || det != det { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/matrix.rs:87:26 [INFO] [stderr] | [INFO] [stderr] 87 | if det == 0.0 || det != det { [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(det - det).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/matrix.rs:87:26 [INFO] [stderr] | [INFO] [stderr] 87 | if det == 0.0 || det != det { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/animations/mod.rs:36:58 [INFO] [stderr] | [INFO] [stderr] 36 | let val = dur.as_secs() as f64 * 1000000.0 + dur.subsec_nanos() as f64 / 1000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(dur.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/animations/mod.rs:41:27 [INFO] [stderr] | [INFO] [stderr] 41 | duration.subsec_nanos() as f64 / 1000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/widgets/circular_progress_bar.rs:35:82 [INFO] [stderr] | [INFO] [stderr] 35 | full: &D::ImageResource, progress: f32, alignment: &Alignment) [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Alignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/widgets/circular_progress_bar.rs:68:57 [INFO] [stderr] | [INFO] [stderr] 68 | let local_matrix = Matrix::rotate(num as f32 * -3.141592 * 0.5) * local_matrix; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/widgets/circular_progress_bar.rs:89:44 [INFO] [stderr] | [INFO] [stderr] 89 | let local_matrix = Matrix::skew_x(-3.141592 / 4.0) * local_matrix; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/widgets/circular_progress_bar.rs:90:63 [INFO] [stderr] | [INFO] [stderr] 90 | let local_matrix = Matrix::rotate((num + 1) as f32 * -3.141592 * 0.5) * local_matrix; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/widgets/image.rs:18:42 [INFO] [stderr] | [INFO] [stderr] 18 | alignment: &Alignment) [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Alignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/widgets/image.rs:39:42 [INFO] [stderr] | [INFO] [stderr] 39 | alignment: &Alignment) [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Alignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/widgets/image_button.rs:26:75 [INFO] [stderr] | [INFO] [stderr] 26 | active_image: &D::ImageResource, alignment: &Alignment) [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Alignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/widgets/image9_button.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn draw(draw: &DrawContext, ui_state: &mut UiState, [INFO] [stderr] 20 | | left_border_percent: f32, normal_image: &D::ImageResource, [INFO] [stderr] 21 | | hovered_image: &D::ImageResource, active_image: &D::ImageResource, [INFO] [stderr] 22 | | top_percent: f32, right_percent: f32, bottom_percent: f32, [INFO] [stderr] ... | [INFO] [stderr] 55 | | } [INFO] [stderr] 56 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/widgets/label.rs:27:42 [INFO] [stderr] | [INFO] [stderr] 27 | alignment: &HorizontalAlignment) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `HorizontalAlignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/widgets/label.rs:47:45 [INFO] [stderr] | [INFO] [stderr] 47 | alignment: &Alignment) [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Alignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/widgets/label.rs:66:43 [INFO] [stderr] | [INFO] [stderr] 66 | alignment: &Alignment) [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Alignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/widgets/progress_bar.rs:34:51 [INFO] [stderr] | [INFO] [stderr] 34 | progress_direction: &HorizontalAlignment, alignment: &Alignment) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `HorizontalAlignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/widgets/progress_bar.rs:34:84 [INFO] [stderr] | [INFO] [stderr] 34 | progress_direction: &HorizontalAlignment, alignment: &Alignment) [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Alignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/widgets/progress_bar.rs:49:54 [INFO] [stderr] | [INFO] [stderr] 49 | progress_direction: &HorizontalAlignment) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `HorizontalAlignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/widgets/mod.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match self { [INFO] [stderr] 36 | | &Interaction::Clicked => true, [INFO] [stderr] 37 | | _ => false, [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | match *self { [INFO] [stderr] 36 | Interaction::Clicked => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 9 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `immi`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/layout.rs:196:41 [INFO] [stderr] | [INFO] [stderr] 196 | fn test(matrix: &Matrix, point: &[f32; 2]) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[f32; 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/layout.rs:281:63 [INFO] [stderr] | [INFO] [stderr] 281 | if output_mouse[0] < -1.0 || output_mouse[0] > 1.0 || output_mouse[0] != output_mouse[0] || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/layout.rs:281:63 [INFO] [stderr] | [INFO] [stderr] 281 | if output_mouse[0] < -1.0 || output_mouse[0] > 1.0 || output_mouse[0] != output_mouse[0] || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(output_mouse[0] - output_mouse[0]).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/layout.rs:281:63 [INFO] [stderr] | [INFO] [stderr] 281 | if output_mouse[0] < -1.0 || output_mouse[0] > 1.0 || output_mouse[0] != output_mouse[0] || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/layout.rs:282:63 [INFO] [stderr] | [INFO] [stderr] 282 | output_mouse[1] < -1.0 || output_mouse[1] > 1.0 || output_mouse[1] != output_mouse[1] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/layout.rs:282:63 [INFO] [stderr] | [INFO] [stderr] 282 | output_mouse[1] < -1.0 || output_mouse[1] > 1.0 || output_mouse[1] != output_mouse[1] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(output_mouse[1] - output_mouse[1]).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/layout.rs:282:63 [INFO] [stderr] | [INFO] [stderr] 282 | output_mouse[1] < -1.0 || output_mouse[1] > 1.0 || output_mouse[1] != output_mouse[1] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/layout.rs:340:84 [INFO] [stderr] | [INFO] [stderr] 340 | pub fn enforce_aspect_ratio_downscale(&self, width_per_height: f32, alignment: &Alignment) [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Alignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/layout.rs:360:82 [INFO] [stderr] | [INFO] [stderr] 360 | pub fn enforce_aspect_ratio_upscale(&self, width_per_height: f32, alignment: &Alignment) [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Alignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/layout.rs:381:59 [INFO] [stderr] | [INFO] [stderr] 381 | pub fn vertical_rescale(&self, scale: f32, alignment: &VerticalAlignment) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `VerticalAlignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/layout.rs:384:17 [INFO] [stderr] | [INFO] [stderr] 384 | let y = match alignment { [INFO] [stderr] | _________________^ [INFO] [stderr] 385 | | &VerticalAlignment::Center => 0.0, [INFO] [stderr] 386 | | &VerticalAlignment::Bottom => scale - 1.0, [INFO] [stderr] 387 | | &VerticalAlignment::Top => 1.0 - scale, [INFO] [stderr] 388 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 384 | let y = match *alignment { [INFO] [stderr] 385 | VerticalAlignment::Center => 0.0, [INFO] [stderr] 386 | VerticalAlignment::Bottom => scale - 1.0, [INFO] [stderr] 387 | VerticalAlignment::Top => 1.0 - scale, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/layout.rs:409:61 [INFO] [stderr] | [INFO] [stderr] 409 | pub fn horizontal_rescale(&self, scale: f32, alignment: &HorizontalAlignment) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `HorizontalAlignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/layout.rs:412:17 [INFO] [stderr] | [INFO] [stderr] 412 | let x = match alignment { [INFO] [stderr] | _________________^ [INFO] [stderr] 413 | | &HorizontalAlignment::Center => 0.0, [INFO] [stderr] 414 | | &HorizontalAlignment::Left => scale - 1.0, [INFO] [stderr] 415 | | &HorizontalAlignment::Right => 1.0 - scale, [INFO] [stderr] 416 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 412 | let x = match *alignment { [INFO] [stderr] 413 | HorizontalAlignment::Center => 0.0, [INFO] [stderr] 414 | HorizontalAlignment::Left => scale - 1.0, [INFO] [stderr] 415 | HorizontalAlignment::Right => 1.0 - scale, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/layout.rs:489:79 [INFO] [stderr] | [INFO] [stderr] 489 | pub fn rescale(&self, width_percent: f32, height_percent: f32, alignment: &Alignment) [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Alignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/layout.rs:571:21 [INFO] [stderr] | [INFO] [stderr] 571 | matrix: self.matrix.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.matrix` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/layout.rs:572:20 [INFO] [stderr] | [INFO] [stderr] 572 | width: self.width.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/layout.rs:573:21 [INFO] [stderr] | [INFO] [stderr] 573 | height: self.height.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/layout.rs:574:24 [INFO] [stderr] | [INFO] [stderr] 574 | animation: self.animation.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.animation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/layout.rs:577:21 [INFO] [stderr] | [INFO] [stderr] 577 | cursor: self.cursor.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/matrix.rs:87:26 [INFO] [stderr] | [INFO] [stderr] 87 | if det == 0.0 || det != det { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/matrix.rs:87:26 [INFO] [stderr] | [INFO] [stderr] 87 | if det == 0.0 || det != det { [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(det - det).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/matrix.rs:87:26 [INFO] [stderr] | [INFO] [stderr] 87 | if det == 0.0 || det != det { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/animations/mod.rs:36:58 [INFO] [stderr] | [INFO] [stderr] 36 | let val = dur.as_secs() as f64 * 1000000.0 + dur.subsec_nanos() as f64 / 1000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(dur.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/animations/mod.rs:41:27 [INFO] [stderr] | [INFO] [stderr] 41 | duration.subsec_nanos() as f64 / 1000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/widgets/circular_progress_bar.rs:35:82 [INFO] [stderr] | [INFO] [stderr] 35 | full: &D::ImageResource, progress: f32, alignment: &Alignment) [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Alignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/widgets/circular_progress_bar.rs:68:57 [INFO] [stderr] | [INFO] [stderr] 68 | let local_matrix = Matrix::rotate(num as f32 * -3.141592 * 0.5) * local_matrix; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/widgets/circular_progress_bar.rs:89:44 [INFO] [stderr] | [INFO] [stderr] 89 | let local_matrix = Matrix::skew_x(-3.141592 / 4.0) * local_matrix; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/widgets/circular_progress_bar.rs:90:63 [INFO] [stderr] | [INFO] [stderr] 90 | let local_matrix = Matrix::rotate((num + 1) as f32 * -3.141592 * 0.5) * local_matrix; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/widgets/image.rs:18:42 [INFO] [stderr] | [INFO] [stderr] 18 | alignment: &Alignment) [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Alignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/widgets/image.rs:39:42 [INFO] [stderr] | [INFO] [stderr] 39 | alignment: &Alignment) [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Alignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/widgets/image_button.rs:26:75 [INFO] [stderr] | [INFO] [stderr] 26 | active_image: &D::ImageResource, alignment: &Alignment) [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Alignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/widgets/image9_button.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn draw(draw: &DrawContext, ui_state: &mut UiState, [INFO] [stderr] 20 | | left_border_percent: f32, normal_image: &D::ImageResource, [INFO] [stderr] 21 | | hovered_image: &D::ImageResource, active_image: &D::ImageResource, [INFO] [stderr] 22 | | top_percent: f32, right_percent: f32, bottom_percent: f32, [INFO] [stderr] ... | [INFO] [stderr] 55 | | } [INFO] [stderr] 56 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/widgets/label.rs:27:42 [INFO] [stderr] | [INFO] [stderr] 27 | alignment: &HorizontalAlignment) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `HorizontalAlignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/widgets/label.rs:47:45 [INFO] [stderr] | [INFO] [stderr] 47 | alignment: &Alignment) [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Alignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/widgets/label.rs:66:43 [INFO] [stderr] | [INFO] [stderr] 66 | alignment: &Alignment) [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Alignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/widgets/progress_bar.rs:34:51 [INFO] [stderr] | [INFO] [stderr] 34 | progress_direction: &HorizontalAlignment, alignment: &Alignment) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `HorizontalAlignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/widgets/progress_bar.rs:34:84 [INFO] [stderr] | [INFO] [stderr] 34 | progress_direction: &HorizontalAlignment, alignment: &Alignment) [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Alignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/widgets/progress_bar.rs:49:54 [INFO] [stderr] | [INFO] [stderr] 49 | progress_direction: &HorizontalAlignment) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `HorizontalAlignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/widgets/mod.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match self { [INFO] [stderr] 36 | | &Interaction::Clicked => true, [INFO] [stderr] 37 | | _ => false, [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | match *self { [INFO] [stderr] 36 | Interaction::Clicked => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 9 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `immi`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "28b0a534764f699bcaf8d37ac7fc500231d43a2e835fa2c884807be18960aeb1"` [INFO] running `"docker" "rm" "-f" "28b0a534764f699bcaf8d37ac7fc500231d43a2e835fa2c884807be18960aeb1"` [INFO] [stdout] 28b0a534764f699bcaf8d37ac7fc500231d43a2e835fa2c884807be18960aeb1