[INFO] crate immeta 0.4.0 is already in cache [INFO] extracting crate immeta 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/immeta/0.4.0 [INFO] extracting crate immeta 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/immeta/0.4.0 [INFO] validating manifest of immeta-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of immeta-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing immeta-0.4.0 [INFO] finished frobbing immeta-0.4.0 [INFO] frobbed toml for immeta-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/immeta/0.4.0/Cargo.toml [INFO] started frobbing immeta-0.4.0 [INFO] finished frobbing immeta-0.4.0 [INFO] frobbed toml for immeta-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/immeta/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting immeta-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/immeta/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6888969f2e94df853956b13fc35e0678f02f736a1507acf01b632a4c0b36169b [INFO] running `"docker" "start" "-a" "6888969f2e94df853956b13fc35e0678f02f736a1507acf01b632a4c0b36169b"` [INFO] [stderr] Checking immeta v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/riff.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | source: source [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/riff.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/tiff.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | source: source [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/tiff.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | byte_order: byte_order, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `byte_order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/tiff.rs:214:13 [INFO] [stderr] | [INFO] [stderr] 214 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/tiff.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/tiff.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/tiff.rs:327:25 [INFO] [stderr] | [INFO] [stderr] 327 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/jpeg.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | sample_precision: sample_precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sample_precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/jpeg.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | coding_process: coding_process, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coding_process` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/jpeg.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | entropy_coding: entropy_coding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entropy_coding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/jpeg.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | baseline: baseline, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `baseline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/jpeg.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | differential: differential, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `differential` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | top: top, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `top` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | interlace: interlace [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interlace` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | user_input: user_input, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `user_input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:227:13 [INFO] [stderr] | [INFO] [stderr] 227 | delay_time: delay_time [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `delay_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:339:13 [INFO] [stderr] | [INFO] [stderr] 339 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:340:13 [INFO] [stderr] | [INFO] [stderr] 340 | top: top, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `top` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:341:13 [INFO] [stderr] | [INFO] [stderr] 341 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:342:13 [INFO] [stderr] | [INFO] [stderr] 342 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:344:13 [INFO] [stderr] | [INFO] [stderr] 344 | cell_width: cell_width, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cell_width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:345:13 [INFO] [stderr] | [INFO] [stderr] 345 | cell_height: cell_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cell_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:347:13 [INFO] [stderr] | [INFO] [stderr] 347 | foreground_color_index: foreground_color_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `foreground_color_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:348:13 [INFO] [stderr] | [INFO] [stderr] 348 | background_color_index: background_color_index [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `background_color_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:403:13 [INFO] [stderr] | [INFO] [stderr] 403 | application_identifier: application_identifier, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `application_identifier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:404:13 [INFO] [stderr] | [INFO] [stderr] 404 | authentication_code: authentication_code [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `authentication_code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:566:13 [INFO] [stderr] | [INFO] [stderr] 566 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:581:13 [INFO] [stderr] | [INFO] [stderr] 581 | background_color_index: background_color_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `background_color_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:582:13 [INFO] [stderr] | [INFO] [stderr] 582 | pixel_aspect_ratio: pixel_aspect_ratio, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pixel_aspect_ratio` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:584:13 [INFO] [stderr] | [INFO] [stderr] 584 | blocks: blocks [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `blocks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/webp.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | x_scale: x_scale, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `x_scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/webp.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | y_scale: y_scale [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y_scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/riff.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | source: source [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/riff.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/tiff.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | source: source [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/tiff.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | byte_order: byte_order, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `byte_order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/tiff.rs:214:13 [INFO] [stderr] | [INFO] [stderr] 214 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/tiff.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/tiff.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/tiff.rs:327:25 [INFO] [stderr] | [INFO] [stderr] 327 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/jpeg.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | sample_precision: sample_precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sample_precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/jpeg.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | coding_process: coding_process, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coding_process` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/jpeg.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | entropy_coding: entropy_coding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entropy_coding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/jpeg.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | baseline: baseline, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `baseline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/jpeg.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | differential: differential, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `differential` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | top: top, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `top` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | interlace: interlace [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interlace` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | user_input: user_input, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `user_input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:227:13 [INFO] [stderr] | [INFO] [stderr] 227 | delay_time: delay_time [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `delay_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:339:13 [INFO] [stderr] | [INFO] [stderr] 339 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:340:13 [INFO] [stderr] | [INFO] [stderr] 340 | top: top, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `top` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:341:13 [INFO] [stderr] | [INFO] [stderr] 341 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:342:13 [INFO] [stderr] | [INFO] [stderr] 342 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:344:13 [INFO] [stderr] | [INFO] [stderr] 344 | cell_width: cell_width, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cell_width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:345:13 [INFO] [stderr] | [INFO] [stderr] 345 | cell_height: cell_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cell_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:347:13 [INFO] [stderr] | [INFO] [stderr] 347 | foreground_color_index: foreground_color_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `foreground_color_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:348:13 [INFO] [stderr] | [INFO] [stderr] 348 | background_color_index: background_color_index [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `background_color_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:403:13 [INFO] [stderr] | [INFO] [stderr] 403 | application_identifier: application_identifier, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `application_identifier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:404:13 [INFO] [stderr] | [INFO] [stderr] 404 | authentication_code: authentication_code [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `authentication_code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:566:13 [INFO] [stderr] | [INFO] [stderr] 566 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:581:13 [INFO] [stderr] | [INFO] [stderr] 581 | background_color_index: background_color_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `background_color_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:582:13 [INFO] [stderr] | [INFO] [stderr] 582 | pixel_aspect_ratio: pixel_aspect_ratio, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pixel_aspect_ratio` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/gif.rs:584:13 [INFO] [stderr] | [INFO] [stderr] 584 | blocks: blocks [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `blocks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/webp.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | x_scale: x_scale, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `x_scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formats/webp.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | y_scale: y_scale [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y_scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formats/gif.rs:112:41 [INFO] [stderr] | [INFO] [stderr] 112 | let local_color_table = (0b10000000 & packed_flags) > 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formats/gif.rs:113:41 [INFO] [stderr] | [INFO] [stderr] 113 | let interlace = (0b01000000 & packed_flags) > 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formats/gif.rs:114:41 [INFO] [stderr] | [INFO] [stderr] 114 | let local_color_table_sorted = (0b00100000 & packed_flags) > 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formats/gif.rs:115:41 [INFO] [stderr] | [INFO] [stderr] 115 | let local_color_table_size_p = (0b00000111 & packed_flags) >> 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/formats/gif.rs:191:22 [INFO] [stderr] | [INFO] [stderr] 191 | const NAME: &'static str = "graphics control extension block"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formats/gif.rs:199:34 [INFO] [stderr] | [INFO] [stderr] 199 | let disposal_method = (0b00011100 & packed_flags) >> 2; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formats/gif.rs:200:34 [INFO] [stderr] | [INFO] [stderr] 200 | let user_input = (0b00000010 & packed_flags) > 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formats/gif.rs:201:34 [INFO] [stderr] | [INFO] [stderr] 201 | let transparent_color = (0b00000001 & packed_flags) > 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/formats/gif.rs:294:22 [INFO] [stderr] | [INFO] [stderr] 294 | const NAME: &'static str = "plain text extension block"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/formats/gif.rs:385:22 [INFO] [stderr] | [INFO] [stderr] 385 | const NAME: &'static str = "application extension block"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/formats/gif.rs:418:22 [INFO] [stderr] | [INFO] [stderr] 418 | const NAME: &'static str = "comments extension block"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formats/gif.rs:522:57 [INFO] [stderr] | [INFO] [stderr] 522 | let global_color_table = (packed_flags & 0b10000000) > 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formats/gif.rs:523:57 [INFO] [stderr] | [INFO] [stderr] 523 | let color_resolution = (packed_flags & 0b01110000) >> 4; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formats/gif.rs:524:57 [INFO] [stderr] | [INFO] [stderr] 524 | let global_color_table_sorted = (packed_flags & 0b00001000) > 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formats/gif.rs:525:57 [INFO] [stderr] | [INFO] [stderr] 525 | let global_color_table_size_p = (packed_flags & 0b00000111) >> 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/common/tiff.rs:788:28 [INFO] [stderr] | [INFO] [stderr] 788 | 123u32, 12u32, 5492957u32, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `5_492_957u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/common/tiff.rs:865:43 [INFO] [stderr] | [INFO] [stderr] 865 | vec![123, 12, 5492957] [INFO] [stderr] | ^^^^^^^ help: consider: `5_492_957` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/common/tiff.rs:869:38 [INFO] [stderr] | [INFO] [stderr] 869 | 123, 12, 5492957 [INFO] [stderr] | ^^^^^^^ help: consider: `5_492_957` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formats/gif.rs:112:41 [INFO] [stderr] | [INFO] [stderr] 112 | let local_color_table = (0b10000000 & packed_flags) > 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formats/gif.rs:113:41 [INFO] [stderr] | [INFO] [stderr] 113 | let interlace = (0b01000000 & packed_flags) > 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formats/gif.rs:114:41 [INFO] [stderr] | [INFO] [stderr] 114 | let local_color_table_sorted = (0b00100000 & packed_flags) > 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formats/gif.rs:115:41 [INFO] [stderr] | [INFO] [stderr] 115 | let local_color_table_size_p = (0b00000111 & packed_flags) >> 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/formats/gif.rs:191:22 [INFO] [stderr] | [INFO] [stderr] 191 | const NAME: &'static str = "graphics control extension block"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formats/gif.rs:199:34 [INFO] [stderr] | [INFO] [stderr] 199 | let disposal_method = (0b00011100 & packed_flags) >> 2; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formats/gif.rs:200:34 [INFO] [stderr] | [INFO] [stderr] 200 | let user_input = (0b00000010 & packed_flags) > 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formats/gif.rs:201:34 [INFO] [stderr] | [INFO] [stderr] 201 | let transparent_color = (0b00000001 & packed_flags) > 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/formats/gif.rs:294:22 [INFO] [stderr] | [INFO] [stderr] 294 | const NAME: &'static str = "plain text extension block"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/formats/gif.rs:385:22 [INFO] [stderr] | [INFO] [stderr] 385 | const NAME: &'static str = "application extension block"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/formats/gif.rs:418:22 [INFO] [stderr] | [INFO] [stderr] 418 | const NAME: &'static str = "comments extension block"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formats/gif.rs:522:57 [INFO] [stderr] | [INFO] [stderr] 522 | let global_color_table = (packed_flags & 0b10000000) > 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formats/gif.rs:523:57 [INFO] [stderr] | [INFO] [stderr] 523 | let color_resolution = (packed_flags & 0b01110000) >> 4; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formats/gif.rs:524:57 [INFO] [stderr] | [INFO] [stderr] 524 | let global_color_table_sorted = (packed_flags & 0b00001000) > 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/formats/gif.rs:525:57 [INFO] [stderr] | [INFO] [stderr] 525 | let global_color_table_size_p = (packed_flags & 0b00000111) >> 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `TiffReader` [INFO] [stderr] --> src/common/tiff.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | pub struct TiffReader { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/common/tiff.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(source: R) -> TiffReader { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `ifds` [INFO] [stderr] --> src/common/tiff.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn ifds(mut self) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `len` [INFO] [stderr] --> src/common/tiff.rs:173:5 [INFO] [stderr] | [INFO] [stderr] 173 | fn len(&self) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Byte` [INFO] [stderr] --> src/common/tiff.rs:442:17 [INFO] [stderr] | [INFO] [stderr] 442 | pub enum $tpe {} [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 480 | / gen_entry_types! { [INFO] [stderr] 481 | | Byte, u8, [INFO] [stderr] 482 | | |source, _| byteorder::ReadBytesExt::read_u8(source).map(|v| (1, v)), [INFO] [stderr] 483 | | |source, _, n, count| if n >= count || n >= 4 { None } else { Some(source[n]) }; [INFO] [stderr] ... | [INFO] [stderr] 558 | | |_, _, _, _| None [INFO] [stderr] 559 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Ascii` [INFO] [stderr] --> src/common/tiff.rs:442:17 [INFO] [stderr] | [INFO] [stderr] 442 | pub enum $tpe {} [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 480 | / gen_entry_types! { [INFO] [stderr] 481 | | Byte, u8, [INFO] [stderr] 482 | | |source, _| byteorder::ReadBytesExt::read_u8(source).map(|v| (1, v)), [INFO] [stderr] 483 | | |source, _, n, count| if n >= count || n >= 4 { None } else { Some(source[n]) }; [INFO] [stderr] ... | [INFO] [stderr] 558 | | |_, _, _, _| None [INFO] [stderr] 559 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Short` [INFO] [stderr] --> src/common/tiff.rs:442:17 [INFO] [stderr] | [INFO] [stderr] 442 | pub enum $tpe {} [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 480 | / gen_entry_types! { [INFO] [stderr] 481 | | Byte, u8, [INFO] [stderr] 482 | | |source, _| byteorder::ReadBytesExt::read_u8(source).map(|v| (1, v)), [INFO] [stderr] 483 | | |source, _, n, count| if n >= count || n >= 4 { None } else { Some(source[n]) }; [INFO] [stderr] ... | [INFO] [stderr] 558 | | |_, _, _, _| None [INFO] [stderr] 559 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Long` [INFO] [stderr] --> src/common/tiff.rs:442:17 [INFO] [stderr] | [INFO] [stderr] 442 | pub enum $tpe {} [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 480 | / gen_entry_types! { [INFO] [stderr] 481 | | Byte, u8, [INFO] [stderr] 482 | | |source, _| byteorder::ReadBytesExt::read_u8(source).map(|v| (1, v)), [INFO] [stderr] 483 | | |source, _, n, count| if n >= count || n >= 4 { None } else { Some(source[n]) }; [INFO] [stderr] ... | [INFO] [stderr] 558 | | |_, _, _, _| None [INFO] [stderr] 559 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Rational` [INFO] [stderr] --> src/common/tiff.rs:442:17 [INFO] [stderr] | [INFO] [stderr] 442 | pub enum $tpe {} [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 480 | / gen_entry_types! { [INFO] [stderr] 481 | | Byte, u8, [INFO] [stderr] 482 | | |source, _| byteorder::ReadBytesExt::read_u8(source).map(|v| (1, v)), [INFO] [stderr] 483 | | |source, _, n, count| if n >= count || n >= 4 { None } else { Some(source[n]) }; [INFO] [stderr] ... | [INFO] [stderr] 558 | | |_, _, _, _| None [INFO] [stderr] 559 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `SignedByte` [INFO] [stderr] --> src/common/tiff.rs:442:17 [INFO] [stderr] | [INFO] [stderr] 442 | pub enum $tpe {} [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 480 | / gen_entry_types! { [INFO] [stderr] 481 | | Byte, u8, [INFO] [stderr] 482 | | |source, _| byteorder::ReadBytesExt::read_u8(source).map(|v| (1, v)), [INFO] [stderr] 483 | | |source, _, n, count| if n >= count || n >= 4 { None } else { Some(source[n]) }; [INFO] [stderr] ... | [INFO] [stderr] 558 | | |_, _, _, _| None [INFO] [stderr] 559 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Undefined` [INFO] [stderr] --> src/common/tiff.rs:442:17 [INFO] [stderr] | [INFO] [stderr] 442 | pub enum $tpe {} [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 480 | / gen_entry_types! { [INFO] [stderr] 481 | | Byte, u8, [INFO] [stderr] 482 | | |source, _| byteorder::ReadBytesExt::read_u8(source).map(|v| (1, v)), [INFO] [stderr] 483 | | |source, _, n, count| if n >= count || n >= 4 { None } else { Some(source[n]) }; [INFO] [stderr] ... | [INFO] [stderr] 558 | | |_, _, _, _| None [INFO] [stderr] 559 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `SignedShort` [INFO] [stderr] --> src/common/tiff.rs:442:17 [INFO] [stderr] | [INFO] [stderr] 442 | pub enum $tpe {} [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 480 | / gen_entry_types! { [INFO] [stderr] 481 | | Byte, u8, [INFO] [stderr] 482 | | |source, _| byteorder::ReadBytesExt::read_u8(source).map(|v| (1, v)), [INFO] [stderr] 483 | | |source, _, n, count| if n >= count || n >= 4 { None } else { Some(source[n]) }; [INFO] [stderr] ... | [INFO] [stderr] 558 | | |_, _, _, _| None [INFO] [stderr] 559 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `SignedLong` [INFO] [stderr] --> src/common/tiff.rs:442:17 [INFO] [stderr] | [INFO] [stderr] 442 | pub enum $tpe {} [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 480 | / gen_entry_types! { [INFO] [stderr] 481 | | Byte, u8, [INFO] [stderr] 482 | | |source, _| byteorder::ReadBytesExt::read_u8(source).map(|v| (1, v)), [INFO] [stderr] 483 | | |source, _, n, count| if n >= count || n >= 4 { None } else { Some(source[n]) }; [INFO] [stderr] ... | [INFO] [stderr] 558 | | |_, _, _, _| None [INFO] [stderr] 559 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `SignedRational` [INFO] [stderr] --> src/common/tiff.rs:442:17 [INFO] [stderr] | [INFO] [stderr] 442 | pub enum $tpe {} [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 480 | / gen_entry_types! { [INFO] [stderr] 481 | | Byte, u8, [INFO] [stderr] 482 | | |source, _| byteorder::ReadBytesExt::read_u8(source).map(|v| (1, v)), [INFO] [stderr] 483 | | |source, _, n, count| if n >= count || n >= 4 { None } else { Some(source[n]) }; [INFO] [stderr] ... | [INFO] [stderr] 558 | | |_, _, _, _| None [INFO] [stderr] 559 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Float` [INFO] [stderr] --> src/common/tiff.rs:442:17 [INFO] [stderr] | [INFO] [stderr] 442 | pub enum $tpe {} [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 480 | / gen_entry_types! { [INFO] [stderr] 481 | | Byte, u8, [INFO] [stderr] 482 | | |source, _| byteorder::ReadBytesExt::read_u8(source).map(|v| (1, v)), [INFO] [stderr] 483 | | |source, _, n, count| if n >= count || n >= 4 { None } else { Some(source[n]) }; [INFO] [stderr] ... | [INFO] [stderr] 558 | | |_, _, _, _| None [INFO] [stderr] 559 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Double` [INFO] [stderr] --> src/common/tiff.rs:442:17 [INFO] [stderr] | [INFO] [stderr] 442 | pub enum $tpe {} [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 480 | / gen_entry_types! { [INFO] [stderr] 481 | | Byte, u8, [INFO] [stderr] 482 | | |source, _| byteorder::ReadBytesExt::read_u8(source).map(|v| (1, v)), [INFO] [stderr] 483 | | |source, _, n, count| if n >= count || n >= 4 { None } else { Some(source[n]) }; [INFO] [stderr] ... | [INFO] [stderr] 558 | | |_, _, _, _| None [INFO] [stderr] 559 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/common/riff.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn as_str(&self) -> Option<&str> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/common/riff.rs:60:64 [INFO] [stderr] | [INFO] [stderr] 60 | delegate: (&mut self.source as &mut Read).take(len as u64), [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `common::riff::RiffChunk<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/common/riff.rs:93:1 [INFO] [stderr] | [INFO] [stderr] 93 | / impl<'a> RiffChunk<'a> { [INFO] [stderr] 94 | | #[inline] [INFO] [stderr] 95 | | pub fn chunk_id(&self) -> ChunkId { self.chunk_id } [INFO] [stderr] 96 | | [INFO] [stderr] ... | [INFO] [stderr] 138 | | } [INFO] [stderr] 139 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `common::riff::RiffListChunk<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/common/riff.rs:150:1 [INFO] [stderr] | [INFO] [stderr] 150 | / impl<'a> RiffListChunk<'a> { [INFO] [stderr] 151 | | #[inline] [INFO] [stderr] 152 | | pub fn chunk_id(&self) -> ChunkId { self.chunk_id } [INFO] [stderr] 153 | | [INFO] [stderr] ... | [INFO] [stderr] 189 | | } [INFO] [stderr] 190 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/common/riff.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | / pub fn next(&mut self) -> Option> { [INFO] [stderr] 162 | | if self.cur_chunk_read < self.cur_chunk_len { [INFO] [stderr] 163 | | let to_skip = (self.cur_chunk_len - self.cur_chunk_read) as u64; [INFO] [stderr] 164 | | match self.data.skip_exact_0(to_skip) { [INFO] [stderr] ... | [INFO] [stderr] 188 | | })) [INFO] [stderr] 189 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/common/riff.rs:163:27 [INFO] [stderr] | [INFO] [stderr] 163 | let to_skip = (self.cur_chunk_len - self.cur_chunk_read) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.cur_chunk_len - self.cur_chunk_read)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/common/riff.rs:174:39 [INFO] [stderr] | [INFO] [stderr] 174 | Err(e) => return Some(Err(e.into())) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/common/riff.rs:185:62 [INFO] [stderr] | [INFO] [stderr] 185 | delegate: (&mut self.data as &mut Read).take(len as u64), [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/common/tiff.rs:67:40 [INFO] [stderr] | [INFO] [stderr] 67 | next_ifd_offset: Cell::new(next_ifd_offset as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(next_ifd_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/common/tiff.rs:129:63 [INFO] [stderr] | [INFO] [stderr] 129 | let next_ifd_offset_offset = current_ifd_offset + 2 + current_ifd_size as u64 * 12; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(current_ifd_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/common/tiff.rs:136:36 [INFO] [stderr] | [INFO] [stderr] 136 | self.0.next_ifd_offset.set(try_if_eof!( [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 137 | | self.0.source.borrow_mut().read_u32(self.0.byte_order), "when reading the next IFD offset" [INFO] [stderr] 138 | | ) as u64); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 136 | self.0.next_ifd_offset.set(u64::from(match $ expr { [INFO] [stderr] 137 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 138 | :: Err ( err ) => { [INFO] [stderr] 139 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 140 | $ crate :: convert :: From :: from ( err ) ) } })); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/common/tiff.rs:181:64 [INFO] [stderr] | [INFO] [stderr] 181 | try!(source.seek(SeekFrom::Start(self.ifd_offset + 2 + self.current_entry as u64 * 12))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.current_entry)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/common/tiff.rs:321:20 [INFO] [stderr] | [INFO] [stderr] 321 | if entry_type_size as u32 * self.count <= 4 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(entry_type_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/common/tiff.rs:364:20 [INFO] [stderr] | [INFO] [stderr] 364 | if entry_type_size as u32 * self.count <= 4 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(entry_type_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/common/tiff.rs:368:78 [INFO] [stderr] | [INFO] [stderr] 368 | match self.ifds.source.borrow_mut().seek(SeekFrom::Start(self.offset as u64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/common/tiff.rs:462:45 [INFO] [stderr] | [INFO] [stderr] 462 | let max_bytes = n * item_size as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(item_size)` [INFO] [stderr] ... [INFO] [stderr] 480 | / gen_entry_types! { [INFO] [stderr] 481 | | Byte, u8, [INFO] [stderr] 482 | | |source, _| byteorder::ReadBytesExt::read_u8(source).map(|v| (1, v)), [INFO] [stderr] 483 | | |source, _, n, count| if n >= count || n >= 4 { None } else { Some(source[n]) }; [INFO] [stderr] ... | [INFO] [stderr] 558 | | |_, _, _, _| None [INFO] [stderr] 559 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/common/tiff.rs:622:44 [INFO] [stderr] | [INFO] [stderr] 622 | if self.bytes_read >= self.count * T::entry_type().size().unwrap() as u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(T::entry_type().size().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/common/tiff.rs:626:65 [INFO] [stderr] | [INFO] [stderr] 626 | try!(self.ifds.source.borrow_mut().seek(SeekFrom::Start(self.next_offset as u64))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.next_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/formats/png.rs:212:22 [INFO] [stderr] | [INFO] [stderr] 212 | .ok_or(invalid_format!("invalid color type: {}", color_type)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| invalid_format!("invalid color type: {}", color_type))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/formats/png.rs:216:22 [INFO] [stderr] | [INFO] [stderr] 216 | .ok_or(invalid_format!("invalid bit depth: {}", bit_depth)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| invalid_format!("invalid bit depth: {}", bit_depth))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/formats/png.rs:220:22 [INFO] [stderr] | [INFO] [stderr] 220 | .ok_or(invalid_format!("invalid compression method: {}", compression_method)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| invalid_format!("invalid compression method: {}", compression_method))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/formats/png.rs:224:22 [INFO] [stderr] | [INFO] [stderr] 224 | .ok_or(invalid_format!("invalid filter method: {}", filter_method)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| invalid_format!("invalid filter method: {}", filter_method))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/formats/png.rs:228:22 [INFO] [stderr] | [INFO] [stderr] 228 | .ok_or(invalid_format!("invalid interlace method: {}", interlace_method)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| invalid_format!("invalid interlace method: {}", interlace_method))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/formats/gif.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | let n = try_if_eof!(r.read_u8(), on_eof()) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 50 | let n = u64::from(match $ expr { [INFO] [stderr] 51 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 52 | :: Err ( err ) => { [INFO] [stderr] 53 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 54 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(0b00000111 & packed_flags)` [INFO] [stderr] --> src/formats/gif.rs:115:40 [INFO] [stderr] | [INFO] [stderr] 115 | let local_color_table_size_p = (0b00000111 & packed_flags) >> 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/formats/gif.rs:124:29 [INFO] [stderr] | [INFO] [stderr] 124 | let skip_size = local_color_table_size as u64 * 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(local_color_table_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/formats/gif.rs:187:9 [INFO] [stderr] | [INFO] [stderr] 187 | self.delay_time as u32 * 10 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.delay_time)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/formats/gif.rs:218:22 [INFO] [stderr] | [INFO] [stderr] 218 | .ok_or(invalid_format!("invalid disposal method in {} {}: {}", [INFO] [stderr] | ______________________^ [INFO] [stderr] 219 | | NAME, index, disposal_method)) [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 218 | .ok_or_else(|| invalid_format!("invalid disposal method in {} {}: {}", [INFO] [stderr] 219 | NAME, index, disposal_method)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/formats/gif.rs:485:19 [INFO] [stderr] | [INFO] [stderr] 485 | Some((self.pixel_aspect_ratio as f64 + 15.0)/64.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.pixel_aspect_ratio)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/formats/gif.rs:515:14 [INFO] [stderr] | [INFO] [stderr] 515 | .ok_or(invalid_format!("invalid GIF version: {:?}", &signature[3..]))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| invalid_format!("invalid GIF version: {:?}", &signature[3..]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(packed_flags & 0b00000111)` [INFO] [stderr] --> src/formats/gif.rs:525:41 [INFO] [stderr] | [INFO] [stderr] 525 | let global_color_table_size_p = (packed_flags & 0b00000111) >> 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/formats/gif.rs:536:29 [INFO] [stderr] | [INFO] [stderr] 536 | let skip_size = global_color_table_size as u64 * 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(global_color_table_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/formats/webp.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / loop { [INFO] [stderr] 59 | | let mut chunk = match root.next() { [INFO] [stderr] 60 | | Some(c) => try!(c), [INFO] [stderr] 61 | | None => return Err(unexpected_eof!("when reading first WEBP chunk")) [INFO] [stderr] ... | [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/formats/webp.rs:99:34 [INFO] [stderr] | [INFO] [stderr] 99 | result.first_partition_len = ((hdr[0] >> 5) as u32) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hdr[0] >> 5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/formats/webp.rs:100:35 [INFO] [stderr] | [INFO] [stderr] 100 | ((hdr[1] as u32) << 3) | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(hdr[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/formats/webp.rs:101:35 [INFO] [stderr] | [INFO] [stderr] 101 | ((hdr[2] as u32) << 11); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(hdr[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/formats/webp.rs:108:12 [INFO] [stderr] | [INFO] [stderr] 108 | if &hdr[..3] != &[0x9d, 0x01, 0x2a] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 108 | if hdr[..3] != [0x9d, 0x01, 0x2a] { [INFO] [stderr] | ^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/formats/webp.rs:120:22 [INFO] [stderr] | [INFO] [stderr] 120 | let width = ((hdr[4] & 0x3f) as u32) << 8 | hdr[3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hdr[4] & 0x3f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/formats/webp.rs:120:54 [INFO] [stderr] | [INFO] [stderr] 120 | let width = ((hdr[4] & 0x3f) as u32) << 8 | hdr[3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(hdr[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/formats/webp.rs:121:22 [INFO] [stderr] | [INFO] [stderr] 121 | let height = ((hdr[6] & 0x3f) as u32) << 8 | hdr[5] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hdr[6] & 0x3f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/formats/webp.rs:121:54 [INFO] [stderr] | [INFO] [stderr] 121 | let height = ((hdr[6] & 0x3f) as u32) << 8 | hdr[5] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(hdr[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `immeta`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/common/riff.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn as_str(&self) -> Option<&str> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/common/riff.rs:60:64 [INFO] [stderr] | [INFO] [stderr] 60 | delegate: (&mut self.source as &mut Read).take(len as u64), [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `common::riff::RiffChunk<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/common/riff.rs:93:1 [INFO] [stderr] | [INFO] [stderr] 93 | / impl<'a> RiffChunk<'a> { [INFO] [stderr] 94 | | #[inline] [INFO] [stderr] 95 | | pub fn chunk_id(&self) -> ChunkId { self.chunk_id } [INFO] [stderr] 96 | | [INFO] [stderr] ... | [INFO] [stderr] 138 | | } [INFO] [stderr] 139 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `common::riff::RiffListChunk<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/common/riff.rs:150:1 [INFO] [stderr] | [INFO] [stderr] 150 | / impl<'a> RiffListChunk<'a> { [INFO] [stderr] 151 | | #[inline] [INFO] [stderr] 152 | | pub fn chunk_id(&self) -> ChunkId { self.chunk_id } [INFO] [stderr] 153 | | [INFO] [stderr] ... | [INFO] [stderr] 189 | | } [INFO] [stderr] 190 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/common/riff.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | / pub fn next(&mut self) -> Option> { [INFO] [stderr] 162 | | if self.cur_chunk_read < self.cur_chunk_len { [INFO] [stderr] 163 | | let to_skip = (self.cur_chunk_len - self.cur_chunk_read) as u64; [INFO] [stderr] 164 | | match self.data.skip_exact_0(to_skip) { [INFO] [stderr] ... | [INFO] [stderr] 188 | | })) [INFO] [stderr] 189 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/common/riff.rs:163:27 [INFO] [stderr] | [INFO] [stderr] 163 | let to_skip = (self.cur_chunk_len - self.cur_chunk_read) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.cur_chunk_len - self.cur_chunk_read)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/common/riff.rs:174:39 [INFO] [stderr] | [INFO] [stderr] 174 | Err(e) => return Some(Err(e.into())) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/common/riff.rs:185:62 [INFO] [stderr] | [INFO] [stderr] 185 | delegate: (&mut self.data as &mut Read).take(len as u64), [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/common/riff.rs:219:15 [INFO] [stderr] | [INFO] [stderr] 219 | $(data.write($arg).unwrap();)+ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 253 | let data = build! { [INFO] [stderr] | ____________________- [INFO] [stderr] 254 | | b"RIFF", &n(37), b"abcd", [INFO] [stderr] 255 | | b"A ", &n(4), b"1234", [INFO] [stderr] 256 | | b"B ", &n(5), b"56789" [INFO] [stderr] 257 | | }; [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/common/riff.rs:219:15 [INFO] [stderr] | [INFO] [stderr] 219 | $(data.write($arg).unwrap();)+ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 253 | let data = build! { [INFO] [stderr] | ____________________- [INFO] [stderr] 254 | | b"RIFF", &n(37), b"abcd", [INFO] [stderr] 255 | | b"A ", &n(4), b"1234", [INFO] [stderr] 256 | | b"B ", &n(5), b"56789" [INFO] [stderr] 257 | | }; [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/common/riff.rs:219:15 [INFO] [stderr] | [INFO] [stderr] 219 | $(data.write($arg).unwrap();)+ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 276 | let data = build! { [INFO] [stderr] | ____________________- [INFO] [stderr] 277 | | b"RIFF", &n(77), b"abcd", [INFO] [stderr] 278 | | b"A ", &n(1), b"z", [INFO] [stderr] 279 | | b"LIST", &n(56), b"wxyz", [INFO] [stderr] ... | [INFO] [stderr] 284 | | b"E ", &n(3), b"fuz" [INFO] [stderr] 285 | | }; [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/common/riff.rs:219:15 [INFO] [stderr] | [INFO] [stderr] 219 | $(data.write($arg).unwrap();)+ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 334 | let data = build! { [INFO] [stderr] | ____________________- [INFO] [stderr] 335 | | b"RIFF", &n(77), b"abcd", [INFO] [stderr] 336 | | b"A ", &n(10), b"abcdefghij", [INFO] [stderr] 337 | | b" B ", &n(12), b"123456789012", [INFO] [stderr] 338 | | b" C ", &n(8), b"ABCDEFGH" [INFO] [stderr] 339 | | }; [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/common/tiff.rs:67:40 [INFO] [stderr] | [INFO] [stderr] 67 | next_ifd_offset: Cell::new(next_ifd_offset as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(next_ifd_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/common/tiff.rs:129:63 [INFO] [stderr] | [INFO] [stderr] 129 | let next_ifd_offset_offset = current_ifd_offset + 2 + current_ifd_size as u64 * 12; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(current_ifd_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/common/tiff.rs:136:36 [INFO] [stderr] | [INFO] [stderr] 136 | self.0.next_ifd_offset.set(try_if_eof!( [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 137 | | self.0.source.borrow_mut().read_u32(self.0.byte_order), "when reading the next IFD offset" [INFO] [stderr] 138 | | ) as u64); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 136 | self.0.next_ifd_offset.set(u64::from(match $ expr { [INFO] [stderr] 137 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 138 | :: Err ( err ) => { [INFO] [stderr] 139 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 140 | $ crate :: convert :: From :: from ( err ) ) } })); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/common/tiff.rs:181:64 [INFO] [stderr] | [INFO] [stderr] 181 | try!(source.seek(SeekFrom::Start(self.ifd_offset + 2 + self.current_entry as u64 * 12))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.current_entry)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/common/tiff.rs:321:20 [INFO] [stderr] | [INFO] [stderr] 321 | if entry_type_size as u32 * self.count <= 4 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(entry_type_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/common/tiff.rs:364:20 [INFO] [stderr] | [INFO] [stderr] 364 | if entry_type_size as u32 * self.count <= 4 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(entry_type_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/common/tiff.rs:368:78 [INFO] [stderr] | [INFO] [stderr] 368 | match self.ifds.source.borrow_mut().seek(SeekFrom::Start(self.offset as u64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/common/tiff.rs:462:45 [INFO] [stderr] | [INFO] [stderr] 462 | let max_bytes = n * item_size as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(item_size)` [INFO] [stderr] ... [INFO] [stderr] 480 | / gen_entry_types! { [INFO] [stderr] 481 | | Byte, u8, [INFO] [stderr] 482 | | |source, _| byteorder::ReadBytesExt::read_u8(source).map(|v| (1, v)), [INFO] [stderr] 483 | | |source, _, n, count| if n >= count || n >= 4 { None } else { Some(source[n]) }; [INFO] [stderr] ... | [INFO] [stderr] 558 | | |_, _, _, _| None [INFO] [stderr] 559 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/common/tiff.rs:622:44 [INFO] [stderr] | [INFO] [stderr] 622 | if self.bytes_read >= self.count * T::entry_type().size().unwrap() as u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(T::entry_type().size().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/common/tiff.rs:626:65 [INFO] [stderr] | [INFO] [stderr] 626 | try!(self.ifds.source.borrow_mut().seek(SeekFrom::Start(self.next_offset as u64))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.next_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 116 [INFO] [stderr] --> src/common/tiff.rs:735:5 [INFO] [stderr] | [INFO] [stderr] 735 | / fn test_one_ifd_all_types() { [INFO] [stderr] 736 | | let data = build! { BigEndian, [INFO] [stderr] 737 | | b"MM", 42u16, 8u32, // 1st IFD starts from 8th offset [INFO] [stderr] 738 | | [INFO] [stderr] ... | [INFO] [stderr] 988 | | } [INFO] [stderr] 989 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: approximate value of `f64::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/common/tiff.rs:806:13 [INFO] [stderr] | [INFO] [stderr] 806 | 3.14f64 [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/common/tiff.rs:960:25 [INFO] [stderr] | [INFO] [stderr] 960 | / assert_items!( [INFO] [stderr] 961 | | e.values::().unwrap(), [INFO] [stderr] 962 | | 0.123 [INFO] [stderr] 963 | | ); [INFO] [stderr] | |__________________________^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/common/tiff.rs:960:25 [INFO] [stderr] | [INFO] [stderr] 960 | / assert_items!( [INFO] [stderr] 961 | | e.values::().unwrap(), [INFO] [stderr] 962 | | 0.123 [INFO] [stderr] 963 | | ); [INFO] [stderr] | |__________________________^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/common/tiff.rs:971:34 [INFO] [stderr] | [INFO] [stderr] 971 | vec![3.14] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/common/tiff.rs:975:29 [INFO] [stderr] | [INFO] [stderr] 975 | 3.14 [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/common/tiff.rs:973:25 [INFO] [stderr] | [INFO] [stderr] 973 | / assert_items!( [INFO] [stderr] 974 | | e.values::().unwrap(), [INFO] [stderr] 975 | | 3.14 [INFO] [stderr] 976 | | ); [INFO] [stderr] | |__________________________^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/common/tiff.rs:973:25 [INFO] [stderr] | [INFO] [stderr] 973 | / assert_items!( [INFO] [stderr] 974 | | e.values::().unwrap(), [INFO] [stderr] 975 | | 3.14 [INFO] [stderr] 976 | | ); [INFO] [stderr] | |__________________________^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/formats/png.rs:212:22 [INFO] [stderr] | [INFO] [stderr] 212 | .ok_or(invalid_format!("invalid color type: {}", color_type)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| invalid_format!("invalid color type: {}", color_type))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/formats/png.rs:216:22 [INFO] [stderr] | [INFO] [stderr] 216 | .ok_or(invalid_format!("invalid bit depth: {}", bit_depth)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| invalid_format!("invalid bit depth: {}", bit_depth))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/formats/png.rs:220:22 [INFO] [stderr] | [INFO] [stderr] 220 | .ok_or(invalid_format!("invalid compression method: {}", compression_method)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| invalid_format!("invalid compression method: {}", compression_method))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/formats/png.rs:224:22 [INFO] [stderr] | [INFO] [stderr] 224 | .ok_or(invalid_format!("invalid filter method: {}", filter_method)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| invalid_format!("invalid filter method: {}", filter_method))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/formats/png.rs:228:22 [INFO] [stderr] | [INFO] [stderr] 228 | .ok_or(invalid_format!("invalid interlace method: {}", interlace_method)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| invalid_format!("invalid interlace method: {}", interlace_method))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/formats/gif.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | let n = try_if_eof!(r.read_u8(), on_eof()) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 50 | let n = u64::from(match $ expr { [INFO] [stderr] 51 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 52 | :: Err ( err ) => { [INFO] [stderr] 53 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 54 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(0b00000111 & packed_flags)` [INFO] [stderr] --> src/formats/gif.rs:115:40 [INFO] [stderr] | [INFO] [stderr] 115 | let local_color_table_size_p = (0b00000111 & packed_flags) >> 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/formats/gif.rs:124:29 [INFO] [stderr] | [INFO] [stderr] 124 | let skip_size = local_color_table_size as u64 * 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(local_color_table_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/formats/gif.rs:187:9 [INFO] [stderr] | [INFO] [stderr] 187 | self.delay_time as u32 * 10 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.delay_time)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/formats/gif.rs:218:22 [INFO] [stderr] | [INFO] [stderr] 218 | .ok_or(invalid_format!("invalid disposal method in {} {}: {}", [INFO] [stderr] | ______________________^ [INFO] [stderr] 219 | | NAME, index, disposal_method)) [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 218 | .ok_or_else(|| invalid_format!("invalid disposal method in {} {}: {}", [INFO] [stderr] 219 | NAME, index, disposal_method)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/formats/gif.rs:485:19 [INFO] [stderr] | [INFO] [stderr] 485 | Some((self.pixel_aspect_ratio as f64 + 15.0)/64.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.pixel_aspect_ratio)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/formats/gif.rs:515:14 [INFO] [stderr] | [INFO] [stderr] 515 | .ok_or(invalid_format!("invalid GIF version: {:?}", &signature[3..]))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| invalid_format!("invalid GIF version: {:?}", &signature[3..]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(packed_flags & 0b00000111)` [INFO] [stderr] --> src/formats/gif.rs:525:41 [INFO] [stderr] | [INFO] [stderr] 525 | let global_color_table_size_p = (packed_flags & 0b00000111) >> 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/formats/gif.rs:536:29 [INFO] [stderr] | [INFO] [stderr] 536 | let skip_size = global_color_table_size as u64 * 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(global_color_table_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/formats/webp.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / loop { [INFO] [stderr] 59 | | let mut chunk = match root.next() { [INFO] [stderr] 60 | | Some(c) => try!(c), [INFO] [stderr] 61 | | None => return Err(unexpected_eof!("when reading first WEBP chunk")) [INFO] [stderr] ... | [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/formats/webp.rs:99:34 [INFO] [stderr] | [INFO] [stderr] 99 | result.first_partition_len = ((hdr[0] >> 5) as u32) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hdr[0] >> 5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/formats/webp.rs:100:35 [INFO] [stderr] | [INFO] [stderr] 100 | ((hdr[1] as u32) << 3) | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(hdr[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/formats/webp.rs:101:35 [INFO] [stderr] | [INFO] [stderr] 101 | ((hdr[2] as u32) << 11); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(hdr[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/formats/webp.rs:108:12 [INFO] [stderr] | [INFO] [stderr] 108 | if &hdr[..3] != &[0x9d, 0x01, 0x2a] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 108 | if hdr[..3] != [0x9d, 0x01, 0x2a] { [INFO] [stderr] | ^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/formats/webp.rs:120:22 [INFO] [stderr] | [INFO] [stderr] 120 | let width = ((hdr[4] & 0x3f) as u32) << 8 | hdr[3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hdr[4] & 0x3f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/formats/webp.rs:120:54 [INFO] [stderr] | [INFO] [stderr] 120 | let width = ((hdr[4] & 0x3f) as u32) << 8 | hdr[3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(hdr[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/formats/webp.rs:121:22 [INFO] [stderr] | [INFO] [stderr] 121 | let height = ((hdr[6] & 0x3f) as u32) << 8 | hdr[5] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hdr[6] & 0x3f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/formats/webp.rs:121:54 [INFO] [stderr] | [INFO] [stderr] 121 | let height = ((hdr[6] & 0x3f) as u32) << 8 | hdr[5] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(hdr[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 10 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `immeta`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6888969f2e94df853956b13fc35e0678f02f736a1507acf01b632a4c0b36169b"` [INFO] running `"docker" "rm" "-f" "6888969f2e94df853956b13fc35e0678f02f736a1507acf01b632a4c0b36169b"` [INFO] [stdout] 6888969f2e94df853956b13fc35e0678f02f736a1507acf01b632a4c0b36169b