[INFO] crate imgui_file_explorer 0.0.3 is already in cache [INFO] extracting crate imgui_file_explorer 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/imgui_file_explorer/0.0.3 [INFO] extracting crate imgui_file_explorer 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/imgui_file_explorer/0.0.3 [INFO] validating manifest of imgui_file_explorer-0.0.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of imgui_file_explorer-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing imgui_file_explorer-0.0.3 [INFO] finished frobbing imgui_file_explorer-0.0.3 [INFO] frobbed toml for imgui_file_explorer-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/imgui_file_explorer/0.0.3/Cargo.toml [INFO] started frobbing imgui_file_explorer-0.0.3 [INFO] finished frobbing imgui_file_explorer-0.0.3 [INFO] frobbed toml for imgui_file_explorer-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/imgui_file_explorer/0.0.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting imgui_file_explorer-0.0.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/imgui_file_explorer/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a172843963acf60dbbf87704ada4e9908490af84dffa6d7066cfe7e5c78a474d [INFO] running `"docker" "start" "-a" "a172843963acf60dbbf87704ada4e9908490af84dffa6d7066cfe7e5c78a474d"` [INFO] [stderr] Compiling imgui-sys v0.0.21 [INFO] [stderr] Checking winit v0.16.2 [INFO] [stderr] Checking glutin v0.17.0 [INFO] [stderr] Checking glium v0.22.0 [INFO] [stderr] Checking imgui v0.0.21 [INFO] [stderr] Checking imgui-glium-renderer v0.0.21 [INFO] [stderr] Checking imgui_file_explorer v0.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:96:24 [INFO] [stderr] | [INFO] [stderr] 96 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 97 | | if let Some(file_name) = i.file_name() { [INFO] [stderr] 98 | | if let Some(file_name) = file_name.to_str() { [INFO] [stderr] 99 | | ui.bullet_text(im_str!("")); [INFO] [stderr] ... | [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 96 | } else if let Some(file_name) = i.file_name() { [INFO] [stderr] 97 | if let Some(file_name) = file_name.to_str() { [INFO] [stderr] 98 | ui.bullet_text(im_str!("")); [INFO] [stderr] 99 | ui.same_line(0.0); [INFO] [stderr] 100 | if ui.small_button(&ImString::new(file_name)) { [INFO] [stderr] 101 | ret = Ok(Some(i.clone())); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:96:24 [INFO] [stderr] | [INFO] [stderr] 96 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 97 | | if let Some(file_name) = i.file_name() { [INFO] [stderr] 98 | | if let Some(file_name) = file_name.to_str() { [INFO] [stderr] 99 | | ui.bullet_text(im_str!("")); [INFO] [stderr] ... | [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 96 | } else if let Some(file_name) = i.file_name() { [INFO] [stderr] 97 | if let Some(file_name) = file_name.to_str() { [INFO] [stderr] 98 | ui.bullet_text(im_str!("")); [INFO] [stderr] 99 | ui.same_line(0.0); [INFO] [stderr] 100 | if ui.small_button(&ImString::new(file_name)) { [INFO] [stderr] 101 | ret = Ok(Some(i.clone())); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 50.61s [INFO] running `"docker" "inspect" "a172843963acf60dbbf87704ada4e9908490af84dffa6d7066cfe7e5c78a474d"` [INFO] running `"docker" "rm" "-f" "a172843963acf60dbbf87704ada4e9908490af84dffa6d7066cfe7e5c78a474d"` [INFO] [stdout] a172843963acf60dbbf87704ada4e9908490af84dffa6d7066cfe7e5c78a474d