[INFO] crate imgui 0.0.21 is already in cache
[INFO] extracting crate imgui 0.0.21 into work/ex/clippy-test-run/sources/stable/reg/imgui/0.0.21
[INFO] extracting crate imgui 0.0.21 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/imgui/0.0.21
[INFO] validating manifest of imgui-0.0.21 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of imgui-0.0.21 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing imgui-0.0.21
[INFO] finished frobbing imgui-0.0.21
[INFO] frobbed toml for imgui-0.0.21 written to work/ex/clippy-test-run/sources/stable/reg/imgui/0.0.21/Cargo.toml
[INFO] started frobbing imgui-0.0.21
[INFO] finished frobbing imgui-0.0.21
[INFO] frobbed toml for imgui-0.0.21 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/imgui/0.0.21/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting imgui-0.0.21 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/imgui/0.0.21:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] dde9352a6f6754ae1a6539ad98c94af2b57c847152e81b8ac2e1ca427da67607
[INFO] running `"docker" "start" "-a" "dde9352a6f6754ae1a6539ad98c94af2b57c847152e81b8ac2e1ca427da67607"`
[INFO] [stderr]    Compiling imgui-sys v0.0.21
[INFO] [stderr]     Checking imgui v0.0.21 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/image.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             texture_id: texture_id,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `texture_id`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/image.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             texture_id: texture_id,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `texture_id`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/fonts.rs:124:9
[INFO] [stderr]     |
[INFO] [stderr] 124 | /         match &self.0 {
[INFO] [stderr] 125 | |             &FontGlyphRangeData::Chinese => sys::ImFontAtlas_GetGlyphRangesChinese(atlas),
[INFO] [stderr] 126 | |             &FontGlyphRangeData::Cyrillic => sys::ImFontAtlas_GetGlyphRangesCyrillic(atlas),
[INFO] [stderr] 127 | |             &FontGlyphRangeData::Default => sys::ImFontAtlas_GetGlyphRangesDefault(atlas),
[INFO] [stderr] ...   |
[INFO] [stderr] 132 | |             &FontGlyphRangeData::Custom(ptr) => ptr,
[INFO] [stderr] 133 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 124 |         match self.0 {
[INFO] [stderr] 125 |             FontGlyphRangeData::Chinese => sys::ImFontAtlas_GetGlyphRangesChinese(atlas),
[INFO] [stderr] 126 |             FontGlyphRangeData::Cyrillic => sys::ImFontAtlas_GetGlyphRangesCyrillic(atlas),
[INFO] [stderr] 127 |             FontGlyphRangeData::Default => sys::ImFontAtlas_GetGlyphRangesDefault(atlas),
[INFO] [stderr] 128 |             FontGlyphRangeData::Japanese => sys::ImFontAtlas_GetGlyphRangesJapanese(atlas),
[INFO] [stderr] 129 |             FontGlyphRangeData::Korean => sys::ImFontAtlas_GetGlyphRangesKorean(atlas),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/image.rs:11:15
[INFO] [stderr]    |
[INFO] [stderr] 11 |     pub fn id(&self) -> usize {
[INFO] [stderr]    |               ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `image::Textures<T>`
[INFO] [stderr]    --> src/image.rs:119:5
[INFO] [stderr]     |
[INFO] [stderr] 119 | /     pub fn new() -> Self {
[INFO] [stderr] 120 | |         Textures {
[INFO] [stderr] 121 | |             textures: HashMap::new(),
[INFO] [stderr] 122 | |             next: 0,
[INFO] [stderr] 123 | |         }
[INFO] [stderr] 124 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 113 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/fonts.rs:124:9
[INFO] [stderr]     |
[INFO] [stderr] 124 | /         match &self.0 {
[INFO] [stderr] 125 | |             &FontGlyphRangeData::Chinese => sys::ImFontAtlas_GetGlyphRangesChinese(atlas),
[INFO] [stderr] 126 | |             &FontGlyphRangeData::Cyrillic => sys::ImFontAtlas_GetGlyphRangesCyrillic(atlas),
[INFO] [stderr] 127 | |             &FontGlyphRangeData::Default => sys::ImFontAtlas_GetGlyphRangesDefault(atlas),
[INFO] [stderr] ...   |
[INFO] [stderr] 132 | |             &FontGlyphRangeData::Custom(ptr) => ptr,
[INFO] [stderr] 133 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 124 |         match self.0 {
[INFO] [stderr] 125 |             FontGlyphRangeData::Chinese => sys::ImFontAtlas_GetGlyphRangesChinese(atlas),
[INFO] [stderr] 126 |             FontGlyphRangeData::Cyrillic => sys::ImFontAtlas_GetGlyphRangesCyrillic(atlas),
[INFO] [stderr] 127 |             FontGlyphRangeData::Default => sys::ImFontAtlas_GetGlyphRangesDefault(atlas),
[INFO] [stderr] 128 |             FontGlyphRangeData::Japanese => sys::ImFontAtlas_GetGlyphRangesJapanese(atlas),
[INFO] [stderr] 129 |             FontGlyphRangeData::Korean => sys::ImFontAtlas_GetGlyphRangesKorean(atlas),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/image.rs:11:15
[INFO] [stderr]    |
[INFO] [stderr] 11 |     pub fn id(&self) -> usize {
[INFO] [stderr]    |               ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `image::Textures<T>`
[INFO] [stderr]    --> src/image.rs:119:5
[INFO] [stderr]     |
[INFO] [stderr] 119 | /     pub fn new() -> Self {
[INFO] [stderr] 120 | |         Textures {
[INFO] [stderr] 121 | |             textures: HashMap::new(),
[INFO] [stderr] 122 | |             next: 0,
[INFO] [stderr] 123 | |         }
[INFO] [stderr] 124 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 113 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]    --> src/lib.rs:789:31
[INFO] [stderr]     |
[INFO] [stderr] 789 |                     let end = start.offset(s.len() as isize);
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `start.add(s.len())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_offset_with_cast)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]    --> src/lib.rs:825:23
[INFO] [stderr]     |
[INFO] [stderr] 825 |             let end = start.offset(s.len() as isize);
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `start.add(s.len())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]     --> src/lib.rs:1251:53
[INFO] [stderr]      |
[INFO] [stderr] 1251 |         let items_inner: Vec<*const c_char> = items.into_iter().map(|item| item.as_ptr()).collect();
[INFO] [stderr]      |                                                     ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]     --> src/lib.rs:1273:53
[INFO] [stderr]      |
[INFO] [stderr] 1273 |         let items_inner: Vec<*const c_char> = items.into_iter().map(|item| item.as_ptr()).collect();
[INFO] [stderr]      |                                                     ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]    --> src/lib.rs:789:31
[INFO] [stderr]     |
[INFO] [stderr] 789 |                     let end = start.offset(s.len() as isize);
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `start.add(s.len())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_offset_with_cast)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]    --> src/lib.rs:825:23
[INFO] [stderr]     |
[INFO] [stderr] 825 |             let end = start.offset(s.len() as isize);
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `start.add(s.len())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]     --> src/lib.rs:1251:53
[INFO] [stderr]      |
[INFO] [stderr] 1251 |         let items_inner: Vec<*const c_char> = items.into_iter().map(|item| item.as_ptr()).collect();
[INFO] [stderr]      |                                                     ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]     --> src/lib.rs:1273:53
[INFO] [stderr]      |
[INFO] [stderr] 1273 |         let items_inner: Vec<*const c_char> = items.into_iter().map(|item| item.as_ptr()).collect();
[INFO] [stderr]      |                                                     ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 9.82s
[INFO] running `"docker" "inspect" "dde9352a6f6754ae1a6539ad98c94af2b57c847152e81b8ac2e1ca427da67607"`
[INFO] running `"docker" "rm" "-f" "dde9352a6f6754ae1a6539ad98c94af2b57c847152e81b8ac2e1ca427da67607"`
[INFO] [stdout] dde9352a6f6754ae1a6539ad98c94af2b57c847152e81b8ac2e1ca427da67607