[INFO] crate imghdr 0.4.0 is already in cache [INFO] extracting crate imghdr 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/imghdr/0.4.0 [INFO] extracting crate imghdr 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/imghdr/0.4.0 [INFO] validating manifest of imghdr-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of imghdr-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing imghdr-0.4.0 [INFO] finished frobbing imghdr-0.4.0 [INFO] frobbed toml for imghdr-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/imghdr/0.4.0/Cargo.toml [INFO] started frobbing imghdr-0.4.0 [INFO] finished frobbing imghdr-0.4.0 [INFO] frobbed toml for imghdr-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/imghdr/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting imghdr-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/imghdr/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 723bdeb4034a2824e3d0d4be8e6b02d069962f713f71c4c16a1aea13d8817f9d [INFO] running `"docker" "start" "-a" "723bdeb4034a2824e3d0d4be8e6b02d069962f713f71c4c16a1aea13d8817f9d"` [INFO] [stderr] Checking imghdr v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:4:13 [INFO] [stderr] | [INFO] [stderr] 4 | const PNG: &'static [u8] = b"\x89PNG\r\n\x1a\n"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:5:14 [INFO] [stderr] | [INFO] [stderr] 5 | const JFIF: &'static [u8] = b"JFIF"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:6:14 [INFO] [stderr] | [INFO] [stderr] 6 | const EXIF: &'static [u8] = b"Exif"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:7:16 [INFO] [stderr] | [INFO] [stderr] 7 | const GIF87A: &'static [u8] = b"GIF87a"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:8:16 [INFO] [stderr] | [INFO] [stderr] 8 | const GIF89A: &'static [u8] = b"GIF89a"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:9:17 [INFO] [stderr] | [INFO] [stderr] 9 | const TIFF_MM: &'static [u8] = b"MM"; // Motorola byte order [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | const TIFF_II: &'static [u8] = b"II"; // Intel byte order [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:11:14 [INFO] [stderr] | [INFO] [stderr] 11 | const RAST: &'static [u8] = b"\x59\xA6\x6A\x95"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | const XBM: &'static [u8] = b"#define "; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:13:14 [INFO] [stderr] | [INFO] [stderr] 13 | const RIFF: &'static [u8] = b"RIFF"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:14:14 [INFO] [stderr] | [INFO] [stderr] 14 | const WEBP: &'static [u8] = b"WEBP"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | const BMP: &'static [u8] = b"BM"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | const BGP: &'static [u8] = b"BPG\xfb"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | const RGB: &'static [u8] = b"\x01\xda"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:18:14 [INFO] [stderr] | [INFO] [stderr] 18 | const FLIF: &'static [u8] = b"FLIF"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/patterns.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / return bytes[0] == b'P' [INFO] [stderr] 23 | | && b"14".contains(&bytes[1]) [INFO] [stderr] 24 | | && b" \t\n\r".contains(&bytes[2]); [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 22 | bytes[0] == b'P' [INFO] [stderr] 23 | && b"14".contains(&bytes[1]) [INFO] [stderr] 24 | && b" \t\n\r".contains(&bytes[2]) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/patterns.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / return bytes[0] == b'P' [INFO] [stderr] 30 | | && b"25".contains(&bytes[1]) [INFO] [stderr] 31 | | && b" \t\n\r".contains(&bytes[2]); [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 29 | bytes[0] == b'P' [INFO] [stderr] 30 | && b"25".contains(&bytes[1]) [INFO] [stderr] 31 | && b" \t\n\r".contains(&bytes[2]) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/patterns.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / return bytes[0] == b'P' [INFO] [stderr] 37 | | && b"36".contains(&bytes[1]) [INFO] [stderr] 38 | | && b" \t\n\r".contains(&bytes[2]); [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 36 | bytes[0] == b'P' [INFO] [stderr] 37 | && b"36".contains(&bytes[1]) [INFO] [stderr] 38 | && b" \t\n\r".contains(&bytes[2]) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/patterns.rs:21:11 [INFO] [stderr] | [INFO] [stderr] 21 | fn is_pbm(ref bytes: [u8; 32]) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/patterns.rs:28:11 [INFO] [stderr] | [INFO] [stderr] 28 | fn is_pgm(ref bytes: [u8; 32]) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/patterns.rs:35:11 [INFO] [stderr] | [INFO] [stderr] 35 | fn is_ppm(ref bytes: [u8; 32]) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/patterns.rs:41:14 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn guess(ref bytes: [u8; 32]) -> Option { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/lib.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | f.read(&mut buffer).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `imghdr`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:4:13 [INFO] [stderr] | [INFO] [stderr] 4 | const PNG: &'static [u8] = b"\x89PNG\r\n\x1a\n"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:5:14 [INFO] [stderr] | [INFO] [stderr] 5 | const JFIF: &'static [u8] = b"JFIF"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:6:14 [INFO] [stderr] | [INFO] [stderr] 6 | const EXIF: &'static [u8] = b"Exif"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:7:16 [INFO] [stderr] | [INFO] [stderr] 7 | const GIF87A: &'static [u8] = b"GIF87a"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:8:16 [INFO] [stderr] | [INFO] [stderr] 8 | const GIF89A: &'static [u8] = b"GIF89a"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:9:17 [INFO] [stderr] | [INFO] [stderr] 9 | const TIFF_MM: &'static [u8] = b"MM"; // Motorola byte order [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | const TIFF_II: &'static [u8] = b"II"; // Intel byte order [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:11:14 [INFO] [stderr] | [INFO] [stderr] 11 | const RAST: &'static [u8] = b"\x59\xA6\x6A\x95"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | const XBM: &'static [u8] = b"#define "; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:13:14 [INFO] [stderr] | [INFO] [stderr] 13 | const RIFF: &'static [u8] = b"RIFF"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:14:14 [INFO] [stderr] | [INFO] [stderr] 14 | const WEBP: &'static [u8] = b"WEBP"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | const BMP: &'static [u8] = b"BM"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | const BGP: &'static [u8] = b"BPG\xfb"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | const RGB: &'static [u8] = b"\x01\xda"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/patterns.rs:18:14 [INFO] [stderr] | [INFO] [stderr] 18 | const FLIF: &'static [u8] = b"FLIF"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/patterns.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / return bytes[0] == b'P' [INFO] [stderr] 23 | | && b"14".contains(&bytes[1]) [INFO] [stderr] 24 | | && b" \t\n\r".contains(&bytes[2]); [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 22 | bytes[0] == b'P' [INFO] [stderr] 23 | && b"14".contains(&bytes[1]) [INFO] [stderr] 24 | && b" \t\n\r".contains(&bytes[2]) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/patterns.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / return bytes[0] == b'P' [INFO] [stderr] 30 | | && b"25".contains(&bytes[1]) [INFO] [stderr] 31 | | && b" \t\n\r".contains(&bytes[2]); [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 29 | bytes[0] == b'P' [INFO] [stderr] 30 | && b"25".contains(&bytes[1]) [INFO] [stderr] 31 | && b" \t\n\r".contains(&bytes[2]) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/patterns.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / return bytes[0] == b'P' [INFO] [stderr] 37 | | && b"36".contains(&bytes[1]) [INFO] [stderr] 38 | | && b" \t\n\r".contains(&bytes[2]); [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 36 | bytes[0] == b'P' [INFO] [stderr] 37 | && b"36".contains(&bytes[1]) [INFO] [stderr] 38 | && b" \t\n\r".contains(&bytes[2]) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/patterns.rs:21:11 [INFO] [stderr] | [INFO] [stderr] 21 | fn is_pbm(ref bytes: [u8; 32]) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/patterns.rs:28:11 [INFO] [stderr] | [INFO] [stderr] 28 | fn is_pgm(ref bytes: [u8; 32]) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/patterns.rs:35:11 [INFO] [stderr] | [INFO] [stderr] 35 | fn is_ppm(ref bytes: [u8; 32]) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/patterns.rs:41:14 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn guess(ref bytes: [u8; 32]) -> Option { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/lib.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | f.read(&mut buffer).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `imghdr`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "723bdeb4034a2824e3d0d4be8e6b02d069962f713f71c4c16a1aea13d8817f9d"` [INFO] running `"docker" "rm" "-f" "723bdeb4034a2824e3d0d4be8e6b02d069962f713f71c4c16a1aea13d8817f9d"` [INFO] [stdout] 723bdeb4034a2824e3d0d4be8e6b02d069962f713f71c4c16a1aea13d8817f9d