[INFO] crate imgcompare 0.1.1 is already in cache [INFO] extracting crate imgcompare 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/imgcompare/0.1.1 [INFO] extracting crate imgcompare 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/imgcompare/0.1.1 [INFO] validating manifest of imgcompare-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of imgcompare-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing imgcompare-0.1.1 [INFO] finished frobbing imgcompare-0.1.1 [INFO] frobbed toml for imgcompare-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/imgcompare/0.1.1/Cargo.toml [INFO] started frobbing imgcompare-0.1.1 [INFO] finished frobbing imgcompare-0.1.1 [INFO] frobbed toml for imgcompare-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/imgcompare/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting imgcompare-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/imgcompare/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2f1d16eb8e14ff89b910a7e6856ce2b955f06377609ee985e606e05485d2b45f [INFO] running `"docker" "start" "-a" "2f1d16eb8e14ff89b910a7e6856ce2b955f06377609ee985e606e05485d2b45f"` [INFO] [stderr] Checking png v0.8.0 [INFO] [stderr] Checking image v0.14.0 [INFO] [stderr] Checking imgcompare v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / return px1.zip(px2).all(|i| { [INFO] [stderr] 40 | | let (a, b) = i; [INFO] [stderr] 41 | | let (x1, y1, p1) = a; [INFO] [stderr] 42 | | let (x2, y2, p2) = b; [INFO] [stderr] ... | [INFO] [stderr] 46 | | return x1 == x2 && y1 == y2 && p1 == p2; [INFO] [stderr] 47 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 39 | px1.zip(px2).all(|i| { [INFO] [stderr] 40 | let (a, b) = i; [INFO] [stderr] 41 | let (x1, y1, p1) = a; [INFO] [stderr] 42 | let (x2, y2, p2) = b; [INFO] [stderr] 43 | [INFO] [stderr] 44 | //println!("a: {:?}", a); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return x1 == x2 && y1 == y2 && p1 == p2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `x1 == x2 && y1 == y2 && p1 == p2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:26:23 [INFO] [stderr] | [INFO] [stderr] 26 | std::process::exit(match result { [INFO] [stderr] | _______________________^ [INFO] [stderr] 27 | | true => 0, [INFO] [stderr] 28 | | false => { [INFO] [stderr] 29 | | println!("Images {} and {} differ!", path1.display(), path2.display()); [INFO] [stderr] 30 | | -1 [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | }); [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 26 | std::process::exit(if result { 0 } else { [INFO] [stderr] 27 | println!("Images {} and {} differ!", path1.display(), path2.display()); [INFO] [stderr] 28 | -1 [INFO] [stderr] 29 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / return px1.zip(px2).all(|i| { [INFO] [stderr] 40 | | let (a, b) = i; [INFO] [stderr] 41 | | let (x1, y1, p1) = a; [INFO] [stderr] 42 | | let (x2, y2, p2) = b; [INFO] [stderr] ... | [INFO] [stderr] 46 | | return x1 == x2 && y1 == y2 && p1 == p2; [INFO] [stderr] 47 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 39 | px1.zip(px2).all(|i| { [INFO] [stderr] 40 | let (a, b) = i; [INFO] [stderr] 41 | let (x1, y1, p1) = a; [INFO] [stderr] 42 | let (x2, y2, p2) = b; [INFO] [stderr] 43 | [INFO] [stderr] 44 | //println!("a: {:?}", a); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return x1 == x2 && y1 == y2 && p1 == p2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `x1 == x2 && y1 == y2 && p1 == p2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:26:23 [INFO] [stderr] | [INFO] [stderr] 26 | std::process::exit(match result { [INFO] [stderr] | _______________________^ [INFO] [stderr] 27 | | true => 0, [INFO] [stderr] 28 | | false => { [INFO] [stderr] 29 | | println!("Images {} and {} differ!", path1.display(), path2.display()); [INFO] [stderr] 30 | | -1 [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | }); [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 26 | std::process::exit(if result { 0 } else { [INFO] [stderr] 27 | println!("Images {} and {} differ!", path1.display(), path2.display()); [INFO] [stderr] 28 | -1 [INFO] [stderr] 29 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.77s [INFO] running `"docker" "inspect" "2f1d16eb8e14ff89b910a7e6856ce2b955f06377609ee985e606e05485d2b45f"` [INFO] running `"docker" "rm" "-f" "2f1d16eb8e14ff89b910a7e6856ce2b955f06377609ee985e606e05485d2b45f"` [INFO] [stdout] 2f1d16eb8e14ff89b910a7e6856ce2b955f06377609ee985e606e05485d2b45f