[INFO] crate img_hash 2.1.0 is already in cache [INFO] extracting crate img_hash 2.1.0 into work/ex/clippy-test-run/sources/stable/reg/img_hash/2.1.0 [INFO] extracting crate img_hash 2.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/img_hash/2.1.0 [INFO] validating manifest of img_hash-2.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of img_hash-2.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing img_hash-2.1.0 [INFO] finished frobbing img_hash-2.1.0 [INFO] frobbed toml for img_hash-2.1.0 written to work/ex/clippy-test-run/sources/stable/reg/img_hash/2.1.0/Cargo.toml [INFO] started frobbing img_hash-2.1.0 [INFO] finished frobbing img_hash-2.1.0 [INFO] frobbed toml for img_hash-2.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/img_hash/2.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting img_hash-2.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/img_hash/2.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1d694cbda6800d658eb92d85e28fbe9539d7a6c3d60b2361c105d0832eaf686b [INFO] running `"docker" "start" "-a" "1d694cbda6800d658eb92d85e28fbe9539d7a6c3d60b2361c105d0832eaf686b"` [INFO] [stderr] Checking img_hash v2.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dct.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dct.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | rowstride: rowstride, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rowstride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dct.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | hash_type: hash_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | hash_type: hash_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:359:13 [INFO] [stderr] | [INFO] [stderr] 359 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:360:13 [INFO] [stderr] | [INFO] [stderr] 360 | rowstride: rowstride, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rowstride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:374:17 [INFO] [stderr] | [INFO] [stderr] 374 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dct.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dct.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | rowstride: rowstride, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rowstride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dct.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | hash_type: hash_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | hash_type: hash_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:359:13 [INFO] [stderr] | [INFO] [stderr] 359 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:360:13 [INFO] [stderr] | [INFO] [stderr] 360 | rowstride: rowstride, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rowstride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:374:17 [INFO] [stderr] | [INFO] [stderr] 374 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/block.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | x + 3 & !3 [INFO] [stderr] | ^^^^^^^^^^ help: consider parenthesizing your expression: `(x + 3) & !3` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/block.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | x + 3 & !3 [INFO] [stderr] | ^^^^^^^^^^ help: consider parenthesizing your expression: `(x + 3) & !3` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `output` [INFO] [stderr] --> src/dct.rs:137:14 [INFO] [stderr] | [INFO] [stderr] 137 | for i in 0 .. len { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 137 | for (i, ) in output.iter_mut().enumerate().take(len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `input` [INFO] [stderr] --> src/dct.rs:140:18 [INFO] [stderr] | [INFO] [stderr] 140 | for j in 0 .. len { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 140 | for (j, ) in input.iter().enumerate().take(len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:68:40 [INFO] [stderr] | [INFO] [stderr] 68 | let (block_width, block_height) = (width as f64 / size as f64, height as f64 / size as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:68:55 [INFO] [stderr] | [INFO] [stderr] 68 | let (block_width, block_height) = (width as f64 / size as f64, height as f64 / size as f64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:68:68 [INFO] [stderr] | [INFO] [stderr] 68 | let (block_width, block_height) = (width as f64 / size as f64, height as f64 / size as f64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:68:84 [INFO] [stderr] | [INFO] [stderr] 68 | let (block_width, block_height) = (width as f64 / size as f64, height as f64 / size as f64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:73:22 [INFO] [stderr] | [INFO] [stderr] 73 | let px_sum = sum_px(px) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(sum_px(px))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:75:23 [INFO] [stderr] | [INFO] [stderr] 75 | let (x, y) = (x as f64, y as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:75:33 [INFO] [stderr] | [INFO] [stderr] 75 | let (x, y) = (x as f64, y as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:35:29 [INFO] [stderr] | [INFO] [stderr] 35 | let channel_count = <$imgty as HashImage>::channel_count() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(<$imgty as HashImage>::channel_count())` [INFO] [stderr] ... [INFO] [stderr] 113 | / gen_hash!(I, f64, blocks, size, block_width, block_height, [INFO] [stderr] 114 | | |l: f64, r: f64| (l - r).abs() < FLOAT_EQ_MARGIN) [INFO] [stderr] | |_________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:42:22 [INFO] [stderr] | [INFO] [stderr] 42 | 3 | 4 => 255u32 as $valty * 3u32 as $valty, [INFO] [stderr] | ^^^^^^ help: try: `f64::from(255u32)` [INFO] [stderr] ... [INFO] [stderr] 113 | / gen_hash!(I, f64, blocks, size, block_width, block_height, [INFO] [stderr] 114 | | |l: f64, r: f64| (l - r).abs() < FLOAT_EQ_MARGIN) [INFO] [stderr] | |_________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:42:41 [INFO] [stderr] | [INFO] [stderr] 42 | 3 | 4 => 255u32 as $valty * 3u32 as $valty, [INFO] [stderr] | ^^^^ help: try: `f64::from(3u32)` [INFO] [stderr] ... [INFO] [stderr] 113 | / gen_hash!(I, f64, blocks, size, block_width, block_height, [INFO] [stderr] 114 | | |l: f64, r: f64| (l - r).abs() < FLOAT_EQ_MARGIN) [INFO] [stderr] | |_________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:43:22 [INFO] [stderr] | [INFO] [stderr] 43 | 2 | 1 => 255u32 as $valty, [INFO] [stderr] | ^^^^^^ help: try: `f64::from(255u32)` [INFO] [stderr] ... [INFO] [stderr] 113 | / gen_hash!(I, f64, blocks, size, block_width, block_height, [INFO] [stderr] 114 | | |l: f64, r: f64| (l - r).abs() < FLOAT_EQ_MARGIN) [INFO] [stderr] | |_________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:47:15 [INFO] [stderr] | [INFO] [stderr] 47 | / (2u32 as $valty); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(2u32)` [INFO] [stderr] ... [INFO] [stderr] 113 | / gen_hash!(I, f64, blocks, size, block_width, block_height, [INFO] [stderr] 114 | | |l: f64, r: f64| (l - r).abs() < FLOAT_EQ_MARGIN) [INFO] [stderr] | |_________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:35:29 [INFO] [stderr] | [INFO] [stderr] 35 | let channel_count = <$imgty as HashImage>::channel_count() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(<$imgty as HashImage>::channel_count())` [INFO] [stderr] ... [INFO] [stderr] 134 | gen_hash!(I, u32, blocks, size, block_width, block_height, |l, r| l == r) [INFO] [stderr] | ------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stderr] --> src/block.rs:42:22 [INFO] [stderr] | [INFO] [stderr] 42 | 3 | 4 => 255u32 as $valty * 3u32 as $valty, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 134 | gen_hash!(I, u32, blocks, size, block_width, block_height, |l, r| l == r) [INFO] [stderr] | ------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stderr] [INFO] [stderr] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stderr] --> src/block.rs:42:41 [INFO] [stderr] | [INFO] [stderr] 42 | 3 | 4 => 255u32 as $valty * 3u32 as $valty, [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 134 | gen_hash!(I, u32, blocks, size, block_width, block_height, |l, r| l == r) [INFO] [stderr] | ------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stderr] [INFO] [stderr] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stderr] --> src/block.rs:43:22 [INFO] [stderr] | [INFO] [stderr] 43 | 2 | 1 => 255u32 as $valty, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 134 | gen_hash!(I, u32, blocks, size, block_width, block_height, |l, r| l == r) [INFO] [stderr] | ------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stderr] [INFO] [stderr] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stderr] --> src/block.rs:47:15 [INFO] [stderr] | [INFO] [stderr] 47 | / (2u32 as $valty); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 134 | gen_hash!(I, u32, blocks, size, block_width, block_height, |l, r| l == r) [INFO] [stderr] | ------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:142:14 [INFO] [stderr] | [INFO] [stderr] 142 | 3 => px[0] as u32 + px[1] as u32 + px[2] as u32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(px[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:142:29 [INFO] [stderr] | [INFO] [stderr] 142 | 3 => px[0] as u32 + px[1] as u32 + px[2] as u32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(px[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:142:44 [INFO] [stderr] | [INFO] [stderr] 142 | 3 => px[0] as u32 + px[1] as u32 + px[2] as u32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(px[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:143:43 [INFO] [stderr] | [INFO] [stderr] 143 | 2 => if px[1] == 0 { 255 } else { px[0] as u32 }, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(px[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:144:14 [INFO] [stderr] | [INFO] [stderr] 144 | 1 => px[0] as u32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(px[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:145:12 [INFO] [stderr] | [INFO] [stderr] 145 | if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:191:15 [INFO] [stderr] | [INFO] [stderr] 191 | fn as_ptr(&self) -> *const () { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | fn call(&self, data: &[f64], rowstride: Rowstride) -> Vec { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:320:54 [INFO] [stderr] | [INFO] [stderr] 320 | let mean = hash_values.iter().fold(0u32, |b, &a| a as u32 + b) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:323:37 [INFO] [stderr] | [INFO] [stderr] 323 | hash_values.into_iter().map(|x| x as u32 >= mean).collect() [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:334:32 [INFO] [stderr] | [INFO] [stderr] 334 | .into_iter().map(|val| (val as f64) / 255.0).collect(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `output` [INFO] [stderr] --> src/dct.rs:137:14 [INFO] [stderr] | [INFO] [stderr] 137 | for i in 0 .. len { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 137 | for (i, ) in output.iter_mut().enumerate().take(len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `input` [INFO] [stderr] --> src/dct.rs:140:18 [INFO] [stderr] | [INFO] [stderr] 140 | for j in 0 .. len { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 140 | for (j, ) in input.iter().enumerate().take(len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:68:40 [INFO] [stderr] | [INFO] [stderr] 68 | let (block_width, block_height) = (width as f64 / size as f64, height as f64 / size as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:68:55 [INFO] [stderr] | [INFO] [stderr] 68 | let (block_width, block_height) = (width as f64 / size as f64, height as f64 / size as f64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:68:68 [INFO] [stderr] | [INFO] [stderr] 68 | let (block_width, block_height) = (width as f64 / size as f64, height as f64 / size as f64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:68:84 [INFO] [stderr] | [INFO] [stderr] 68 | let (block_width, block_height) = (width as f64 / size as f64, height as f64 / size as f64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:73:22 [INFO] [stderr] | [INFO] [stderr] 73 | let px_sum = sum_px(px) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(sum_px(px))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:75:23 [INFO] [stderr] | [INFO] [stderr] 75 | let (x, y) = (x as f64, y as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:75:33 [INFO] [stderr] | [INFO] [stderr] 75 | let (x, y) = (x as f64, y as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:35:29 [INFO] [stderr] | [INFO] [stderr] 35 | let channel_count = <$imgty as HashImage>::channel_count() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(<$imgty as HashImage>::channel_count())` [INFO] [stderr] ... [INFO] [stderr] 113 | / gen_hash!(I, f64, blocks, size, block_width, block_height, [INFO] [stderr] 114 | | |l: f64, r: f64| (l - r).abs() < FLOAT_EQ_MARGIN) [INFO] [stderr] | |_________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:42:22 [INFO] [stderr] | [INFO] [stderr] 42 | 3 | 4 => 255u32 as $valty * 3u32 as $valty, [INFO] [stderr] | ^^^^^^ help: try: `f64::from(255u32)` [INFO] [stderr] ... [INFO] [stderr] 113 | / gen_hash!(I, f64, blocks, size, block_width, block_height, [INFO] [stderr] 114 | | |l: f64, r: f64| (l - r).abs() < FLOAT_EQ_MARGIN) [INFO] [stderr] | |_________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:42:41 [INFO] [stderr] | [INFO] [stderr] 42 | 3 | 4 => 255u32 as $valty * 3u32 as $valty, [INFO] [stderr] | ^^^^ help: try: `f64::from(3u32)` [INFO] [stderr] ... [INFO] [stderr] 113 | / gen_hash!(I, f64, blocks, size, block_width, block_height, [INFO] [stderr] 114 | | |l: f64, r: f64| (l - r).abs() < FLOAT_EQ_MARGIN) [INFO] [stderr] | |_________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:43:22 [INFO] [stderr] | [INFO] [stderr] 43 | 2 | 1 => 255u32 as $valty, [INFO] [stderr] | ^^^^^^ help: try: `f64::from(255u32)` [INFO] [stderr] ... [INFO] [stderr] 113 | / gen_hash!(I, f64, blocks, size, block_width, block_height, [INFO] [stderr] 114 | | |l: f64, r: f64| (l - r).abs() < FLOAT_EQ_MARGIN) [INFO] [stderr] | |_________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:47:15 [INFO] [stderr] | [INFO] [stderr] 47 | / (2u32 as $valty); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(2u32)` [INFO] [stderr] ... [INFO] [stderr] 113 | / gen_hash!(I, f64, blocks, size, block_width, block_height, [INFO] [stderr] 114 | | |l: f64, r: f64| (l - r).abs() < FLOAT_EQ_MARGIN) [INFO] [stderr] | |_________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:35:29 [INFO] [stderr] | [INFO] [stderr] 35 | let channel_count = <$imgty as HashImage>::channel_count() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(<$imgty as HashImage>::channel_count())` [INFO] [stderr] ... [INFO] [stderr] 134 | gen_hash!(I, u32, blocks, size, block_width, block_height, |l, r| l == r) [INFO] [stderr] | ------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stderr] --> src/block.rs:42:22 [INFO] [stderr] | [INFO] [stderr] 42 | 3 | 4 => 255u32 as $valty * 3u32 as $valty, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 134 | gen_hash!(I, u32, blocks, size, block_width, block_height, |l, r| l == r) [INFO] [stderr] | ------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stderr] [INFO] [stderr] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stderr] --> src/block.rs:42:41 [INFO] [stderr] | [INFO] [stderr] 42 | 3 | 4 => 255u32 as $valty * 3u32 as $valty, [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 134 | gen_hash!(I, u32, blocks, size, block_width, block_height, |l, r| l == r) [INFO] [stderr] | ------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stderr] [INFO] [stderr] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stderr] --> src/block.rs:43:22 [INFO] [stderr] | [INFO] [stderr] 43 | 2 | 1 => 255u32 as $valty, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 134 | gen_hash!(I, u32, blocks, size, block_width, block_height, |l, r| l == r) [INFO] [stderr] | ------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stderr] [INFO] [stderr] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stderr] --> src/block.rs:47:15 [INFO] [stderr] | [INFO] [stderr] 47 | / (2u32 as $valty); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 134 | gen_hash!(I, u32, blocks, size, block_width, block_height, |l, r| l == r) [INFO] [stderr] | ------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:142:14 [INFO] [stderr] | [INFO] [stderr] 142 | 3 => px[0] as u32 + px[1] as u32 + px[2] as u32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(px[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:142:29 [INFO] [stderr] | [INFO] [stderr] 142 | 3 => px[0] as u32 + px[1] as u32 + px[2] as u32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(px[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:142:44 [INFO] [stderr] | [INFO] [stderr] 142 | 3 => px[0] as u32 + px[1] as u32 + px[2] as u32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(px[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:143:43 [INFO] [stderr] | [INFO] [stderr] 143 | 2 => if px[1] == 0 { 255 } else { px[0] as u32 }, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(px[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:144:14 [INFO] [stderr] | [INFO] [stderr] 144 | 1 => px[0] as u32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(px[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:145:12 [INFO] [stderr] | [INFO] [stderr] 145 | if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:191:15 [INFO] [stderr] | [INFO] [stderr] 191 | fn as_ptr(&self) -> *const () { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | fn call(&self, data: &[f64], rowstride: Rowstride) -> Vec { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:320:54 [INFO] [stderr] | [INFO] [stderr] 320 | let mean = hash_values.iter().fold(0u32, |b, &a| a as u32 + b) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:323:37 [INFO] [stderr] | [INFO] [stderr] 323 | hash_values.into_iter().map(|x| x as u32 >= mean).collect() [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:334:32 [INFO] [stderr] | [INFO] [stderr] 334 | .into_iter().map(|val| (val as f64) / 255.0).collect(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.50s [INFO] running `"docker" "inspect" "1d694cbda6800d658eb92d85e28fbe9539d7a6c3d60b2361c105d0832eaf686b"` [INFO] running `"docker" "rm" "-f" "1d694cbda6800d658eb92d85e28fbe9539d7a6c3d60b2361c105d0832eaf686b"` [INFO] [stdout] 1d694cbda6800d658eb92d85e28fbe9539d7a6c3d60b2361c105d0832eaf686b