[INFO] crate img 0.1.0 is already in cache [INFO] extracting crate img 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/img/0.1.0 [INFO] extracting crate img 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/img/0.1.0 [INFO] validating manifest of img-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of img-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing img-0.1.0 [INFO] finished frobbing img-0.1.0 [INFO] frobbed toml for img-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/img/0.1.0/Cargo.toml [INFO] started frobbing img-0.1.0 [INFO] finished frobbing img-0.1.0 [INFO] frobbed toml for img-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/img/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting img-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/img/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 07dec416a40ecfcd11cb16b7a5e85637429ec0c1bc95a5d5126bcf447d973f19 [INFO] running `"docker" "start" "-a" "07dec416a40ecfcd11cb16b7a5e85637429ec0c1bc95a5d5126bcf447d973f19"` [INFO] [stderr] Checking img v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/impl_buffer.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/impl_buffer.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/impl_buffer.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | pitch: pitch, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `pitch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/impl_buffer.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/impl_buffer.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/impl_buffer.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | pitch: pitch, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `pitch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/px/impl_gray.rs:40:50 [INFO] [stderr] | [INFO] [stderr] 40 | let intensity: &mut BaseTypeP = unsafe { transmute(&mut buffer[start]) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut buffer[start] as *mut u8 as *mut BaseTypeP)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/image/impl_core.rs:75:36 [INFO] [stderr] | [INFO] [stderr] 75 | self.0.get_pixel(x, y).map(|v| PixelVal(v)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `PixelVal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: where clauses are not enforced in type aliases [INFO] [stderr] --> src/image/impl_buffer.rs:18:39 [INFO] [stderr] | [INFO] [stderr] 18 | pub type ImageBufferVal where PixelP: Pixel = ImageVal>; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(type_alias_bounds)] on by default [INFO] [stderr] = help: the clause will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/image/impl_buffer.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | .expect(&format!("Invalid combindation of width ({:}), height ({:}) and pitch ({:}) \ [INFO] [stderr] | ______________^ [INFO] [stderr] 33 | | for this pixel type", [INFO] [stderr] 34 | | width, [INFO] [stderr] 35 | | height, [INFO] [stderr] 36 | | pitch)); [INFO] [stderr] | |____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | .unwrap_or_else(|| panic!("Invalid combindation of width ({:}), height ({:}) and pitch ({:}) \ [INFO] [stderr] 33 | for this pixel type", width)); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/image/impl_buffer.rs:58:14 [INFO] [stderr] | [INFO] [stderr] 58 | .expect(&format!("Invalid combindation of width ({:}), height ({:}) and pitch ({:}) \ [INFO] [stderr] | ______________^ [INFO] [stderr] 59 | | for this pixel type - for an image ALREADY CREATED", [INFO] [stderr] 60 | | self.width, [INFO] [stderr] 61 | | self.height, [INFO] [stderr] 62 | | self.pitch)) [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | .unwrap_or_else(|| panic!("Invalid combindation of width ({:}), height ({:}) and pitch ({:}) \ [INFO] [stderr] 59 | for this pixel type - for an image ALREADY CREATED", self.width)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> src/scalar/mod.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | a + b; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/scalar/mod.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | a + b; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: unused comparison that must be used [INFO] [stderr] --> src/scalar/mod.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | a == b; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/scalar/mod.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | a == b; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/px/impl_gray.rs:40:50 [INFO] [stderr] | [INFO] [stderr] 40 | let intensity: &mut BaseTypeP = unsafe { transmute(&mut buffer[start]) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut buffer[start] as *mut u8 as *mut BaseTypeP)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/image/impl_core.rs:75:36 [INFO] [stderr] | [INFO] [stderr] 75 | self.0.get_pixel(x, y).map(|v| PixelVal(v)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `PixelVal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: where clauses are not enforced in type aliases [INFO] [stderr] --> src/image/impl_buffer.rs:18:39 [INFO] [stderr] | [INFO] [stderr] 18 | pub type ImageBufferVal where PixelP: Pixel = ImageVal>; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(type_alias_bounds)] on by default [INFO] [stderr] = help: the clause will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/image/impl_buffer.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | .expect(&format!("Invalid combindation of width ({:}), height ({:}) and pitch ({:}) \ [INFO] [stderr] | ______________^ [INFO] [stderr] 33 | | for this pixel type", [INFO] [stderr] 34 | | width, [INFO] [stderr] 35 | | height, [INFO] [stderr] 36 | | pitch)); [INFO] [stderr] | |____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | .unwrap_or_else(|| panic!("Invalid combindation of width ({:}), height ({:}) and pitch ({:}) \ [INFO] [stderr] 33 | for this pixel type", width)); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/image/impl_buffer.rs:58:14 [INFO] [stderr] | [INFO] [stderr] 58 | .expect(&format!("Invalid combindation of width ({:}), height ({:}) and pitch ({:}) \ [INFO] [stderr] | ______________^ [INFO] [stderr] 59 | | for this pixel type - for an image ALREADY CREATED", [INFO] [stderr] 60 | | self.width, [INFO] [stderr] 61 | | self.height, [INFO] [stderr] 62 | | self.pitch)) [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | .unwrap_or_else(|| panic!("Invalid combindation of width ({:}), height ({:}) and pitch ({:}) \ [INFO] [stderr] 59 | for this pixel type - for an image ALREADY CREATED", self.width)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.09s [INFO] running `"docker" "inspect" "07dec416a40ecfcd11cb16b7a5e85637429ec0c1bc95a5d5126bcf447d973f19"` [INFO] running `"docker" "rm" "-f" "07dec416a40ecfcd11cb16b7a5e85637429ec0c1bc95a5d5126bcf447d973f19"` [INFO] [stdout] 07dec416a40ecfcd11cb16b7a5e85637429ec0c1bc95a5d5126bcf447d973f19