[INFO] crate imdb-index 0.1.1 is already in cache [INFO] extracting crate imdb-index 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/imdb-index/0.1.1 [INFO] extracting crate imdb-index 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/imdb-index/0.1.1 [INFO] validating manifest of imdb-index-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of imdb-index-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing imdb-index-0.1.1 [INFO] finished frobbing imdb-index-0.1.1 [INFO] frobbed toml for imdb-index-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/imdb-index/0.1.1/Cargo.toml [INFO] started frobbing imdb-index-0.1.1 [INFO] finished frobbing imdb-index-0.1.1 [INFO] frobbed toml for imdb-index-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/imdb-index/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting imdb-index-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/imdb-index/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 617e05463fde81029b27bbd9db069f6232044de575f86d06d6f0463897f1002a [INFO] running `"docker" "start" "-a" "617e05463fde81029b27bbd9db069f6232044de575f86d06d6f0463897f1002a"` [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking fst v0.3.3 [INFO] [stderr] Checking imdb-index v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/aka.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | rdr: rdr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rdr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/episode.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | seasons: seasons, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `seasons` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/episode.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | tvshows: tvshows, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `tvshows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/episode.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/episode.rs:217:9 [INFO] [stderr] | [INFO] [stderr] 217 | tvshow_id: tvshow_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tvshow_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/episode.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | season: season, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `season` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/episode.rs:257:9 [INFO] [stderr] | [INFO] [stderr] 257 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/episode.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | tvshow_id: tvshow_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tvshow_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/episode.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | season: season, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `season` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:243:13 [INFO] [stderr] | [INFO] [stderr] 243 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | ngram: ngram, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ngram` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:245:13 [INFO] [stderr] | [INFO] [stderr] 245 | postings: postings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `postings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:246:13 [INFO] [stderr] | [INFO] [stderr] 246 | idmap: idmap, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `idmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | norms: norms, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `norms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:301:13 [INFO] [stderr] | [INFO] [stderr] 301 | k: k, [INFO] [stderr] | ^^^^ help: replace it with: `k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:530:13 [INFO] [stderr] | [INFO] [stderr] 530 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:532:13 [INFO] [stderr] | [INFO] [stderr] 532 | scorer: scorer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `scorer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:752:21 [INFO] [stderr] | [INFO] [stderr] 752 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:753:21 [INFO] [stderr] | [INFO] [stderr] 753 | scorer: scorer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `scorer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:771:13 [INFO] [stderr] | [INFO] [stderr] 771 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:772:13 [INFO] [stderr] | [INFO] [stderr] 772 | scorer: scorer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `scorer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:775:13 [INFO] [stderr] | [INFO] [stderr] 775 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:778:13 [INFO] [stderr] | [INFO] [stderr] 778 | okapi_idf: okapi_idf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `okapi_idf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:1006:13 [INFO] [stderr] | [INFO] [stderr] 1006 | ngram: ngram, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ngram` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:1007:13 [INFO] [stderr] | [INFO] [stderr] 1007 | ngram_type: ngram_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ngram_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:1008:13 [INFO] [stderr] | [INFO] [stderr] 1008 | ngram_size: ngram_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ngram_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:1009:13 [INFO] [stderr] | [INFO] [stderr] 1009 | postings: postings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `postings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:1010:13 [INFO] [stderr] | [INFO] [stderr] 1010 | idmap: idmap, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `idmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:1011:13 [INFO] [stderr] | [INFO] [stderr] 1011 | norms: norms, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `norms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:1012:13 [INFO] [stderr] | [INFO] [stderr] 1012 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:1117:38 [INFO] [stderr] | [INFO] [stderr] 1117 | self.list.push(Posting { docid: docid, frequency: 0 }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `docid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/rating.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/writer.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | wtr: wtr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `wtr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scored.rs:121:30 [INFO] [stderr] | [INFO] [stderr] 121 | Scored { score: 1.0, value: value } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/aka.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | rdr: rdr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rdr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/episode.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | seasons: seasons, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `seasons` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/episode.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | tvshows: tvshows, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `tvshows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/episode.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/episode.rs:217:9 [INFO] [stderr] | [INFO] [stderr] 217 | tvshow_id: tvshow_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tvshow_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/episode.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | season: season, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `season` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/episode.rs:257:9 [INFO] [stderr] | [INFO] [stderr] 257 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/episode.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | tvshow_id: tvshow_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tvshow_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/episode.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | season: season, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `season` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:243:13 [INFO] [stderr] | [INFO] [stderr] 243 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | ngram: ngram, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ngram` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:245:13 [INFO] [stderr] | [INFO] [stderr] 245 | postings: postings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `postings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:246:13 [INFO] [stderr] | [INFO] [stderr] 246 | idmap: idmap, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `idmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | norms: norms, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `norms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:301:13 [INFO] [stderr] | [INFO] [stderr] 301 | k: k, [INFO] [stderr] | ^^^^ help: replace it with: `k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:530:13 [INFO] [stderr] | [INFO] [stderr] 530 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:532:13 [INFO] [stderr] | [INFO] [stderr] 532 | scorer: scorer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `scorer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:752:21 [INFO] [stderr] | [INFO] [stderr] 752 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:753:21 [INFO] [stderr] | [INFO] [stderr] 753 | scorer: scorer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `scorer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:771:13 [INFO] [stderr] | [INFO] [stderr] 771 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:772:13 [INFO] [stderr] | [INFO] [stderr] 772 | scorer: scorer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `scorer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:775:13 [INFO] [stderr] | [INFO] [stderr] 775 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:778:13 [INFO] [stderr] | [INFO] [stderr] 778 | okapi_idf: okapi_idf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `okapi_idf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:1006:13 [INFO] [stderr] | [INFO] [stderr] 1006 | ngram: ngram, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ngram` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:1007:13 [INFO] [stderr] | [INFO] [stderr] 1007 | ngram_type: ngram_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ngram_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:1008:13 [INFO] [stderr] | [INFO] [stderr] 1008 | ngram_size: ngram_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ngram_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:1009:13 [INFO] [stderr] | [INFO] [stderr] 1009 | postings: postings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `postings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:1010:13 [INFO] [stderr] | [INFO] [stderr] 1010 | idmap: idmap, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `idmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:1011:13 [INFO] [stderr] | [INFO] [stderr] 1011 | norms: norms, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `norms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:1012:13 [INFO] [stderr] | [INFO] [stderr] 1012 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/names.rs:1117:38 [INFO] [stderr] | [INFO] [stderr] 1117 | self.list.push(Posting { docid: docid, frequency: 0 }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `docid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/rating.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index/writer.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | wtr: wtr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `wtr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scored.rs:121:30 [INFO] [stderr] | [INFO] [stderr] 121 | Scored { score: 1.0, value: value } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/index/aka.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | / if self.record.is_empty() { [INFO] [stderr] 183 | | if !itry!(self.rdr.read_byte_record(&mut self.record)) { [INFO] [stderr] 184 | | return None; [INFO] [stderr] 185 | | } [INFO] [stderr] 186 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 182 | if self.record.is_empty() && !itry!(self.rdr.read_byte_record(&mut self.record)) { [INFO] [stderr] 183 | return None; [INFO] [stderr] 184 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/index/aka.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | / if self.record.is_empty() { [INFO] [stderr] 183 | | if !itry!(self.rdr.read_byte_record(&mut self.record)) { [INFO] [stderr] 184 | | return None; [INFO] [stderr] 185 | | } [INFO] [stderr] 186 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 182 | if self.record.is_empty() && !itry!(self.rdr.read_byte_record(&mut self.record)) { [INFO] [stderr] 183 | return None; [INFO] [stderr] 184 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/index/names.rs:1373:20 [INFO] [stderr] | [INFO] [stderr] 1373 | const BRUCES: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/index/names.rs:1373:30 [INFO] [stderr] | [INFO] [stderr] 1373 | const BRUCES: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/index/episode.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | / while let Some(tvshow_bytes) = stream.next() { [INFO] [stderr] 159 | | return Ok(Some(read_tvshow(tvshow_bytes)?)); [INFO] [stderr] 160 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/index/names.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | LE::read_u16(&self.norms[2 * (docid as usize)..]) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(LE::read_u16(&self.norms[2 * (docid as usize)..]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/index/names.rs:826:18 [INFO] [stderr] | [INFO] [stderr] 826 | let tf = post.frequency as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(post.frequency)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/index/names.rs:844:18 [INFO] [stderr] | [INFO] [stderr] 844 | let tf = post.frequency as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(post.frequency)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/index/names.rs:1046:28 [INFO] [stderr] | [INFO] [stderr] 1046 | num_documents: num_docs as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(num_docs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/index/names.rs:1063:9 [INFO] [stderr] | [INFO] [stderr] 1063 | self.ngram_type.clone().iter(self.ngram_size, &name, |ngram| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.ngram_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/index/names.rs:1071:14 [INFO] [stderr] | [INFO] [stderr] 1071 | (count as f64 - self.avg_document_len) / (self.num_docs() as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/index/names.rs:1071:54 [INFO] [stderr] | [INFO] [stderr] 1071 | (count as f64 - self.avg_document_len) / (self.num_docs() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.num_docs())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/index/names.rs:1157:19 [INFO] [stderr] | [INFO] [stderr] 1157 | pub fn as_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/index/names.rs:1239:19 [INFO] [stderr] | [INFO] [stderr] 1239 | pub fn as_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/index/names.rs:1252:9 [INFO] [stderr] | [INFO] [stderr] 1252 | &self, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/index/rating.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | / while let Some(rating_bytes) = stream.next() { [INFO] [stderr] 74 | | return Ok(Some(read_rating(rating_bytes)?)); [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/record.rs:101:19 [INFO] [stderr] | [INFO] [stderr] 101 | pub fn as_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/record.rs:118:25 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn is_tv_series(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/scored.rs:33:55 [INFO] [stderr] | [INFO] [stderr] 33 | assert!(self.0.last().map_or(true, |smallest| &scored <= smallest)); [INFO] [stderr] | -------^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `scored` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/search.rs:514:9 [INFO] [stderr] | [INFO] [stderr] 514 | / !self.season.is_none() [INFO] [stderr] 515 | | || !self.episode.is_none() [INFO] [stderr] 516 | | || !self.tvshow_id.is_none() [INFO] [stderr] | |____________________________________^ help: try: `!self.season.is_none() || !self.episode.is_none() || self.tvshow_id.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/search.rs:677:20 [INFO] [stderr] | [INFO] [stderr] 677 | pub fn is_none(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/search.rs:686:23 [INFO] [stderr] | [INFO] [stderr] 686 | pub fn similarity(&self, q1: &str, q2: &str) -> f64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:61:26 [INFO] [stderr] | [INFO] [stderr] 61 | let fractional = (self.0.subsec_nanos() as f64) / 1_000_000_000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.0.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `imdb-index`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/index/episode.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | / while let Some(tvshow_bytes) = stream.next() { [INFO] [stderr] 159 | | return Ok(Some(read_tvshow(tvshow_bytes)?)); [INFO] [stderr] 160 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/index/names.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | LE::read_u16(&self.norms[2 * (docid as usize)..]) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(LE::read_u16(&self.norms[2 * (docid as usize)..]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/index/names.rs:826:18 [INFO] [stderr] | [INFO] [stderr] 826 | let tf = post.frequency as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(post.frequency)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/index/names.rs:844:18 [INFO] [stderr] | [INFO] [stderr] 844 | let tf = post.frequency as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(post.frequency)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/index/names.rs:1046:28 [INFO] [stderr] | [INFO] [stderr] 1046 | num_documents: num_docs as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(num_docs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/index/names.rs:1063:9 [INFO] [stderr] | [INFO] [stderr] 1063 | self.ngram_type.clone().iter(self.ngram_size, &name, |ngram| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.ngram_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/index/names.rs:1071:14 [INFO] [stderr] | [INFO] [stderr] 1071 | (count as f64 - self.avg_document_len) / (self.num_docs() as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/index/names.rs:1071:54 [INFO] [stderr] | [INFO] [stderr] 1071 | (count as f64 - self.avg_document_len) / (self.num_docs() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.num_docs())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/index/names.rs:1157:19 [INFO] [stderr] | [INFO] [stderr] 1157 | pub fn as_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/index/names.rs:1239:19 [INFO] [stderr] | [INFO] [stderr] 1239 | pub fn as_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/index/names.rs:1252:9 [INFO] [stderr] | [INFO] [stderr] 1252 | &self, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/index/names.rs:1394:9 [INFO] [stderr] | [INFO] [stderr] 1394 | assert_eq!(results[0].score(), 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/index/names.rs:1394:9 [INFO] [stderr] | [INFO] [stderr] 1394 | assert_eq!(results[0].score(), 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/index/names.rs:1395:9 [INFO] [stderr] | [INFO] [stderr] 1395 | assert_eq!(results[1].score(), 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/index/names.rs:1395:9 [INFO] [stderr] | [INFO] [stderr] 1395 | assert_eq!(results[1].score(), 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/index/rating.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | / while let Some(rating_bytes) = stream.next() { [INFO] [stderr] 74 | | return Ok(Some(read_rating(rating_bytes)?)); [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/index/rating.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | assert_eq!(rat.rating, 5.8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/index/rating.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | assert_eq!(rat.rating, 5.8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/record.rs:101:19 [INFO] [stderr] | [INFO] [stderr] 101 | pub fn as_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/record.rs:118:25 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn is_tv_series(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/scored.rs:33:55 [INFO] [stderr] | [INFO] [stderr] 33 | assert!(self.0.last().map_or(true, |smallest| &scored <= smallest)); [INFO] [stderr] | -------^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `scored` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/search.rs:514:9 [INFO] [stderr] | [INFO] [stderr] 514 | / !self.season.is_none() [INFO] [stderr] 515 | | || !self.episode.is_none() [INFO] [stderr] 516 | | || !self.tvshow_id.is_none() [INFO] [stderr] | |____________________________________^ help: try: `!self.season.is_none() || !self.episode.is_none() || self.tvshow_id.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/search.rs:677:20 [INFO] [stderr] | [INFO] [stderr] 677 | pub fn is_none(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/search.rs:686:23 [INFO] [stderr] | [INFO] [stderr] 686 | pub fn similarity(&self, q1: &str, q2: &str) -> f64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:61:26 [INFO] [stderr] | [INFO] [stderr] 61 | let fractional = (self.0.subsec_nanos() as f64) / 1_000_000_000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.0.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `imdb-index`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "617e05463fde81029b27bbd9db069f6232044de575f86d06d6f0463897f1002a"` [INFO] running `"docker" "rm" "-f" "617e05463fde81029b27bbd9db069f6232044de575f86d06d6f0463897f1002a"` [INFO] [stdout] 617e05463fde81029b27bbd9db069f6232044de575f86d06d6f0463897f1002a