[INFO] crate imap-proto 0.7.0 is already in cache [INFO] extracting crate imap-proto 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/imap-proto/0.7.0 [INFO] extracting crate imap-proto 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/imap-proto/0.7.0 [INFO] validating manifest of imap-proto-0.7.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of imap-proto-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing imap-proto-0.7.0 [INFO] finished frobbing imap-proto-0.7.0 [INFO] frobbed toml for imap-proto-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/imap-proto/0.7.0/Cargo.toml [INFO] started frobbing imap-proto-0.7.0 [INFO] finished frobbing imap-proto-0.7.0 [INFO] frobbed toml for imap-proto-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/imap-proto/0.7.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting imap-proto-0.7.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/imap-proto/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 984d84205f3be43be06c52b0e4443896b75a078bbc397bfda60abe86d597eb9c [INFO] running `"docker" "start" "-a" "984d84205f3be43be06c52b0e4443896b75a078bbc397bfda60abe86d597eb9c"` [INFO] [stderr] Checking imap-proto v0.7.0 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/parser.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/parser.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_closure` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/parser.rs:3:45 [INFO] [stderr] | [INFO] [stderr] 3 | #![cfg_attr(feature = "cargo-clippy", allow(redundant_closure))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_closure` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_closure` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/parser.rs:3:45 [INFO] [stderr] | [INFO] [stderr] 3 | #![cfg_attr(feature = "cargo-clippy", allow(redundant_closure))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_closure` [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_closure` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/parser.rs:3:45 [INFO] [stderr] | [INFO] [stderr] 3 | #![cfg_attr(feature = "cargo-clippy", allow(redundant_closure))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_closure` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_closure` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/parser.rs:3:45 [INFO] [stderr] | [INFO] [stderr] 3 | #![cfg_attr(feature = "cargo-clippy", allow(redundant_closure))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_closure` [INFO] [stderr] [INFO] [stderr] warning: the `rsp @ _` pattern can be written as just `rsp` [INFO] [stderr] --> src/parser.rs:723:13 [INFO] [stderr] | [INFO] [stderr] 723 | rsp @ _ => panic!("unexpected response {:?}", rsp), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `rsp @ _` pattern can be written as just `rsp` [INFO] [stderr] --> src/parser.rs:738:13 [INFO] [stderr] | [INFO] [stderr] 738 | rsp @ _ => panic!("unexpected response {:?}", rsp), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `rsp @ _` pattern can be written as just `rsp` [INFO] [stderr] --> src/parser.rs:752:13 [INFO] [stderr] | [INFO] [stderr] 752 | rsp @ _ => panic!("unexpected response {:?}", rsp), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `rsp @ _` pattern can be written as just `rsp` [INFO] [stderr] --> src/parser.rs:760:13 [INFO] [stderr] | [INFO] [stderr] 760 | rsp @ _ => panic!("unexpected response {:?}", rsp), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `rsp @ _` pattern can be written as just `rsp` [INFO] [stderr] --> src/parser.rs:764:13 [INFO] [stderr] | [INFO] [stderr] 764 | rsp @ _ => panic!("unexpected response {:?}", rsp), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `rsp @ _` pattern can be written as just `rsp` [INFO] [stderr] --> src/parser.rs:768:13 [INFO] [stderr] | [INFO] [stderr] 768 | rsp @ _ => panic!("unexpected response {:?}", rsp), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `rsp @ _` pattern can be written as just `rsp` [INFO] [stderr] --> src/parser.rs:778:13 [INFO] [stderr] | [INFO] [stderr] 778 | rsp @ _ => panic!("unexpected response {:?}", rsp), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `rsp @ _` pattern can be written as just `rsp` [INFO] [stderr] --> src/parser.rs:785:13 [INFO] [stderr] | [INFO] [stderr] 785 | rsp @ _ => panic!("unexpected response {:?}", rsp), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parser.rs:801:35 [INFO] [stderr] | [INFO] [stderr] 801 | assert_eq!(value, "XYZ".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"XYZ"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parser.rs:811:35 [INFO] [stderr] | [INFO] [stderr] 811 | assert_eq!(value, "text".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"text"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: the `rsp @ _` pattern can be written as just `rsp` [INFO] [stderr] --> src/parser.rs:828:13 [INFO] [stderr] | [INFO] [stderr] 828 | rsp @ _ => panic!("unexpected response {:?}", rsp), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.13s [INFO] running `"docker" "inspect" "984d84205f3be43be06c52b0e4443896b75a078bbc397bfda60abe86d597eb9c"` [INFO] running `"docker" "rm" "-f" "984d84205f3be43be06c52b0e4443896b75a078bbc397bfda60abe86d597eb9c"` [INFO] [stdout] 984d84205f3be43be06c52b0e4443896b75a078bbc397bfda60abe86d597eb9c