[INFO] crate imap 0.10.0 is already in cache [INFO] extracting crate imap 0.10.0 into work/ex/clippy-test-run/sources/stable/reg/imap/0.10.0 [INFO] extracting crate imap 0.10.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/imap/0.10.0 [INFO] validating manifest of imap-0.10.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of imap-0.10.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing imap-0.10.0 [INFO] finished frobbing imap-0.10.0 [INFO] frobbed toml for imap-0.10.0 written to work/ex/clippy-test-run/sources/stable/reg/imap/0.10.0/Cargo.toml [INFO] started frobbing imap-0.10.0 [INFO] finished frobbing imap-0.10.0 [INFO] frobbed toml for imap-0.10.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/imap/0.10.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting imap-0.10.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/imap/0.10.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fc63f97165d95caa3b97f4c32f7780e95b8453edffcc590e822ffbc6b3c60d61 [INFO] running `"docker" "start" "-a" "fc63f97165d95caa3b97f4c32f7780e95b8453edffcc590e822ffbc6b3c60d61"` [INFO] [stderr] Checking imap-proto v0.7.0 [INFO] [stderr] Checking lettre-openssl111 v0.9.0 [INFO] [stderr] Checking imap v0.10.0 (/opt/crater/workdir) [INFO] [stderr] Checking lettre-openssl111_email v0.9.0 [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parse.rs:399:41 [INFO] [stderr] | [INFO] [stderr] 399 | assert_eq!(fetches[0].uid, Some(4827943)); [INFO] [stderr] | ^^^^^^^ help: consider: `4_827_943` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parse.rs:464:50 [INFO] [stderr] | [INFO] [stderr] 464 | StatusAttribute::UidValidity(1408806928), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_408_806_928` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parse.rs:491:50 [INFO] [stderr] | [INFO] [stderr] 491 | StatusAttribute::UidValidity(1408806928), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_408_806_928` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/client.rs:1515:32 [INFO] [stderr] | [INFO] [stderr] 1515 | uid_validity: Some(1257842737), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_257_842_737` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/client.rs:1561:32 [INFO] [stderr] | [INFO] [stderr] 1561 | uid_validity: Some(1257842737), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_257_842_737` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client.rs:1392:23 [INFO] [stderr] | [INFO] [stderr] 1392 | let command = format!("a1 LOGOUT\r\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"a1 LOGOUT\r\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client.rs:1812:13 [INFO] [stderr] | [INFO] [stderr] 1812 | / if let &Error::Validate(ref ve) = e { [INFO] [stderr] 1813 | | if ve.0 == '\n' { [INFO] [stderr] 1814 | | return; [INFO] [stderr] 1815 | | } [INFO] [stderr] 1816 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1812 | if let Error::Validate(ref ve) = *e { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client.rs:1826:13 [INFO] [stderr] | [INFO] [stderr] 1826 | / if let &Error::Validate(ref ve) = e { [INFO] [stderr] 1827 | | if ve.0 == '\r' { [INFO] [stderr] 1828 | | return; [INFO] [stderr] 1829 | | } [INFO] [stderr] 1830 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1826 | if let Error::Validate(ref ve) = *e { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 24.12s [INFO] running `"docker" "inspect" "fc63f97165d95caa3b97f4c32f7780e95b8453edffcc590e822ffbc6b3c60d61"` [INFO] running `"docker" "rm" "-f" "fc63f97165d95caa3b97f4c32f7780e95b8453edffcc590e822ffbc6b3c60d61"` [INFO] [stdout] fc63f97165d95caa3b97f4c32f7780e95b8453edffcc590e822ffbc6b3c60d61