[INFO] crate imagepipe 0.2.0 is already in cache [INFO] extracting crate imagepipe 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/imagepipe/0.2.0 [INFO] extracting crate imagepipe 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/imagepipe/0.2.0 [INFO] validating manifest of imagepipe-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of imagepipe-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing imagepipe-0.2.0 [INFO] finished frobbing imagepipe-0.2.0 [INFO] frobbed toml for imagepipe-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/imagepipe/0.2.0/Cargo.toml [INFO] started frobbing imagepipe-0.2.0 [INFO] finished frobbing imagepipe-0.2.0 [INFO] frobbed toml for imagepipe-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/imagepipe/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting imagepipe-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/imagepipe/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 983a0b23e9ffc8e94059561ae7a3ee8976890792180d5883c92d59d620f440b6 [INFO] running `"docker" "start" "-a" "983a0b23e9ffc8e94059561ae7a3ee8976890792180d5883c92d59d620f440b6"` [INFO] [stderr] Compiling arrayvec v0.4.10 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Checking lazy_static v1.2.0 [INFO] [stderr] Compiling proc-macro2 v0.4.26 [INFO] [stderr] Compiling serde v1.0.85 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling typenum v1.10.0 [INFO] [stderr] Compiling num-bigint v0.2.2 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Compiling rayon-core v1.4.1 [INFO] [stderr] Compiling num-iter v0.1.37 [INFO] [stderr] Compiling rayon v1.0.3 [INFO] [stderr] Compiling num-complex v0.2.1 [INFO] [stderr] Compiling num-rational v0.2.1 [INFO] [stderr] Checking adler32 v1.0.3 [INFO] [stderr] Compiling glob v0.2.11 [INFO] [stderr] Compiling num-derive v0.2.4 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking byte-tools v0.2.0 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking linked-hash-map v0.5.1 [INFO] [stderr] Checking dtoa v0.4.3 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking inflate v0.4.4 [INFO] [stderr] Checking itertools v0.7.11 [INFO] [stderr] Checking gif v0.10.1 [INFO] [stderr] Checking yaml-rust v0.4.2 [INFO] [stderr] Checking multicache v0.5.0 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking generic-array v0.8.3 [INFO] [stderr] Checking num_cpus v1.9.0 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking block-buffer v0.2.0 [INFO] [stderr] Checking digest v0.6.2 [INFO] [stderr] Checking deflate v0.7.19 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Compiling quote v0.6.11 [INFO] [stderr] Checking sha2 v0.6.0 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Compiling toml v0.4.10 [INFO] [stderr] Checking bincode v1.0.1 [INFO] [stderr] Checking serde_yaml v0.7.5 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Compiling rawloader v0.35.4 [INFO] [stderr] Compiling serde_derive v1.0.85 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking imagepipe v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:24:7 [INFO] [stderr] | [INFO] [stderr] 24 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:25:7 [INFO] [stderr] | [INFO] [stderr] 25 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:26:7 [INFO] [stderr] | [INFO] [stderr] 26 | colors: colors, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `colors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:85:7 [INFO] [stderr] | [INFO] [stderr] 85 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:86:7 [INFO] [stderr] | [INFO] [stderr] 86 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:87:7 [INFO] [stderr] | [INFO] [stderr] 87 | colors: colors, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `colors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | let x = r * cmatrix[0][0] + g * cmatrix[0][1] + b * cmatrix[0][2] + e * cmatrix[0][3]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | let y = r * cmatrix[1][0] + g * cmatrix[1][1] + b * cmatrix[1][2] + e * cmatrix[1][3]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | let z = r * cmatrix[2][0] + g * cmatrix[2][1] + b * cmatrix[2][2] + e * cmatrix[2][3]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | let (l,a,b) = xyz_to_lab(x,y,z); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:32:16 [INFO] [stderr] | [INFO] [stderr] 32 | let (l,a,b) = xyz_to_lab(x,y,z); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:63:16 [INFO] [stderr] | [INFO] [stderr] 63 | let (x,y,z) = lab_to_xyz(l,a,b); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | let (x,y,z) = lab_to_xyz(l,a,b); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | let r = x * cmatrix[0][0] + y * cmatrix[0][1] + z * cmatrix[0][2]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | let g = x * cmatrix[1][0] + y * cmatrix[1][1] + z * cmatrix[1][2]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:114:7 [INFO] [stderr] | [INFO] [stderr] 114 | let a = 500.0 * (labf(x/xw) - labf(y/yw)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:115:7 [INFO] [stderr] | [INFO] [stderr] 115 | let b = 200.0 * (labf(y/yw) - labf(z/zw)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:157:7 [INFO] [stderr] | [INFO] [stderr] 157 | let y = yw * labinvf((1.0/116.0) * (cl+16.0)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:158:7 [INFO] [stderr] | [INFO] [stderr] 158 | let z = zw * labinvf((1.0/116.0) * (cl+16.0) - (1.0/200.0) * cb); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ops/curves.rs:93:7 [INFO] [stderr] | [INFO] [stderr] 93 | points: points, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ops/curves.rs:94:7 [INFO] [stderr] | [INFO] [stderr] 94 | c1s: c1s, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `c1s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ops/curves.rs:95:7 [INFO] [stderr] | [INFO] [stderr] 95 | c2s: c2s, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `c2s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ops/curves.rs:96:7 [INFO] [stderr] | [INFO] [stderr] 96 | c3s: c3s, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `c3s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:30:7 [INFO] [stderr] | [INFO] [stderr] 30 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:31:7 [INFO] [stderr] | [INFO] [stderr] 31 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:24:7 [INFO] [stderr] | [INFO] [stderr] 24 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:25:7 [INFO] [stderr] | [INFO] [stderr] 25 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:26:7 [INFO] [stderr] | [INFO] [stderr] 26 | colors: colors, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `colors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:85:7 [INFO] [stderr] | [INFO] [stderr] 85 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:86:7 [INFO] [stderr] | [INFO] [stderr] 86 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:87:7 [INFO] [stderr] | [INFO] [stderr] 87 | colors: colors, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `colors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | let x = r * cmatrix[0][0] + g * cmatrix[0][1] + b * cmatrix[0][2] + e * cmatrix[0][3]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | let y = r * cmatrix[1][0] + g * cmatrix[1][1] + b * cmatrix[1][2] + e * cmatrix[1][3]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | let z = r * cmatrix[2][0] + g * cmatrix[2][1] + b * cmatrix[2][2] + e * cmatrix[2][3]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | let (l,a,b) = xyz_to_lab(x,y,z); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:32:16 [INFO] [stderr] | [INFO] [stderr] 32 | let (l,a,b) = xyz_to_lab(x,y,z); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:63:16 [INFO] [stderr] | [INFO] [stderr] 63 | let (x,y,z) = lab_to_xyz(l,a,b); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | let (x,y,z) = lab_to_xyz(l,a,b); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | let r = x * cmatrix[0][0] + y * cmatrix[0][1] + z * cmatrix[0][2]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | let g = x * cmatrix[1][0] + y * cmatrix[1][1] + z * cmatrix[1][2]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:114:7 [INFO] [stderr] | [INFO] [stderr] 114 | let a = 500.0 * (labf(x/xw) - labf(y/yw)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:115:7 [INFO] [stderr] | [INFO] [stderr] 115 | let b = 200.0 * (labf(y/yw) - labf(z/zw)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:157:7 [INFO] [stderr] | [INFO] [stderr] 157 | let y = yw * labinvf((1.0/116.0) * (cl+16.0)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ops/colorspaces.rs:158:7 [INFO] [stderr] | [INFO] [stderr] 158 | let z = zw * labinvf((1.0/116.0) * (cl+16.0) - (1.0/200.0) * cb); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ops/curves.rs:93:7 [INFO] [stderr] | [INFO] [stderr] 93 | points: points, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ops/curves.rs:94:7 [INFO] [stderr] | [INFO] [stderr] 94 | c1s: c1s, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `c1s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ops/curves.rs:95:7 [INFO] [stderr] | [INFO] [stderr] 95 | c2s: c2s, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `c2s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ops/curves.rs:96:7 [INFO] [stderr] | [INFO] [stderr] 96 | c3s: c3s, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `c3s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:30:7 [INFO] [stderr] | [INFO] [stderr] 30 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:31:7 [INFO] [stderr] | [INFO] [stderr] 31 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/colorspaces.rs:101:7 [INFO] [stderr] | [INFO] [stderr] 101 | [ 0.412453, 0.357580, 0.180423 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.412_453` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/colorspaces.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | [ 0.412453, 0.357580, 0.180423 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.357_580` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/colorspaces.rs:101:27 [INFO] [stderr] | [INFO] [stderr] 101 | [ 0.412453, 0.357580, 0.180423 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.180_423` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/colorspaces.rs:102:7 [INFO] [stderr] | [INFO] [stderr] 102 | [ 0.212671, 0.715160, 0.072169 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.212_671` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/colorspaces.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | [ 0.212671, 0.715160, 0.072169 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.715_160` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/colorspaces.rs:102:27 [INFO] [stderr] | [INFO] [stderr] 102 | [ 0.212671, 0.715160, 0.072169 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.072_169` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/colorspaces.rs:103:7 [INFO] [stderr] | [INFO] [stderr] 103 | [ 0.019334, 0.119193, 0.950227 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.019_334` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/colorspaces.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | [ 0.019334, 0.119193, 0.950227 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.119_193` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/colorspaces.rs:103:27 [INFO] [stderr] | [INFO] [stderr] 103 | [ 0.019334, 0.119193, 0.950227 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.950_227` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pipeline.rs:35:52 [INFO] [stderr] | [INFO] [stderr] 35 | println!("{} ms for '{}'", (to_time - from_time)/1000000, name); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/colorspaces.rs:101:7 [INFO] [stderr] | [INFO] [stderr] 101 | [ 0.412453, 0.357580, 0.180423 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.412_453` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/colorspaces.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | [ 0.412453, 0.357580, 0.180423 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.357_580` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/colorspaces.rs:101:27 [INFO] [stderr] | [INFO] [stderr] 101 | [ 0.412453, 0.357580, 0.180423 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.180_423` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/colorspaces.rs:102:7 [INFO] [stderr] | [INFO] [stderr] 102 | [ 0.212671, 0.715160, 0.072169 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.212_671` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/colorspaces.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | [ 0.212671, 0.715160, 0.072169 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.715_160` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/colorspaces.rs:102:27 [INFO] [stderr] | [INFO] [stderr] 102 | [ 0.212671, 0.715160, 0.072169 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.072_169` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/colorspaces.rs:103:7 [INFO] [stderr] | [INFO] [stderr] 103 | [ 0.019334, 0.119193, 0.950227 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.019_334` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/colorspaces.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | [ 0.019334, 0.119193, 0.950227 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.119_193` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/colorspaces.rs:103:27 [INFO] [stderr] | [INFO] [stderr] 103 | [ 0.019334, 0.119193, 0.950227 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.950_227` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pipeline.rs:35:52 [INFO] [stderr] | [INFO] [stderr] 35 | println!("{} ms for '{}'", (to_time - from_time)/1000000, name); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the `c @ _` pattern can be written as just `c` [INFO] [stderr] --> src/buffer.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | c @ _ => panic!(format!( [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `hasher::BufHasher` [INFO] [stderr] --> src/hasher.rs:21:3 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> BufHasher { [INFO] [stderr] 22 | | BufHasher { [INFO] [stderr] 23 | | hash: HashType::default(), [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/hasher.rs:49:28 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn from_serialize(&mut self, obj: &T) where T: Serialize { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: the `c @ _` pattern can be written as just `c` [INFO] [stderr] --> src/buffer.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | c @ _ => panic!(format!( [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `hasher::BufHasher` [INFO] [stderr] --> src/hasher.rs:21:3 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> BufHasher { [INFO] [stderr] 22 | | BufHasher { [INFO] [stderr] 23 | | hash: HashType::default(), [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/hasher.rs:49:28 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn from_serialize(&mut self, obj: &T) where T: Serialize { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/gofloat.rs:41:22 [INFO] [stderr] | [INFO] [stderr] 41 | o[0] = i[0] as f32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/gofloat.rs:42:22 [INFO] [stderr] | [INFO] [stderr] 42 | o[1] = i[0] as f32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/gofloat.rs:43:22 [INFO] [stderr] | [INFO] [stderr] 43 | o[2] = i[0] as f32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/gofloat.rs:53:22 [INFO] [stderr] | [INFO] [stderr] 53 | o[0] = i[0] as f32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/gofloat.rs:54:22 [INFO] [stderr] | [INFO] [stderr] 54 | o[1] = i[1] as f32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/gofloat.rs:55:22 [INFO] [stderr] | [INFO] [stderr] 55 | o[2] = i[2] as f32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/gofloat.rs:41:22 [INFO] [stderr] | [INFO] [stderr] 41 | o[0] = i[0] as f32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/gofloat.rs:42:22 [INFO] [stderr] | [INFO] [stderr] 42 | o[1] = i[0] as f32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(i[0])` [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/gofloat.rs:64:22 [INFO] [stderr] | [INFO] [stderr] 64 | o[0] = i[0] as f32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/gofloat.rs:43:22 [INFO] [stderr] | [INFO] [stderr] 43 | o[2] = i[0] as f32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/gofloat.rs:53:22 [INFO] [stderr] | [INFO] [stderr] 53 | o[0] = i[0] as f32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/gofloat.rs:54:22 [INFO] [stderr] | [INFO] [stderr] 54 | o[1] = i[1] as f32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/gofloat.rs:55:22 [INFO] [stderr] | [INFO] [stderr] 55 | o[2] = i[2] as f32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/gofloat.rs:64:22 [INFO] [stderr] | [INFO] [stderr] 64 | o[0] = i[0] as f32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/ops/demosaic.rs:92:11 [INFO] [stderr] | [INFO] [stderr] 92 | let ref colors = lookups[row%48][col%48]; [INFO] [stderr] | ----^^^^^^^^^^--------------------------- help: try: `let colors = &lookups[row%48][col%48];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/ops/demosaic.rs:92:11 [INFO] [stderr] | [INFO] [stderr] 92 | let ref colors = lookups[row%48][col%48]; [INFO] [stderr] | ----^^^^^^^^^^--------------------------- help: try: `let colors = &lookups[row%48][col%48];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/level.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | [arr[0] as f32, arr[1] as f32, arr[2] as f32, arr[3] as f32] [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(arr[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/level.rs:11:19 [INFO] [stderr] | [INFO] [stderr] 11 | [arr[0] as f32, arr[1] as f32, arr[2] as f32, arr[3] as f32] [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(arr[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/level.rs:11:34 [INFO] [stderr] | [INFO] [stderr] 11 | [arr[0] as f32, arr[1] as f32, arr[2] as f32, arr[3] as f32] [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(arr[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/level.rs:11:49 [INFO] [stderr] | [INFO] [stderr] 11 | [arr[0] as f32, arr[1] as f32, arr[2] as f32, arr[3] as f32] [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(arr[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/level.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | [arr[0] as f32, arr[1] as f32, arr[2] as f32, arr[3] as f32] [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(arr[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/level.rs:11:19 [INFO] [stderr] | [INFO] [stderr] 11 | [arr[0] as f32, arr[1] as f32, arr[2] as f32, arr[3] as f32] [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(arr[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/level.rs:11:34 [INFO] [stderr] | [INFO] [stderr] 11 | [arr[0] as f32, arr[1] as f32, arr[2] as f32, arr[3] as f32] [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(arr[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/level.rs:11:49 [INFO] [stderr] | [INFO] [stderr] 11 | [arr[0] as f32, arr[1] as f32, arr[2] as f32, arr[3] as f32] [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(arr[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `lookup` [INFO] [stderr] --> src/ops/colorspaces.rs:124:14 [INFO] [stderr] | [INFO] [stderr] 124 | for i in 0..(CBRT_MAXVALS+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 124 | for (i, ) in lookup.iter_mut().enumerate().take((CBRT_MAXVALS+1)) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ops/colorspaces.rs:124:14 [INFO] [stderr] | [INFO] [stderr] 124 | for i in 0..(CBRT_MAXVALS+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `0..=CBRT_MAXVALS` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `glookup` [INFO] [stderr] --> src/ops/gamma.rs:26:16 [INFO] [stderr] | [INFO] [stderr] 26 | for i in 0..(maxvals+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 26 | for (i, ) in glookup.iter_mut().enumerate().take((maxvals+1)) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ops/gamma.rs:26:16 [INFO] [stderr] | [INFO] [stderr] 26 | for i in 0..(maxvals+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=maxvals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ops/transform.rs:30:47 [INFO] [stderr] | [INFO] [stderr] 30 | fn rotate_buffer(buf: &OpBuffer, orientation: &Orientation) -> OpBuffer { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Orientation` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `lookup` [INFO] [stderr] --> src/ops/colorspaces.rs:124:14 [INFO] [stderr] | [INFO] [stderr] 124 | for i in 0..(CBRT_MAXVALS+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 124 | for (i, ) in lookup.iter_mut().enumerate().take((CBRT_MAXVALS+1)) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ops/colorspaces.rs:124:14 [INFO] [stderr] | [INFO] [stderr] 124 | for i in 0..(CBRT_MAXVALS+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `0..=CBRT_MAXVALS` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/pipeline.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | hasher.write(self.name().as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `glookup` [INFO] [stderr] --> src/ops/gamma.rs:26:16 [INFO] [stderr] | [INFO] [stderr] 26 | for i in 0..(maxvals+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 26 | for (i, ) in glookup.iter_mut().enumerate().take((maxvals+1)) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ops/gamma.rs:26:16 [INFO] [stderr] | [INFO] [stderr] 26 | for i in 0..(maxvals+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=maxvals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ops/transform.rs:30:47 [INFO] [stderr] | [INFO] [stderr] 30 | fn rotate_buffer(buf: &OpBuffer, orientation: &Orientation) -> OpBuffer { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Orientation` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/pipeline.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | hasher.write(self.name().as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/pipeline.rs:204:3 [INFO] [stderr] | [INFO] [stderr] 204 | / pub fn run(&mut self, cache: Option<&PipelineCache>) -> Arc { [INFO] [stderr] 205 | | // Generate all the hashes for the operations [INFO] [stderr] 206 | | let mut hasher = BufHasher::new(); [INFO] [stderr] 207 | | let mut ophashes = Vec::new(); [INFO] [stderr] ... | [INFO] [stderr] 237 | | bufin [INFO] [stderr] 238 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:214:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.gofloat;` [INFO] [stderr] ... [INFO] [stderr] 214 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:214:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.demosaic;` [INFO] [stderr] ... [INFO] [stderr] 214 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:214:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.level;` [INFO] [stderr] ... [INFO] [stderr] 214 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:214:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.tolab;` [INFO] [stderr] ... [INFO] [stderr] 214 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:214:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.basecurve;` [INFO] [stderr] ... [INFO] [stderr] 214 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:214:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.fromlab;` [INFO] [stderr] ... [INFO] [stderr] 214 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:214:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.gamma;` [INFO] [stderr] ... [INFO] [stderr] 214 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:214:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.transform;` [INFO] [stderr] ... [INFO] [stderr] 214 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:229:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.gofloat;` [INFO] [stderr] ... [INFO] [stderr] 229 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:229:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.demosaic;` [INFO] [stderr] ... [INFO] [stderr] 229 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:229:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.level;` [INFO] [stderr] ... [INFO] [stderr] 229 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:229:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.tolab;` [INFO] [stderr] ... [INFO] [stderr] 229 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:229:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.basecurve;` [INFO] [stderr] ... [INFO] [stderr] 229 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:229:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.fromlab;` [INFO] [stderr] ... [INFO] [stderr] 229 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:229:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.gamma;` [INFO] [stderr] ... [INFO] [stderr] 229 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:229:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.transform;` [INFO] [stderr] ... [INFO] [stderr] 229 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/pipeline.rs:204:3 [INFO] [stderr] | [INFO] [stderr] 204 | / pub fn run(&mut self, cache: Option<&PipelineCache>) -> Arc { [INFO] [stderr] 205 | | // Generate all the hashes for the operations [INFO] [stderr] 206 | | let mut hasher = BufHasher::new(); [INFO] [stderr] 207 | | let mut ophashes = Vec::new(); [INFO] [stderr] ... | [INFO] [stderr] 237 | | bufin [INFO] [stderr] 238 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:214:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.gofloat;` [INFO] [stderr] ... [INFO] [stderr] 214 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:214:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.demosaic;` [INFO] [stderr] ... [INFO] [stderr] 214 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:214:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.level;` [INFO] [stderr] ... [INFO] [stderr] 214 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:214:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.tolab;` [INFO] [stderr] ... [INFO] [stderr] 214 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:214:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.basecurve;` [INFO] [stderr] ... [INFO] [stderr] 214 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:214:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.fromlab;` [INFO] [stderr] ... [INFO] [stderr] 214 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:214:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.gamma;` [INFO] [stderr] ... [INFO] [stderr] 214 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:214:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.transform;` [INFO] [stderr] ... [INFO] [stderr] 214 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:229:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.gofloat;` [INFO] [stderr] ... [INFO] [stderr] 229 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:229:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.demosaic;` [INFO] [stderr] ... [INFO] [stderr] 229 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:229:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.level;` [INFO] [stderr] ... [INFO] [stderr] 229 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:229:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.tolab;` [INFO] [stderr] ... [INFO] [stderr] 229 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:229:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.basecurve;` [INFO] [stderr] ... [INFO] [stderr] 229 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:229:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.fromlab;` [INFO] [stderr] ... [INFO] [stderr] 229 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:229:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.gamma;` [INFO] [stderr] ... [INFO] [stderr] 229 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pipeline.rs:229:25 [INFO] [stderr] | [INFO] [stderr] 106 | let $x = $val; [INFO] [stderr] | -------------- help: try: `let op = &$ops.transform;` [INFO] [stderr] ... [INFO] [stderr] 229 | all_ops!(self.ops, |ref op, i| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: Could not compile `imagepipe`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `imagepipe`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "983a0b23e9ffc8e94059561ae7a3ee8976890792180d5883c92d59d620f440b6"` [INFO] running `"docker" "rm" "-f" "983a0b23e9ffc8e94059561ae7a3ee8976890792180d5883c92d59d620f440b6"` [INFO] [stdout] 983a0b23e9ffc8e94059561ae7a3ee8976890792180d5883c92d59d620f440b6