[INFO] crate image2 0.4.0 is already in cache [INFO] extracting crate image2 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/image2/0.4.0 [INFO] extracting crate image2 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/image2/0.4.0 [INFO] validating manifest of image2-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of image2-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing image2-0.4.0 [INFO] finished frobbing image2-0.4.0 [INFO] frobbed toml for image2-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/image2/0.4.0/Cargo.toml [INFO] started frobbing image2-0.4.0 [INFO] finished frobbing image2-0.4.0 [INFO] frobbed toml for image2-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/image2/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting image2-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/image2/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4b10f83f49aa454eb9b28bbadbdd75bffe7cfde0611159bb74479b8760d8a5d8 [INFO] running `"docker" "start" "-a" "4b10f83f49aa454eb9b28bbadbdd75bffe7cfde0611159bb74479b8760d8a5d8"` [INFO] [stderr] Checking png v0.13.2 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Checking image2 v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image_buf.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | layout: layout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layout` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image_buf.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | layout: layout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layout` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/io/magick.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/io/magick.rs:161:19 [INFO] [stderr] | [INFO] [stderr] 161 | let res = match proc.wait() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 162 | | Ok(_) => Ok(()), [INFO] [stderr] 163 | | Err(_) => Err(Error::UnableToExecuteCommand), [INFO] [stderr] 164 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/io/magick.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/io/magick.rs:161:19 [INFO] [stderr] | [INFO] [stderr] 161 | let res = match proc.wait() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 162 | | Ok(_) => Ok(()), [INFO] [stderr] 163 | | Err(_) => Err(Error::UnableToExecuteCommand), [INFO] [stderr] 164 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/tests.rs:18:31 [INFO] [stderr] | [INFO] [stderr] 18 | t.as_secs() as f64 + (t.subsec_millis() as f64 * 0.001) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(t.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/image.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | layout: &Layout, [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Layout` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/image.rs:114:22 [INFO] [stderr] | [INFO] [stderr] 114 | let layout = self.layout().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.layout()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/image.rs:118:36 [INFO] [stderr] | [INFO] [stderr] 118 | unsafe { px.push(&mut *data.offset(index as isize)) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `data.add(index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/image.rs:127:22 [INFO] [stderr] | [INFO] [stderr] 127 | let layout = self.layout().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.layout()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/image.rs:131:32 [INFO] [stderr] | [INFO] [stderr] 131 | unsafe { px.push(&*data.offset(index as isize)) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `data.add(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/image.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | / match T::from(T::denormalize(f)) { [INFO] [stderr] 173 | | Some(f) => self.data_mut()[index] = f, [INFO] [stderr] 174 | | None => (), [INFO] [stderr] 175 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(f) = T::from(T::denormalize(f)) { self.data_mut()[index] = f }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `px` [INFO] [stderr] --> src/image.rs:215:22 [INFO] [stderr] | [INFO] [stderr] 215 | for i in 0..C::channels() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 215 | for (i, ) in px.iter_mut().enumerate().take(C::channels()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/image.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | self.layout().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.layout()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this call to `as_mut` does nothing [INFO] [stderr] --> src/image.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | self.data_mut().as_mut(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.data_mut()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `c` is used to index `pixel` [INFO] [stderr] --> src/filter.rs:93:26 [INFO] [stderr] | [INFO] [stderr] 93 | for c in 0..channels { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 93 | for (c, ) in pixel.iter_mut().enumerate().take(channels) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/image_ref.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | self.data.as_ref() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `self.data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_mut` does nothing [INFO] [stderr] --> src/image_ref.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | self.data.as_mut() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `self.data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/io/magick.rs:68:20 [INFO] [stderr] | [INFO] [stderr] 68 | .split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/io/png.rs:114:8 [INFO] [stderr] | [INFO] [stderr] 114 | Ok(writer.write_image_data(image.data())?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 114 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/io/mod.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | Ok(magick::write(filename, image)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 51 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kernel.rs:74:19 [INFO] [stderr] | [INFO] [stderr] 74 | for ky in -r2..r2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `-r2..=r2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kernel.rs:76:23 [INFO] [stderr] | [INFO] [stderr] 76 | for kx in -c2..c2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `-c2..=c2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `d` [INFO] [stderr] --> src/kernel.rs:108:22 [INFO] [stderr] | [INFO] [stderr] 108 | for i in 0..cols { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 108 | for (i, ) in d.iter_mut().enumerate().take(cols) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kernel.rs:186:27 [INFO] [stderr] | [INFO] [stderr] 186 | for ky in -r2..r2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `-r2..=r2` [INFO] [stderr] ... [INFO] [stderr] 212 | op!(Add, add, |a, b| a + b); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kernel.rs:189:31 [INFO] [stderr] | [INFO] [stderr] 189 | for kx in -c2..c2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `-c2..=c2` [INFO] [stderr] ... [INFO] [stderr] 212 | op!(Add, add, |a, b| a + b); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kernel.rs:186:27 [INFO] [stderr] | [INFO] [stderr] 186 | for ky in -r2..r2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `-r2..=r2` [INFO] [stderr] ... [INFO] [stderr] 213 | op!(Sub, sub, |a, b| a - b); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kernel.rs:189:31 [INFO] [stderr] | [INFO] [stderr] 189 | for kx in -c2..c2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `-c2..=c2` [INFO] [stderr] ... [INFO] [stderr] 213 | op!(Sub, sub, |a, b| a - b); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kernel.rs:186:27 [INFO] [stderr] | [INFO] [stderr] 186 | for ky in -r2..r2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `-r2..=r2` [INFO] [stderr] ... [INFO] [stderr] 214 | op!(Mul, mul, |a, b| a * b); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kernel.rs:189:31 [INFO] [stderr] | [INFO] [stderr] 189 | for kx in -c2..c2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `-c2..=c2` [INFO] [stderr] ... [INFO] [stderr] 214 | op!(Mul, mul, |a, b| a * b); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kernel.rs:186:27 [INFO] [stderr] | [INFO] [stderr] 186 | for ky in -r2..r2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `-r2..=r2` [INFO] [stderr] ... [INFO] [stderr] 215 | op!(Div, div, |a, b| a / b); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kernel.rs:189:31 [INFO] [stderr] | [INFO] [stderr] 189 | for kx in -c2..c2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `-c2..=c2` [INFO] [stderr] ... [INFO] [stderr] 215 | op!(Div, div, |a, b| a / b); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kernel.rs:186:27 [INFO] [stderr] | [INFO] [stderr] 186 | for ky in -r2..r2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `-r2..=r2` [INFO] [stderr] ... [INFO] [stderr] 216 | op!(Rem, rem, |a, b| a % b); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kernel.rs:189:31 [INFO] [stderr] | [INFO] [stderr] 189 | for kx in -c2..c2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `-c2..=c2` [INFO] [stderr] ... [INFO] [stderr] 216 | op!(Rem, rem, |a, b| a % b); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `data` [INFO] [stderr] --> src/pixel.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | for i in 0..len { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 27 | for (i, ) in data.iter().enumerate().take(len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/pixel.rs:70:23 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn from_pixel<'a, P: AsRef<[T]>>(pixel: P) -> PixelVec { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ty.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | Self::to_float(&Self::from_float(0.5)) == 0.5 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(Self::to_float(&Self::from_float(0.5)) - 0.5).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ty.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | Self::to_float(&Self::from_float(0.5)) == 0.5 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/image.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | layout: &Layout, [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Layout` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/image.rs:114:22 [INFO] [stderr] | [INFO] [stderr] 114 | let layout = self.layout().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.layout()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/image.rs:118:36 [INFO] [stderr] | [INFO] [stderr] 118 | unsafe { px.push(&mut *data.offset(index as isize)) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `data.add(index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/image.rs:127:22 [INFO] [stderr] | [INFO] [stderr] 127 | let layout = self.layout().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.layout()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/image.rs:131:32 [INFO] [stderr] | [INFO] [stderr] 131 | unsafe { px.push(&*data.offset(index as isize)) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `data.add(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/image.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | / match T::from(T::denormalize(f)) { [INFO] [stderr] 173 | | Some(f) => self.data_mut()[index] = f, [INFO] [stderr] 174 | | None => (), [INFO] [stderr] 175 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(f) = T::from(T::denormalize(f)) { self.data_mut()[index] = f }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `px` [INFO] [stderr] --> src/image.rs:215:22 [INFO] [stderr] | [INFO] [stderr] 215 | for i in 0..C::channels() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 215 | for (i, ) in px.iter_mut().enumerate().take(C::channels()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/image.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | self.layout().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.layout()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this call to `as_mut` does nothing [INFO] [stderr] --> src/image.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | self.data_mut().as_mut(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.data_mut()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: the loop variable `c` is used to index `pixel` [INFO] [stderr] --> src/filter.rs:93:26 [INFO] [stderr] | [INFO] [stderr] 93 | for c in 0..channels { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 93 | for (c, ) in pixel.iter_mut().enumerate().take(channels) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: Could not compile `image2`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/image_ref.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | self.data.as_ref() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `self.data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_mut` does nothing [INFO] [stderr] --> src/image_ref.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | self.data.as_mut() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `self.data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/io/magick.rs:68:20 [INFO] [stderr] | [INFO] [stderr] 68 | .split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/io/png.rs:114:8 [INFO] [stderr] | [INFO] [stderr] 114 | Ok(writer.write_image_data(image.data())?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 114 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/io/mod.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | Ok(magick::write(filename, image)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 51 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kernel.rs:74:19 [INFO] [stderr] | [INFO] [stderr] 74 | for ky in -r2..r2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `-r2..=r2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kernel.rs:76:23 [INFO] [stderr] | [INFO] [stderr] 76 | for kx in -c2..c2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `-c2..=c2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `d` [INFO] [stderr] --> src/kernel.rs:108:22 [INFO] [stderr] | [INFO] [stderr] 108 | for i in 0..cols { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 108 | for (i, ) in d.iter_mut().enumerate().take(cols) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kernel.rs:186:27 [INFO] [stderr] | [INFO] [stderr] 186 | for ky in -r2..r2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `-r2..=r2` [INFO] [stderr] ... [INFO] [stderr] 212 | op!(Add, add, |a, b| a + b); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kernel.rs:189:31 [INFO] [stderr] | [INFO] [stderr] 189 | for kx in -c2..c2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `-c2..=c2` [INFO] [stderr] ... [INFO] [stderr] 212 | op!(Add, add, |a, b| a + b); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kernel.rs:186:27 [INFO] [stderr] | [INFO] [stderr] 186 | for ky in -r2..r2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `-r2..=r2` [INFO] [stderr] ... [INFO] [stderr] 213 | op!(Sub, sub, |a, b| a - b); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kernel.rs:189:31 [INFO] [stderr] | [INFO] [stderr] 189 | for kx in -c2..c2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `-c2..=c2` [INFO] [stderr] ... [INFO] [stderr] 213 | op!(Sub, sub, |a, b| a - b); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kernel.rs:186:27 [INFO] [stderr] | [INFO] [stderr] 186 | for ky in -r2..r2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `-r2..=r2` [INFO] [stderr] ... [INFO] [stderr] 214 | op!(Mul, mul, |a, b| a * b); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kernel.rs:189:31 [INFO] [stderr] | [INFO] [stderr] 189 | for kx in -c2..c2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `-c2..=c2` [INFO] [stderr] ... [INFO] [stderr] 214 | op!(Mul, mul, |a, b| a * b); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kernel.rs:186:27 [INFO] [stderr] | [INFO] [stderr] 186 | for ky in -r2..r2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `-r2..=r2` [INFO] [stderr] ... [INFO] [stderr] 215 | op!(Div, div, |a, b| a / b); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kernel.rs:189:31 [INFO] [stderr] | [INFO] [stderr] 189 | for kx in -c2..c2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `-c2..=c2` [INFO] [stderr] ... [INFO] [stderr] 215 | op!(Div, div, |a, b| a / b); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kernel.rs:186:27 [INFO] [stderr] | [INFO] [stderr] 186 | for ky in -r2..r2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `-r2..=r2` [INFO] [stderr] ... [INFO] [stderr] 216 | op!(Rem, rem, |a, b| a % b); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kernel.rs:189:31 [INFO] [stderr] | [INFO] [stderr] 189 | for kx in -c2..c2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `-c2..=c2` [INFO] [stderr] ... [INFO] [stderr] 216 | op!(Rem, rem, |a, b| a % b); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `data` [INFO] [stderr] --> src/pixel.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | for i in 0..len { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 27 | for (i, ) in data.iter().enumerate().take(len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/pixel.rs:70:23 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn from_pixel<'a, P: AsRef<[T]>>(pixel: P) -> PixelVec { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ty.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | Self::to_float(&Self::from_float(0.5)) == 0.5 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(Self::to_float(&Self::from_float(0.5)) - 0.5).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ty.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | Self::to_float(&Self::from_float(0.5)) == 0.5 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `image2`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4b10f83f49aa454eb9b28bbadbdd75bffe7cfde0611159bb74479b8760d8a5d8"` [INFO] running `"docker" "rm" "-f" "4b10f83f49aa454eb9b28bbadbdd75bffe7cfde0611159bb74479b8760d8a5d8"` [INFO] [stdout] 4b10f83f49aa454eb9b28bbadbdd75bffe7cfde0611159bb74479b8760d8a5d8