[INFO] crate image-base64 0.1.0 is already in cache [INFO] extracting crate image-base64 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/image-base64/0.1.0 [INFO] extracting crate image-base64 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/image-base64/0.1.0 [INFO] validating manifest of image-base64-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of image-base64-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing image-base64-0.1.0 [INFO] finished frobbing image-base64-0.1.0 [INFO] frobbed toml for image-base64-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/image-base64/0.1.0/Cargo.toml [INFO] started frobbing image-base64-0.1.0 [INFO] finished frobbing image-base64-0.1.0 [INFO] frobbed toml for image-base64-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/image-base64/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting image-base64-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/image-base64/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 197e35813daefc6b427264000df9ff295e970129e3f4addd688e250d1fe16130 [INFO] running `"docker" "start" "-a" "197e35813daefc6b427264000df9ff295e970129e3f4addd688e250d1fe16130"` [INFO] [stderr] Checking base64 v0.4.2 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking image v0.12.4 [INFO] [stderr] Checking image-base64 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return value.from_base64().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `value.from_base64().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lib.rs:12:19 [INFO] [stderr] | [INFO] [stderr] 12 | if Regex::new(r"^ffd8ffe0").unwrap().is_match(hex) { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::starts_with` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lib.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | } else if Regex::new(r"^89504e47").unwrap().is_match(hex) { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::starts_with` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lib.rs:16:26 [INFO] [stderr] | [INFO] [stderr] 16 | } else if Regex::new(r"^47494638").unwrap().is_match(hex) { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::starts_with` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:32:35 [INFO] [stderr] | [INFO] [stderr] 32 | let offset = base64.find(',').unwrap_or(base64.len())+1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| base64.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return value.from_base64().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `value.from_base64().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lib.rs:12:19 [INFO] [stderr] | [INFO] [stderr] 12 | if Regex::new(r"^ffd8ffe0").unwrap().is_match(hex) { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::starts_with` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lib.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | } else if Regex::new(r"^89504e47").unwrap().is_match(hex) { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::starts_with` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lib.rs:16:26 [INFO] [stderr] | [INFO] [stderr] 16 | } else if Regex::new(r"^47494638").unwrap().is_match(hex) { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::starts_with` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:32:35 [INFO] [stderr] | [INFO] [stderr] 32 | let offset = base64.find(',').unwrap_or(base64.len())+1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| base64.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/test.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / match file.read_to_string(&mut buffer) { [INFO] [stderr] 40 | | Err(why) => panic!("couldn't read {}", why), [INFO] [stderr] 41 | | Ok(_) => {}, [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut buffer) { panic!("couldn't read {}", why) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/test.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / match original.read_to_string(&mut base64) { [INFO] [stderr] 72 | | Err(why) => panic!("couldn't read {}", why), [INFO] [stderr] 73 | | Ok(_) => {}, [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = original.read_to_string(&mut base64) { panic!("couldn't read {}", why) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/test.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / match file.read_to_end(&mut file_vec) { [INFO] [stderr] 93 | | Err(why) => panic!("couldn't read {}", why), [INFO] [stderr] 94 | | Ok(_) => {}, [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_end(&mut file_vec) { panic!("couldn't read {}", why) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.33s [INFO] running `"docker" "inspect" "197e35813daefc6b427264000df9ff295e970129e3f4addd688e250d1fe16130"` [INFO] running `"docker" "rm" "-f" "197e35813daefc6b427264000df9ff295e970129e3f4addd688e250d1fe16130"` [INFO] [stdout] 197e35813daefc6b427264000df9ff295e970129e3f4addd688e250d1fe16130