[INFO] crate ilvm 0.2.1 is already in cache [INFO] extracting crate ilvm 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/ilvm/0.2.1 [INFO] extracting crate ilvm 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ilvm/0.2.1 [INFO] validating manifest of ilvm-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ilvm-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ilvm-0.2.1 [INFO] finished frobbing ilvm-0.2.1 [INFO] frobbed toml for ilvm-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/ilvm/0.2.1/Cargo.toml [INFO] started frobbing ilvm-0.2.1 [INFO] finished frobbing ilvm-0.2.1 [INFO] frobbed toml for ilvm-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ilvm/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ilvm-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ilvm/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 83f9b5877d31e5a9b25b68c36661ce82d9c4e61b46f4d47c9bb62dfd802adbcd [INFO] running `"docker" "start" "-a" "83f9b5877d31e5a9b25b68c36661ce82d9c4e61b46f4d47c9bb62dfd802adbcd"` [INFO] [stderr] Checking combine v3.6.6 [INFO] [stderr] Checking ilvm v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return eval::eval(mem_limit, reg_limit, blocks); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `eval::eval(mem_limit, reg_limit, blocks)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return eval::eval(mem_limit, reg_limit, blocks); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `eval::eval(mem_limit, reg_limit, blocks)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/eval.rs:149:26 [INFO] [stderr] | [INFO] [stderr] 149 | .ok_or(Error::Runtime("malloc OOM".to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Runtime("malloc OOM".to_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/eval.rs:163:22 [INFO] [stderr] | [INFO] [stderr] 163 | .ok_or(Error::Runtime("free bad ptr".to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Runtime("free bad ptr".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/eval.rs:188:10 [INFO] [stderr] | [INFO] [stderr] 188 | .ok_or(Error::Usage("Expected block 0".to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Usage("Expected block 0".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:117:15 [INFO] [stderr] | [INFO] [stderr] 117 | reg().map(|r| Val::Reg(r)).or(i32().map(|n| Val::Imm(n))) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `Val::Reg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:117:45 [INFO] [stderr] | [INFO] [stderr] 117 | reg().map(|r| Val::Reg(r)).or(i32().map(|n| Val::Imm(n))) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `Val::Imm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:148:14 [INFO] [stderr] | [INFO] [stderr] 148 | .map(|v| Instr::Goto(v)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instr::Goto` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:159:14 [INFO] [stderr] | [INFO] [stderr] 159 | .map(|v| Instr::Exit(v)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instr::Exit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:167:22 [INFO] [stderr] | [INFO] [stderr] 167 | .map(|v| AfterReg::Load(v)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AfterReg::Load` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:173:34 [INFO] [stderr] | [INFO] [stderr] 173 | .map(|p| Some(p))), [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:182:26 [INFO] [stderr] | [INFO] [stderr] 182 | .map(|v| AfterReg::Malloc(v))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AfterReg::Malloc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/eval.rs:149:26 [INFO] [stderr] | [INFO] [stderr] 149 | .ok_or(Error::Runtime("malloc OOM".to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Runtime("malloc OOM".to_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/eval.rs:163:22 [INFO] [stderr] | [INFO] [stderr] 163 | .ok_or(Error::Runtime("free bad ptr".to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Runtime("free bad ptr".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/eval.rs:188:10 [INFO] [stderr] | [INFO] [stderr] 188 | .ok_or(Error::Usage("Expected block 0".to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Usage("Expected block 0".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:117:15 [INFO] [stderr] | [INFO] [stderr] 117 | reg().map(|r| Val::Reg(r)).or(i32().map(|n| Val::Imm(n))) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `Val::Reg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:117:45 [INFO] [stderr] | [INFO] [stderr] 117 | reg().map(|r| Val::Reg(r)).or(i32().map(|n| Val::Imm(n))) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `Val::Imm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:148:14 [INFO] [stderr] | [INFO] [stderr] 148 | .map(|v| Instr::Goto(v)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instr::Goto` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:159:14 [INFO] [stderr] | [INFO] [stderr] 159 | .map(|v| Instr::Exit(v)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instr::Exit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:167:22 [INFO] [stderr] | [INFO] [stderr] 167 | .map(|v| AfterReg::Load(v)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AfterReg::Load` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:173:34 [INFO] [stderr] | [INFO] [stderr] 173 | .map(|p| Some(p))), [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:182:26 [INFO] [stderr] | [INFO] [stderr] 182 | .map(|v| AfterReg::Malloc(v))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AfterReg::Malloc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 28.79s [INFO] running `"docker" "inspect" "83f9b5877d31e5a9b25b68c36661ce82d9c4e61b46f4d47c9bb62dfd802adbcd"` [INFO] running `"docker" "rm" "-f" "83f9b5877d31e5a9b25b68c36661ce82d9c4e61b46f4d47c9bb62dfd802adbcd"` [INFO] [stdout] 83f9b5877d31e5a9b25b68c36661ce82d9c4e61b46f4d47c9bb62dfd802adbcd