[INFO] crate ilda 0.2.0 is already in cache [INFO] extracting crate ilda 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/ilda/0.2.0 [INFO] extracting crate ilda 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ilda/0.2.0 [INFO] validating manifest of ilda-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ilda-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ilda-0.2.0 [INFO] finished frobbing ilda-0.2.0 [INFO] frobbed toml for ilda-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/ilda/0.2.0/Cargo.toml [INFO] started frobbing ilda-0.2.0 [INFO] finished frobbing ilda-0.2.0 [INFO] frobbed toml for ilda-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ilda/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ilda-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ilda/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f5ed05574a33bf30d706c682fd2e9468612b7dfad44f05682586e7998dea2568 [INFO] running `"docker" "start" "-a" "f5ed05574a33bf30d706c682fd2e9468612b7dfad44f05682586e7998dea2568"` [INFO] [stderr] Checking point v0.3.1 [INFO] [stderr] Checking ilda v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/animation.rs:127:7 [INFO] [stderr] | [INFO] [stderr] 127 | frames: frames, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `frames` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/animation.rs:308:9 [INFO] [stderr] | [INFO] [stderr] 308 | points: points, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/animation.rs:444:7 [INFO] [stderr] | [INFO] [stderr] 444 | points: points, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | company_name: company_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `company_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | total_frames: total_frames, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_frames` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | projector_number: projector_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `projector_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/animation.rs:127:7 [INFO] [stderr] | [INFO] [stderr] 127 | frames: frames, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `frames` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/animation.rs:308:9 [INFO] [stderr] | [INFO] [stderr] 308 | points: points, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/animation.rs:444:7 [INFO] [stderr] | [INFO] [stderr] 444 | points: points, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | company_name: company_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `company_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | total_frames: total_frames, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_frames` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | projector_number: projector_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `projector_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/animation.rs:224:15 [INFO] [stderr] | [INFO] [stderr] 224 | None => return None, // Iteration has ended [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/animation.rs:224:15 [INFO] [stderr] | [INFO] [stderr] 224 | None => return None, // Iteration has ended [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/animation.rs:51:30 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn into_frame_iter<'a>(&'a self) -> AnimationFrameIterator<'a> { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/animation.rs:51:3 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn into_frame_iter<'a>(&'a self) -> AnimationFrameIterator<'a> { [INFO] [stderr] 52 | | AnimationFrameIterator { animation: self, index: 0 } [INFO] [stderr] 53 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/animation.rs:57:30 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn into_point_iter<'a>(&'a self) -> AnimationPointIterator<'a> { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/animation.rs:57:3 [INFO] [stderr] | [INFO] [stderr] 57 | / pub fn into_point_iter<'a>(&'a self) -> AnimationPointIterator<'a> { [INFO] [stderr] 58 | | AnimationPointIterator { [INFO] [stderr] 59 | | animation: self, [INFO] [stderr] 60 | | current_frame: self.frames.get(0), [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/animation.rs:88:7 [INFO] [stderr] | [INFO] [stderr] 88 | / match entry { [INFO] [stderr] 89 | | IldaEntry::HeaderEntry(mut header) => { [INFO] [stderr] 90 | | if current_frame.is_some() { [INFO] [stderr] 91 | | let frame = current_frame.take().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 103 | | _ => {}, [INFO] [stderr] 104 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | if let IldaEntry::HeaderEntry(mut header) = entry { [INFO] [stderr] 89 | if current_frame.is_some() { [INFO] [stderr] 90 | let frame = current_frame.take().unwrap(); [INFO] [stderr] 91 | frames.push(frame); [INFO] [stderr] 92 | } [INFO] [stderr] 93 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:323:5 [INFO] [stderr] | [INFO] [stderr] 323 | (((bytes[0] as u16) << 8) | (bytes[1] as u16)) as i16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:323:31 [INFO] [stderr] | [INFO] [stderr] 323 | (((bytes[0] as u16) << 8) | (bytes[1] as u16)) as i16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/parser.rs:123:34 [INFO] [stderr] | [INFO] [stderr] 123 | if header_bytes.len() != 32 || &header_bytes[0..4] != &ILDA_HEADER { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 123 | if header_bytes.len() != 32 || header_bytes[0..4] != ILDA_HEADER { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:165:4 [INFO] [stderr] | [INFO] [stderr] 165 | ((bytes[0] as u16) << 8) | (bytes[1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:165:30 [INFO] [stderr] | [INFO] [stderr] 165 | ((bytes[0] as u16) << 8) | (bytes[1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/animation.rs:51:30 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn into_frame_iter<'a>(&'a self) -> AnimationFrameIterator<'a> { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/animation.rs:51:3 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn into_frame_iter<'a>(&'a self) -> AnimationFrameIterator<'a> { [INFO] [stderr] 52 | | AnimationFrameIterator { animation: self, index: 0 } [INFO] [stderr] 53 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/animation.rs:57:30 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn into_point_iter<'a>(&'a self) -> AnimationPointIterator<'a> { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/animation.rs:57:3 [INFO] [stderr] | [INFO] [stderr] 57 | / pub fn into_point_iter<'a>(&'a self) -> AnimationPointIterator<'a> { [INFO] [stderr] 58 | | AnimationPointIterator { [INFO] [stderr] 59 | | animation: self, [INFO] [stderr] 60 | | current_frame: self.frames.get(0), [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/animation.rs:88:7 [INFO] [stderr] | [INFO] [stderr] 88 | / match entry { [INFO] [stderr] 89 | | IldaEntry::HeaderEntry(mut header) => { [INFO] [stderr] 90 | | if current_frame.is_some() { [INFO] [stderr] 91 | | let frame = current_frame.take().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 103 | | _ => {}, [INFO] [stderr] 104 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | if let IldaEntry::HeaderEntry(mut header) = entry { [INFO] [stderr] 89 | if current_frame.is_some() { [INFO] [stderr] 90 | let frame = current_frame.take().unwrap(); [INFO] [stderr] 91 | frames.push(frame); [INFO] [stderr] 92 | } [INFO] [stderr] 93 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:323:5 [INFO] [stderr] | [INFO] [stderr] 323 | (((bytes[0] as u16) << 8) | (bytes[1] as u16)) as i16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:323:31 [INFO] [stderr] | [INFO] [stderr] 323 | (((bytes[0] as u16) << 8) | (bytes[1] as u16)) as i16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/parser.rs:123:34 [INFO] [stderr] | [INFO] [stderr] 123 | if header_bytes.len() != 32 || &header_bytes[0..4] != &ILDA_HEADER { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 123 | if header_bytes.len() != 32 || header_bytes[0..4] != ILDA_HEADER { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:165:4 [INFO] [stderr] | [INFO] [stderr] 165 | ((bytes[0] as u16) << 8) | (bytes[1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:165:30 [INFO] [stderr] | [INFO] [stderr] 165 | ((bytes[0] as u16) << 8) | (bytes[1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/render_test_pattern.rs:39:7 [INFO] [stderr] | [INFO] [stderr] 39 | let ref mut fout = File::create(&Path::new("output.png")) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 39 | let fout = &mut File::create(&Path::new("output.png")) [INFO] [stderr] 40 | .unwrap(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> examples/render_test_pattern.rs:47:12 [INFO] [stderr] | [INFO] [stderr] 47 | let ix = (x as i32).saturating_add(limit::MAX_X as i32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> examples/render_test_pattern.rs:47:38 [INFO] [stderr] | [INFO] [stderr] 47 | let ix = (x as i32).saturating_add(limit::MAX_X as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(limit::MAX_X)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/render_test_pattern.rs:48:15 [INFO] [stderr] | [INFO] [stderr] 48 | let scale = (img_width as f64) / (limit::WIDTH as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(img_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/render_test_pattern.rs:48:36 [INFO] [stderr] | [INFO] [stderr] 48 | let scale = (img_width as f64) / (limit::WIDTH as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(limit::WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/render_test_pattern.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | ((ix as f64 * scale) as i32).abs() as u32 [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ix)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> examples/render_test_pattern.rs:56:12 [INFO] [stderr] | [INFO] [stderr] 56 | let iy = ((y * -1) as i32).saturating_add(limit::MAX_Y as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(y * -1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> examples/render_test_pattern.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | let iy = ((y * -1) as i32).saturating_add(limit::MAX_Y as i32); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> examples/render_test_pattern.rs:56:45 [INFO] [stderr] | [INFO] [stderr] 56 | let iy = ((y * -1) as i32).saturating_add(limit::MAX_Y as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(limit::MAX_Y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/render_test_pattern.rs:57:15 [INFO] [stderr] | [INFO] [stderr] 57 | let scale = (img_height as f64) / (limit::HEIGHT as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(img_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/render_test_pattern.rs:57:37 [INFO] [stderr] | [INFO] [stderr] 57 | let scale = (img_height as f64) / (limit::HEIGHT as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(limit::HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/render_test_pattern.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | ((iy as f64 * scale) as i32).abs() as u32 [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(iy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.62s [INFO] running `"docker" "inspect" "f5ed05574a33bf30d706c682fd2e9468612b7dfad44f05682586e7998dea2568"` [INFO] running `"docker" "rm" "-f" "f5ed05574a33bf30d706c682fd2e9468612b7dfad44f05682586e7998dea2568"` [INFO] [stdout] f5ed05574a33bf30d706c682fd2e9468612b7dfad44f05682586e7998dea2568