[INFO] crate ilc-ops 0.1.2 is already in cache [INFO] extracting crate ilc-ops 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/ilc-ops/0.1.2 [INFO] extracting crate ilc-ops 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ilc-ops/0.1.2 [INFO] validating manifest of ilc-ops-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ilc-ops-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ilc-ops-0.1.2 [INFO] finished frobbing ilc-ops-0.1.2 [INFO] frobbed toml for ilc-ops-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/ilc-ops/0.1.2/Cargo.toml [INFO] started frobbing ilc-ops-0.1.2 [INFO] finished frobbing ilc-ops-0.1.2 [INFO] frobbed toml for ilc-ops-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ilc-ops/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ilc-ops-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ilc-ops/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b58e2606bc2b70d324c8ce8b41b4f3df1fe3d7b53b9a9cd17b8577421ef3b3f3 [INFO] running `"docker" "start" "-a" "b58e2606bc2b70d324c8ce8b41b4f3df1fe3d7b53b9a9cd17b8577421ef3b3f3"` [INFO] [stderr] Checking linked-list v0.0.3 [INFO] [stderr] Checking bit-set v0.3.0 [INFO] [stderr] Checking num-bigint v0.2.2 [INFO] [stderr] Checking ilc-base v0.2.0 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Checking traverse v0.0.12 [INFO] [stderr] Checking blist v0.0.4 [INFO] [stderr] Checking ilc-ops v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/freq.rs:70:38 [INFO] [stderr] | [INFO] [stderr] 70 | words: words, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `words` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/freq.rs:70:38 [INFO] [stderr] | [INFO] [stderr] 70 | words: words, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `words` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/freq.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / match m { [INFO] [stderr] 54 | | Event { ty: Type::Msg { ref from, ref content, .. }, .. } => { [INFO] [stderr] 55 | | let nick = strip_nick_prefix(from); [INFO] [stderr] 56 | | if stats.contains_key(nick) { [INFO] [stderr] ... | [INFO] [stderr] 74 | | _ => (), [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | if let Event { ty: Type::Msg { ref from, ref content, .. }, .. } = m { [INFO] [stderr] 54 | let nick = strip_nick_prefix(from); [INFO] [stderr] 55 | if stats.contains_key(nick) { [INFO] [stderr] 56 | let p: &mut Person = stats.get_mut(nick).unwrap(); [INFO] [stderr] 57 | let (words, alpha) = words_alpha(content); [INFO] [stderr] 58 | p.lines += 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:200:25 [INFO] [stderr] | [INFO] [stderr] 200 | / if let &Ok(ref ev) = ev { [INFO] [stderr] 201 | | if current.map(|c: &Event| ev.time < c.time).unwrap_or(true) { [INFO] [stderr] 202 | | current = Some(ev); [INFO] [stderr] 203 | | stream_idx = Some(idx); [INFO] [stderr] 204 | | } [INFO] [stderr] 205 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 200 | if let Ok(ref ev) = *ev { [INFO] [stderr] | ^^^^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::iter::Peekable` that must be used [INFO] [stderr] --> src/lib.rs:222:17 [INFO] [stderr] | [INFO] [stderr] 222 | events.remove(offset + idx); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: iterator adaptors are lazy and do nothing unless consumed [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/freq.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / match m { [INFO] [stderr] 54 | | Event { ty: Type::Msg { ref from, ref content, .. }, .. } => { [INFO] [stderr] 55 | | let nick = strip_nick_prefix(from); [INFO] [stderr] 56 | | if stats.contains_key(nick) { [INFO] [stderr] ... | [INFO] [stderr] 74 | | _ => (), [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | if let Event { ty: Type::Msg { ref from, ref content, .. }, .. } = m { [INFO] [stderr] 54 | let nick = strip_nick_prefix(from); [INFO] [stderr] 55 | if stats.contains_key(nick) { [INFO] [stderr] 56 | let p: &mut Person = stats.get_mut(nick).unwrap(); [INFO] [stderr] 57 | let (words, alpha) = words_alpha(content); [INFO] [stderr] 58 | p.lines += 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:200:25 [INFO] [stderr] | [INFO] [stderr] 200 | / if let &Ok(ref ev) = ev { [INFO] [stderr] 201 | | if current.map(|c: &Event| ev.time < c.time).unwrap_or(true) { [INFO] [stderr] 202 | | current = Some(ev); [INFO] [stderr] 203 | | stream_idx = Some(idx); [INFO] [stderr] 204 | | } [INFO] [stderr] 205 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 200 | if let Ok(ref ev) = *ev { [INFO] [stderr] | ^^^^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::iter::Peekable` that must be used [INFO] [stderr] --> src/lib.rs:222:17 [INFO] [stderr] | [INFO] [stderr] 222 | events.remove(offset + idx); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: iterator adaptors are lazy and do nothing unless consumed [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.83s [INFO] running `"docker" "inspect" "b58e2606bc2b70d324c8ce8b41b4f3df1fe3d7b53b9a9cd17b8577421ef3b3f3"` [INFO] running `"docker" "rm" "-f" "b58e2606bc2b70d324c8ce8b41b4f3df1fe3d7b53b9a9cd17b8577421ef3b3f3"` [INFO] [stdout] b58e2606bc2b70d324c8ce8b41b4f3df1fe3d7b53b9a9cd17b8577421ef3b3f3