[INFO] crate ilc-format-weechat 0.2.0 is already in cache [INFO] extracting crate ilc-format-weechat 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/ilc-format-weechat/0.2.0 [INFO] extracting crate ilc-format-weechat 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ilc-format-weechat/0.2.0 [INFO] validating manifest of ilc-format-weechat-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ilc-format-weechat-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ilc-format-weechat-0.2.0 [INFO] finished frobbing ilc-format-weechat-0.2.0 [INFO] frobbed toml for ilc-format-weechat-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/ilc-format-weechat/0.2.0/Cargo.toml [INFO] started frobbing ilc-format-weechat-0.2.0 [INFO] finished frobbing ilc-format-weechat-0.2.0 [INFO] frobbed toml for ilc-format-weechat-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ilc-format-weechat/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ilc-format-weechat-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ilc-format-weechat/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a72378e876d0658852636f5b17b09b1cd66f38d0106e9c5a95d60243f7650bc8 [INFO] running `"docker" "start" "-a" "a72378e876d0658852636f5b17b09b1cd66f38d0106e9c5a95d60243f7650bc8"` [INFO] [stderr] Checking ilc-base v0.2.0 [INFO] [stderr] Checking ilc-format-weechat v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | context: context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | context: context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/lib.rs:256:17 [INFO] [stderr] | [INFO] [stderr] 256 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/lib.rs:256:17 [INFO] [stderr] | [INFO] [stderr] 256 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | / match event { [INFO] [stderr] 195 | | &Event { ty: Type::Msg { ref from, ref content, .. }, ref time, .. } => { [INFO] [stderr] 196 | | try!(writeln!(&mut output, [INFO] [stderr] 197 | | "{}\t{}\t{}", [INFO] [stderr] ... | [INFO] [stderr] 257 | | } [INFO] [stderr] 258 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 194 | match *event { [INFO] [stderr] 195 | Event { ty: Type::Msg { ref from, ref content, .. }, ref time, .. } => { [INFO] [stderr] 196 | try!(writeln!(&mut output, [INFO] [stderr] 197 | "{}\t{}\t{}", [INFO] [stderr] 198 | time.with_format(&context.timezone, TIME_DATE_FORMAT), [INFO] [stderr] 199 | from, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | / match event { [INFO] [stderr] 195 | | &Event { ty: Type::Msg { ref from, ref content, .. }, ref time, .. } => { [INFO] [stderr] 196 | | try!(writeln!(&mut output, [INFO] [stderr] 197 | | "{}\t{}\t{}", [INFO] [stderr] ... | [INFO] [stderr] 257 | | } [INFO] [stderr] 258 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 194 | match *event { [INFO] [stderr] 195 | Event { ty: Type::Msg { ref from, ref content, .. }, ref time, .. } => { [INFO] [stderr] 196 | try!(writeln!(&mut output, [INFO] [stderr] 197 | "{}\t{}\t{}", [INFO] [stderr] 198 | time.with_format(&context.timezone, TIME_DATE_FORMAT), [INFO] [stderr] 199 | from, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.78s [INFO] running `"docker" "inspect" "a72378e876d0658852636f5b17b09b1cd66f38d0106e9c5a95d60243f7650bc8"` [INFO] running `"docker" "rm" "-f" "a72378e876d0658852636f5b17b09b1cd66f38d0106e9c5a95d60243f7650bc8"` [INFO] [stdout] a72378e876d0658852636f5b17b09b1cd66f38d0106e9c5a95d60243f7650bc8