[INFO] crate ilc-format-energymech 0.2.0 is already in cache [INFO] extracting crate ilc-format-energymech 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/ilc-format-energymech/0.2.0 [INFO] extracting crate ilc-format-energymech 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ilc-format-energymech/0.2.0 [INFO] validating manifest of ilc-format-energymech-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ilc-format-energymech-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ilc-format-energymech-0.2.0 [INFO] finished frobbing ilc-format-energymech-0.2.0 [INFO] frobbed toml for ilc-format-energymech-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/ilc-format-energymech/0.2.0/Cargo.toml [INFO] started frobbing ilc-format-energymech-0.2.0 [INFO] finished frobbing ilc-format-energymech-0.2.0 [INFO] frobbed toml for ilc-format-energymech-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ilc-format-energymech/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ilc-format-energymech-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ilc-format-energymech/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 623bac07ccc9f73a2b79bbdd62da43921c232bbb12d166242febe02740986b90 [INFO] running `"docker" "start" "-a" "623bac07ccc9f73a2b79bbdd62da43921c232bbb12d166242febe02740986b90"` [INFO] [stderr] Checking ilc-base v0.2.0 [INFO] [stderr] Checking ilc-format-energymech v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | context: context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | context: context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/lib.rs:320:17 [INFO] [stderr] | [INFO] [stderr] 320 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/lib.rs:320:17 [INFO] [stderr] | [INFO] [stderr] 320 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:140:36 [INFO] [stderr] | [INFO] [stderr] 140 | masks: rejoin(&tokens[6..], &split_tokens[6..]).to_owned().into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `rejoin(&tokens[6..], &split_tokens[6..]).to_owned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | / match event { [INFO] [stderr] 250 | | &Event { ty: Type::Msg { ref from, ref content }, ref time, .. } => { [INFO] [stderr] 251 | | try!(writeln!(&mut output, [INFO] [stderr] 252 | | "[{}] <{}> {}", [INFO] [stderr] ... | [INFO] [stderr] 321 | | } [INFO] [stderr] 322 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 249 | match *event { [INFO] [stderr] 250 | Event { ty: Type::Msg { ref from, ref content }, ref time, .. } => { [INFO] [stderr] 251 | try!(writeln!(&mut output, [INFO] [stderr] 252 | "[{}] <{}> {}", [INFO] [stderr] 253 | time.with_format(&context.timezone, TIME_FORMAT), [INFO] [stderr] 254 | from, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:140:36 [INFO] [stderr] | [INFO] [stderr] 140 | masks: rejoin(&tokens[6..], &split_tokens[6..]).to_owned().into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `rejoin(&tokens[6..], &split_tokens[6..]).to_owned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | / match event { [INFO] [stderr] 250 | | &Event { ty: Type::Msg { ref from, ref content }, ref time, .. } => { [INFO] [stderr] 251 | | try!(writeln!(&mut output, [INFO] [stderr] 252 | | "[{}] <{}> {}", [INFO] [stderr] ... | [INFO] [stderr] 321 | | } [INFO] [stderr] 322 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 249 | match *event { [INFO] [stderr] 250 | Event { ty: Type::Msg { ref from, ref content }, ref time, .. } => { [INFO] [stderr] 251 | try!(writeln!(&mut output, [INFO] [stderr] 252 | "[{}] <{}> {}", [INFO] [stderr] 253 | time.with_format(&context.timezone, TIME_FORMAT), [INFO] [stderr] 254 | from, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.31s [INFO] running `"docker" "inspect" "623bac07ccc9f73a2b79bbdd62da43921c232bbb12d166242febe02740986b90"` [INFO] running `"docker" "rm" "-f" "623bac07ccc9f73a2b79bbdd62da43921c232bbb12d166242febe02740986b90"` [INFO] [stdout] 623bac07ccc9f73a2b79bbdd62da43921c232bbb12d166242febe02740986b90