[INFO] crate ilc-base 0.2.0 is already in cache [INFO] extracting crate ilc-base 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/ilc-base/0.2.0 [INFO] extracting crate ilc-base 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ilc-base/0.2.0 [INFO] validating manifest of ilc-base-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ilc-base-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ilc-base-0.2.0 [INFO] finished frobbing ilc-base-0.2.0 [INFO] frobbed toml for ilc-base-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/ilc-base/0.2.0/Cargo.toml [INFO] started frobbing ilc-base-0.2.0 [INFO] finished frobbing ilc-base-0.2.0 [INFO] frobbed toml for ilc-base-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ilc-base/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ilc-base-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ilc-base/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 46437f97b7f93014855a2b5b868dfabf282444aace8a51005eb9781ff45569d8 [INFO] running `"docker" "start" "-a" "46437f97b7f93014855a2b5b868dfabf282444aace8a51005eb9781ff45569d8"` [INFO] [stderr] Checking ilc-base v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/event.rs:43:28 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn from_format(tz: &FixedOffset, s: &str, f: &str) -> Time { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `FixedOffset` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/event.rs:50:35 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn with_format(&self, tz: &FixedOffset, f: &str) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `FixedOffset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/event.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / match self { [INFO] [stderr] 52 | | &Time::Unknown => panic!("Time data for this event is not present"), [INFO] [stderr] 53 | | &Time::Hms(h, m, s) => { [INFO] [stderr] 54 | | format!("{}", [INFO] [stderr] ... | [INFO] [stderr] 57 | | &Time::Timestamp(t) => format!("{}", tz.timestamp(t, 0).format(f)), [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 51 | match *self { [INFO] [stderr] 52 | Time::Unknown => panic!("Time data for this event is not present"), [INFO] [stderr] 53 | Time::Hms(h, m, s) => { [INFO] [stderr] 54 | format!("{}", [INFO] [stderr] 55 | NaiveTime::from_hms(h as u32, m as u32, s as u32).format(f)) [INFO] [stderr] 56 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/event.rs:55:45 [INFO] [stderr] | [INFO] [stderr] 55 | NaiveTime::from_hms(h as u32, m as u32, s as u32).format(f)) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/event.rs:55:55 [INFO] [stderr] | [INFO] [stderr] 55 | NaiveTime::from_hms(h as u32, m as u32, s as u32).format(f)) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/event.rs:55:65 [INFO] [stderr] | [INFO] [stderr] 55 | NaiveTime::from_hms(h as u32, m as u32, s as u32).format(f)) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/event.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / match self { [INFO] [stderr] 64 | | &Unknown => 0, [INFO] [stderr] 65 | | &Hms(h, m, s) => { [INFO] [stderr] 66 | | Local::today() [INFO] [stderr] ... | [INFO] [stderr] 70 | | &Timestamp(i) => i, [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 63 | match *self { [INFO] [stderr] 64 | Unknown => 0, [INFO] [stderr] 65 | Hms(h, m, s) => { [INFO] [stderr] 66 | Local::today() [INFO] [stderr] 67 | .and_hms(h as u32, m as u32, s as u32) [INFO] [stderr] 68 | .timestamp() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/event.rs:67:30 [INFO] [stderr] | [INFO] [stderr] 67 | .and_hms(h as u32, m as u32, s as u32) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/event.rs:67:40 [INFO] [stderr] | [INFO] [stderr] 67 | .and_hms(h as u32, m as u32, s as u32) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/event.rs:67:50 [INFO] [stderr] | [INFO] [stderr] 67 | .and_hms(h as u32, m as u32, s as u32) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/event.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | / match self { [INFO] [stderr] 170 | | &Msg { ref from, .. } => from == needle, [INFO] [stderr] 171 | | &Action { ref from, .. } => from == needle, [INFO] [stderr] 172 | | &Join { ref nick, .. } => nick == needle, [INFO] [stderr] ... | [INFO] [stderr] 185 | | _ => false, [INFO] [stderr] 186 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 169 | match *self { [INFO] [stderr] 170 | Msg { ref from, .. } => from == needle, [INFO] [stderr] 171 | Action { ref from, .. } => from == needle, [INFO] [stderr] 172 | Join { ref nick, .. } => nick == needle, [INFO] [stderr] 173 | Part { ref nick, .. } => nick == needle, [INFO] [stderr] 174 | Quit { ref nick, .. } => nick == needle, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / match self { [INFO] [stderr] 26 | | &Parse(_) => "error while parsing", [INFO] [stderr] 27 | | &Chrono(_) => "error while parsing time strings", [INFO] [stderr] 28 | | &Io(_) => "error during input/output", [INFO] [stderr] 29 | | &Custom(ref e) => e.description(), [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | match *self { [INFO] [stderr] 26 | Parse(_) => "error while parsing", [INFO] [stderr] 27 | Chrono(_) => "error while parsing time strings", [INFO] [stderr] 28 | Io(_) => "error during input/output", [INFO] [stderr] 29 | Custom(ref e) => e.description(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match self { [INFO] [stderr] 36 | | &Parse(ref _e) => None, [INFO] [stderr] 37 | | &Chrono(ref e) => Some(e), [INFO] [stderr] 38 | | &Io(ref e) => Some(e), [INFO] [stderr] 39 | | &Custom(ref e) => e.cause(), [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | match *self { [INFO] [stderr] 36 | Parse(ref _e) => None, [INFO] [stderr] 37 | Chrono(ref e) => Some(e), [INFO] [stderr] 38 | Io(ref e) => Some(e), [INFO] [stderr] 39 | Custom(ref e) => e.cause(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/format.rs:4:40 [INFO] [stderr] | [INFO] [stderr] 4 | let len = s.iter().map(|s| s.len()).fold(0, |a, b| a + b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/event.rs:43:28 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn from_format(tz: &FixedOffset, s: &str, f: &str) -> Time { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `FixedOffset` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/event.rs:50:35 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn with_format(&self, tz: &FixedOffset, f: &str) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `FixedOffset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/event.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / match self { [INFO] [stderr] 52 | | &Time::Unknown => panic!("Time data for this event is not present"), [INFO] [stderr] 53 | | &Time::Hms(h, m, s) => { [INFO] [stderr] 54 | | format!("{}", [INFO] [stderr] ... | [INFO] [stderr] 57 | | &Time::Timestamp(t) => format!("{}", tz.timestamp(t, 0).format(f)), [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 51 | match *self { [INFO] [stderr] 52 | Time::Unknown => panic!("Time data for this event is not present"), [INFO] [stderr] 53 | Time::Hms(h, m, s) => { [INFO] [stderr] 54 | format!("{}", [INFO] [stderr] 55 | NaiveTime::from_hms(h as u32, m as u32, s as u32).format(f)) [INFO] [stderr] 56 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/event.rs:55:45 [INFO] [stderr] | [INFO] [stderr] 55 | NaiveTime::from_hms(h as u32, m as u32, s as u32).format(f)) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/event.rs:55:55 [INFO] [stderr] | [INFO] [stderr] 55 | NaiveTime::from_hms(h as u32, m as u32, s as u32).format(f)) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/event.rs:55:65 [INFO] [stderr] | [INFO] [stderr] 55 | NaiveTime::from_hms(h as u32, m as u32, s as u32).format(f)) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/event.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / match self { [INFO] [stderr] 64 | | &Unknown => 0, [INFO] [stderr] 65 | | &Hms(h, m, s) => { [INFO] [stderr] 66 | | Local::today() [INFO] [stderr] ... | [INFO] [stderr] 70 | | &Timestamp(i) => i, [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 63 | match *self { [INFO] [stderr] 64 | Unknown => 0, [INFO] [stderr] 65 | Hms(h, m, s) => { [INFO] [stderr] 66 | Local::today() [INFO] [stderr] 67 | .and_hms(h as u32, m as u32, s as u32) [INFO] [stderr] 68 | .timestamp() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/event.rs:67:30 [INFO] [stderr] | [INFO] [stderr] 67 | .and_hms(h as u32, m as u32, s as u32) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/event.rs:67:40 [INFO] [stderr] | [INFO] [stderr] 67 | .and_hms(h as u32, m as u32, s as u32) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/event.rs:67:50 [INFO] [stderr] | [INFO] [stderr] 67 | .and_hms(h as u32, m as u32, s as u32) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/event.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | / match self { [INFO] [stderr] 170 | | &Msg { ref from, .. } => from == needle, [INFO] [stderr] 171 | | &Action { ref from, .. } => from == needle, [INFO] [stderr] 172 | | &Join { ref nick, .. } => nick == needle, [INFO] [stderr] ... | [INFO] [stderr] 185 | | _ => false, [INFO] [stderr] 186 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 169 | match *self { [INFO] [stderr] 170 | Msg { ref from, .. } => from == needle, [INFO] [stderr] 171 | Action { ref from, .. } => from == needle, [INFO] [stderr] 172 | Join { ref nick, .. } => nick == needle, [INFO] [stderr] 173 | Part { ref nick, .. } => nick == needle, [INFO] [stderr] 174 | Quit { ref nick, .. } => nick == needle, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / match self { [INFO] [stderr] 26 | | &Parse(_) => "error while parsing", [INFO] [stderr] 27 | | &Chrono(_) => "error while parsing time strings", [INFO] [stderr] 28 | | &Io(_) => "error during input/output", [INFO] [stderr] 29 | | &Custom(ref e) => e.description(), [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | match *self { [INFO] [stderr] 26 | Parse(_) => "error while parsing", [INFO] [stderr] 27 | Chrono(_) => "error while parsing time strings", [INFO] [stderr] 28 | Io(_) => "error during input/output", [INFO] [stderr] 29 | Custom(ref e) => e.description(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match self { [INFO] [stderr] 36 | | &Parse(ref _e) => None, [INFO] [stderr] 37 | | &Chrono(ref e) => Some(e), [INFO] [stderr] 38 | | &Io(ref e) => Some(e), [INFO] [stderr] 39 | | &Custom(ref e) => e.cause(), [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | match *self { [INFO] [stderr] 36 | Parse(ref _e) => None, [INFO] [stderr] 37 | Chrono(ref e) => Some(e), [INFO] [stderr] 38 | Io(ref e) => Some(e), [INFO] [stderr] 39 | Custom(ref e) => e.cause(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/format.rs:4:40 [INFO] [stderr] | [INFO] [stderr] 4 | let len = s.iter().map(|s| s.len()).fold(0, |a, b| a + b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.06s [INFO] running `"docker" "inspect" "46437f97b7f93014855a2b5b868dfabf282444aace8a51005eb9781ff45569d8"` [INFO] running `"docker" "rm" "-f" "46437f97b7f93014855a2b5b868dfabf282444aace8a51005eb9781ff45569d8"` [INFO] [stdout] 46437f97b7f93014855a2b5b868dfabf282444aace8a51005eb9781ff45569d8