[INFO] crate ignore 0.4.4 is already in cache [INFO] extracting crate ignore 0.4.4 into work/ex/clippy-test-run/sources/stable/reg/ignore/0.4.4 [INFO] extracting crate ignore 0.4.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ignore/0.4.4 [INFO] validating manifest of ignore-0.4.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ignore-0.4.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ignore-0.4.4 [INFO] finished frobbing ignore-0.4.4 [INFO] frobbed toml for ignore-0.4.4 written to work/ex/clippy-test-run/sources/stable/reg/ignore/0.4.4/Cargo.toml [INFO] started frobbing ignore-0.4.4 [INFO] finished frobbing ignore-0.4.4 [INFO] frobbed toml for ignore-0.4.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ignore/0.4.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ignore-0.4.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ignore/0.4.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 19c205b39e8aca550004341ba5762e4b45b48941daf061d6191f83240a97755e [INFO] running `"docker" "start" "-a" "19c205b39e8aca550004341ba5762e4b45b48941daf061d6191f83240a97755e"` [INFO] [stderr] Checking ignore v0.4.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gitignore.rs:353:13 [INFO] [stderr] | [INFO] [stderr] 353 | set: set, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `set` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gitignore.rs:432:13 [INFO] [stderr] | [INFO] [stderr] 432 | from: from, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:571:13 [INFO] [stderr] | [INFO] [stderr] 571 | defs: defs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `defs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:572:13 [INFO] [stderr] | [INFO] [stderr] 572 | selections: selections, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `selections` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:573:13 [INFO] [stderr] | [INFO] [stderr] 573 | has_selected: has_selected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `has_selected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:574:13 [INFO] [stderr] | [INFO] [stderr] 574 | glob_to_selection: glob_to_selection, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `glob_to_selection` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:575:13 [INFO] [stderr] | [INFO] [stderr] 575 | set: set, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | err: err, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | err: err, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:336:17 [INFO] [stderr] | [INFO] [stderr] 336 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:352:17 [INFO] [stderr] | [INFO] [stderr] 352 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:358:13 [INFO] [stderr] | [INFO] [stderr] 358 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:360:13 [INFO] [stderr] | [INFO] [stderr] 360 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:375:13 [INFO] [stderr] | [INFO] [stderr] 375 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:377:13 [INFO] [stderr] | [INFO] [stderr] 377 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:395:13 [INFO] [stderr] | [INFO] [stderr] 395 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:415:13 [INFO] [stderr] | [INFO] [stderr] 415 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:557:13 [INFO] [stderr] | [INFO] [stderr] 557 | its: its, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `its` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:1118:17 [INFO] [stderr] | [INFO] [stderr] 1118 | dent: dent, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:1120:17 [INFO] [stderr] | [INFO] [stderr] 1120 | root_device: root_device, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `root_device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:1143:17 [INFO] [stderr] | [INFO] [stderr] 1143 | threads: threads, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `threads` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:1431:17 [INFO] [stderr] | [INFO] [stderr] 1431 | dent: dent, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:1433:17 [INFO] [stderr] | [INFO] [stderr] 1433 | root_device: root_device, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `root_device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:140:41 [INFO] [stderr] | [INFO] [stderr] 140 | Error::WithLineNumber { line: line, err: err.clone() } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:146:36 [INFO] [stderr] | [INFO] [stderr] 146 | Error::WithDepth { depth: depth, err: err.clone() } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:248:17 [INFO] [stderr] | [INFO] [stderr] 248 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:259:17 [INFO] [stderr] | [INFO] [stderr] 259 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gitignore.rs:353:13 [INFO] [stderr] | [INFO] [stderr] 353 | set: set, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `set` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gitignore.rs:432:13 [INFO] [stderr] | [INFO] [stderr] 432 | from: from, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:571:13 [INFO] [stderr] | [INFO] [stderr] 571 | defs: defs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `defs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:572:13 [INFO] [stderr] | [INFO] [stderr] 572 | selections: selections, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `selections` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:573:13 [INFO] [stderr] | [INFO] [stderr] 573 | has_selected: has_selected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `has_selected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:574:13 [INFO] [stderr] | [INFO] [stderr] 574 | glob_to_selection: glob_to_selection, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `glob_to_selection` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:575:13 [INFO] [stderr] | [INFO] [stderr] 575 | set: set, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | err: err, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | err: err, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:336:17 [INFO] [stderr] | [INFO] [stderr] 336 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:352:17 [INFO] [stderr] | [INFO] [stderr] 352 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:358:13 [INFO] [stderr] | [INFO] [stderr] 358 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:360:13 [INFO] [stderr] | [INFO] [stderr] 360 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:375:13 [INFO] [stderr] | [INFO] [stderr] 375 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:377:13 [INFO] [stderr] | [INFO] [stderr] 377 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:395:13 [INFO] [stderr] | [INFO] [stderr] 395 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:415:13 [INFO] [stderr] | [INFO] [stderr] 415 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:557:13 [INFO] [stderr] | [INFO] [stderr] 557 | its: its, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `its` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:1118:17 [INFO] [stderr] | [INFO] [stderr] 1118 | dent: dent, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:1120:17 [INFO] [stderr] | [INFO] [stderr] 1120 | root_device: root_device, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `root_device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:1143:17 [INFO] [stderr] | [INFO] [stderr] 1143 | threads: threads, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `threads` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:1431:17 [INFO] [stderr] | [INFO] [stderr] 1431 | dent: dent, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk.rs:1433:17 [INFO] [stderr] | [INFO] [stderr] 1433 | root_device: root_device, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `root_device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:140:41 [INFO] [stderr] | [INFO] [stderr] 140 | Error::WithLineNumber { line: line, err: err.clone() } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:146:36 [INFO] [stderr] | [INFO] [stderr] 146 | Error::WithDepth { depth: depth, err: err.clone() } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:248:17 [INFO] [stderr] | [INFO] [stderr] 248 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:259:17 [INFO] [stderr] | [INFO] [stderr] 259 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/types.rs:99:23 [INFO] [stderr] | [INFO] [stderr] 99 | const DEFAULT_TYPES: &'static [(&'static str, &'static [&'static str])] = &[ [INFO] [stderr] | -^^^^^^^------------------------------------------ help: consider removing `'static`: `&[(&'static str, &'static [&'static str])]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/types.rs:99:34 [INFO] [stderr] | [INFO] [stderr] 99 | const DEFAULT_TYPES: &'static [(&'static str, &'static [&'static str])] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/types.rs:99:48 [INFO] [stderr] | [INFO] [stderr] 99 | const DEFAULT_TYPES: &'static [(&'static str, &'static [&'static str])] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/types.rs:99:58 [INFO] [stderr] | [INFO] [stderr] 99 | const DEFAULT_TYPES: &'static [(&'static str, &'static [&'static str])] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/walk.rs:1534:16 [INFO] [stderr] | [INFO] [stderr] 1534 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 1535 | | if self.is_quitting { [INFO] [stderr] 1536 | | self.is_quitting = false; [INFO] [stderr] 1537 | | self.num_quitting.fetch_sub(1, Ordering::SeqCst); [INFO] [stderr] 1538 | | } [INFO] [stderr] 1539 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1534 | } else if self.is_quitting { [INFO] [stderr] 1535 | self.is_quitting = false; [INFO] [stderr] 1536 | self.num_quitting.fetch_sub(1, Ordering::SeqCst); [INFO] [stderr] 1537 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/walk.rs:1549:16 [INFO] [stderr] | [INFO] [stderr] 1549 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 1550 | | if self.is_waiting { [INFO] [stderr] 1551 | | self.is_waiting = false; [INFO] [stderr] 1552 | | self.num_waiting.fetch_sub(1, Ordering::SeqCst); [INFO] [stderr] 1553 | | } [INFO] [stderr] 1554 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1549 | } else if self.is_waiting { [INFO] [stderr] 1550 | self.is_waiting = false; [INFO] [stderr] 1551 | self.num_waiting.fetch_sub(1, Ordering::SeqCst); [INFO] [stderr] 1552 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/gitignore.rs:649:18 [INFO] [stderr] | [INFO] [stderr] 649 | const ROOT: &'static str = "/home/foobar/rust/rg"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/overrides.rs:158:18 [INFO] [stderr] | [INFO] [stderr] 158 | const ROOT: &'static str = "/home/andrew/foo"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/types.rs:99:23 [INFO] [stderr] | [INFO] [stderr] 99 | const DEFAULT_TYPES: &'static [(&'static str, &'static [&'static str])] = &[ [INFO] [stderr] | -^^^^^^^------------------------------------------ help: consider removing `'static`: `&[(&'static str, &'static [&'static str])]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/types.rs:99:34 [INFO] [stderr] | [INFO] [stderr] 99 | const DEFAULT_TYPES: &'static [(&'static str, &'static [&'static str])] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/types.rs:99:48 [INFO] [stderr] | [INFO] [stderr] 99 | const DEFAULT_TYPES: &'static [(&'static str, &'static [&'static str])] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/types.rs:99:58 [INFO] [stderr] | [INFO] [stderr] 99 | const DEFAULT_TYPES: &'static [(&'static str, &'static [&'static str])] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/walk.rs:1534:16 [INFO] [stderr] | [INFO] [stderr] 1534 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 1535 | | if self.is_quitting { [INFO] [stderr] 1536 | | self.is_quitting = false; [INFO] [stderr] 1537 | | self.num_quitting.fetch_sub(1, Ordering::SeqCst); [INFO] [stderr] 1538 | | } [INFO] [stderr] 1539 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1534 | } else if self.is_quitting { [INFO] [stderr] 1535 | self.is_quitting = false; [INFO] [stderr] 1536 | self.num_quitting.fetch_sub(1, Ordering::SeqCst); [INFO] [stderr] 1537 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/walk.rs:1549:16 [INFO] [stderr] | [INFO] [stderr] 1549 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 1550 | | if self.is_waiting { [INFO] [stderr] 1551 | | self.is_waiting = false; [INFO] [stderr] 1552 | | self.num_waiting.fetch_sub(1, Ordering::SeqCst); [INFO] [stderr] 1553 | | } [INFO] [stderr] 1554 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1549 | } else if self.is_waiting { [INFO] [stderr] 1550 | self.is_waiting = false; [INFO] [stderr] 1551 | self.num_waiting.fetch_sub(1, Ordering::SeqCst); [INFO] [stderr] 1552 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/dir.rs:292:5 [INFO] [stderr] | [INFO] [stderr] 292 | / pub fn matched<'a, P: AsRef>( [INFO] [stderr] 293 | | &'a self, [INFO] [stderr] 294 | | path: P, [INFO] [stderr] 295 | | is_dir: bool, [INFO] [stderr] ... | [INFO] [stderr] 336 | | whitelisted [INFO] [stderr] 337 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/gitignore.rs:106:36 [INFO] [stderr] | [INFO] [stderr] 106 | let parent = path.parent().unwrap_or(Path::new("/")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Path::new("/"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/gitignore.rs:439:9 [INFO] [stderr] | [INFO] [stderr] 439 | / let mut is_absolute = false; [INFO] [stderr] 440 | | if line.starts_with("\\!") || line.starts_with("\\#") { [INFO] [stderr] 441 | | line = &line[1..]; [INFO] [stderr] 442 | | is_absolute = line.chars().nth(0) == Some('/'); [INFO] [stderr] ... | [INFO] [stderr] 456 | | } [INFO] [stderr] 457 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let is_absolute = if line.starts_with("\\!") || line.starts_with("\\#") { ..; line.chars().nth(0) == Some('/') } else { ..; false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/gitignore.rs:422:29 [INFO] [stderr] | [INFO] [stderr] 422 | if line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/gitignore.rs:444:33 [INFO] [stderr] | [INFO] [stderr] 444 | if line.starts_with("!") { [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/gitignore.rs:448:33 [INFO] [stderr] | [INFO] [stderr] 448 | if line.starts_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gitignore.rs:525:5 [INFO] [stderr] | [INFO] [stderr] 525 | / match gitconfig_home_contents().and_then(|x| parse_excludes_file(&x)) { [INFO] [stderr] 526 | | Some(path) => return Some(path), [INFO] [stderr] 527 | | None => {} [INFO] [stderr] 528 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(path) = gitconfig_home_contents().and_then(|x| parse_excludes_file(&x)) { return Some(path) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gitignore.rs:529:5 [INFO] [stderr] | [INFO] [stderr] 529 | / match gitconfig_xdg_contents().and_then(|x| parse_excludes_file(&x)) { [INFO] [stderr] 530 | | Some(path) => return Some(path), [INFO] [stderr] 531 | | None => {} [INFO] [stderr] 532 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(path) = gitconfig_xdg_contents().and_then(|x| parse_excludes_file(&x)) { return Some(path) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/pathutil.rs:79:1 [INFO] [stderr] | [INFO] [stderr] 79 | / pub fn file_name<'a, P: AsRef + ?Sized>( [INFO] [stderr] 80 | | path: &'a P, [INFO] [stderr] 81 | | ) -> Option<&'a OsStr> { [INFO] [stderr] 82 | | use std::os::unix::ffi::OsStrExt; [INFO] [stderr] ... | [INFO] [stderr] 96 | | Some(OsStr::from_bytes(&path[last_slash..])) [INFO] [stderr] 97 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/pathutil.rs:88:50 [INFO] [stderr] | [INFO] [stderr] 88 | } else if path.len() == 1 && path[0] == b'.' { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 89 | | return None; [INFO] [stderr] 90 | | } else if path.last() == Some(&b'.') { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/pathutil.rs:86:24 [INFO] [stderr] | [INFO] [stderr] 86 | if path.is_empty() { [INFO] [stderr] | ________________________^ [INFO] [stderr] 87 | | return None; [INFO] [stderr] 88 | | } else if path.len() == 1 && path[0] == b'.' { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/pathutil.rs:92:34 [INFO] [stderr] | [INFO] [stderr] 92 | } else if path.len() >= 2 && &path[path.len() - 2..] == &b".."[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 92 | } else if path.len() >= 2 && path[path.len() - 2..] == b".."[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/overrides.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / pub fn matched<'a, P: AsRef>( [INFO] [stderr] 93 | | &'a self, [INFO] [stderr] 94 | | path: P, [INFO] [stderr] 95 | | is_dir: bool, [INFO] [stderr] ... | [INFO] [stderr] 104 | | mat.map(move |giglob| Glob(GlobInner::Matched(giglob))) [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/types.rs:469:5 [INFO] [stderr] | [INFO] [stderr] 469 | / pub fn matched<'a, P: AsRef>( [INFO] [stderr] 470 | | &'a self, [INFO] [stderr] 471 | | path: P, [INFO] [stderr] 472 | | is_dir: bool, [INFO] [stderr] ... | [INFO] [stderr] 511 | | } [INFO] [stderr] 512 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `types::TypesBuilder` [INFO] [stderr] --> src/types.rs:528:5 [INFO] [stderr] | [INFO] [stderr] 528 | / pub fn new() -> TypesBuilder { [INFO] [stderr] 529 | | TypesBuilder { [INFO] [stderr] 530 | | types: HashMap::new(), [INFO] [stderr] 531 | | selections: vec![], [INFO] [stderr] 532 | | } [INFO] [stderr] 533 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 517 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/types.rs:680:33 [INFO] [stderr] | [INFO] [stderr] 680 | let globs = self.types.get(type_name).unwrap().globs.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.types[type_name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/walk.rs:309:35 [INFO] [stderr] | [INFO] [stderr] 309 | }.map_err(|err| Error::Io(io::Error::from(err)).with_path(&self.path)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `io::Error::from()`: `err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/walk.rs:334:33 [INFO] [stderr] | [INFO] [stderr] 334 | let err = Error::Io(io::Error::from(err)).with_path(ent.path()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `io::Error::from()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/walk.rs:1038:16 [INFO] [stderr] | [INFO] [stderr] 1038 | fn is_quit(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `ignore`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/dir.rs:292:5 [INFO] [stderr] | [INFO] [stderr] 292 | / pub fn matched<'a, P: AsRef>( [INFO] [stderr] 293 | | &'a self, [INFO] [stderr] 294 | | path: P, [INFO] [stderr] 295 | | is_dir: bool, [INFO] [stderr] ... | [INFO] [stderr] 336 | | whitelisted [INFO] [stderr] 337 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/gitignore.rs:106:36 [INFO] [stderr] | [INFO] [stderr] 106 | let parent = path.parent().unwrap_or(Path::new("/")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Path::new("/"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/gitignore.rs:439:9 [INFO] [stderr] | [INFO] [stderr] 439 | / let mut is_absolute = false; [INFO] [stderr] 440 | | if line.starts_with("\\!") || line.starts_with("\\#") { [INFO] [stderr] 441 | | line = &line[1..]; [INFO] [stderr] 442 | | is_absolute = line.chars().nth(0) == Some('/'); [INFO] [stderr] ... | [INFO] [stderr] 456 | | } [INFO] [stderr] 457 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let is_absolute = if line.starts_with("\\!") || line.starts_with("\\#") { ..; line.chars().nth(0) == Some('/') } else { ..; false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/gitignore.rs:422:29 [INFO] [stderr] | [INFO] [stderr] 422 | if line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/gitignore.rs:444:33 [INFO] [stderr] | [INFO] [stderr] 444 | if line.starts_with("!") { [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/gitignore.rs:448:33 [INFO] [stderr] | [INFO] [stderr] 448 | if line.starts_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gitignore.rs:525:5 [INFO] [stderr] | [INFO] [stderr] 525 | / match gitconfig_home_contents().and_then(|x| parse_excludes_file(&x)) { [INFO] [stderr] 526 | | Some(path) => return Some(path), [INFO] [stderr] 527 | | None => {} [INFO] [stderr] 528 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(path) = gitconfig_home_contents().and_then(|x| parse_excludes_file(&x)) { return Some(path) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gitignore.rs:529:5 [INFO] [stderr] | [INFO] [stderr] 529 | / match gitconfig_xdg_contents().and_then(|x| parse_excludes_file(&x)) { [INFO] [stderr] 530 | | Some(path) => return Some(path), [INFO] [stderr] 531 | | None => {} [INFO] [stderr] 532 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(path) = gitconfig_xdg_contents().and_then(|x| parse_excludes_file(&x)) { return Some(path) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/pathutil.rs:79:1 [INFO] [stderr] | [INFO] [stderr] 79 | / pub fn file_name<'a, P: AsRef + ?Sized>( [INFO] [stderr] 80 | | path: &'a P, [INFO] [stderr] 81 | | ) -> Option<&'a OsStr> { [INFO] [stderr] 82 | | use std::os::unix::ffi::OsStrExt; [INFO] [stderr] ... | [INFO] [stderr] 96 | | Some(OsStr::from_bytes(&path[last_slash..])) [INFO] [stderr] 97 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/pathutil.rs:88:50 [INFO] [stderr] | [INFO] [stderr] 88 | } else if path.len() == 1 && path[0] == b'.' { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 89 | | return None; [INFO] [stderr] 90 | | } else if path.last() == Some(&b'.') { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/pathutil.rs:86:24 [INFO] [stderr] | [INFO] [stderr] 86 | if path.is_empty() { [INFO] [stderr] | ________________________^ [INFO] [stderr] 87 | | return None; [INFO] [stderr] 88 | | } else if path.len() == 1 && path[0] == b'.' { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/pathutil.rs:92:34 [INFO] [stderr] | [INFO] [stderr] 92 | } else if path.len() >= 2 && &path[path.len() - 2..] == &b".."[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 92 | } else if path.len() >= 2 && path[path.len() - 2..] == b".."[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/overrides.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / pub fn matched<'a, P: AsRef>( [INFO] [stderr] 93 | | &'a self, [INFO] [stderr] 94 | | path: P, [INFO] [stderr] 95 | | is_dir: bool, [INFO] [stderr] ... | [INFO] [stderr] 104 | | mat.map(move |giglob| Glob(GlobInner::Matched(giglob))) [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/types.rs:469:5 [INFO] [stderr] | [INFO] [stderr] 469 | / pub fn matched<'a, P: AsRef>( [INFO] [stderr] 470 | | &'a self, [INFO] [stderr] 471 | | path: P, [INFO] [stderr] 472 | | is_dir: bool, [INFO] [stderr] ... | [INFO] [stderr] 511 | | } [INFO] [stderr] 512 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `types::TypesBuilder` [INFO] [stderr] --> src/types.rs:528:5 [INFO] [stderr] | [INFO] [stderr] 528 | / pub fn new() -> TypesBuilder { [INFO] [stderr] 529 | | TypesBuilder { [INFO] [stderr] 530 | | types: HashMap::new(), [INFO] [stderr] 531 | | selections: vec![], [INFO] [stderr] 532 | | } [INFO] [stderr] 533 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 517 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/types.rs:680:33 [INFO] [stderr] | [INFO] [stderr] 680 | let globs = self.types.get(type_name).unwrap().globs.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.types[type_name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:748:31 [INFO] [stderr] | [INFO] [stderr] 748 | matched!(match1, types(), vec!["rust"], vec![], "lib.rs"); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&["rust"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:748:45 [INFO] [stderr] | [INFO] [stderr] 748 | matched!(match1, types(), vec!["rust"], vec![], "lib.rs"); [INFO] [stderr] | ^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:749:31 [INFO] [stderr] | [INFO] [stderr] 749 | matched!(match2, types(), vec!["html"], vec![], "index.html"); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&["html"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:749:45 [INFO] [stderr] | [INFO] [stderr] 749 | matched!(match2, types(), vec!["html"], vec![], "index.html"); [INFO] [stderr] | ^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:750:31 [INFO] [stderr] | [INFO] [stderr] 750 | matched!(match3, types(), vec!["html"], vec![], "index.htm"); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&["html"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:750:45 [INFO] [stderr] | [INFO] [stderr] 750 | matched!(match3, types(), vec!["html"], vec![], "index.htm"); [INFO] [stderr] | ^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:751:31 [INFO] [stderr] | [INFO] [stderr] 751 | matched!(match4, types(), vec!["html", "rust"], vec![], "main.rs"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["html", "rust"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:751:53 [INFO] [stderr] | [INFO] [stderr] 751 | matched!(match4, types(), vec!["html", "rust"], vec![], "main.rs"); [INFO] [stderr] | ^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:752:31 [INFO] [stderr] | [INFO] [stderr] 752 | matched!(match5, types(), vec![], vec![], "index.html"); [INFO] [stderr] | ^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:752:39 [INFO] [stderr] | [INFO] [stderr] 752 | matched!(match5, types(), vec![], vec![], "index.html"); [INFO] [stderr] | ^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:753:31 [INFO] [stderr] | [INFO] [stderr] 753 | matched!(match6, types(), vec![], vec!["rust"], "index.html"); [INFO] [stderr] | ^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:753:39 [INFO] [stderr] | [INFO] [stderr] 753 | matched!(match6, types(), vec![], vec!["rust"], "index.html"); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&["rust"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:754:31 [INFO] [stderr] | [INFO] [stderr] 754 | matched!(match7, types(), vec!["foo"], vec!["rust"], "main.foo"); [INFO] [stderr] | ^^^^^^^^^^^ help: you can use a slice directly: `&["foo"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:754:44 [INFO] [stderr] | [INFO] [stderr] 754 | matched!(match7, types(), vec!["foo"], vec!["rust"], "main.foo"); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&["rust"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:755:31 [INFO] [stderr] | [INFO] [stderr] 755 | matched!(match8, types(), vec!["combo"], vec![], "index.html"); [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&["combo"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:755:46 [INFO] [stderr] | [INFO] [stderr] 755 | matched!(match8, types(), vec!["combo"], vec![], "index.html"); [INFO] [stderr] | ^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:756:31 [INFO] [stderr] | [INFO] [stderr] 756 | matched!(match9, types(), vec!["combo"], vec![], "lib.rs"); [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&["combo"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:756:46 [INFO] [stderr] | [INFO] [stderr] 756 | matched!(match9, types(), vec!["combo"], vec![], "lib.rs"); [INFO] [stderr] | ^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:758:39 [INFO] [stderr] | [INFO] [stderr] 758 | matched!(not, matchnot1, types(), vec!["rust"], vec![], "index.html"); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&["rust"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:758:53 [INFO] [stderr] | [INFO] [stderr] 758 | matched!(not, matchnot1, types(), vec!["rust"], vec![], "index.html"); [INFO] [stderr] | ^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:759:39 [INFO] [stderr] | [INFO] [stderr] 759 | matched!(not, matchnot2, types(), vec![], vec!["rust"], "main.rs"); [INFO] [stderr] | ^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:759:47 [INFO] [stderr] | [INFO] [stderr] 759 | matched!(not, matchnot2, types(), vec![], vec!["rust"], "main.rs"); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&["rust"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:760:39 [INFO] [stderr] | [INFO] [stderr] 760 | matched!(not, matchnot3, types(), vec!["foo"], vec!["rust"], "main.rs"); [INFO] [stderr] | ^^^^^^^^^^^ help: you can use a slice directly: `&["foo"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:760:52 [INFO] [stderr] | [INFO] [stderr] 760 | matched!(not, matchnot3, types(), vec!["foo"], vec!["rust"], "main.rs"); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&["rust"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:761:39 [INFO] [stderr] | [INFO] [stderr] 761 | matched!(not, matchnot4, types(), vec!["rust"], vec!["foo"], "main.rs"); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&["rust"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:761:53 [INFO] [stderr] | [INFO] [stderr] 761 | matched!(not, matchnot4, types(), vec!["rust"], vec!["foo"], "main.rs"); [INFO] [stderr] | ^^^^^^^^^^^ help: you can use a slice directly: `&["foo"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:762:39 [INFO] [stderr] | [INFO] [stderr] 762 | matched!(not, matchnot5, types(), vec!["rust"], vec!["foo"], "main.foo"); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&["rust"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:762:53 [INFO] [stderr] | [INFO] [stderr] 762 | matched!(not, matchnot5, types(), vec!["rust"], vec!["foo"], "main.foo"); [INFO] [stderr] | ^^^^^^^^^^^ help: you can use a slice directly: `&["foo"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:763:39 [INFO] [stderr] | [INFO] [stderr] 763 | matched!(not, matchnot6, types(), vec!["combo"], vec![], "leftpad.js"); [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&["combo"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/types.rs:763:54 [INFO] [stderr] | [INFO] [stderr] 763 | matched!(not, matchnot6, types(), vec!["combo"], vec![], "leftpad.js"); [INFO] [stderr] | ^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/walk.rs:309:35 [INFO] [stderr] | [INFO] [stderr] 309 | }.map_err(|err| Error::Io(io::Error::from(err)).with_path(&self.path)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `io::Error::from()`: `err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/walk.rs:334:33 [INFO] [stderr] | [INFO] [stderr] 334 | let err = Error::Io(io::Error::from(err)).with_path(ent.path()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `io::Error::from()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/walk.rs:1038:16 [INFO] [stderr] | [INFO] [stderr] 1038 | fn is_quit(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/walk.rs:1984:21 [INFO] [stderr] | [INFO] [stderr] 1984 | let dents = WalkBuilder::new(td.path().join("foo")) [INFO] [stderr] | _____________________^ [INFO] [stderr] 1985 | | .build() [INFO] [stderr] 1986 | | .into_iter() [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 1984 | let dents = WalkBuilder::new(td.path().join("foo")) [INFO] [stderr] 1985 | .build() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `ignore`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "19c205b39e8aca550004341ba5762e4b45b48941daf061d6191f83240a97755e"` [INFO] running `"docker" "rm" "-f" "19c205b39e8aca550004341ba5762e4b45b48941daf061d6191f83240a97755e"` [INFO] [stdout] 19c205b39e8aca550004341ba5762e4b45b48941daf061d6191f83240a97755e