[INFO] crate igd 0.7.0 is already in cache
[INFO] extracting crate igd 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/igd/0.7.0
[INFO] extracting crate igd 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/igd/0.7.0
[INFO] validating manifest of igd-0.7.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of igd-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing igd-0.7.0
[INFO] finished frobbing igd-0.7.0
[INFO] frobbed toml for igd-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/igd/0.7.0/Cargo.toml
[INFO] started frobbing igd-0.7.0
[INFO] finished frobbing igd-0.7.0
[INFO] frobbed toml for igd-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/igd/0.7.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting igd-0.7.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/igd/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2fa51da0e8f6d569c5a1b3c5224328c14b15ac1f0a393474ab0030419cfd864e
[INFO] running `"docker" "start" "-a" "2fa51da0e8f6d569c5a1b3c5224328c14b15ac1f0a393474ab0030419cfd864e"`
[INFO] [stderr]     Checking xmltree v0.7.0
[INFO] [stderr]     Checking tokio-retry v0.1.1
[INFO] [stderr]     Checking igd v0.7.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/search.rs:70:17
[INFO] [stderr]    |
[INFO] [stderr] 70 |                 control_url: control_url,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_url`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/async/gateway.rs:33:13
[INFO] [stderr]    |
[INFO] [stderr] 33 |             addr: addr,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `addr`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/async/gateway.rs:34:13
[INFO] [stderr]    |
[INFO] [stderr] 34 |             control_url: control_url,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_url`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/async/gateway.rs:35:13
[INFO] [stderr]    |
[INFO] [stderr] 35 |             handle: handle,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `handle`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/search.rs:70:17
[INFO] [stderr]    |
[INFO] [stderr] 70 |                 control_url: control_url,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_url`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/async/gateway.rs:33:13
[INFO] [stderr]    |
[INFO] [stderr] 33 |             addr: addr,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `addr`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/async/gateway.rs:34:13
[INFO] [stderr]    |
[INFO] [stderr] 34 |             control_url: control_url,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_url`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/async/gateway.rs:35:13
[INFO] [stderr]    |
[INFO] [stderr] 35 |             handle: handle,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `handle`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/search.rs:13:28
[INFO] [stderr]    |
[INFO] [stderr] 13 | pub const SEARCH_REQUEST: &'static str = "M-SEARCH * HTTP/1.1\r
[INFO] [stderr]    |                           -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/soap.rs:86:18
[INFO] [stderr]    |
[INFO] [stderr] 86 |         .map_err(|err| Error::from(err))
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/soap.rs:88:55
[INFO] [stderr]    |
[INFO] [stderr] 88 |             String::from_utf8(bytes.to_vec()).map_err(|err| Error::from(err))
[INFO] [stderr]    |                                                       ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/async/gateway.rs:48:22
[INFO] [stderr]    |
[INFO] [stderr] 48 |             .map_err(|err| RequestError::from(err))
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RequestError::from`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/async/gateway.rs:225:37
[INFO] [stderr]     |
[INFO] [stderr] 225 |               |err: &AddAnyPortError| match err {
[INFO] [stderr]     |  _____________________________________^
[INFO] [stderr] 226 | |                 &AddAnyPortError::NoPortsAvailable => true,
[INFO] [stderr] 227 | |                 _ => false,
[INFO] [stderr] 228 | |             },
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 225 |             |err: &AddAnyPortError| match *err {
[INFO] [stderr] 226 |                 AddAnyPortError::NoPortsAvailable => true,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/async/search.rs:69:18
[INFO] [stderr]    |
[INFO] [stderr] 69 |         .map_err(|err| SearchError::from(err))
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SearchError::from`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/async/search.rs:72:26
[INFO] [stderr]    |
[INFO] [stderr] 72 |                 .map_err(|err| SearchError::from(err))
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SearchError::from`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/async/search.rs:152:24
[INFO] [stderr]     |
[INFO] [stderr] 152 |                     && service.control_url.len() != 0
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!service.control_url.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/search.rs:13:28
[INFO] [stderr]    |
[INFO] [stderr] 13 | pub const SEARCH_REQUEST: &'static str = "M-SEARCH * HTTP/1.1\r
[INFO] [stderr]    |                           -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/soap.rs:86:18
[INFO] [stderr]    |
[INFO] [stderr] 86 |         .map_err(|err| Error::from(err))
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/soap.rs:88:55
[INFO] [stderr]    |
[INFO] [stderr] 88 |             String::from_utf8(bytes.to_vec()).map_err(|err| Error::from(err))
[INFO] [stderr]    |                                                       ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/async/gateway.rs:48:22
[INFO] [stderr]    |
[INFO] [stderr] 48 |             .map_err(|err| RequestError::from(err))
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RequestError::from`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/async/gateway.rs:225:37
[INFO] [stderr]     |
[INFO] [stderr] 225 |               |err: &AddAnyPortError| match err {
[INFO] [stderr]     |  _____________________________________^
[INFO] [stderr] 226 | |                 &AddAnyPortError::NoPortsAvailable => true,
[INFO] [stderr] 227 | |                 _ => false,
[INFO] [stderr] 228 | |             },
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 225 |             |err: &AddAnyPortError| match *err {
[INFO] [stderr] 226 |                 AddAnyPortError::NoPortsAvailable => true,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/async/search.rs:69:18
[INFO] [stderr]    |
[INFO] [stderr] 69 |         .map_err(|err| SearchError::from(err))
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SearchError::from`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/async/search.rs:72:26
[INFO] [stderr]    |
[INFO] [stderr] 72 |                 .map_err(|err| SearchError::from(err))
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SearchError::from`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/async/search.rs:152:24
[INFO] [stderr]     |
[INFO] [stderr] 152 |                     && service.control_url.len() != 0
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!service.control_url.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 21.64s
[INFO] running `"docker" "inspect" "2fa51da0e8f6d569c5a1b3c5224328c14b15ac1f0a393474ab0030419cfd864e"`
[INFO] running `"docker" "rm" "-f" "2fa51da0e8f6d569c5a1b3c5224328c14b15ac1f0a393474ab0030419cfd864e"`
[INFO] [stdout] 2fa51da0e8f6d569c5a1b3c5224328c14b15ac1f0a393474ab0030419cfd864e