[INFO] crate iflet 0.1.0 is already in cache [INFO] extracting crate iflet 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/iflet/0.1.0 [INFO] extracting crate iflet 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/iflet/0.1.0 [INFO] validating manifest of iflet-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of iflet-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing iflet-0.1.0 [INFO] finished frobbing iflet-0.1.0 [INFO] frobbed toml for iflet-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/iflet/0.1.0/Cargo.toml [INFO] started frobbing iflet-0.1.0 [INFO] finished frobbing iflet-0.1.0 [INFO] frobbed toml for iflet-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/iflet/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting iflet-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/iflet/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2ae6b02b1f97f3ea38db3ea080dfd0eaf22a616a8e74a5afdef3d19d43665b20 [INFO] running `"docker" "start" "-a" "2ae6b02b1f97f3ea38db3ea080dfd0eaf22a616a8e74a5afdef3d19d43665b20"` [INFO] [stderr] Checking iflet v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | / match $r { [INFO] [stderr] 6 | | $l $(if $c),* => $b [INFO] [stderr] 7 | | _ => {} [INFO] [stderr] 8 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 44 | / if_chain!([let Some(y) => x] { [INFO] [stderr] 45 | | assert_eq!(y, 3); [INFO] [stderr] 46 | | return; [INFO] [stderr] 47 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | if let Some(y) = x { if_chain!([let Some(y) => x] { [INFO] [stderr] 6 | assert_eq!(y, 3); [INFO] [stderr] 7 | return; [INFO] [stderr] 8 | }); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | / match $r { [INFO] [stderr] 6 | | $l $(if $c),* => $b [INFO] [stderr] 7 | | _ => {} [INFO] [stderr] 8 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 56 | / if_chain!([let Some(_) => x] { [INFO] [stderr] 57 | | panic!("match succeeded when failure was expected!"); [INFO] [stderr] 58 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | if let Some(_) = x { if_chain!([let Some(_) => x] { [INFO] [stderr] 6 | panic!("match succeeded when failure was expected!"); [INFO] [stderr] 7 | }); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match $r { [INFO] [stderr] 22 | | $l $( if $c ),* => if_chain!([$( let $ll $( if $cc ),* => $rr ),+] $b), [INFO] [stderr] 23 | | _ => {} [INFO] [stderr] 24 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 67 | / if_chain!([let Some(a) => x, [INFO] [stderr] 68 | | let Ok(b) => y, [INFO] [stderr] 69 | | let (c, d) => z] { [INFO] [stderr] 70 | | assert_eq!(a, 3); [INFO] [stderr] ... | [INFO] [stderr] 74 | | return; [INFO] [stderr] 75 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | if let Some(a) = x { if_chain!([let Some(a) => x, [INFO] [stderr] 22 | let Ok(b) => y, [INFO] [stderr] 23 | let (c, d) => z] { [INFO] [stderr] 24 | assert_eq!(a, 3); [INFO] [stderr] 25 | assert_eq!(b, "foo"); [INFO] [stderr] 26 | assert_eq!(c, false); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match $r { [INFO] [stderr] 22 | | $l $( if $c ),* => if_chain!([$( let $ll $( if $cc ),* => $rr ),+] $b), [INFO] [stderr] 23 | | _ => {} [INFO] [stderr] 24 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 67 | / if_chain!([let Some(a) => x, [INFO] [stderr] 68 | | let Ok(b) => y, [INFO] [stderr] 69 | | let (c, d) => z] { [INFO] [stderr] 70 | | assert_eq!(a, 3); [INFO] [stderr] ... | [INFO] [stderr] 74 | | return; [INFO] [stderr] 75 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | if let Ok(b) = y { if_chain!([let Some(a) => x, [INFO] [stderr] 22 | let Ok(b) => y, [INFO] [stderr] 23 | let (c, d) => z] { [INFO] [stderr] 24 | assert_eq!(a, 3); [INFO] [stderr] 25 | assert_eq!(b, "foo"); [INFO] [stderr] 26 | assert_eq!(c, false); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | / match $r { [INFO] [stderr] 6 | | $l $(if $c),* => $b [INFO] [stderr] 7 | | _ => {} [INFO] [stderr] 8 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 67 | / if_chain!([let Some(a) => x, [INFO] [stderr] 68 | | let Ok(b) => y, [INFO] [stderr] 69 | | let (c, d) => z] { [INFO] [stderr] 70 | | assert_eq!(a, 3); [INFO] [stderr] ... | [INFO] [stderr] 74 | | return; [INFO] [stderr] 75 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | if let (c, d) = z { if_chain!([let Some(a) => x, [INFO] [stderr] 6 | let Ok(b) => y, [INFO] [stderr] 7 | let (c, d) => z] { [INFO] [stderr] 8 | assert_eq!(a, 3); [INFO] [stderr] 9 | assert_eq!(b, "foo"); [INFO] [stderr] 10 | assert_eq!(c, false); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match $r { [INFO] [stderr] 22 | | $l $( if $c ),* => if_chain!([$( let $ll $( if $cc ),* => $rr ),+] $b), [INFO] [stderr] 23 | | _ => {} [INFO] [stderr] 24 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 86 | / if_chain!([let Some(_) => x, [INFO] [stderr] 87 | | let Ok(_) => y, [INFO] [stderr] 88 | | let (_, _) => z] { [INFO] [stderr] 89 | | panic!("match succeeded when failure was expected!"); [INFO] [stderr] 90 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | if let Some(_) = x { if_chain!([let Some(_) => x, [INFO] [stderr] 22 | let Ok(_) => y, [INFO] [stderr] 23 | let (_, _) => z] { [INFO] [stderr] 24 | panic!("match succeeded when failure was expected!"); [INFO] [stderr] 25 | }); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match $r { [INFO] [stderr] 22 | | $l $( if $c ),* => if_chain!([$( let $ll $( if $cc ),* => $rr ),+] $b), [INFO] [stderr] 23 | | _ => {} [INFO] [stderr] 24 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 86 | / if_chain!([let Some(_) => x, [INFO] [stderr] 87 | | let Ok(_) => y, [INFO] [stderr] 88 | | let (_, _) => z] { [INFO] [stderr] 89 | | panic!("match succeeded when failure was expected!"); [INFO] [stderr] 90 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | if let Ok(_) = y { if_chain!([let Some(_) => x, [INFO] [stderr] 22 | let Ok(_) => y, [INFO] [stderr] 23 | let (_, _) => z] { [INFO] [stderr] 24 | panic!("match succeeded when failure was expected!"); [INFO] [stderr] 25 | }); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | / match $r { [INFO] [stderr] 6 | | $l $(if $c),* => $b [INFO] [stderr] 7 | | _ => {} [INFO] [stderr] 8 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 86 | / if_chain!([let Some(_) => x, [INFO] [stderr] 87 | | let Ok(_) => y, [INFO] [stderr] 88 | | let (_, _) => z] { [INFO] [stderr] 89 | | panic!("match succeeded when failure was expected!"); [INFO] [stderr] 90 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | if let (_, _) = z { if_chain!([let Some(_) => x, [INFO] [stderr] 6 | let Ok(_) => y, [INFO] [stderr] 7 | let (_, _) => z] { [INFO] [stderr] 8 | panic!("match succeeded when failure was expected!"); [INFO] [stderr] 9 | }); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match $r { [INFO] [stderr] 22 | | $l $( if $c ),* => if_chain!([$( let $ll $( if $cc ),* => $rr ),+] $b), [INFO] [stderr] 23 | | _ => {} [INFO] [stderr] 24 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 193 | / if_chain!([let Some(a) if a > 2 => x, [INFO] [stderr] 194 | | let Ok(b) => y, [INFO] [stderr] 195 | | let (c, d) if !c => z] { [INFO] [stderr] 196 | | assert_eq!(a, 3); [INFO] [stderr] ... | [INFO] [stderr] 200 | | return; [INFO] [stderr] 201 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | if let Ok(b) = y { if_chain!([let Some(a) if a > 2 => x, [INFO] [stderr] 22 | let Ok(b) => y, [INFO] [stderr] 23 | let (c, d) if !c => z] { [INFO] [stderr] 24 | assert_eq!(a, 3); [INFO] [stderr] 25 | assert_eq!(b, "foo"); [INFO] [stderr] 26 | assert_eq!(c, false); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match $r { [INFO] [stderr] 22 | | $l $( if $c ),* => if_chain!([$( let $ll $( if $cc ),* => $rr ),+] $b), [INFO] [stderr] 23 | | _ => {} [INFO] [stderr] 24 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 212 | / if_chain!([let Some(_) => x, [INFO] [stderr] 213 | | let Ok(_b) if _b > 2 => y, [INFO] [stderr] 214 | | let (_, _) => z] { [INFO] [stderr] 215 | | panic!("match succeeded when failure was expected!"); [INFO] [stderr] 216 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | if let Some(_) = x { if_chain!([let Some(_) => x, [INFO] [stderr] 22 | let Ok(_b) if _b > 2 => y, [INFO] [stderr] 23 | let (_, _) => z] { [INFO] [stderr] 24 | panic!("match succeeded when failure was expected!"); [INFO] [stderr] 25 | }); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | / match $r { [INFO] [stderr] 6 | | $l $(if $c),* => $b [INFO] [stderr] 7 | | _ => {} [INFO] [stderr] 8 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 212 | / if_chain!([let Some(_) => x, [INFO] [stderr] 213 | | let Ok(_b) if _b > 2 => y, [INFO] [stderr] 214 | | let (_, _) => z] { [INFO] [stderr] 215 | | panic!("match succeeded when failure was expected!"); [INFO] [stderr] 216 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | if let (_, _) = z { if_chain!([let Some(_) => x, [INFO] [stderr] 6 | let Ok(_b) if _b > 2 => y, [INFO] [stderr] 7 | let (_, _) => z] { [INFO] [stderr] 8 | panic!("match succeeded when failure was expected!"); [INFO] [stderr] 9 | }); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match $r { [INFO] [stderr] 22 | | $l $( if $c ),* => if_chain!([$( let $ll $( if $cc ),* => $rr ),+] $b), [INFO] [stderr] 23 | | _ => {} [INFO] [stderr] 24 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 225 | / if_chain!([let Some(_a) => x, [INFO] [stderr] 226 | | let Ok(_b) => y, [INFO] [stderr] 227 | | let (_c, _) if _c => z] { [INFO] [stderr] 228 | | panic!("match succeeded when failure was expected!"); [INFO] [stderr] 229 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | if let Some(_a) = x { if_chain!([let Some(_a) => x, [INFO] [stderr] 22 | let Ok(_b) => y, [INFO] [stderr] 23 | let (_c, _) if _c => z] { [INFO] [stderr] 24 | panic!("match succeeded when failure was expected!"); [INFO] [stderr] 25 | }); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match $r { [INFO] [stderr] 22 | | $l $( if $c ),* => if_chain!([$( let $ll $( if $cc ),* => $rr ),+] $b), [INFO] [stderr] 23 | | _ => {} [INFO] [stderr] 24 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 225 | / if_chain!([let Some(_a) => x, [INFO] [stderr] 226 | | let Ok(_b) => y, [INFO] [stderr] 227 | | let (_c, _) if _c => z] { [INFO] [stderr] 228 | | panic!("match succeeded when failure was expected!"); [INFO] [stderr] 229 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | if let Ok(_b) = y { if_chain!([let Some(_a) => x, [INFO] [stderr] 22 | let Ok(_b) => y, [INFO] [stderr] 23 | let (_c, _) if _c => z] { [INFO] [stderr] 24 | panic!("match succeeded when failure was expected!"); [INFO] [stderr] 25 | }); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.64s [INFO] running `"docker" "inspect" "2ae6b02b1f97f3ea38db3ea080dfd0eaf22a616a8e74a5afdef3d19d43665b20"` [INFO] running `"docker" "rm" "-f" "2ae6b02b1f97f3ea38db3ea080dfd0eaf22a616a8e74a5afdef3d19d43665b20"` [INFO] [stdout] 2ae6b02b1f97f3ea38db3ea080dfd0eaf22a616a8e74a5afdef3d19d43665b20