[INFO] crate ideal 0.7.4 is already in cache [INFO] extracting crate ideal 0.7.4 into work/ex/clippy-test-run/sources/stable/reg/ideal/0.7.4 [INFO] extracting crate ideal 0.7.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ideal/0.7.4 [INFO] validating manifest of ideal-0.7.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ideal-0.7.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ideal-0.7.4 [INFO] finished frobbing ideal-0.7.4 [INFO] frobbed toml for ideal-0.7.4 written to work/ex/clippy-test-run/sources/stable/reg/ideal/0.7.4/Cargo.toml [INFO] started frobbing ideal-0.7.4 [INFO] finished frobbing ideal-0.7.4 [INFO] frobbed toml for ideal-0.7.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ideal/0.7.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ideal-0.7.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ideal/0.7.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 14d70ca66ba39b21cde003eccc81c76b7cbc2b457345b5c7b8e0c23c854a0bb6 [INFO] running `"docker" "start" "-a" "14d70ca66ba39b21cde003eccc81c76b7cbc2b457345b5c7b8e0c23c854a0bb6"` [INFO] [stderr] Checking ideal v0.7.4 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/id.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn is_invalid(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/id.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn is_valid(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/id.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn cast(&self) -> Id { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: item `vec::IdVec` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/vec.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / impl IdVec { [INFO] [stderr] 16 | | pub fn new() -> Self { [INFO] [stderr] 17 | | Self::default() [INFO] [stderr] 18 | | } [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/id.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn is_invalid(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/id.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn is_valid(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/id.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn cast(&self) -> Id { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: item `vec::IdVec` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/vec.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / impl IdVec { [INFO] [stderr] 16 | | pub fn new() -> Self { [INFO] [stderr] 17 | | Self::default() [INFO] [stderr] 18 | | } [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.89s [INFO] running `"docker" "inspect" "14d70ca66ba39b21cde003eccc81c76b7cbc2b457345b5c7b8e0c23c854a0bb6"` [INFO] running `"docker" "rm" "-f" "14d70ca66ba39b21cde003eccc81c76b7cbc2b457345b5c7b8e0c23c854a0bb6"` [INFO] [stdout] 14d70ca66ba39b21cde003eccc81c76b7cbc2b457345b5c7b8e0c23c854a0bb6