[INFO] crate id3 0.2.5 is already in cache [INFO] extracting crate id3 0.2.5 into work/ex/clippy-test-run/sources/stable/reg/id3/0.2.5 [INFO] extracting crate id3 0.2.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/id3/0.2.5 [INFO] validating manifest of id3-0.2.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of id3-0.2.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing id3-0.2.5 [INFO] finished frobbing id3-0.2.5 [INFO] frobbed toml for id3-0.2.5 written to work/ex/clippy-test-run/sources/stable/reg/id3/0.2.5/Cargo.toml [INFO] started frobbing id3-0.2.5 [INFO] finished frobbing id3-0.2.5 [INFO] frobbed toml for id3-0.2.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/id3/0.2.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting id3-0.2.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/id3/0.2.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0a37cd449d20fa40125934ad1e3daa7fcba3ed22f6e7ee541608afb0fefc6398 [INFO] running `"docker" "start" "-a" "0a37cd449d20fa40125934ad1e3daa7fcba3ed22f6e7ee541608afb0fefc6398"` [INFO] [stderr] Checking id3 v0.2.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream/frame/content.rs:536:21 [INFO] [stderr] | [INFO] [stderr] 536 | picture_type: picture_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `picture_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream/frame/content.rs:536:21 [INFO] [stderr] | [INFO] [stderr] 536 | picture_type: picture_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `picture_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/v1/mod.rs:116:18 [INFO] [stderr] | [INFO] [stderr] 116 | base.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/v1/mod.rs:120:41 [INFO] [stderr] | [INFO] [stderr] 120 | .flat_map(|s| s.into_iter()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/v1/mod.rs:210:9 [INFO] [stderr] | [INFO] [stderr] 210 | / GENRE_LIST.get(self.genre_id as usize) [INFO] [stderr] 211 | | .map(|s| *s) [INFO] [stderr] | |________________________^ help: Consider calling the dedicated `cloned` method: `GENRE_LIST.get(self.genre_id as usize).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/stream/frame/content.rs:402:1 [INFO] [stderr] | [INFO] [stderr] 402 | / fn parse_apic_v3(data: &[u8]) -> ::Result { [INFO] [stderr] 403 | | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] 405 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:298:16 [INFO] [stderr] | [INFO] [stderr] 298 | if $i + 1 >= $bytes.len() { [INFO] [stderr] | ________________^ [INFO] [stderr] 299 | | return Err(::Error::new(::ErrorKind::Parsing, "insufficient data")); [INFO] [stderr] 300 | | } [INFO] [stderr] 301 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::eval_order_dependence)] on by default [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:302:25 [INFO] [stderr] | [INFO] [stderr] 302 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 303 | | $i += 1; [INFO] [stderr] 304 | | [INFO] [stderr] 305 | | let picture_type = match $bytes[start] { [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | / $i += 1; [INFO] [stderr] 304 | | [INFO] [stderr] 305 | | let picture_type = match $bytes[start] { [INFO] [stderr] 306 | | 0 => Some(PictureType::Other), [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:250:25 [INFO] [stderr] | [INFO] [stderr] 250 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 251 | | let (end, with_delim) = find_delim!($bytes, $params.encoding, $i, $terminated); [INFO] [stderr] 252 | | $i = with_delim; Some(&$i); [INFO] [stderr] 253 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | match ::util::find_delim($encoding, $bytes, $i) { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 240 | | Some(i) => (i, i + ::util::delim_len($encoding)), [INFO] [stderr] 241 | | None => return Err(::Error::new(::ErrorKind::Parsing, "delimiter not found")) [INFO] [stderr] 242 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:337:25 [INFO] [stderr] | [INFO] [stderr] 337 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 338 | | $i = $bytes.len(); Some(&$i); [INFO] [stderr] 339 | | $bytes[start..].to_vec() [INFO] [stderr] 340 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:290:25 [INFO] [stderr] | [INFO] [stderr] 290 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 291 | | let (end, with_delim) = find_delim!($bytes, Encoding::Latin1, $i, $terminated); [INFO] [stderr] 292 | | $i = with_delim; Some(&$i); [INFO] [stderr] 293 | | try!(String::from_utf8($bytes[start..end].to_vec())) [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | $i += 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | match ::util::find_delim($encoding, $bytes, $i) { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 240 | | Some(i) => (i, i + ::util::delim_len($encoding)), [INFO] [stderr] 241 | | None => return Err(::Error::new(::ErrorKind::Parsing, "delimiter not found")) [INFO] [stderr] 242 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | $i += 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:250:25 [INFO] [stderr] | [INFO] [stderr] 250 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 251 | | let (end, with_delim) = find_delim!($bytes, $params.encoding, $i, $terminated); [INFO] [stderr] 252 | | $i = with_delim; Some(&$i); [INFO] [stderr] 253 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | $i += 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:337:25 [INFO] [stderr] | [INFO] [stderr] 337 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 338 | | $i = $bytes.len(); Some(&$i); [INFO] [stderr] 339 | | $bytes[start..].to_vec() [INFO] [stderr] 340 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | $i += 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:290:25 [INFO] [stderr] | [INFO] [stderr] 290 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 291 | | let (end, with_delim) = find_delim!($bytes, Encoding::Latin1, $i, $terminated); [INFO] [stderr] 292 | | $i = with_delim; Some(&$i); [INFO] [stderr] 293 | | try!(String::from_utf8($bytes[start..end].to_vec())) [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | match ::util::find_delim($encoding, $bytes, $i) { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 240 | | Some(i) => (i, i + ::util::delim_len($encoding)), [INFO] [stderr] 241 | | None => return Err(::Error::new(::ErrorKind::Parsing, "delimiter not found")) [INFO] [stderr] 242 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:298:16 [INFO] [stderr] | [INFO] [stderr] 298 | if $i + 1 >= $bytes.len() { [INFO] [stderr] | ________________^ [INFO] [stderr] 299 | | return Err(::Error::new(::ErrorKind::Parsing, "insufficient data")); [INFO] [stderr] 300 | | } [INFO] [stderr] 301 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:302:25 [INFO] [stderr] | [INFO] [stderr] 302 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 303 | | $i += 1; [INFO] [stderr] 304 | | [INFO] [stderr] 305 | | let picture_type = match $bytes[start] { [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | / $i += 1; [INFO] [stderr] 304 | | [INFO] [stderr] 305 | | let picture_type = match $bytes[start] { [INFO] [stderr] 306 | | 0 => Some(PictureType::Other), [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:337:25 [INFO] [stderr] | [INFO] [stderr] 337 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 338 | | $i = $bytes.len(); Some(&$i); [INFO] [stderr] 339 | | $bytes[start..].to_vec() [INFO] [stderr] 340 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:290:25 [INFO] [stderr] | [INFO] [stderr] 290 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 291 | | let (end, with_delim) = find_delim!($bytes, Encoding::Latin1, $i, $terminated); [INFO] [stderr] 292 | | $i = with_delim; Some(&$i); [INFO] [stderr] 293 | | try!(String::from_utf8($bytes[start..end].to_vec())) [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:338:13 [INFO] [stderr] | [INFO] [stderr] 338 | $i = $bytes.len(); Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | match ::util::find_delim($encoding, $bytes, $i) { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 240 | | Some(i) => (i, i + ::util::delim_len($encoding)), [INFO] [stderr] 241 | | None => return Err(::Error::new(::ErrorKind::Parsing, "delimiter not found")) [INFO] [stderr] 242 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:338:13 [INFO] [stderr] | [INFO] [stderr] 338 | $i = $bytes.len(); Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:298:16 [INFO] [stderr] | [INFO] [stderr] 298 | if $i + 1 >= $bytes.len() { [INFO] [stderr] | ________________^ [INFO] [stderr] 299 | | return Err(::Error::new(::ErrorKind::Parsing, "insufficient data")); [INFO] [stderr] 300 | | } [INFO] [stderr] 301 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:338:13 [INFO] [stderr] | [INFO] [stderr] 338 | $i = $bytes.len(); Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:302:25 [INFO] [stderr] | [INFO] [stderr] 302 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 303 | | $i += 1; [INFO] [stderr] 304 | | [INFO] [stderr] 305 | | let picture_type = match $bytes[start] { [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:338:13 [INFO] [stderr] | [INFO] [stderr] 338 | $i = $bytes.len(); Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | / $i += 1; [INFO] [stderr] 304 | | [INFO] [stderr] 305 | | let picture_type = match $bytes[start] { [INFO] [stderr] 306 | | 0 => Some(PictureType::Other), [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:338:13 [INFO] [stderr] | [INFO] [stderr] 338 | $i = $bytes.len(); Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:250:25 [INFO] [stderr] | [INFO] [stderr] 250 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 251 | | let (end, with_delim) = find_delim!($bytes, $params.encoding, $i, $terminated); [INFO] [stderr] 252 | | $i = with_delim; Some(&$i); [INFO] [stderr] 253 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:338:13 [INFO] [stderr] | [INFO] [stderr] 338 | $i = $bytes.len(); Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:250:25 [INFO] [stderr] | [INFO] [stderr] 250 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 251 | | let (end, with_delim) = find_delim!($bytes, $params.encoding, $i, $terminated); [INFO] [stderr] 252 | | $i = with_delim; Some(&$i); [INFO] [stderr] 253 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | $i += $len; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | match ::util::find_delim($encoding, $bytes, $i) { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 240 | | Some(i) => (i, i + ::util::delim_len($encoding)), [INFO] [stderr] 241 | | None => return Err(::Error::new(::ErrorKind::Parsing, "delimiter not found")) [INFO] [stderr] 242 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | $i += $len; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:279:16 [INFO] [stderr] | [INFO] [stderr] 279 | if $i + $len >= $bytes.len() { [INFO] [stderr] | ________________^ [INFO] [stderr] 280 | | return Err(::Error::new(::ErrorKind::Parsing, "insufficient data")); [INFO] [stderr] 281 | | } [INFO] [stderr] 282 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:283:25 [INFO] [stderr] | [INFO] [stderr] 283 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 284 | | $i += $len; [INFO] [stderr] 285 | | try!(::util::string_from_latin1(&$bytes[start..$i])) [INFO] [stderr] 286 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | / $i += $len; [INFO] [stderr] 285 | | try!(::util::string_from_latin1(&$bytes[start..$i])) [INFO] [stderr] 286 | | } [INFO] [stderr] 287 | | }; [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:250:25 [INFO] [stderr] | [INFO] [stderr] 250 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 251 | | let (end, with_delim) = find_delim!($bytes, $params.encoding, $i, $terminated); [INFO] [stderr] 252 | | $i = with_delim; Some(&$i); [INFO] [stderr] 253 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | match ::util::find_delim($encoding, $bytes, $i) { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 240 | | Some(i) => (i, i + ::util::delim_len($encoding)), [INFO] [stderr] 241 | | None => return Err(::Error::new(::ErrorKind::Parsing, "delimiter not found")) [INFO] [stderr] 242 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:279:16 [INFO] [stderr] | [INFO] [stderr] 279 | if $i + $len >= $bytes.len() { [INFO] [stderr] | ________________^ [INFO] [stderr] 280 | | return Err(::Error::new(::ErrorKind::Parsing, "insufficient data")); [INFO] [stderr] 281 | | } [INFO] [stderr] 282 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:283:25 [INFO] [stderr] | [INFO] [stderr] 283 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 284 | | $i += $len; [INFO] [stderr] 285 | | try!(::util::string_from_latin1(&$bytes[start..$i])) [INFO] [stderr] 286 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | / $i += $len; [INFO] [stderr] 285 | | try!(::util::string_from_latin1(&$bytes[start..$i])) [INFO] [stderr] 286 | | } [INFO] [stderr] 287 | | }; [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:250:25 [INFO] [stderr] | [INFO] [stderr] 250 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 251 | | let (end, with_delim) = find_delim!($bytes, $params.encoding, $i, $terminated); [INFO] [stderr] 252 | | $i = with_delim; Some(&$i); [INFO] [stderr] 253 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | match ::util::find_delim($encoding, $bytes, $i) { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 240 | | Some(i) => (i, i + ::util::delim_len($encoding)), [INFO] [stderr] 241 | | None => return Err(::Error::new(::ErrorKind::Parsing, "delimiter not found")) [INFO] [stderr] 242 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:250:25 [INFO] [stderr] | [INFO] [stderr] 250 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 251 | | let (end, with_delim) = find_delim!($bytes, $params.encoding, $i, $terminated); [INFO] [stderr] 252 | | $i = with_delim; Some(&$i); [INFO] [stderr] 253 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 428 | return decode!(data, ExtendedText, description: string(true), value: string(false)); [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 428 | return decode!(data, ExtendedText, description: string(true), value: string(false)); [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | match ::util::find_delim($encoding, $bytes, $i) { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 240 | | Some(i) => (i, i + ::util::delim_len($encoding)), [INFO] [stderr] 241 | | None => return Err(::Error::new(::ErrorKind::Parsing, "delimiter not found")) [INFO] [stderr] 242 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 428 | return decode!(data, ExtendedText, description: string(true), value: string(false)); [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 428 | return decode!(data, ExtendedText, description: string(true), value: string(false)); [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:250:25 [INFO] [stderr] | [INFO] [stderr] 250 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 251 | | let (end, with_delim) = find_delim!($bytes, $params.encoding, $i, $terminated); [INFO] [stderr] 252 | | $i = with_delim; Some(&$i); [INFO] [stderr] 253 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 428 | return decode!(data, ExtendedText, description: string(true), value: string(false)); [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 428 | return decode!(data, ExtendedText, description: string(true), value: string(false)); [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | match ::util::find_delim($encoding, $bytes, $i) { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 240 | | Some(i) => (i, i + ::util::delim_len($encoding)), [INFO] [stderr] 241 | | None => return Err(::Error::new(::ErrorKind::Parsing, "delimiter not found")) [INFO] [stderr] 242 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 428 | return decode!(data, ExtendedText, description: string(true), value: string(false)); [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 428 | return decode!(data, ExtendedText, description: string(true), value: string(false)); [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:250:25 [INFO] [stderr] | [INFO] [stderr] 250 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 251 | | let (end, with_delim) = find_delim!($bytes, $params.encoding, $i, $terminated); [INFO] [stderr] 252 | | $i = with_delim; Some(&$i); [INFO] [stderr] 253 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | $i += $len; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | match ::util::find_delim($encoding, $bytes, $i) { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 240 | | Some(i) => (i, i + ::util::delim_len($encoding)), [INFO] [stderr] 241 | | None => return Err(::Error::new(::ErrorKind::Parsing, "delimiter not found")) [INFO] [stderr] 242 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | $i += $len; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:279:16 [INFO] [stderr] | [INFO] [stderr] 279 | if $i + $len >= $bytes.len() { [INFO] [stderr] | ________________^ [INFO] [stderr] 280 | | return Err(::Error::new(::ErrorKind::Parsing, "insufficient data")); [INFO] [stderr] 281 | | } [INFO] [stderr] 282 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:283:25 [INFO] [stderr] | [INFO] [stderr] 283 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 284 | | $i += $len; [INFO] [stderr] 285 | | try!(::util::string_from_latin1(&$bytes[start..$i])) [INFO] [stderr] 286 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | / $i += $len; [INFO] [stderr] 285 | | try!(::util::string_from_latin1(&$bytes[start..$i])) [INFO] [stderr] 286 | | } [INFO] [stderr] 287 | | }; [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:250:25 [INFO] [stderr] | [INFO] [stderr] 250 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 251 | | let (end, with_delim) = find_delim!($bytes, $params.encoding, $i, $terminated); [INFO] [stderr] 252 | | $i = with_delim; Some(&$i); [INFO] [stderr] 253 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | match ::util::find_delim($encoding, $bytes, $i) { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 240 | | Some(i) => (i, i + ::util::delim_len($encoding)), [INFO] [stderr] 241 | | None => return Err(::Error::new(::ErrorKind::Parsing, "delimiter not found")) [INFO] [stderr] 242 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:279:16 [INFO] [stderr] | [INFO] [stderr] 279 | if $i + $len >= $bytes.len() { [INFO] [stderr] | ________________^ [INFO] [stderr] 280 | | return Err(::Error::new(::ErrorKind::Parsing, "insufficient data")); [INFO] [stderr] 281 | | } [INFO] [stderr] 282 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:283:25 [INFO] [stderr] | [INFO] [stderr] 283 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 284 | | $i += $len; [INFO] [stderr] 285 | | try!(::util::string_from_latin1(&$bytes[start..$i])) [INFO] [stderr] 286 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | / $i += $len; [INFO] [stderr] 285 | | try!(::util::string_from_latin1(&$bytes[start..$i])) [INFO] [stderr] 286 | | } [INFO] [stderr] 287 | | }; [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:250:25 [INFO] [stderr] | [INFO] [stderr] 250 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 251 | | let (end, with_delim) = find_delim!($bytes, $params.encoding, $i, $terminated); [INFO] [stderr] 252 | | $i = with_delim; Some(&$i); [INFO] [stderr] 253 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | match ::util::find_delim($encoding, $bytes, $i) { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 240 | | Some(i) => (i, i + ::util::delim_len($encoding)), [INFO] [stderr] 241 | | None => return Err(::Error::new(::ErrorKind::Parsing, "delimiter not found")) [INFO] [stderr] 242 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tag.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn minor(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/util.rs:209:5 [INFO] [stderr] | [INFO] [stderr] 209 | ID_2_TO_3.get(id).map(|t| *t) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `ID_2_TO_3.get(id).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/util.rs:214:5 [INFO] [stderr] | [INFO] [stderr] 214 | ID_3_TO_2.get(id).map(|t| *t) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `ID_3_TO_2.get(id).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/v1/mod.rs:116:18 [INFO] [stderr] | [INFO] [stderr] 116 | base.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/v1/mod.rs:120:41 [INFO] [stderr] | [INFO] [stderr] 120 | .flat_map(|s| s.into_iter()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/v1/mod.rs:210:9 [INFO] [stderr] | [INFO] [stderr] 210 | / GENRE_LIST.get(self.genre_id as usize) [INFO] [stderr] 211 | | .map(|s| *s) [INFO] [stderr] | |________________________^ help: Consider calling the dedicated `cloned` method: `GENRE_LIST.get(self.genre_id as usize).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/stream/frame/content.rs:402:1 [INFO] [stderr] | [INFO] [stderr] 402 | / fn parse_apic_v3(data: &[u8]) -> ::Result { [INFO] [stderr] 403 | | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] 405 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:298:16 [INFO] [stderr] | [INFO] [stderr] 298 | if $i + 1 >= $bytes.len() { [INFO] [stderr] | ________________^ [INFO] [stderr] 299 | | return Err(::Error::new(::ErrorKind::Parsing, "insufficient data")); [INFO] [stderr] 300 | | } [INFO] [stderr] 301 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::eval_order_dependence)] on by default [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:302:25 [INFO] [stderr] | [INFO] [stderr] 302 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 303 | | $i += 1; [INFO] [stderr] 304 | | [INFO] [stderr] 305 | | let picture_type = match $bytes[start] { [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | / $i += 1; [INFO] [stderr] 304 | | [INFO] [stderr] 305 | | let picture_type = match $bytes[start] { [INFO] [stderr] 306 | | 0 => Some(PictureType::Other), [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:250:25 [INFO] [stderr] | [INFO] [stderr] 250 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 251 | | let (end, with_delim) = find_delim!($bytes, $params.encoding, $i, $terminated); [INFO] [stderr] 252 | | $i = with_delim; Some(&$i); [INFO] [stderr] 253 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | match ::util::find_delim($encoding, $bytes, $i) { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 240 | | Some(i) => (i, i + ::util::delim_len($encoding)), [INFO] [stderr] 241 | | None => return Err(::Error::new(::ErrorKind::Parsing, "delimiter not found")) [INFO] [stderr] 242 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:337:25 [INFO] [stderr] | [INFO] [stderr] 337 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 338 | | $i = $bytes.len(); Some(&$i); [INFO] [stderr] 339 | | $bytes[start..].to_vec() [INFO] [stderr] 340 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:290:25 [INFO] [stderr] | [INFO] [stderr] 290 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 291 | | let (end, with_delim) = find_delim!($bytes, Encoding::Latin1, $i, $terminated); [INFO] [stderr] 292 | | $i = with_delim; Some(&$i); [INFO] [stderr] 293 | | try!(String::from_utf8($bytes[start..end].to_vec())) [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | $i += 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | match ::util::find_delim($encoding, $bytes, $i) { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 240 | | Some(i) => (i, i + ::util::delim_len($encoding)), [INFO] [stderr] 241 | | None => return Err(::Error::new(::ErrorKind::Parsing, "delimiter not found")) [INFO] [stderr] 242 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | $i += 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:250:25 [INFO] [stderr] | [INFO] [stderr] 250 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 251 | | let (end, with_delim) = find_delim!($bytes, $params.encoding, $i, $terminated); [INFO] [stderr] 252 | | $i = with_delim; Some(&$i); [INFO] [stderr] 253 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | $i += 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:337:25 [INFO] [stderr] | [INFO] [stderr] 337 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 338 | | $i = $bytes.len(); Some(&$i); [INFO] [stderr] 339 | | $bytes[start..].to_vec() [INFO] [stderr] 340 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | $i += 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:290:25 [INFO] [stderr] | [INFO] [stderr] 290 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 291 | | let (end, with_delim) = find_delim!($bytes, Encoding::Latin1, $i, $terminated); [INFO] [stderr] 292 | | $i = with_delim; Some(&$i); [INFO] [stderr] 293 | | try!(String::from_utf8($bytes[start..end].to_vec())) [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | match ::util::find_delim($encoding, $bytes, $i) { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 240 | | Some(i) => (i, i + ::util::delim_len($encoding)), [INFO] [stderr] 241 | | None => return Err(::Error::new(::ErrorKind::Parsing, "delimiter not found")) [INFO] [stderr] 242 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:298:16 [INFO] [stderr] | [INFO] [stderr] 298 | if $i + 1 >= $bytes.len() { [INFO] [stderr] | ________________^ [INFO] [stderr] 299 | | return Err(::Error::new(::ErrorKind::Parsing, "insufficient data")); [INFO] [stderr] 300 | | } [INFO] [stderr] 301 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:302:25 [INFO] [stderr] | [INFO] [stderr] 302 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 303 | | $i += 1; [INFO] [stderr] 304 | | [INFO] [stderr] 305 | | let picture_type = match $bytes[start] { [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | / $i += 1; [INFO] [stderr] 304 | | [INFO] [stderr] 305 | | let picture_type = match $bytes[start] { [INFO] [stderr] 306 | | 0 => Some(PictureType::Other), [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:337:25 [INFO] [stderr] | [INFO] [stderr] 337 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 338 | | $i = $bytes.len(); Some(&$i); [INFO] [stderr] 339 | | $bytes[start..].to_vec() [INFO] [stderr] 340 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:290:25 [INFO] [stderr] | [INFO] [stderr] 290 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 291 | | let (end, with_delim) = find_delim!($bytes, Encoding::Latin1, $i, $terminated); [INFO] [stderr] 292 | | $i = with_delim; Some(&$i); [INFO] [stderr] 293 | | try!(String::from_utf8($bytes[start..end].to_vec())) [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:338:13 [INFO] [stderr] | [INFO] [stderr] 338 | $i = $bytes.len(); Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | match ::util::find_delim($encoding, $bytes, $i) { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 240 | | Some(i) => (i, i + ::util::delim_len($encoding)), [INFO] [stderr] 241 | | None => return Err(::Error::new(::ErrorKind::Parsing, "delimiter not found")) [INFO] [stderr] 242 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:338:13 [INFO] [stderr] | [INFO] [stderr] 338 | $i = $bytes.len(); Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:298:16 [INFO] [stderr] | [INFO] [stderr] 298 | if $i + 1 >= $bytes.len() { [INFO] [stderr] | ________________^ [INFO] [stderr] 299 | | return Err(::Error::new(::ErrorKind::Parsing, "insufficient data")); [INFO] [stderr] 300 | | } [INFO] [stderr] 301 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:338:13 [INFO] [stderr] | [INFO] [stderr] 338 | $i = $bytes.len(); Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:302:25 [INFO] [stderr] | [INFO] [stderr] 302 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 303 | | $i += 1; [INFO] [stderr] 304 | | [INFO] [stderr] 305 | | let picture_type = match $bytes[start] { [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:338:13 [INFO] [stderr] | [INFO] [stderr] 338 | $i = $bytes.len(); Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | / $i += 1; [INFO] [stderr] 304 | | [INFO] [stderr] 305 | | let picture_type = match $bytes[start] { [INFO] [stderr] 306 | | 0 => Some(PictureType::Other), [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:338:13 [INFO] [stderr] | [INFO] [stderr] 338 | $i = $bytes.len(); Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:250:25 [INFO] [stderr] | [INFO] [stderr] 250 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 251 | | let (end, with_delim) = find_delim!($bytes, $params.encoding, $i, $terminated); [INFO] [stderr] 252 | | $i = with_delim; Some(&$i); [INFO] [stderr] 253 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:338:13 [INFO] [stderr] | [INFO] [stderr] 338 | $i = $bytes.len(); Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | return decode!(data, Picture, mime_type: latin1(true), picture_type : picture_type(), [INFO] [stderr] | ____________- [INFO] [stderr] 404 | | description: string(true), data: bytes()); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:250:25 [INFO] [stderr] | [INFO] [stderr] 250 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 251 | | let (end, with_delim) = find_delim!($bytes, $params.encoding, $i, $terminated); [INFO] [stderr] 252 | | $i = with_delim; Some(&$i); [INFO] [stderr] 253 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | $i += $len; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | match ::util::find_delim($encoding, $bytes, $i) { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 240 | | Some(i) => (i, i + ::util::delim_len($encoding)), [INFO] [stderr] 241 | | None => return Err(::Error::new(::ErrorKind::Parsing, "delimiter not found")) [INFO] [stderr] 242 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | $i += $len; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:279:16 [INFO] [stderr] | [INFO] [stderr] 279 | if $i + $len >= $bytes.len() { [INFO] [stderr] | ________________^ [INFO] [stderr] 280 | | return Err(::Error::new(::ErrorKind::Parsing, "insufficient data")); [INFO] [stderr] 281 | | } [INFO] [stderr] 282 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:283:25 [INFO] [stderr] | [INFO] [stderr] 283 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 284 | | $i += $len; [INFO] [stderr] 285 | | try!(::util::string_from_latin1(&$bytes[start..$i])) [INFO] [stderr] 286 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | / $i += $len; [INFO] [stderr] 285 | | try!(::util::string_from_latin1(&$bytes[start..$i])) [INFO] [stderr] 286 | | } [INFO] [stderr] 287 | | }; [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:250:25 [INFO] [stderr] | [INFO] [stderr] 250 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 251 | | let (end, with_delim) = find_delim!($bytes, $params.encoding, $i, $terminated); [INFO] [stderr] 252 | | $i = with_delim; Some(&$i); [INFO] [stderr] 253 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | match ::util::find_delim($encoding, $bytes, $i) { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 240 | | Some(i) => (i, i + ::util::delim_len($encoding)), [INFO] [stderr] 241 | | None => return Err(::Error::new(::ErrorKind::Parsing, "delimiter not found")) [INFO] [stderr] 242 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:279:16 [INFO] [stderr] | [INFO] [stderr] 279 | if $i + $len >= $bytes.len() { [INFO] [stderr] | ________________^ [INFO] [stderr] 280 | | return Err(::Error::new(::ErrorKind::Parsing, "insufficient data")); [INFO] [stderr] 281 | | } [INFO] [stderr] 282 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:283:25 [INFO] [stderr] | [INFO] [stderr] 283 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 284 | | $i += $len; [INFO] [stderr] 285 | | try!(::util::string_from_latin1(&$bytes[start..$i])) [INFO] [stderr] 286 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | / $i += $len; [INFO] [stderr] 285 | | try!(::util::string_from_latin1(&$bytes[start..$i])) [INFO] [stderr] 286 | | } [INFO] [stderr] 287 | | }; [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:250:25 [INFO] [stderr] | [INFO] [stderr] 250 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 251 | | let (end, with_delim) = find_delim!($bytes, $params.encoding, $i, $terminated); [INFO] [stderr] 252 | | $i = with_delim; Some(&$i); [INFO] [stderr] 253 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | match ::util::find_delim($encoding, $bytes, $i) { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 240 | | Some(i) => (i, i + ::util::delim_len($encoding)), [INFO] [stderr] 241 | | None => return Err(::Error::new(::ErrorKind::Parsing, "delimiter not found")) [INFO] [stderr] 242 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 410 | return decode!(data, Comment, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 411 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:250:25 [INFO] [stderr] | [INFO] [stderr] 250 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 251 | | let (end, with_delim) = find_delim!($bytes, $params.encoding, $i, $terminated); [INFO] [stderr] 252 | | $i = with_delim; Some(&$i); [INFO] [stderr] 253 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 428 | return decode!(data, ExtendedText, description: string(true), value: string(false)); [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 428 | return decode!(data, ExtendedText, description: string(true), value: string(false)); [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | match ::util::find_delim($encoding, $bytes, $i) { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 240 | | Some(i) => (i, i + ::util::delim_len($encoding)), [INFO] [stderr] 241 | | None => return Err(::Error::new(::ErrorKind::Parsing, "delimiter not found")) [INFO] [stderr] 242 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 428 | return decode!(data, ExtendedText, description: string(true), value: string(false)); [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 428 | return decode!(data, ExtendedText, description: string(true), value: string(false)); [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:250:25 [INFO] [stderr] | [INFO] [stderr] 250 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 251 | | let (end, with_delim) = find_delim!($bytes, $params.encoding, $i, $terminated); [INFO] [stderr] 252 | | $i = with_delim; Some(&$i); [INFO] [stderr] 253 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 428 | return decode!(data, ExtendedText, description: string(true), value: string(false)); [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 428 | return decode!(data, ExtendedText, description: string(true), value: string(false)); [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | match ::util::find_delim($encoding, $bytes, $i) { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 240 | | Some(i) => (i, i + ::util::delim_len($encoding)), [INFO] [stderr] 241 | | None => return Err(::Error::new(::ErrorKind::Parsing, "delimiter not found")) [INFO] [stderr] 242 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 428 | return decode!(data, ExtendedText, description: string(true), value: string(false)); [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 428 | return decode!(data, ExtendedText, description: string(true), value: string(false)); [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:250:25 [INFO] [stderr] | [INFO] [stderr] 250 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 251 | | let (end, with_delim) = find_delim!($bytes, $params.encoding, $i, $terminated); [INFO] [stderr] 252 | | $i = with_delim; Some(&$i); [INFO] [stderr] 253 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | $i += $len; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | match ::util::find_delim($encoding, $bytes, $i) { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 240 | | Some(i) => (i, i + ::util::delim_len($encoding)), [INFO] [stderr] 241 | | None => return Err(::Error::new(::ErrorKind::Parsing, "delimiter not found")) [INFO] [stderr] 242 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | $i += $len; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:279:16 [INFO] [stderr] | [INFO] [stderr] 279 | if $i + $len >= $bytes.len() { [INFO] [stderr] | ________________^ [INFO] [stderr] 280 | | return Err(::Error::new(::ErrorKind::Parsing, "insufficient data")); [INFO] [stderr] 281 | | } [INFO] [stderr] 282 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:283:25 [INFO] [stderr] | [INFO] [stderr] 283 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 284 | | $i += $len; [INFO] [stderr] 285 | | try!(::util::string_from_latin1(&$bytes[start..$i])) [INFO] [stderr] 286 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | / $i += $len; [INFO] [stderr] 285 | | try!(::util::string_from_latin1(&$bytes[start..$i])) [INFO] [stderr] 286 | | } [INFO] [stderr] 287 | | }; [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:250:25 [INFO] [stderr] | [INFO] [stderr] 250 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 251 | | let (end, with_delim) = find_delim!($bytes, $params.encoding, $i, $terminated); [INFO] [stderr] 252 | | $i = with_delim; Some(&$i); [INFO] [stderr] 253 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | match ::util::find_delim($encoding, $bytes, $i) { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 240 | | Some(i) => (i, i + ::util::delim_len($encoding)), [INFO] [stderr] 241 | | None => return Err(::Error::new(::ErrorKind::Parsing, "delimiter not found")) [INFO] [stderr] 242 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:279:16 [INFO] [stderr] | [INFO] [stderr] 279 | if $i + $len >= $bytes.len() { [INFO] [stderr] | ________________^ [INFO] [stderr] 280 | | return Err(::Error::new(::ErrorKind::Parsing, "insufficient data")); [INFO] [stderr] 281 | | } [INFO] [stderr] 282 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:283:25 [INFO] [stderr] | [INFO] [stderr] 283 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 284 | | $i += $len; [INFO] [stderr] 285 | | try!(::util::string_from_latin1(&$bytes[start..$i])) [INFO] [stderr] 286 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | / $i += $len; [INFO] [stderr] 285 | | try!(::util::string_from_latin1(&$bytes[start..$i])) [INFO] [stderr] 286 | | } [INFO] [stderr] 287 | | }; [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:250:25 [INFO] [stderr] | [INFO] [stderr] 250 | let start = $i; [INFO] [stderr] | _________________________^ [INFO] [stderr] 251 | | let (end, with_delim) = find_delim!($bytes, $params.encoding, $i, $terminated); [INFO] [stderr] 252 | | $i = with_delim; Some(&$i); [INFO] [stderr] 253 | | [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/stream/frame/content.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | match ::util::find_delim($encoding, $bytes, $i) { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 240 | | Some(i) => (i, i + ::util::delim_len($encoding)), [INFO] [stderr] 241 | | None => return Err(::Error::new(::ErrorKind::Parsing, "delimiter not found")) [INFO] [stderr] 242 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | content: Content::$result_type( $result_type { [INFO] [stderr] 359 | | $($field: decode_part!($bytes, params, i, $part ( $($params)* ) ),)+ [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/stream/frame/content.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | $i = with_delim; Some(&$i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 458 | return decode!(data, Lyrics, lang: fixed_string(3), description: string(true), [INFO] [stderr] | ____________- [INFO] [stderr] 459 | | text: string(false)); [INFO] [stderr] | |_______________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tag.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn minor(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/util.rs:209:5 [INFO] [stderr] | [INFO] [stderr] 209 | ID_2_TO_3.get(id).map(|t| *t) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `ID_2_TO_3.get(id).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/util.rs:214:5 [INFO] [stderr] | [INFO] [stderr] 214 | ID_3_TO_2.get(id).map(|t| *t) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `ID_3_TO_2.get(id).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.88s [INFO] running `"docker" "inspect" "0a37cd449d20fa40125934ad1e3daa7fcba3ed22f6e7ee541608afb0fefc6398"` [INFO] running `"docker" "rm" "-f" "0a37cd449d20fa40125934ad1e3daa7fcba3ed22f6e7ee541608afb0fefc6398"` [INFO] [stdout] 0a37cd449d20fa40125934ad1e3daa7fcba3ed22f6e7ee541608afb0fefc6398