[INFO] crate icns 0.3.0 is already in cache
[INFO] extracting crate icns 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/icns/0.3.0
[INFO] extracting crate icns 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/icns/0.3.0
[INFO] validating manifest of icns-0.3.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of icns-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing icns-0.3.0
[INFO] finished frobbing icns-0.3.0
[INFO] frobbed toml for icns-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/icns/0.3.0/Cargo.toml
[INFO] started frobbing icns-0.3.0
[INFO] finished frobbing icns-0.3.0
[INFO] frobbed toml for icns-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/icns/0.3.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting icns-0.3.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/icns/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ae9de89e69f14c2667d684975a8416469dc8c5a57dd6df2e7c7c7bfd4ba184f4
[INFO] running `"docker" "start" "-a" "ae9de89e69f14c2667d684975a8416469dc8c5a57dd6df2e7c7c7bfd4ba184f4"`
[INFO] [stderr]     Checking png v0.13.2
[INFO] [stderr]     Checking icns v0.3.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/element.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 |             ostype: ostype,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `ostype`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/element.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |             data: data,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/image.rs:29:13
[INFO] [stderr]    |
[INFO] [stderr] 29 |             format: format,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `format`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/image.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 |             width: width,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `width`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/image.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |             height: height,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `height`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/image.rs:47:17
[INFO] [stderr]    |
[INFO] [stderr] 47 |                 format: format,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^ help: replace it with: `format`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/image.rs:48:17
[INFO] [stderr]    |
[INFO] [stderr] 48 |                 width: width,
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: replace it with: `width`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/image.rs:49:17
[INFO] [stderr]    |
[INFO] [stderr] 49 |                 height: height,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^ help: replace it with: `height`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/image.rs:146:13
[INFO] [stderr]     |
[INFO] [stderr] 146 |             format: format,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `format`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/element.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 |             ostype: ostype,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `ostype`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/element.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |             data: data,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/image.rs:29:13
[INFO] [stderr]    |
[INFO] [stderr] 29 |             format: format,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `format`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/image.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 |             width: width,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `width`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/image.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |             height: height,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `height`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/image.rs:47:17
[INFO] [stderr]    |
[INFO] [stderr] 47 |                 format: format,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^ help: replace it with: `format`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/image.rs:48:17
[INFO] [stderr]    |
[INFO] [stderr] 48 |                 width: width,
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: replace it with: `width`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/image.rs:49:17
[INFO] [stderr]    |
[INFO] [stderr] 49 |                 height: height,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^ help: replace it with: `height`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/image.rs:146:13
[INFO] [stderr]     |
[INFO] [stderr] 146 |             format: format,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `format`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/family.rs:9:28
[INFO] [stderr]   |
[INFO] [stderr] 9 | const ICNS_MAGIC_LITERAL: &'static [u8; 4] = b"icns";
[INFO] [stderr]   |                           -^^^^^^^-------- help: consider removing `'static`: `&[u8; 4]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/family.rs:9:28
[INFO] [stderr]   |
[INFO] [stderr] 9 | const ICNS_MAGIC_LITERAL: &'static [u8; 4] = b"icns";
[INFO] [stderr]   |                           -^^^^^^^-------- help: consider removing `'static`: `&[u8; 4]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `family::IconFamily`
[INFO] [stderr]   --> src/family.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 | /     pub fn new() -> IconFamily {
[INFO] [stderr] 23 | |         IconFamily { elements: Vec::new() }
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 15 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/icontype.rs:397:24
[INFO] [stderr]     |
[INFO] [stderr] 397 |             if value > std::u8::MAX as u32 {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(std::u8::MAX)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `family::IconFamily`
[INFO] [stderr]   --> src/family.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 | /     pub fn new() -> IconFamily {
[INFO] [stderr] 23 | |         IconFamily { elements: Vec::new() }
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 15 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/icontype.rs:397:24
[INFO] [stderr]     |
[INFO] [stderr] 397 |             if value > std::u8::MAX as u32 {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(std::u8::MAX)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 6.84s
[INFO] running `"docker" "inspect" "ae9de89e69f14c2667d684975a8416469dc8c5a57dd6df2e7c7c7bfd4ba184f4"`
[INFO] running `"docker" "rm" "-f" "ae9de89e69f14c2667d684975a8416469dc8c5a57dd6df2e7c7c7bfd4ba184f4"`
[INFO] [stdout] ae9de89e69f14c2667d684975a8416469dc8c5a57dd6df2e7c7c7bfd4ba184f4