[INFO] crate icingacli 0.1.2 is already in cache [INFO] extracting crate icingacli 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/icingacli/0.1.2 [INFO] extracting crate icingacli 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/icingacli/0.1.2 [INFO] validating manifest of icingacli-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of icingacli-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing icingacli-0.1.2 [INFO] finished frobbing icingacli-0.1.2 [INFO] frobbed toml for icingacli-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/icingacli/0.1.2/Cargo.toml [INFO] started frobbing icingacli-0.1.2 [INFO] finished frobbing icingacli-0.1.2 [INFO] frobbed toml for icingacli-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/icingacli/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting icingacli-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/icingacli/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a995ff0266d80c7c29469ba4d57487a0d660c1c13348cd506d97169e4bb49ac3 [INFO] running `"docker" "start" "-a" "a995ff0266d80c7c29469ba4d57487a0d660c1c13348cd506d97169e4bb49ac3"` [INFO] [stderr] Checking icingacli v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:202:17 [INFO] [stderr] | [INFO] [stderr] 202 | Group { name: name } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:235:16 [INFO] [stderr] | [INFO] [stderr] 235 | Host { name: name } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:271:13 [INFO] [stderr] | [INFO] [stderr] 271 | author: author, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `author` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:272:13 [INFO] [stderr] | [INFO] [stderr] 272 | comment: comment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `comment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:311:26 [INFO] [stderr] | [INFO] [stderr] 311 | GenerateTicket { cn: cn } [INFO] [stderr] | ^^^^^^ help: replace it with: `cn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:363:13 [INFO] [stderr] | [INFO] [stderr] 363 | author: author, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `author` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:364:13 [INFO] [stderr] | [INFO] [stderr] 364 | comment: comment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `comment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:365:13 [INFO] [stderr] | [INFO] [stderr] 365 | expiry: expiry, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `expiry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:366:13 [INFO] [stderr] | [INFO] [stderr] 366 | sticky: sticky, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sticky` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:367:13 [INFO] [stderr] | [INFO] [stderr] 367 | notify: notify, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `notify` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:368:13 [INFO] [stderr] | [INFO] [stderr] 368 | filter: filter, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `filter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:418:13 [INFO] [stderr] | [INFO] [stderr] 418 | author: author, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `author` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:419:13 [INFO] [stderr] | [INFO] [stderr] 419 | comment: comment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `comment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:420:13 [INFO] [stderr] | [INFO] [stderr] 420 | start_time: start_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:421:13 [INFO] [stderr] | [INFO] [stderr] 421 | end_time: end_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `end_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:422:13 [INFO] [stderr] | [INFO] [stderr] 422 | child_options: child_options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `child_options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:202:17 [INFO] [stderr] | [INFO] [stderr] 202 | Group { name: name } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:235:16 [INFO] [stderr] | [INFO] [stderr] 235 | Host { name: name } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:271:13 [INFO] [stderr] | [INFO] [stderr] 271 | author: author, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `author` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:272:13 [INFO] [stderr] | [INFO] [stderr] 272 | comment: comment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `comment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:311:26 [INFO] [stderr] | [INFO] [stderr] 311 | GenerateTicket { cn: cn } [INFO] [stderr] | ^^^^^^ help: replace it with: `cn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:363:13 [INFO] [stderr] | [INFO] [stderr] 363 | author: author, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `author` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:364:13 [INFO] [stderr] | [INFO] [stderr] 364 | comment: comment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `comment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:365:13 [INFO] [stderr] | [INFO] [stderr] 365 | expiry: expiry, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `expiry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:366:13 [INFO] [stderr] | [INFO] [stderr] 366 | sticky: sticky, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sticky` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:367:13 [INFO] [stderr] | [INFO] [stderr] 367 | notify: notify, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `notify` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:368:13 [INFO] [stderr] | [INFO] [stderr] 368 | filter: filter, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `filter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:418:13 [INFO] [stderr] | [INFO] [stderr] 418 | author: author, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `author` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:419:13 [INFO] [stderr] | [INFO] [stderr] 419 | comment: comment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `comment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:420:13 [INFO] [stderr] | [INFO] [stderr] 420 | start_time: start_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:421:13 [INFO] [stderr] | [INFO] [stderr] 421 | end_time: end_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `end_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:422:13 [INFO] [stderr] | [INFO] [stderr] 422 | child_options: child_options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `child_options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: method is never used: `send` [INFO] [stderr] --> src/api.rs:463:5 [INFO] [stderr] | [INFO] [stderr] 463 | pub fn send(&self, conf: Config) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `send` [INFO] [stderr] --> src/api.rs:463:5 [INFO] [stderr] | [INFO] [stderr] 463 | pub fn send(&self, conf: Config) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/icingacli.rs:132:48 [INFO] [stderr] | [INFO] [stderr] 132 | let cn = api::GenerateTicket { cn: cn }; [INFO] [stderr] | ^^^^^^ help: replace it with: `cn` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/icingacli.rs:132:48 [INFO] [stderr] | [INFO] [stderr] 132 | let cn = api::GenerateTicket { cn: cn }; [INFO] [stderr] | ^^^^^^ help: replace it with: `cn` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 36 [INFO] [stderr] --> src/bin/icingacli.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / fn main() { [INFO] [stderr] 14 | | let yaml = load_yaml!("cli.yml"); [INFO] [stderr] 15 | | let matches = App::from_yaml(yaml).version(crate_version!()).get_matches(); [INFO] [stderr] 16 | | let path = if matches.is_present("config") { [INFO] [stderr] ... | [INFO] [stderr] 252 | | } [INFO] [stderr] 253 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 36 [INFO] [stderr] --> src/bin/icingacli.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / fn main() { [INFO] [stderr] 14 | | let yaml = load_yaml!("cli.yml"); [INFO] [stderr] 15 | | let matches = App::from_yaml(yaml).version(crate_version!()).get_matches(); [INFO] [stderr] 16 | | let path = if matches.is_present("config") { [INFO] [stderr] ... | [INFO] [stderr] 252 | | } [INFO] [stderr] 253 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.97s [INFO] running `"docker" "inspect" "a995ff0266d80c7c29469ba4d57487a0d660c1c13348cd506d97169e4bb49ac3"` [INFO] running `"docker" "rm" "-f" "a995ff0266d80c7c29469ba4d57487a0d660c1c13348cd506d97169e4bb49ac3"` [INFO] [stdout] a995ff0266d80c7c29469ba4d57487a0d660c1c13348cd506d97169e4bb49ac3