[INFO] crate ice-age 0.3.0 is already in cache [INFO] extracting crate ice-age 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/ice-age/0.3.0 [INFO] extracting crate ice-age 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ice-age/0.3.0 [INFO] validating manifest of ice-age-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ice-age-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ice-age-0.3.0 [INFO] finished frobbing ice-age-0.3.0 [INFO] frobbed toml for ice-age-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/ice-age/0.3.0/Cargo.toml [INFO] started frobbing ice-age-0.3.0 [INFO] finished frobbing ice-age-0.3.0 [INFO] frobbed toml for ice-age-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ice-age/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ice-age-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ice-age/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2d9f508148e1805321a980fb9c8c4a692d7dc04e5f08209505ab39e3f886ebe8 [INFO] running `"docker" "start" "-a" "2d9f508148e1805321a980fb9c8c4a692d7dc04e5f08209505ab39e3f886ebe8"` [INFO] [stderr] Compiling libsqlite3-sys v0.11.1 [INFO] [stderr] Checking rusqlite v0.16.0 [INFO] [stderr] Checking ice-age v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/__.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | pub const UUID: &'static str = "3ec2df31-b5fb-49a9-b91f-de63ec69a058"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/__.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | pub const VERSION: &'static str = "0.1.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:150:18 [INFO] [stderr] | [INFO] [stderr] 150 | pub const NAME: &'static str = "Ice Age"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:153:23 [INFO] [stderr] | [INFO] [stderr] 153 | pub const CODE_NAME: &'static str = code_name!(); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:156:21 [INFO] [stderr] | [INFO] [stderr] 156 | pub const VERSION: &'static str = version!(); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:162:18 [INFO] [stderr] | [INFO] [stderr] 162 | pub const UUID: &'static str = "a9ab5574-e977-427d-a17b-ea421a1a6b5b"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:165:17 [INFO] [stderr] | [INFO] [stderr] 165 | pub const TAG: &'static str = concat!(code_name!(), "::a9ab5574::", version!()); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:178:21 [INFO] [stderr] | [INFO] [stderr] 178 | const SQL_CREATOR: &'static str = include_str!("../res/db_creator.sql"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:181:22 [INFO] [stderr] | [INFO] [stderr] 181 | const LOG_FILE_EXT: &'static str = ".sqlite"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:353:35 [INFO] [stderr] | [INFO] [stderr] 353 | let disk_flush_interval = config.disk_flush_interval.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.disk_flush_interval` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:383:21 [INFO] [stderr] | [INFO] [stderr] 383 | / match now - last_saved >= disk_flush_interval { [INFO] [stderr] 384 | | true => match sender.send(Cmd::FlushToDisk) { [INFO] [stderr] 385 | | Ok(()) => last_saved = Instant::now(), [INFO] [stderr] 386 | | Err(err) => { [INFO] [stderr] ... | [INFO] [stderr] 394 | | }, [INFO] [stderr] 395 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 383 | if now - last_saved >= disk_flush_interval { match sender.send(Cmd::FlushToDisk) { [INFO] [stderr] 384 | Ok(()) => last_saved = Instant::now(), [INFO] [stderr] 385 | Err(err) => { [INFO] [stderr] 386 | __e!("Failed sending {:?} to server -> {}", Cmd::FlushToDisk, err); [INFO] [stderr] 387 | break; [INFO] [stderr] 388 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:427:17 [INFO] [stderr] | [INFO] [stderr] 427 | / match localtime.is_null() { [INFO] [stderr] 428 | | true => return Err(Error::new(ErrorKind::Other, __!("Failed to get local time"))), [INFO] [stderr] 429 | | false => ( [INFO] [stderr] 430 | | (*localtime).tm_year.saturating_add(1900), (*localtime).tm_mon.saturating_add(1), (*localtime).tm_mday, [INFO] [stderr] 431 | | (*localtime).tm_hour, (*localtime).tm_min, (*localtime).tm_sec, [INFO] [stderr] 432 | | ), [INFO] [stderr] 433 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 427 | if localtime.is_null() { return Err(Error::new(ErrorKind::Other, __!("Failed to get local time"))) } else { ( [INFO] [stderr] 428 | (*localtime).tm_year.saturating_add(1900), (*localtime).tm_mon.saturating_add(1), (*localtime).tm_mday, [INFO] [stderr] 429 | (*localtime).tm_hour, (*localtime).tm_min, (*localtime).tm_sec, [INFO] [stderr] 430 | ) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:438:13 [INFO] [stderr] | [INFO] [stderr] 438 | / match path.exists() { [INFO] [stderr] 439 | | true => return Err(Error::new(ErrorKind::Other, __!("Failed to create output file (it existed already): {:?}", path))), [INFO] [stderr] 440 | | false => self.output = Some(path), [INFO] [stderr] 441 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if path.exists() { return Err(Error::new(ErrorKind::Other, __!("Failed to create output file (it existed already): {:?}", path))) } else { self.output = Some(path) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:461:12 [INFO] [stderr] | [INFO] [stderr] 461 | if file_existed == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!file_existed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:516:34 [INFO] [stderr] | [INFO] [stderr] 516 | let log_files_reserved = self.config.log_files_reserved.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.config.log_files_reserved` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:534:32 [INFO] [stderr] | [INFO] [stderr] 534 | if path.is_file() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!path.is_file()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/__.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | pub const UUID: &'static str = "3ec2df31-b5fb-49a9-b91f-de63ec69a058"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/__.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | pub const VERSION: &'static str = "0.1.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:150:18 [INFO] [stderr] | [INFO] [stderr] 150 | pub const NAME: &'static str = "Ice Age"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:153:23 [INFO] [stderr] | [INFO] [stderr] 153 | pub const CODE_NAME: &'static str = code_name!(); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:156:21 [INFO] [stderr] | [INFO] [stderr] 156 | pub const VERSION: &'static str = version!(); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:162:18 [INFO] [stderr] | [INFO] [stderr] 162 | pub const UUID: &'static str = "a9ab5574-e977-427d-a17b-ea421a1a6b5b"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:165:17 [INFO] [stderr] | [INFO] [stderr] 165 | pub const TAG: &'static str = concat!(code_name!(), "::a9ab5574::", version!()); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:178:21 [INFO] [stderr] | [INFO] [stderr] 178 | const SQL_CREATOR: &'static str = include_str!("../res/db_creator.sql"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:181:22 [INFO] [stderr] | [INFO] [stderr] 181 | const LOG_FILE_EXT: &'static str = ".sqlite"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:353:35 [INFO] [stderr] | [INFO] [stderr] 353 | let disk_flush_interval = config.disk_flush_interval.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.disk_flush_interval` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:383:21 [INFO] [stderr] | [INFO] [stderr] 383 | / match now - last_saved >= disk_flush_interval { [INFO] [stderr] 384 | | true => match sender.send(Cmd::FlushToDisk) { [INFO] [stderr] 385 | | Ok(()) => last_saved = Instant::now(), [INFO] [stderr] 386 | | Err(err) => { [INFO] [stderr] ... | [INFO] [stderr] 394 | | }, [INFO] [stderr] 395 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 383 | if now - last_saved >= disk_flush_interval { match sender.send(Cmd::FlushToDisk) { [INFO] [stderr] 384 | Ok(()) => last_saved = Instant::now(), [INFO] [stderr] 385 | Err(err) => { [INFO] [stderr] 386 | __e!("Failed sending {:?} to server -> {}", Cmd::FlushToDisk, err); [INFO] [stderr] 387 | break; [INFO] [stderr] 388 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:427:17 [INFO] [stderr] | [INFO] [stderr] 427 | / match localtime.is_null() { [INFO] [stderr] 428 | | true => return Err(Error::new(ErrorKind::Other, __!("Failed to get local time"))), [INFO] [stderr] 429 | | false => ( [INFO] [stderr] 430 | | (*localtime).tm_year.saturating_add(1900), (*localtime).tm_mon.saturating_add(1), (*localtime).tm_mday, [INFO] [stderr] 431 | | (*localtime).tm_hour, (*localtime).tm_min, (*localtime).tm_sec, [INFO] [stderr] 432 | | ), [INFO] [stderr] 433 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 427 | if localtime.is_null() { return Err(Error::new(ErrorKind::Other, __!("Failed to get local time"))) } else { ( [INFO] [stderr] 428 | (*localtime).tm_year.saturating_add(1900), (*localtime).tm_mon.saturating_add(1), (*localtime).tm_mday, [INFO] [stderr] 429 | (*localtime).tm_hour, (*localtime).tm_min, (*localtime).tm_sec, [INFO] [stderr] 430 | ) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:438:13 [INFO] [stderr] | [INFO] [stderr] 438 | / match path.exists() { [INFO] [stderr] 439 | | true => return Err(Error::new(ErrorKind::Other, __!("Failed to create output file (it existed already): {:?}", path))), [INFO] [stderr] 440 | | false => self.output = Some(path), [INFO] [stderr] 441 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if path.exists() { return Err(Error::new(ErrorKind::Other, __!("Failed to create output file (it existed already): {:?}", path))) } else { self.output = Some(path) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:461:12 [INFO] [stderr] | [INFO] [stderr] 461 | if file_existed == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!file_existed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:516:34 [INFO] [stderr] | [INFO] [stderr] 516 | let log_files_reserved = self.config.log_files_reserved.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.config.log_files_reserved` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:534:32 [INFO] [stderr] | [INFO] [stderr] 534 | if path.is_file() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!path.is_file()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> tests/sending.rs:21:90 [INFO] [stderr] | [INFO] [stderr] 21 | Duration::from_secs(match env::var("TEST_DURATION").map(|s| u8::from_str(&s).map(|d| d.max(1) as u64)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(d.max(1))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.79s [INFO] running `"docker" "inspect" "2d9f508148e1805321a980fb9c8c4a692d7dc04e5f08209505ab39e3f886ebe8"` [INFO] running `"docker" "rm" "-f" "2d9f508148e1805321a980fb9c8c4a692d7dc04e5f08209505ab39e3f886ebe8"` [INFO] [stdout] 2d9f508148e1805321a980fb9c8c4a692d7dc04e5f08209505ab39e3f886ebe8