[INFO] crate iata 0.3.0 is already in cache [INFO] extracting crate iata 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/iata/0.3.0 [INFO] extracting crate iata 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/iata/0.3.0 [INFO] validating manifest of iata-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of iata-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing iata-0.3.0 [INFO] finished frobbing iata-0.3.0 [INFO] frobbed toml for iata-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/iata/0.3.0/Cargo.toml [INFO] started frobbing iata-0.3.0 [INFO] finished frobbing iata-0.3.0 [INFO] frobbed toml for iata-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/iata/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting iata-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/iata/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d44d0dba63813b5474791f625c73d9769cbbead855e230bdac861ab260a191b3 [INFO] running `"docker" "start" "-a" "d44d0dba63813b5474791f625c73d9769cbbead855e230bdac861ab260a191b3"` [INFO] [stderr] Checking iata v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: value assigned to `chunk` is never read [INFO] [stderr] --> src/bcbp/mod.rs:403:41 [INFO] [stderr] | [INFO] [stderr] 403 | chunk = last; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `bcbp::Leg` [INFO] [stderr] --> src/bcbp/mod.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn new() -> Leg { [INFO] [stderr] 39 | | Leg { [INFO] [stderr] 40 | | pnr: String::new(), [INFO] [stderr] 41 | | airline: String::new(), [INFO] [stderr] ... | [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bcbp/mod.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | format!("{:0>3}", self.flight_day).into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("{:0>3}", self.flight_day)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bcbp/mod.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | format!("{:0>4}", seat).into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("{:0>4}", seat)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bcbp/mod.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | format!("{:0>4}", seq).into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("{:0>4}", seq)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `bcbp::BCBP` [INFO] [stderr] --> src/bcbp/mod.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | / pub fn new() -> BCBP { [INFO] [stderr] 192 | | BCBP { [INFO] [stderr] 193 | | name_first: String::new(), [INFO] [stderr] 194 | | name_last: String::new(), [INFO] [stderr] ... | [INFO] [stderr] 207 | | } [INFO] [stderr] 208 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 173 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `bcbp::Leg` [INFO] [stderr] --> src/bcbp/mod.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn new() -> Leg { [INFO] [stderr] 39 | | Leg { [INFO] [stderr] 40 | | pnr: String::new(), [INFO] [stderr] 41 | | airline: String::new(), [INFO] [stderr] ... | [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bcbp/mod.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | format!("{:0>3}", self.flight_day).into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("{:0>3}", self.flight_day)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bcbp/mod.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | format!("{:0>4}", seat).into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("{:0>4}", seat)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bcbp/mod.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | format!("{:0>4}", seq).into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("{:0>4}", seq)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `bcbp::BCBP` [INFO] [stderr] --> src/bcbp/mod.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | / pub fn new() -> BCBP { [INFO] [stderr] 192 | | BCBP { [INFO] [stderr] 193 | | name_first: String::new(), [INFO] [stderr] 194 | | name_last: String::new(), [INFO] [stderr] ... | [INFO] [stderr] 207 | | } [INFO] [stderr] 208 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 173 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> tests/bcbp.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / fn mandatory4() { [INFO] [stderr] 71 | | let src = "M4VERYLONGESTLASTNAMEDEABCDEF JFKSVOSU 1234 207 000ABCDEF SVOLEDSU 5678 210 000ABCDEF LEDSVOSU 9876 215 000ABCDEF SVOJFKSU 1357 215 000"; [INFO] [stderr] 72 | | let tmp = BCBP::from(src); [INFO] [stderr] 73 | | [INFO] [stderr] ... | [INFO] [stderr] 109 | | assert!(bcbp.build().unwrap() == src); [INFO] [stderr] 110 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.63s [INFO] running `"docker" "inspect" "d44d0dba63813b5474791f625c73d9769cbbead855e230bdac861ab260a191b3"` [INFO] running `"docker" "rm" "-f" "d44d0dba63813b5474791f625c73d9769cbbead855e230bdac861ab260a191b3"` [INFO] [stdout] d44d0dba63813b5474791f625c73d9769cbbead855e230bdac861ab260a191b3