[INFO] crate i3gamma 0.1.0 is already in cache [INFO] extracting crate i3gamma 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/i3gamma/0.1.0 [INFO] extracting crate i3gamma 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/i3gamma/0.1.0 [INFO] validating manifest of i3gamma-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of i3gamma-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing i3gamma-0.1.0 [INFO] finished frobbing i3gamma-0.1.0 [INFO] frobbed toml for i3gamma-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/i3gamma/0.1.0/Cargo.toml [INFO] started frobbing i3gamma-0.1.0 [INFO] finished frobbing i3gamma-0.1.0 [INFO] frobbed toml for i3gamma-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/i3gamma/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting i3gamma-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/i3gamma/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f722187e978c4537cf665a265eff1338428212bae84f95a51042bd574805065a [INFO] running `"docker" "start" "-a" "f722187e978c4537cf665a265eff1338428212bae84f95a51042bd574805065a"` [INFO] [stderr] Checking i3ipc v0.8.4 [INFO] [stderr] Checking i3gamma v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:61:21 [INFO] [stderr] | [INFO] [stderr] 61 | / if tree.name.as_ref().map(|x| x.as_str()) == Some(window.title.as_ref()) { [INFO] [stderr] 62 | | if window.gamma.contains_key(output) { [INFO] [stderr] 63 | | let gamma = window.gamma[output]; [INFO] [stderr] 64 | | [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 61 | if tree.name.as_ref().map(|x| x.as_str()) == Some(window.title.as_ref()) && window.gamma.contains_key(output) { [INFO] [stderr] 62 | let gamma = window.gamma[output]; [INFO] [stderr] 63 | [INFO] [stderr] 64 | println!("output {output} set gamma to {gamma} for {title}", [INFO] [stderr] 65 | output=output, gamma=gamma, title=window.title); [INFO] [stderr] 66 | connection [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / match event.expect("cannot receive i3 events") { [INFO] [stderr] 39 | | Event::WindowEvent(WindowEventInfo { change: WindowChange::Focus, .. }) => { [INFO] [stderr] 40 | | let mut tree = &connection.get_tree().expect("cannot request i3 node tree"); [INFO] [stderr] 41 | | let mut output = None; [INFO] [stderr] ... | [INFO] [stderr] 92 | | _ => () [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | if let Event::WindowEvent(WindowEventInfo { change: WindowChange::Focus, .. }) = event.expect("cannot receive i3 events") { [INFO] [stderr] 39 | let mut tree = &connection.get_tree().expect("cannot request i3 node tree"); [INFO] [stderr] 40 | let mut output = None; [INFO] [stderr] 41 | while !tree.focused { [INFO] [stderr] 42 | if tree.nodetype == NodeType::Output { [INFO] [stderr] 43 | output = tree.name.as_ref(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:61:21 [INFO] [stderr] | [INFO] [stderr] 61 | / if tree.name.as_ref().map(|x| x.as_str()) == Some(window.title.as_ref()) { [INFO] [stderr] 62 | | if window.gamma.contains_key(output) { [INFO] [stderr] 63 | | let gamma = window.gamma[output]; [INFO] [stderr] 64 | | [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 61 | if tree.name.as_ref().map(|x| x.as_str()) == Some(window.title.as_ref()) && window.gamma.contains_key(output) { [INFO] [stderr] 62 | let gamma = window.gamma[output]; [INFO] [stderr] 63 | [INFO] [stderr] 64 | println!("output {output} set gamma to {gamma} for {title}", [INFO] [stderr] 65 | output=output, gamma=gamma, title=window.title); [INFO] [stderr] 66 | connection [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / match event.expect("cannot receive i3 events") { [INFO] [stderr] 39 | | Event::WindowEvent(WindowEventInfo { change: WindowChange::Focus, .. }) => { [INFO] [stderr] 40 | | let mut tree = &connection.get_tree().expect("cannot request i3 node tree"); [INFO] [stderr] 41 | | let mut output = None; [INFO] [stderr] ... | [INFO] [stderr] 92 | | _ => () [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | if let Event::WindowEvent(WindowEventInfo { change: WindowChange::Focus, .. }) = event.expect("cannot receive i3 events") { [INFO] [stderr] 39 | let mut tree = &connection.get_tree().expect("cannot request i3 node tree"); [INFO] [stderr] 40 | let mut output = None; [INFO] [stderr] 41 | while !tree.focused { [INFO] [stderr] 42 | if tree.nodetype == NodeType::Output { [INFO] [stderr] 43 | output = tree.name.as_ref(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.89s [INFO] running `"docker" "inspect" "f722187e978c4537cf665a265eff1338428212bae84f95a51042bd574805065a"` [INFO] running `"docker" "rm" "-f" "f722187e978c4537cf665a265eff1338428212bae84f95a51042bd574805065a"` [INFO] [stdout] f722187e978c4537cf665a265eff1338428212bae84f95a51042bd574805065a