[INFO] crate i3-style 1.0.1 is already in cache [INFO] extracting crate i3-style 1.0.1 into work/ex/clippy-test-run/sources/stable/reg/i3-style/1.0.1 [INFO] extracting crate i3-style 1.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/i3-style/1.0.1 [INFO] validating manifest of i3-style-1.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of i3-style-1.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing i3-style-1.0.1 [INFO] finished frobbing i3-style-1.0.1 [INFO] frobbed toml for i3-style-1.0.1 written to work/ex/clippy-test-run/sources/stable/reg/i3-style/1.0.1/Cargo.toml [INFO] started frobbing i3-style-1.0.1 [INFO] finished frobbing i3-style-1.0.1 [INFO] frobbed toml for i3-style-1.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/i3-style/1.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting i3-style-1.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/i3-style/1.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f9612719b73402bfb1246d2724551024792f0e7e3af7601530b1f31edb560f2a [INFO] running `"docker" "start" "-a" "f9612719b73402bfb1246d2724551024792f0e7e3af7601530b1f31edb560f2a"` [INFO] [stderr] Checking vpsearch v1.3.5 [INFO] [stderr] Checking includedir v0.4.0 [INFO] [stderr] Compiling includedir_codegen v0.4.0 [INFO] [stderr] Checking colornamer v0.1.0 [INFO] [stderr] Compiling i3-style v1.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/theme.rs:353:9 [INFO] [stderr] | [INFO] [stderr] 353 | description: description, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/theme.rs:353:9 [INFO] [stderr] | [INFO] [stderr] 353 | description: description, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/theme.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/theme.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | return hex.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hex.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `theme::from_yaml` [INFO] [stderr] --> src/writer.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use theme::from_yaml; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/writer.rs:128:29 [INFO] [stderr] | [INFO] [stderr] 128 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/writer.rs:142:20 [INFO] [stderr] | [INFO] [stderr] 142 | if (!colors_found) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/writer.rs:193:33 [INFO] [stderr] | [INFO] [stderr] 193 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/i3-style-c105c8bb66a76b3a/out/data.rs:4:10 [INFO] [stderr] | [INFO] [stderr] 4 | key: 5562424625550093841, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `5_562_424_625_550_093_841` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/main.rs:37:78 [INFO] [stderr] | [INFO] [stderr] 37 | let sec = (elapsed.as_secs() as u64) + (elapsed.subsec_nanos() as u64) / 1000_000; [INFO] [stderr] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: unused variable: `result` [INFO] [stderr] --> src/main.rs:298:20 [INFO] [stderr] | [INFO] [stderr] 298 | Ok(result) => { [INFO] [stderr] | ^^^^^^ help: consider using `_result` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `result` [INFO] [stderr] --> src/main.rs:313:20 [INFO] [stderr] | [INFO] [stderr] 313 | Ok(result) => { [INFO] [stderr] | ^^^^^^ help: consider using `_result` instead [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/theme.rs:96:30 [INFO] [stderr] | [INFO] [stderr] 96 | fn has_color(&self, hex: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/theme.rs:105:30 [INFO] [stderr] | [INFO] [stderr] 105 | fn get_color(&self, hex: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/theme.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | / match hex { [INFO] [stderr] 121 | | &Some(ref h) => { [INFO] [stderr] 122 | | let h = h.to_uppercase(); [INFO] [stderr] 123 | | if self.has_color(&h) { [INFO] [stderr] ... | [INFO] [stderr] 144 | | &None => () [INFO] [stderr] 145 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 120 | match *hex { [INFO] [stderr] 121 | Some(ref h) => { [INFO] [stderr] 122 | let h = h.to_uppercase(); [INFO] [stderr] 123 | if self.has_color(&h) { [INFO] [stderr] 124 | return; [INFO] [stderr] 125 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/theme.rs:128:21 [INFO] [stderr] | [INFO] [stderr] 128 | let ref mut colors = self.colors; [INFO] [stderr] | ----^^^^^^^^^^^^^^--------------- help: try: `let colors = &mut self.colors;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/theme.rs:131:25 [INFO] [stderr] | [INFO] [stderr] 131 | color_name = color_name + "-1"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_name += "-1"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/theme.rs:139:25 [INFO] [stderr] | [INFO] [stderr] 139 | color_name = color_name + num.to_string().as_str(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_name += num.to_string().as_str()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/theme.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | / match group { [INFO] [stderr] 150 | | &Some(ref g) => { [INFO] [stderr] 151 | | self.add_hex(&g.border); [INFO] [stderr] 152 | | self.add_hex(&g.background); [INFO] [stderr] ... | [INFO] [stderr] 156 | | &None => () [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 149 | match *group { [INFO] [stderr] 150 | Some(ref g) => { [INFO] [stderr] 151 | self.add_hex(&g.border); [INFO] [stderr] 152 | self.add_hex(&g.background); [INFO] [stderr] 153 | self.add_hex(&g.text); [INFO] [stderr] 154 | self.add_hex(&g.indicator); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/theme.rs:187:32 [INFO] [stderr] | [INFO] [stderr] 187 | pub fn to_yaml_with_colors(self) -> Yaml { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/theme.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | let ref bar_colors = self.bar_colors; [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------- help: try: `let bar_colors = &self.bar_colors;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/theme.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | / match bar_colors { [INFO] [stderr] 192 | | &Some(ref bc) => { [INFO] [stderr] 193 | | colormap.add_hex(&bc.separator); [INFO] [stderr] 194 | | colormap.add_hex(&bc.background); [INFO] [stderr] ... | [INFO] [stderr] 201 | | &None => () [INFO] [stderr] 202 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 191 | match *bar_colors { [INFO] [stderr] 192 | Some(ref bc) => { [INFO] [stderr] 193 | colormap.add_hex(&bc.separator); [INFO] [stderr] 194 | colormap.add_hex(&bc.background); [INFO] [stderr] 195 | colormap.add_hex(&bc.statusline); [INFO] [stderr] 196 | colormap.add_color_group(&bc.focused_workspace); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/theme.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | let ref window_colors = self.window_colors; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^---------------------- help: try: `let window_colors = &self.window_colors;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/theme.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | / match window_colors { [INFO] [stderr] 205 | | &Some(ref wc) => { [INFO] [stderr] 206 | | colormap.add_color_group(&wc.focused); [INFO] [stderr] 207 | | colormap.add_color_group(&wc.focused_inactive); [INFO] [stderr] ... | [INFO] [stderr] 211 | | &None => () [INFO] [stderr] 212 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 204 | match *window_colors { [INFO] [stderr] 205 | Some(ref wc) => { [INFO] [stderr] 206 | colormap.add_color_group(&wc.focused); [INFO] [stderr] 207 | colormap.add_color_group(&wc.focused_inactive); [INFO] [stderr] 208 | colormap.add_color_group(&wc.unfocused); [INFO] [stderr] 209 | colormap.add_color_group(&wc.urgent); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/theme.rs:226:9 [INFO] [stderr] | [INFO] [stderr] 226 | / match window_colors { [INFO] [stderr] 227 | | &Some(ref wc) => { [INFO] [stderr] 228 | | if wc.focused.is_some() { [INFO] [stderr] 229 | | window_colors_yaml.insert(Yaml::String("focused".to_string()), wc.focused.as_ref().unwrap().to_yaml(&colormap)); [INFO] [stderr] ... | [INFO] [stderr] 241 | | &None => () [INFO] [stderr] 242 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 226 | match *window_colors { [INFO] [stderr] 227 | Some(ref wc) => { [INFO] [stderr] 228 | if wc.focused.is_some() { [INFO] [stderr] 229 | window_colors_yaml.insert(Yaml::String("focused".to_string()), wc.focused.as_ref().unwrap().to_yaml(&colormap)); [INFO] [stderr] 230 | } [INFO] [stderr] 231 | if wc.focused_inactive.is_some() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/theme.rs:244:9 [INFO] [stderr] | [INFO] [stderr] 244 | / match bar_colors { [INFO] [stderr] 245 | | &Some(ref bc) => { [INFO] [stderr] 246 | | if bc.background.is_some() { [INFO] [stderr] 247 | | bar_colors_yaml.insert(Yaml::String("background".to_string()), Yaml::String(colormap.get_color(&bc.background.as_ref().unwrap().to_string()))); [INFO] [stderr] ... | [INFO] [stderr] 265 | | &None => () [INFO] [stderr] 266 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 244 | match *bar_colors { [INFO] [stderr] 245 | Some(ref bc) => { [INFO] [stderr] 246 | if bc.background.is_some() { [INFO] [stderr] 247 | bar_colors_yaml.insert(Yaml::String("background".to_string()), Yaml::String(colormap.get_color(&bc.background.as_ref().unwrap().to_string()))); [INFO] [stderr] 248 | } [INFO] [stderr] 249 | if bc.statusline.is_some() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/theme.rs:278:5 [INFO] [stderr] | [INFO] [stderr] 278 | / if color_spec.as_str().is_none() { [INFO] [stderr] 279 | | return Option::None; [INFO] [stderr] 280 | | } [INFO] [stderr] | |_____^ help: replace_it_with: `color_spec.as_str()?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/theme.rs:295:5 [INFO] [stderr] | [INFO] [stderr] 295 | / if doc[top_key][bottom_key].as_hash().is_none() { [INFO] [stderr] 296 | | return Option::None; [INFO] [stderr] 297 | | } [INFO] [stderr] | |_____^ help: replace_it_with: `doc[top_key][bottom_key].as_hash()?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/theme.rs:316:5 [INFO] [stderr] | [INFO] [stderr] 316 | / if doc["window_colors"].as_hash().is_none() { [INFO] [stderr] 317 | | return Option::None; [INFO] [stderr] 318 | | } [INFO] [stderr] | |_____^ help: replace_it_with: `doc["window_colors"].as_hash()?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/theme.rs:331:5 [INFO] [stderr] | [INFO] [stderr] 331 | / if bar_colors.as_hash().is_none() { [INFO] [stderr] 332 | | return Option::None; [INFO] [stderr] 333 | | } [INFO] [stderr] | |_____^ help: replace_it_with: `bar_colors.as_hash()?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/theme.rs:380:12 [INFO] [stderr] | [INFO] [stderr] 380 | if vec.len() == 0 || vec[0].starts_with("#") { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/theme.rs:380:49 [INFO] [stderr] | [INFO] [stderr] 380 | if vec.len() == 0 || vec[0].starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/theme.rs:421:66 [INFO] [stderr] | [INFO] [stderr] 421 | let mut group = bar_colors.focused_workspace.unwrap_or(ColorGroup::empty()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(ColorGroup::empty)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/theme.rs:433:67 [INFO] [stderr] | [INFO] [stderr] 433 | let mut group = bar_colors.inactive_workspace.unwrap_or(ColorGroup::empty()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(ColorGroup::empty)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/theme.rs:445:65 [INFO] [stderr] | [INFO] [stderr] 445 | let mut group = bar_colors.urgent_workspace.unwrap_or(ColorGroup::empty()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(ColorGroup::empty)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/theme.rs:461:59 [INFO] [stderr] | [INFO] [stderr] 461 | let mut group = window_colors.focused.unwrap_or(ColorGroup::empty()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(ColorGroup::empty)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/theme.rs:476:68 [INFO] [stderr] | [INFO] [stderr] 476 | let mut group = window_colors.focused_inactive.unwrap_or(ColorGroup::empty()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(ColorGroup::empty)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/theme.rs:492:61 [INFO] [stderr] | [INFO] [stderr] 492 | let mut group = window_colors.unfocused.unwrap_or(ColorGroup::empty()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(ColorGroup::empty)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/theme.rs:508:58 [INFO] [stderr] | [INFO] [stderr] 508 | let mut group = window_colors.urgent.unwrap_or(ColorGroup::empty()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(ColorGroup::empty)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/theme.rs:529:32 [INFO] [stderr] | [INFO] [stderr] 529 | pub fn from_config_file(input: &String) -> Theme { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/writer.rs:10:27 [INFO] [stderr] | [INFO] [stderr] 10 | fn leading_spaces(string: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/writer.rs:24:28 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn write_config(input: &String, output: Option<&String>, theme: &Theme) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 57 [INFO] [stderr] --> src/writer.rs:30:1 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn write_config_from_reader(input: BufReader, output: Option<&String>, theme: &Theme) { [INFO] [stderr] 31 | | let mut writer = match output { [INFO] [stderr] 32 | | Some(x) => { [INFO] [stderr] 33 | | let path = Path::new(x.as_str()); [INFO] [stderr] ... | [INFO] [stderr] 414 | | } [INFO] [stderr] 415 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/writer.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | if vec.len() > 0 && !vec[0].starts_with("#") { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/writer.rs:58:49 [INFO] [stderr] | [INFO] [stderr] 58 | if vec.len() > 0 && !vec[0].starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/writer.rs:62:21 [INFO] [stderr] | [INFO] [stderr] 62 | bar_colors.separator.as_ref().map(|color| { [INFO] [stderr] | _____________________^ [INFO] [stderr] | |_____________________| [INFO] [stderr] | || [INFO] [stderr] 63 | || writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] 64 | || writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] 65 | || writer.write(b"separator ").unwrap(); [INFO] [stderr] 66 | || writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] 67 | || writer.write(b"\n").unwrap(); [INFO] [stderr] 68 | || }); [INFO] [stderr] | ||______________________^- help: try this: `if let Some(color) = bar_colors.separator.as_ref() { ... }` [INFO] [stderr] | |_______________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:64:25 [INFO] [stderr] | [INFO] [stderr] 64 | writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | writer.write(b"separator ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:66:25 [INFO] [stderr] | [INFO] [stderr] 66 | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:67:25 [INFO] [stderr] | [INFO] [stderr] 67 | writer.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/writer.rs:72:21 [INFO] [stderr] | [INFO] [stderr] 72 | bar_colors.background.as_ref().map(|color| { [INFO] [stderr] | _____________________^ [INFO] [stderr] | |_____________________| [INFO] [stderr] | || [INFO] [stderr] 73 | || writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] 74 | || writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] 75 | || writer.write(b"background ").unwrap(); [INFO] [stderr] 76 | || writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] 77 | || writer.write(b"\n").unwrap(); [INFO] [stderr] 78 | || }); [INFO] [stderr] | ||______________________^- help: try this: `if let Some(color) = bar_colors.background.as_ref() { ... }` [INFO] [stderr] | |_______________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:73:25 [INFO] [stderr] | [INFO] [stderr] 73 | writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:74:25 [INFO] [stderr] | [INFO] [stderr] 74 | writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:75:25 [INFO] [stderr] | [INFO] [stderr] 75 | writer.write(b"background ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:76:25 [INFO] [stderr] | [INFO] [stderr] 76 | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:77:25 [INFO] [stderr] | [INFO] [stderr] 77 | writer.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/writer.rs:82:21 [INFO] [stderr] | [INFO] [stderr] 82 | bar_colors.statusline.as_ref().map(|color| { [INFO] [stderr] | _____________________^ [INFO] [stderr] | |_____________________| [INFO] [stderr] | || [INFO] [stderr] 83 | || writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] 84 | || writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] 85 | || writer.write(b"statusline ").unwrap(); [INFO] [stderr] 86 | || writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] 87 | || writer.write(b"\n").unwrap(); [INFO] [stderr] 88 | || }); [INFO] [stderr] | ||______________________^- help: try this: `if let Some(color) = bar_colors.statusline.as_ref() { ... }` [INFO] [stderr] | |_______________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:83:25 [INFO] [stderr] | [INFO] [stderr] 83 | writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:84:25 [INFO] [stderr] | [INFO] [stderr] 84 | writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:85:25 [INFO] [stderr] | [INFO] [stderr] 85 | writer.write(b"statusline ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:86:25 [INFO] [stderr] | [INFO] [stderr] 86 | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:87:25 [INFO] [stderr] | [INFO] [stderr] 87 | writer.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/writer.rs:96:39 [INFO] [stderr] | [INFO] [stderr] 96 | let group = match group_name.as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `group_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:113:21 [INFO] [stderr] | [INFO] [stderr] 113 | writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:114:21 [INFO] [stderr] | [INFO] [stderr] 114 | writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:115:21 [INFO] [stderr] | [INFO] [stderr] 115 | writer.write(group_name.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:116:21 [INFO] [stderr] | [INFO] [stderr] 116 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:117:21 [INFO] [stderr] | [INFO] [stderr] 117 | writer.write(group.border.as_ref().unwrap().as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:118:21 [INFO] [stderr] | [INFO] [stderr] 118 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:119:21 [INFO] [stderr] | [INFO] [stderr] 119 | writer.write(group.background.as_ref().unwrap().as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:120:21 [INFO] [stderr] | [INFO] [stderr] 120 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:121:21 [INFO] [stderr] | [INFO] [stderr] 121 | writer.write(group.text.as_ref().unwrap().as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/writer.rs:124:21 [INFO] [stderr] | [INFO] [stderr] 124 | / match group.indicator { [INFO] [stderr] 125 | | Some(ref color) => { [INFO] [stderr] 126 | | writer.write(b" ").unwrap(); [INFO] [stderr] 127 | | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 130 | | None => () [INFO] [stderr] 131 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 124 | if let Some(ref color) = group.indicator { [INFO] [stderr] 125 | writer.write(b" ").unwrap(); [INFO] [stderr] 126 | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] 127 | () [INFO] [stderr] 128 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:126:29 [INFO] [stderr] | [INFO] [stderr] 126 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:127:29 [INFO] [stderr] | [INFO] [stderr] 127 | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:133:21 [INFO] [stderr] | [INFO] [stderr] 133 | writer.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | writer.write(original_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:143:21 [INFO] [stderr] | [INFO] [stderr] 143 | writer.write(b" colors {\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/writer.rs:144:21 [INFO] [stderr] | [INFO] [stderr] 144 | bar_colors.separator.as_ref().map(|color| { [INFO] [stderr] | _____________________^ [INFO] [stderr] | |_____________________| [INFO] [stderr] | || [INFO] [stderr] 145 | || writer.write(b" separator ").unwrap(); [INFO] [stderr] 146 | || writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] 147 | || writer.write(b"\n").unwrap(); [INFO] [stderr] 148 | || }); [INFO] [stderr] | ||______________________^- help: try this: `if let Some(color) = bar_colors.separator.as_ref() { ... }` [INFO] [stderr] | |_______________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:145:25 [INFO] [stderr] | [INFO] [stderr] 145 | writer.write(b" separator ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:146:25 [INFO] [stderr] | [INFO] [stderr] 146 | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:147:25 [INFO] [stderr] | [INFO] [stderr] 147 | writer.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/writer.rs:149:21 [INFO] [stderr] | [INFO] [stderr] 149 | bar_colors.background.as_ref().map(|color| { [INFO] [stderr] | _____________________^ [INFO] [stderr] | |_____________________| [INFO] [stderr] | || [INFO] [stderr] 150 | || writer.write(b" background ").unwrap(); [INFO] [stderr] 151 | || writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] 152 | || writer.write(b"\n").unwrap(); [INFO] [stderr] 153 | || }); [INFO] [stderr] | ||______________________^- help: try this: `if let Some(color) = bar_colors.background.as_ref() { ... }` [INFO] [stderr] | |_______________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:150:25 [INFO] [stderr] | [INFO] [stderr] 150 | writer.write(b" background ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:151:25 [INFO] [stderr] | [INFO] [stderr] 151 | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | writer.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/writer.rs:154:21 [INFO] [stderr] | [INFO] [stderr] 154 | bar_colors.statusline.as_ref().map(|color| { [INFO] [stderr] | _____________________^ [INFO] [stderr] | |_____________________| [INFO] [stderr] | || [INFO] [stderr] 155 | || writer.write(b" statusline ").unwrap(); [INFO] [stderr] 156 | || writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] 157 | || writer.write(b"\n").unwrap(); [INFO] [stderr] 158 | || }); [INFO] [stderr] | ||______________________^- help: try this: `if let Some(color) = bar_colors.statusline.as_ref() { ... }` [INFO] [stderr] | |_______________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:155:25 [INFO] [stderr] | [INFO] [stderr] 155 | writer.write(b" statusline ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:156:25 [INFO] [stderr] | [INFO] [stderr] 156 | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:157:25 [INFO] [stderr] | [INFO] [stderr] 157 | writer.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/writer.rs:162:43 [INFO] [stderr] | [INFO] [stderr] 162 | let group = match group_name.as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `group_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:179:25 [INFO] [stderr] | [INFO] [stderr] 179 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:180:25 [INFO] [stderr] | [INFO] [stderr] 180 | writer.write(group_name.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:181:25 [INFO] [stderr] | [INFO] [stderr] 181 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:182:25 [INFO] [stderr] | [INFO] [stderr] 182 | writer.write(group.border.as_ref().unwrap().as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:183:25 [INFO] [stderr] | [INFO] [stderr] 183 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:184:25 [INFO] [stderr] | [INFO] [stderr] 184 | writer.write(group.background.as_ref().unwrap().as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:185:25 [INFO] [stderr] | [INFO] [stderr] 185 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:186:25 [INFO] [stderr] | [INFO] [stderr] 186 | writer.write(group.text.as_ref().unwrap().as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:187:25 [INFO] [stderr] | [INFO] [stderr] 187 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/writer.rs:189:25 [INFO] [stderr] | [INFO] [stderr] 189 | / match group.indicator { [INFO] [stderr] 190 | | Some(ref color) => { [INFO] [stderr] 191 | | writer.write(b" ").unwrap(); [INFO] [stderr] 192 | | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 195 | | None => () [INFO] [stderr] 196 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 189 | if let Some(ref color) = group.indicator { [INFO] [stderr] 190 | writer.write(b" ").unwrap(); [INFO] [stderr] 191 | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] 192 | () [INFO] [stderr] 193 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:191:33 [INFO] [stderr] | [INFO] [stderr] 191 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:192:33 [INFO] [stderr] | [INFO] [stderr] 192 | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:198:25 [INFO] [stderr] | [INFO] [stderr] 198 | writer.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:200:21 [INFO] [stderr] | [INFO] [stderr] 200 | writer.write(b" }\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:205:17 [INFO] [stderr] | [INFO] [stderr] 205 | writer.write(original_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:211:21 [INFO] [stderr] | [INFO] [stderr] 211 | writer.write(original_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:220:21 [INFO] [stderr] | [INFO] [stderr] 220 | writer.write(vec[0].as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:223:21 [INFO] [stderr] | [INFO] [stderr] 223 | / writer.write(match vec[0] { [INFO] [stderr] 224 | | "separator" => match bar_colors.separator { [INFO] [stderr] 225 | | Some(ref color) => color.as_bytes(), [INFO] [stderr] 226 | | None => vec[1].as_bytes() [INFO] [stderr] ... | [INFO] [stderr] 236 | | _ => vec[1].as_bytes(), [INFO] [stderr] 237 | | }).unwrap(); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:238:21 [INFO] [stderr] | [INFO] [stderr] 238 | writer.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:251:25 [INFO] [stderr] | [INFO] [stderr] 251 | writer.write(original_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:257:21 [INFO] [stderr] | [INFO] [stderr] 257 | writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:258:21 [INFO] [stderr] | [INFO] [stderr] 258 | writer.write(vec[0].as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:259:21 [INFO] [stderr] | [INFO] [stderr] 259 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:261:21 [INFO] [stderr] | [INFO] [stderr] 261 | / writer.write(match group.border.as_ref() { [INFO] [stderr] 262 | | Some(color) => color.as_bytes(), [INFO] [stderr] 263 | | None => vec[1].as_bytes() [INFO] [stderr] 264 | | }).unwrap(); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:265:21 [INFO] [stderr] | [INFO] [stderr] 265 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:267:21 [INFO] [stderr] | [INFO] [stderr] 267 | / writer.write(match group.background.as_ref() { [INFO] [stderr] 268 | | Some(color) => color.as_bytes(), [INFO] [stderr] 269 | | None => vec[2].as_bytes() [INFO] [stderr] 270 | | }).unwrap(); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:271:21 [INFO] [stderr] | [INFO] [stderr] 271 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:273:21 [INFO] [stderr] | [INFO] [stderr] 273 | / writer.write(match group.text.as_ref() { [INFO] [stderr] 274 | | Some(color) => color.as_bytes(), [INFO] [stderr] 275 | | None => vec[3].as_bytes() [INFO] [stderr] 276 | | }).unwrap(); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:279:25 [INFO] [stderr] | [INFO] [stderr] 279 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:280:25 [INFO] [stderr] | [INFO] [stderr] 280 | / writer.write(match group.indicator.as_ref() { [INFO] [stderr] 281 | | Some(color) => color.as_bytes(), [INFO] [stderr] 282 | | None => vec[3].as_bytes() [INFO] [stderr] 283 | | }).unwrap(); [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:285:21 [INFO] [stderr] | [INFO] [stderr] 285 | writer.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:294:17 [INFO] [stderr] | [INFO] [stderr] 294 | writer.write(original_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:300:17 [INFO] [stderr] | [INFO] [stderr] 300 | writer.write(original_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:307:21 [INFO] [stderr] | [INFO] [stderr] 307 | writer.write(original_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:322:21 [INFO] [stderr] | [INFO] [stderr] 322 | writer.write(original_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:328:17 [INFO] [stderr] | [INFO] [stderr] 328 | writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:329:17 [INFO] [stderr] | [INFO] [stderr] 329 | writer.write(vec[0].as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:330:17 [INFO] [stderr] | [INFO] [stderr] 330 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:332:17 [INFO] [stderr] | [INFO] [stderr] 332 | / writer.write(match group.border.as_ref() { [INFO] [stderr] 333 | | Some(color) => color.as_bytes(), [INFO] [stderr] 334 | | None => vec[1].as_bytes() [INFO] [stderr] 335 | | }).unwrap(); [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:336:17 [INFO] [stderr] | [INFO] [stderr] 336 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:338:17 [INFO] [stderr] | [INFO] [stderr] 338 | / writer.write(match group.background.as_ref() { [INFO] [stderr] 339 | | Some(color) => color.as_bytes(), [INFO] [stderr] 340 | | None => vec[2].as_bytes() [INFO] [stderr] 341 | | }).unwrap(); [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:345:21 [INFO] [stderr] | [INFO] [stderr] 345 | / writer.write(match group.text.as_ref() { [INFO] [stderr] 346 | | Some(color) => color.as_bytes(), [INFO] [stderr] 347 | | None => vec[3].as_bytes() [INFO] [stderr] 348 | | }).unwrap(); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:349:21 [INFO] [stderr] | [INFO] [stderr] 349 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:353:25 [INFO] [stderr] | [INFO] [stderr] 353 | / writer.write(match group.indicator.as_ref() { [INFO] [stderr] 354 | | Some(color) => color.as_bytes(), [INFO] [stderr] 355 | | None => vec[4].as_bytes() [INFO] [stderr] 356 | | }).unwrap(); [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:360:17 [INFO] [stderr] | [INFO] [stderr] 360 | writer.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:365:9 [INFO] [stderr] | [INFO] [stderr] 365 | writer.write(original_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/writer.rs:375:27 [INFO] [stderr] | [INFO] [stderr] 375 | let group = match window_color_name.as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `window_color_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/writer.rs:389:9 [INFO] [stderr] | [INFO] [stderr] 389 | writer.write(window_color_name.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/writer.rs:390:9 [INFO] [stderr] | [INFO] [stderr] 390 | writer.write(b" "); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:391:9 [INFO] [stderr] | [INFO] [stderr] 391 | / writer.write(match group.border.as_ref() { [INFO] [stderr] 392 | | Some(color) => color.as_bytes(), [INFO] [stderr] 393 | | None => b"#000000" [INFO] [stderr] 394 | | }).unwrap(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:395:9 [INFO] [stderr] | [INFO] [stderr] 395 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:397:9 [INFO] [stderr] | [INFO] [stderr] 397 | / writer.write(match group.background.as_ref() { [INFO] [stderr] 398 | | Some(color) => color.as_bytes(), [INFO] [stderr] 399 | | None => b"#000000" [INFO] [stderr] 400 | | }).unwrap(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:401:9 [INFO] [stderr] | [INFO] [stderr] 401 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:403:9 [INFO] [stderr] | [INFO] [stderr] 403 | / writer.write(match group.text.as_ref() { [INFO] [stderr] 404 | | Some(color) => color.as_bytes(), [INFO] [stderr] 405 | | None => b"#000000" [INFO] [stderr] 406 | | }).unwrap(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/writer.rs:408:9 [INFO] [stderr] | [INFO] [stderr] 408 | group.indicator.as_ref().map(|color| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 409 | || writer.write(b" ").unwrap(); [INFO] [stderr] 410 | || writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] 411 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(color) = group.indicator.as_ref() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:409:13 [INFO] [stderr] | [INFO] [stderr] 409 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:410:13 [INFO] [stderr] | [INFO] [stderr] 410 | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:413:9 [INFO] [stderr] | [INFO] [stderr] 413 | writer.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | writeln!(&mut std::io::stderr(), "{}", msg); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:44 [INFO] [stderr] | [INFO] [stderr] 37 | let sec = (elapsed.as_secs() as u64) + (elapsed.subsec_nanos() as u64) / 1000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | let home = String::from(env::var("HOME").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `env::var("HOME").unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:64:26 [INFO] [stderr] | [INFO] [stderr] 64 | fn validate_config(path: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | writeln!(&mut std::io::stderr(), "Could not find i3 binary in the system PATH to validate the config before parsing"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | file.read_to_string(&mut contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:206:13 [INFO] [stderr] | [INFO] [stderr] 206 | writeln!(&mut std::io::stderr(), "Could not validate config at {}. Use `i3 -C -c {}` to see validation errors.", config, config); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:246:9 [INFO] [stderr] | [INFO] [stderr] 246 | writeln!(&mut std::io::stderr(), "Could not validate config at {}. Use `i3 -C -c {}` to see validation errors.", config, config); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:268:14 [INFO] [stderr] | [INFO] [stderr] 268 | Some(config.as_str().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 268 | Some(&(*config.as_str()).clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 268 | Some(&str::clone(config.as_str())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:281:9 [INFO] [stderr] | [INFO] [stderr] 281 | writeln!(&mut std::io::stderr(), "saving config at {} to {}", &config, &tmp_input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:302:21 [INFO] [stderr] | [INFO] [stderr] 302 | writeln!(&mut std::io::stderr(), "Could not reload config with swaymsg: {}", err); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:317:21 [INFO] [stderr] | [INFO] [stderr] 317 | writeln!(&mut std::io::stderr(), "Could not reload config with i3-msg: {}", err); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:321:13 [INFO] [stderr] | [INFO] [stderr] 321 | writeln!(&mut std::io::stderr(), "Could not reload config: no display environment variable set."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 96 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `i3-style`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/theme.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/theme.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | return hex.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hex.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/writer.rs:128:29 [INFO] [stderr] | [INFO] [stderr] 128 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/writer.rs:142:20 [INFO] [stderr] | [INFO] [stderr] 142 | if (!colors_found) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/writer.rs:193:33 [INFO] [stderr] | [INFO] [stderr] 193 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/i3-style-c105c8bb66a76b3a/out/data.rs:4:10 [INFO] [stderr] | [INFO] [stderr] 4 | key: 5562424625550093841, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `5_562_424_625_550_093_841` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/main.rs:37:78 [INFO] [stderr] | [INFO] [stderr] 37 | let sec = (elapsed.as_secs() as u64) + (elapsed.subsec_nanos() as u64) / 1000_000; [INFO] [stderr] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: unused variable: `result` [INFO] [stderr] --> src/main.rs:298:20 [INFO] [stderr] | [INFO] [stderr] 298 | Ok(result) => { [INFO] [stderr] | ^^^^^^ help: consider using `_result` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `result` [INFO] [stderr] --> src/main.rs:313:20 [INFO] [stderr] | [INFO] [stderr] 313 | Ok(result) => { [INFO] [stderr] | ^^^^^^ help: consider using `_result` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bc` [INFO] [stderr] --> src/theme.rs:550:13 [INFO] [stderr] | [INFO] [stderr] 550 | let bc = theme.bar_colors.unwrap(); [INFO] [stderr] | ^^ help: consider using `_bc` instead [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/theme.rs:96:30 [INFO] [stderr] | [INFO] [stderr] 96 | fn has_color(&self, hex: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/theme.rs:105:30 [INFO] [stderr] | [INFO] [stderr] 105 | fn get_color(&self, hex: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/theme.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | / match hex { [INFO] [stderr] 121 | | &Some(ref h) => { [INFO] [stderr] 122 | | let h = h.to_uppercase(); [INFO] [stderr] 123 | | if self.has_color(&h) { [INFO] [stderr] ... | [INFO] [stderr] 144 | | &None => () [INFO] [stderr] 145 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 120 | match *hex { [INFO] [stderr] 121 | Some(ref h) => { [INFO] [stderr] 122 | let h = h.to_uppercase(); [INFO] [stderr] 123 | if self.has_color(&h) { [INFO] [stderr] 124 | return; [INFO] [stderr] 125 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/theme.rs:128:21 [INFO] [stderr] | [INFO] [stderr] 128 | let ref mut colors = self.colors; [INFO] [stderr] | ----^^^^^^^^^^^^^^--------------- help: try: `let colors = &mut self.colors;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/theme.rs:131:25 [INFO] [stderr] | [INFO] [stderr] 131 | color_name = color_name + "-1"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_name += "-1"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/theme.rs:139:25 [INFO] [stderr] | [INFO] [stderr] 139 | color_name = color_name + num.to_string().as_str(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_name += num.to_string().as_str()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/theme.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | / match group { [INFO] [stderr] 150 | | &Some(ref g) => { [INFO] [stderr] 151 | | self.add_hex(&g.border); [INFO] [stderr] 152 | | self.add_hex(&g.background); [INFO] [stderr] ... | [INFO] [stderr] 156 | | &None => () [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 149 | match *group { [INFO] [stderr] 150 | Some(ref g) => { [INFO] [stderr] 151 | self.add_hex(&g.border); [INFO] [stderr] 152 | self.add_hex(&g.background); [INFO] [stderr] 153 | self.add_hex(&g.text); [INFO] [stderr] 154 | self.add_hex(&g.indicator); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/theme.rs:187:32 [INFO] [stderr] | [INFO] [stderr] 187 | pub fn to_yaml_with_colors(self) -> Yaml { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/theme.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | let ref bar_colors = self.bar_colors; [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------- help: try: `let bar_colors = &self.bar_colors;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/theme.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | / match bar_colors { [INFO] [stderr] 192 | | &Some(ref bc) => { [INFO] [stderr] 193 | | colormap.add_hex(&bc.separator); [INFO] [stderr] 194 | | colormap.add_hex(&bc.background); [INFO] [stderr] ... | [INFO] [stderr] 201 | | &None => () [INFO] [stderr] 202 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 191 | match *bar_colors { [INFO] [stderr] 192 | Some(ref bc) => { [INFO] [stderr] 193 | colormap.add_hex(&bc.separator); [INFO] [stderr] 194 | colormap.add_hex(&bc.background); [INFO] [stderr] 195 | colormap.add_hex(&bc.statusline); [INFO] [stderr] 196 | colormap.add_color_group(&bc.focused_workspace); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/theme.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | let ref window_colors = self.window_colors; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^---------------------- help: try: `let window_colors = &self.window_colors;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/theme.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | / match window_colors { [INFO] [stderr] 205 | | &Some(ref wc) => { [INFO] [stderr] 206 | | colormap.add_color_group(&wc.focused); [INFO] [stderr] 207 | | colormap.add_color_group(&wc.focused_inactive); [INFO] [stderr] ... | [INFO] [stderr] 211 | | &None => () [INFO] [stderr] 212 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 204 | match *window_colors { [INFO] [stderr] 205 | Some(ref wc) => { [INFO] [stderr] 206 | colormap.add_color_group(&wc.focused); [INFO] [stderr] 207 | colormap.add_color_group(&wc.focused_inactive); [INFO] [stderr] 208 | colormap.add_color_group(&wc.unfocused); [INFO] [stderr] 209 | colormap.add_color_group(&wc.urgent); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/theme.rs:226:9 [INFO] [stderr] | [INFO] [stderr] 226 | / match window_colors { [INFO] [stderr] 227 | | &Some(ref wc) => { [INFO] [stderr] 228 | | if wc.focused.is_some() { [INFO] [stderr] 229 | | window_colors_yaml.insert(Yaml::String("focused".to_string()), wc.focused.as_ref().unwrap().to_yaml(&colormap)); [INFO] [stderr] ... | [INFO] [stderr] 241 | | &None => () [INFO] [stderr] 242 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 226 | match *window_colors { [INFO] [stderr] 227 | Some(ref wc) => { [INFO] [stderr] 228 | if wc.focused.is_some() { [INFO] [stderr] 229 | window_colors_yaml.insert(Yaml::String("focused".to_string()), wc.focused.as_ref().unwrap().to_yaml(&colormap)); [INFO] [stderr] 230 | } [INFO] [stderr] 231 | if wc.focused_inactive.is_some() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/theme.rs:244:9 [INFO] [stderr] | [INFO] [stderr] 244 | / match bar_colors { [INFO] [stderr] 245 | | &Some(ref bc) => { [INFO] [stderr] 246 | | if bc.background.is_some() { [INFO] [stderr] 247 | | bar_colors_yaml.insert(Yaml::String("background".to_string()), Yaml::String(colormap.get_color(&bc.background.as_ref().unwrap().to_string()))); [INFO] [stderr] ... | [INFO] [stderr] 265 | | &None => () [INFO] [stderr] 266 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 244 | match *bar_colors { [INFO] [stderr] 245 | Some(ref bc) => { [INFO] [stderr] 246 | if bc.background.is_some() { [INFO] [stderr] 247 | bar_colors_yaml.insert(Yaml::String("background".to_string()), Yaml::String(colormap.get_color(&bc.background.as_ref().unwrap().to_string()))); [INFO] [stderr] 248 | } [INFO] [stderr] 249 | if bc.statusline.is_some() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/theme.rs:278:5 [INFO] [stderr] | [INFO] [stderr] 278 | / if color_spec.as_str().is_none() { [INFO] [stderr] 279 | | return Option::None; [INFO] [stderr] 280 | | } [INFO] [stderr] | |_____^ help: replace_it_with: `color_spec.as_str()?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/theme.rs:295:5 [INFO] [stderr] | [INFO] [stderr] 295 | / if doc[top_key][bottom_key].as_hash().is_none() { [INFO] [stderr] 296 | | return Option::None; [INFO] [stderr] 297 | | } [INFO] [stderr] | |_____^ help: replace_it_with: `doc[top_key][bottom_key].as_hash()?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/theme.rs:316:5 [INFO] [stderr] | [INFO] [stderr] 316 | / if doc["window_colors"].as_hash().is_none() { [INFO] [stderr] 317 | | return Option::None; [INFO] [stderr] 318 | | } [INFO] [stderr] | |_____^ help: replace_it_with: `doc["window_colors"].as_hash()?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/theme.rs:331:5 [INFO] [stderr] | [INFO] [stderr] 331 | / if bar_colors.as_hash().is_none() { [INFO] [stderr] 332 | | return Option::None; [INFO] [stderr] 333 | | } [INFO] [stderr] | |_____^ help: replace_it_with: `bar_colors.as_hash()?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/theme.rs:380:12 [INFO] [stderr] | [INFO] [stderr] 380 | if vec.len() == 0 || vec[0].starts_with("#") { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/theme.rs:380:49 [INFO] [stderr] | [INFO] [stderr] 380 | if vec.len() == 0 || vec[0].starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/theme.rs:421:66 [INFO] [stderr] | [INFO] [stderr] 421 | let mut group = bar_colors.focused_workspace.unwrap_or(ColorGroup::empty()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(ColorGroup::empty)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/theme.rs:433:67 [INFO] [stderr] | [INFO] [stderr] 433 | let mut group = bar_colors.inactive_workspace.unwrap_or(ColorGroup::empty()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(ColorGroup::empty)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/theme.rs:445:65 [INFO] [stderr] | [INFO] [stderr] 445 | let mut group = bar_colors.urgent_workspace.unwrap_or(ColorGroup::empty()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(ColorGroup::empty)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/theme.rs:461:59 [INFO] [stderr] | [INFO] [stderr] 461 | let mut group = window_colors.focused.unwrap_or(ColorGroup::empty()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(ColorGroup::empty)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/theme.rs:476:68 [INFO] [stderr] | [INFO] [stderr] 476 | let mut group = window_colors.focused_inactive.unwrap_or(ColorGroup::empty()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(ColorGroup::empty)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/theme.rs:492:61 [INFO] [stderr] | [INFO] [stderr] 492 | let mut group = window_colors.unfocused.unwrap_or(ColorGroup::empty()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(ColorGroup::empty)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/theme.rs:508:58 [INFO] [stderr] | [INFO] [stderr] 508 | let mut group = window_colors.urgent.unwrap_or(ColorGroup::empty()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(ColorGroup::empty)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/theme.rs:529:32 [INFO] [stderr] | [INFO] [stderr] 529 | pub fn from_config_file(input: &String) -> Theme { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/writer.rs:10:27 [INFO] [stderr] | [INFO] [stderr] 10 | fn leading_spaces(string: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/writer.rs:24:28 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn write_config(input: &String, output: Option<&String>, theme: &Theme) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 57 [INFO] [stderr] --> src/writer.rs:30:1 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn write_config_from_reader(input: BufReader, output: Option<&String>, theme: &Theme) { [INFO] [stderr] 31 | | let mut writer = match output { [INFO] [stderr] 32 | | Some(x) => { [INFO] [stderr] 33 | | let path = Path::new(x.as_str()); [INFO] [stderr] ... | [INFO] [stderr] 414 | | } [INFO] [stderr] 415 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/writer.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | if vec.len() > 0 && !vec[0].starts_with("#") { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/writer.rs:58:49 [INFO] [stderr] | [INFO] [stderr] 58 | if vec.len() > 0 && !vec[0].starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/writer.rs:62:21 [INFO] [stderr] | [INFO] [stderr] 62 | bar_colors.separator.as_ref().map(|color| { [INFO] [stderr] | _____________________^ [INFO] [stderr] | |_____________________| [INFO] [stderr] | || [INFO] [stderr] 63 | || writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] 64 | || writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] 65 | || writer.write(b"separator ").unwrap(); [INFO] [stderr] 66 | || writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] 67 | || writer.write(b"\n").unwrap(); [INFO] [stderr] 68 | || }); [INFO] [stderr] | ||______________________^- help: try this: `if let Some(color) = bar_colors.separator.as_ref() { ... }` [INFO] [stderr] | |_______________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:64:25 [INFO] [stderr] | [INFO] [stderr] 64 | writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | writer.write(b"separator ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:66:25 [INFO] [stderr] | [INFO] [stderr] 66 | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:67:25 [INFO] [stderr] | [INFO] [stderr] 67 | writer.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/writer.rs:72:21 [INFO] [stderr] | [INFO] [stderr] 72 | bar_colors.background.as_ref().map(|color| { [INFO] [stderr] | _____________________^ [INFO] [stderr] | |_____________________| [INFO] [stderr] | || [INFO] [stderr] 73 | || writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] 74 | || writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] 75 | || writer.write(b"background ").unwrap(); [INFO] [stderr] 76 | || writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] 77 | || writer.write(b"\n").unwrap(); [INFO] [stderr] 78 | || }); [INFO] [stderr] | ||______________________^- help: try this: `if let Some(color) = bar_colors.background.as_ref() { ... }` [INFO] [stderr] | |_______________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:73:25 [INFO] [stderr] | [INFO] [stderr] 73 | writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:74:25 [INFO] [stderr] | [INFO] [stderr] 74 | writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:75:25 [INFO] [stderr] | [INFO] [stderr] 75 | writer.write(b"background ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:76:25 [INFO] [stderr] | [INFO] [stderr] 76 | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:77:25 [INFO] [stderr] | [INFO] [stderr] 77 | writer.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/writer.rs:82:21 [INFO] [stderr] | [INFO] [stderr] 82 | bar_colors.statusline.as_ref().map(|color| { [INFO] [stderr] | _____________________^ [INFO] [stderr] | |_____________________| [INFO] [stderr] | || [INFO] [stderr] 83 | || writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] 84 | || writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] 85 | || writer.write(b"statusline ").unwrap(); [INFO] [stderr] 86 | || writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] 87 | || writer.write(b"\n").unwrap(); [INFO] [stderr] 88 | || }); [INFO] [stderr] | ||______________________^- help: try this: `if let Some(color) = bar_colors.statusline.as_ref() { ... }` [INFO] [stderr] | |_______________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:83:25 [INFO] [stderr] | [INFO] [stderr] 83 | writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:84:25 [INFO] [stderr] | [INFO] [stderr] 84 | writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:85:25 [INFO] [stderr] | [INFO] [stderr] 85 | writer.write(b"statusline ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:86:25 [INFO] [stderr] | [INFO] [stderr] 86 | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:87:25 [INFO] [stderr] | [INFO] [stderr] 87 | writer.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/writer.rs:96:39 [INFO] [stderr] | [INFO] [stderr] 96 | let group = match group_name.as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `group_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:113:21 [INFO] [stderr] | [INFO] [stderr] 113 | writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:114:21 [INFO] [stderr] | [INFO] [stderr] 114 | writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:115:21 [INFO] [stderr] | [INFO] [stderr] 115 | writer.write(group_name.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:116:21 [INFO] [stderr] | [INFO] [stderr] 116 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:117:21 [INFO] [stderr] | [INFO] [stderr] 117 | writer.write(group.border.as_ref().unwrap().as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:118:21 [INFO] [stderr] | [INFO] [stderr] 118 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:119:21 [INFO] [stderr] | [INFO] [stderr] 119 | writer.write(group.background.as_ref().unwrap().as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:120:21 [INFO] [stderr] | [INFO] [stderr] 120 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:121:21 [INFO] [stderr] | [INFO] [stderr] 121 | writer.write(group.text.as_ref().unwrap().as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/writer.rs:124:21 [INFO] [stderr] | [INFO] [stderr] 124 | / match group.indicator { [INFO] [stderr] 125 | | Some(ref color) => { [INFO] [stderr] 126 | | writer.write(b" ").unwrap(); [INFO] [stderr] 127 | | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 130 | | None => () [INFO] [stderr] 131 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 124 | if let Some(ref color) = group.indicator { [INFO] [stderr] 125 | writer.write(b" ").unwrap(); [INFO] [stderr] 126 | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] 127 | () [INFO] [stderr] 128 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:126:29 [INFO] [stderr] | [INFO] [stderr] 126 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:127:29 [INFO] [stderr] | [INFO] [stderr] 127 | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:133:21 [INFO] [stderr] | [INFO] [stderr] 133 | writer.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | writer.write(original_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:143:21 [INFO] [stderr] | [INFO] [stderr] 143 | writer.write(b" colors {\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/writer.rs:144:21 [INFO] [stderr] | [INFO] [stderr] 144 | bar_colors.separator.as_ref().map(|color| { [INFO] [stderr] | _____________________^ [INFO] [stderr] | |_____________________| [INFO] [stderr] | || [INFO] [stderr] 145 | || writer.write(b" separator ").unwrap(); [INFO] [stderr] 146 | || writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] 147 | || writer.write(b"\n").unwrap(); [INFO] [stderr] 148 | || }); [INFO] [stderr] | ||______________________^- help: try this: `if let Some(color) = bar_colors.separator.as_ref() { ... }` [INFO] [stderr] | |_______________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:145:25 [INFO] [stderr] | [INFO] [stderr] 145 | writer.write(b" separator ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:146:25 [INFO] [stderr] | [INFO] [stderr] 146 | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:147:25 [INFO] [stderr] | [INFO] [stderr] 147 | writer.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/writer.rs:149:21 [INFO] [stderr] | [INFO] [stderr] 149 | bar_colors.background.as_ref().map(|color| { [INFO] [stderr] | _____________________^ [INFO] [stderr] | |_____________________| [INFO] [stderr] | || [INFO] [stderr] 150 | || writer.write(b" background ").unwrap(); [INFO] [stderr] 151 | || writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] 152 | || writer.write(b"\n").unwrap(); [INFO] [stderr] 153 | || }); [INFO] [stderr] | ||______________________^- help: try this: `if let Some(color) = bar_colors.background.as_ref() { ... }` [INFO] [stderr] | |_______________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:150:25 [INFO] [stderr] | [INFO] [stderr] 150 | writer.write(b" background ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:151:25 [INFO] [stderr] | [INFO] [stderr] 151 | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | writer.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/writer.rs:154:21 [INFO] [stderr] | [INFO] [stderr] 154 | bar_colors.statusline.as_ref().map(|color| { [INFO] [stderr] | _____________________^ [INFO] [stderr] | |_____________________| [INFO] [stderr] | || [INFO] [stderr] 155 | || writer.write(b" statusline ").unwrap(); [INFO] [stderr] 156 | || writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] 157 | || writer.write(b"\n").unwrap(); [INFO] [stderr] 158 | || }); [INFO] [stderr] | ||______________________^- help: try this: `if let Some(color) = bar_colors.statusline.as_ref() { ... }` [INFO] [stderr] | |_______________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:155:25 [INFO] [stderr] | [INFO] [stderr] 155 | writer.write(b" statusline ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:156:25 [INFO] [stderr] | [INFO] [stderr] 156 | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:157:25 [INFO] [stderr] | [INFO] [stderr] 157 | writer.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/writer.rs:162:43 [INFO] [stderr] | [INFO] [stderr] 162 | let group = match group_name.as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `group_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:179:25 [INFO] [stderr] | [INFO] [stderr] 179 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:180:25 [INFO] [stderr] | [INFO] [stderr] 180 | writer.write(group_name.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:181:25 [INFO] [stderr] | [INFO] [stderr] 181 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:182:25 [INFO] [stderr] | [INFO] [stderr] 182 | writer.write(group.border.as_ref().unwrap().as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:183:25 [INFO] [stderr] | [INFO] [stderr] 183 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:184:25 [INFO] [stderr] | [INFO] [stderr] 184 | writer.write(group.background.as_ref().unwrap().as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:185:25 [INFO] [stderr] | [INFO] [stderr] 185 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:186:25 [INFO] [stderr] | [INFO] [stderr] 186 | writer.write(group.text.as_ref().unwrap().as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:187:25 [INFO] [stderr] | [INFO] [stderr] 187 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/writer.rs:189:25 [INFO] [stderr] | [INFO] [stderr] 189 | / match group.indicator { [INFO] [stderr] 190 | | Some(ref color) => { [INFO] [stderr] 191 | | writer.write(b" ").unwrap(); [INFO] [stderr] 192 | | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 195 | | None => () [INFO] [stderr] 196 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 189 | if let Some(ref color) = group.indicator { [INFO] [stderr] 190 | writer.write(b" ").unwrap(); [INFO] [stderr] 191 | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] 192 | () [INFO] [stderr] 193 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:191:33 [INFO] [stderr] | [INFO] [stderr] 191 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:192:33 [INFO] [stderr] | [INFO] [stderr] 192 | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:198:25 [INFO] [stderr] | [INFO] [stderr] 198 | writer.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:200:21 [INFO] [stderr] | [INFO] [stderr] 200 | writer.write(b" }\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:205:17 [INFO] [stderr] | [INFO] [stderr] 205 | writer.write(original_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:211:21 [INFO] [stderr] | [INFO] [stderr] 211 | writer.write(original_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:220:21 [INFO] [stderr] | [INFO] [stderr] 220 | writer.write(vec[0].as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:223:21 [INFO] [stderr] | [INFO] [stderr] 223 | / writer.write(match vec[0] { [INFO] [stderr] 224 | | "separator" => match bar_colors.separator { [INFO] [stderr] 225 | | Some(ref color) => color.as_bytes(), [INFO] [stderr] 226 | | None => vec[1].as_bytes() [INFO] [stderr] ... | [INFO] [stderr] 236 | | _ => vec[1].as_bytes(), [INFO] [stderr] 237 | | }).unwrap(); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:238:21 [INFO] [stderr] | [INFO] [stderr] 238 | writer.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:251:25 [INFO] [stderr] | [INFO] [stderr] 251 | writer.write(original_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:257:21 [INFO] [stderr] | [INFO] [stderr] 257 | writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:258:21 [INFO] [stderr] | [INFO] [stderr] 258 | writer.write(vec[0].as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:259:21 [INFO] [stderr] | [INFO] [stderr] 259 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:261:21 [INFO] [stderr] | [INFO] [stderr] 261 | / writer.write(match group.border.as_ref() { [INFO] [stderr] 262 | | Some(color) => color.as_bytes(), [INFO] [stderr] 263 | | None => vec[1].as_bytes() [INFO] [stderr] 264 | | }).unwrap(); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:265:21 [INFO] [stderr] | [INFO] [stderr] 265 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:267:21 [INFO] [stderr] | [INFO] [stderr] 267 | / writer.write(match group.background.as_ref() { [INFO] [stderr] 268 | | Some(color) => color.as_bytes(), [INFO] [stderr] 269 | | None => vec[2].as_bytes() [INFO] [stderr] 270 | | }).unwrap(); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:271:21 [INFO] [stderr] | [INFO] [stderr] 271 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:273:21 [INFO] [stderr] | [INFO] [stderr] 273 | / writer.write(match group.text.as_ref() { [INFO] [stderr] 274 | | Some(color) => color.as_bytes(), [INFO] [stderr] 275 | | None => vec[3].as_bytes() [INFO] [stderr] 276 | | }).unwrap(); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:279:25 [INFO] [stderr] | [INFO] [stderr] 279 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:280:25 [INFO] [stderr] | [INFO] [stderr] 280 | / writer.write(match group.indicator.as_ref() { [INFO] [stderr] 281 | | Some(color) => color.as_bytes(), [INFO] [stderr] 282 | | None => vec[3].as_bytes() [INFO] [stderr] 283 | | }).unwrap(); [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:285:21 [INFO] [stderr] | [INFO] [stderr] 285 | writer.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:294:17 [INFO] [stderr] | [INFO] [stderr] 294 | writer.write(original_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:300:17 [INFO] [stderr] | [INFO] [stderr] 300 | writer.write(original_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:307:21 [INFO] [stderr] | [INFO] [stderr] 307 | writer.write(original_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:322:21 [INFO] [stderr] | [INFO] [stderr] 322 | writer.write(original_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:328:17 [INFO] [stderr] | [INFO] [stderr] 328 | writer.write(leading.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:329:17 [INFO] [stderr] | [INFO] [stderr] 329 | writer.write(vec[0].as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:330:17 [INFO] [stderr] | [INFO] [stderr] 330 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:332:17 [INFO] [stderr] | [INFO] [stderr] 332 | / writer.write(match group.border.as_ref() { [INFO] [stderr] 333 | | Some(color) => color.as_bytes(), [INFO] [stderr] 334 | | None => vec[1].as_bytes() [INFO] [stderr] 335 | | }).unwrap(); [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:336:17 [INFO] [stderr] | [INFO] [stderr] 336 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:338:17 [INFO] [stderr] | [INFO] [stderr] 338 | / writer.write(match group.background.as_ref() { [INFO] [stderr] 339 | | Some(color) => color.as_bytes(), [INFO] [stderr] 340 | | None => vec[2].as_bytes() [INFO] [stderr] 341 | | }).unwrap(); [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:345:21 [INFO] [stderr] | [INFO] [stderr] 345 | / writer.write(match group.text.as_ref() { [INFO] [stderr] 346 | | Some(color) => color.as_bytes(), [INFO] [stderr] 347 | | None => vec[3].as_bytes() [INFO] [stderr] 348 | | }).unwrap(); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:349:21 [INFO] [stderr] | [INFO] [stderr] 349 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:353:25 [INFO] [stderr] | [INFO] [stderr] 353 | / writer.write(match group.indicator.as_ref() { [INFO] [stderr] 354 | | Some(color) => color.as_bytes(), [INFO] [stderr] 355 | | None => vec[4].as_bytes() [INFO] [stderr] 356 | | }).unwrap(); [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:360:17 [INFO] [stderr] | [INFO] [stderr] 360 | writer.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:365:9 [INFO] [stderr] | [INFO] [stderr] 365 | writer.write(original_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/writer.rs:375:27 [INFO] [stderr] | [INFO] [stderr] 375 | let group = match window_color_name.as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `window_color_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/writer.rs:389:9 [INFO] [stderr] | [INFO] [stderr] 389 | writer.write(window_color_name.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/writer.rs:390:9 [INFO] [stderr] | [INFO] [stderr] 390 | writer.write(b" "); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:391:9 [INFO] [stderr] | [INFO] [stderr] 391 | / writer.write(match group.border.as_ref() { [INFO] [stderr] 392 | | Some(color) => color.as_bytes(), [INFO] [stderr] 393 | | None => b"#000000" [INFO] [stderr] 394 | | }).unwrap(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:395:9 [INFO] [stderr] | [INFO] [stderr] 395 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:397:9 [INFO] [stderr] | [INFO] [stderr] 397 | / writer.write(match group.background.as_ref() { [INFO] [stderr] 398 | | Some(color) => color.as_bytes(), [INFO] [stderr] 399 | | None => b"#000000" [INFO] [stderr] 400 | | }).unwrap(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:401:9 [INFO] [stderr] | [INFO] [stderr] 401 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:403:9 [INFO] [stderr] | [INFO] [stderr] 403 | / writer.write(match group.text.as_ref() { [INFO] [stderr] 404 | | Some(color) => color.as_bytes(), [INFO] [stderr] 405 | | None => b"#000000" [INFO] [stderr] 406 | | }).unwrap(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/writer.rs:408:9 [INFO] [stderr] | [INFO] [stderr] 408 | group.indicator.as_ref().map(|color| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 409 | || writer.write(b" ").unwrap(); [INFO] [stderr] 410 | || writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] 411 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(color) = group.indicator.as_ref() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:409:13 [INFO] [stderr] | [INFO] [stderr] 409 | writer.write(b" ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:410:13 [INFO] [stderr] | [INFO] [stderr] 410 | writer.write(color.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:413:9 [INFO] [stderr] | [INFO] [stderr] 413 | writer.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/writer.rs:428:32 [INFO] [stderr] | [INFO] [stderr] 428 | fn get_file_contents(path: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/writer.rs:431:9 [INFO] [stderr] | [INFO] [stderr] 431 | file.read_to_string(&mut contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | writeln!(&mut std::io::stderr(), "{}", msg); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:44 [INFO] [stderr] | [INFO] [stderr] 37 | let sec = (elapsed.as_secs() as u64) + (elapsed.subsec_nanos() as u64) / 1000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | let home = String::from(env::var("HOME").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `env::var("HOME").unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:64:26 [INFO] [stderr] | [INFO] [stderr] 64 | fn validate_config(path: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | writeln!(&mut std::io::stderr(), "Could not find i3 binary in the system PATH to validate the config before parsing"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | file.read_to_string(&mut contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:206:13 [INFO] [stderr] | [INFO] [stderr] 206 | writeln!(&mut std::io::stderr(), "Could not validate config at {}. Use `i3 -C -c {}` to see validation errors.", config, config); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:246:9 [INFO] [stderr] | [INFO] [stderr] 246 | writeln!(&mut std::io::stderr(), "Could not validate config at {}. Use `i3 -C -c {}` to see validation errors.", config, config); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:268:14 [INFO] [stderr] | [INFO] [stderr] 268 | Some(config.as_str().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 268 | Some(&(*config.as_str()).clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 268 | Some(&str::clone(config.as_str())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:281:9 [INFO] [stderr] | [INFO] [stderr] 281 | writeln!(&mut std::io::stderr(), "saving config at {} to {}", &config, &tmp_input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:302:21 [INFO] [stderr] | [INFO] [stderr] 302 | writeln!(&mut std::io::stderr(), "Could not reload config with swaymsg: {}", err); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:317:21 [INFO] [stderr] | [INFO] [stderr] 317 | writeln!(&mut std::io::stderr(), "Could not reload config with i3-msg: {}", err); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:321:13 [INFO] [stderr] | [INFO] [stderr] 321 | writeln!(&mut std::io::stderr(), "Could not reload config: no display environment variable set."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 96 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `i3-style`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f9612719b73402bfb1246d2724551024792f0e7e3af7601530b1f31edb560f2a"` [INFO] running `"docker" "rm" "-f" "f9612719b73402bfb1246d2724551024792f0e7e3af7601530b1f31edb560f2a"` [INFO] [stdout] f9612719b73402bfb1246d2724551024792f0e7e3af7601530b1f31edb560f2a