[INFO] crate i3-quick-bind 0.1.0 is already in cache [INFO] extracting crate i3-quick-bind 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/i3-quick-bind/0.1.0 [INFO] extracting crate i3-quick-bind 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/i3-quick-bind/0.1.0 [INFO] validating manifest of i3-quick-bind-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of i3-quick-bind-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing i3-quick-bind-0.1.0 [INFO] finished frobbing i3-quick-bind-0.1.0 [INFO] frobbed toml for i3-quick-bind-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/i3-quick-bind/0.1.0/Cargo.toml [INFO] started frobbing i3-quick-bind-0.1.0 [INFO] finished frobbing i3-quick-bind-0.1.0 [INFO] frobbed toml for i3-quick-bind-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/i3-quick-bind/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting i3-quick-bind-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/i3-quick-bind/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4eae1f112d4e453ca46d360a9ebe9f2ca208cbd77ec9f839b82194573ba3dc94 [INFO] running `"docker" "start" "-a" "4eae1f112d4e453ca46d360a9ebe9f2ca208cbd77ec9f839b82194573ba3dc94"` [INFO] [stderr] Checking i3ipc v0.8.4 [INFO] [stderr] Checking i3-quick-bind v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:78:25 [INFO] [stderr] | [INFO] [stderr] 78 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:78:25 [INFO] [stderr] | [INFO] [stderr] 78 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | / if mods.len() == 0 || mods == &cloned_mods[..] { [INFO] [stderr] 77 | | if command == "nop" && &matchsym == keysym { [INFO] [stderr] 78 | | println!(""); [INFO] [stderr] 79 | | if let Ok(child) = Command::new("sh") [INFO] [stderr] ... | [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 76 | if (mods.len() == 0 || mods == &cloned_mods[..]) && command == "nop" && &matchsym == keysym { [INFO] [stderr] 77 | println!(""); [INFO] [stderr] 78 | if let Ok(child) = Command::new("sh") [INFO] [stderr] 79 | .arg("-c") [INFO] [stderr] 80 | .arg(&sharg) [INFO] [stderr] 81 | .spawn() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | / if mods.len() == 0 || mods == &cloned_mods[..] { [INFO] [stderr] 77 | | if command == "nop" && &matchsym == keysym { [INFO] [stderr] 78 | | println!(""); [INFO] [stderr] 79 | | if let Ok(child) = Command::new("sh") [INFO] [stderr] ... | [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 76 | if (mods.len() == 0 || mods == &cloned_mods[..]) && command == "nop" && &matchsym == keysym { [INFO] [stderr] 77 | println!(""); [INFO] [stderr] 78 | if let Ok(child) = Command::new("sh") [INFO] [stderr] 79 | .arg("-c") [INFO] [stderr] 80 | .arg(&sharg) [INFO] [stderr] 81 | .spawn() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:17:24 [INFO] [stderr] | [INFO] [stderr] 17 | let shownmods = if mods.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `mods.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:50:52 [INFO] [stderr] | [INFO] [stderr] 50 | .unwrap_or("?".to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "?".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:76:20 [INFO] [stderr] | [INFO] [stderr] 76 | if mods.len() == 0 || mods == &cloned_mods[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `mods.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:77:44 [INFO] [stderr] | [INFO] [stderr] 77 | if command == "nop" && &matchsym == keysym { [INFO] [stderr] | ---------^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `matchsym` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:116:52 [INFO] [stderr] | [INFO] [stderr] 116 | let mut keyvec: Vec<&str> = unparsed_key.split("+").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'+'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:17:24 [INFO] [stderr] | [INFO] [stderr] 17 | let shownmods = if mods.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `mods.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:50:52 [INFO] [stderr] | [INFO] [stderr] 50 | .unwrap_or("?".to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "?".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:76:20 [INFO] [stderr] | [INFO] [stderr] 76 | if mods.len() == 0 || mods == &cloned_mods[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `mods.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:77:44 [INFO] [stderr] | [INFO] [stderr] 77 | if command == "nop" && &matchsym == keysym { [INFO] [stderr] | ---------^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `matchsym` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:116:52 [INFO] [stderr] | [INFO] [stderr] 116 | let mut keyvec: Vec<&str> = unparsed_key.split("+").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'+'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.19s [INFO] running `"docker" "inspect" "4eae1f112d4e453ca46d360a9ebe9f2ca208cbd77ec9f839b82194573ba3dc94"` [INFO] running `"docker" "rm" "-f" "4eae1f112d4e453ca46d360a9ebe9f2ca208cbd77ec9f839b82194573ba3dc94"` [INFO] [stdout] 4eae1f112d4e453ca46d360a9ebe9f2ca208cbd77ec9f839b82194573ba3dc94