[INFO] crate i2p 0.0.1 is already in cache [INFO] extracting crate i2p 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/i2p/0.0.1 [INFO] extracting crate i2p 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/i2p/0.0.1 [INFO] validating manifest of i2p-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of i2p-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing i2p-0.0.1 [INFO] finished frobbing i2p-0.0.1 [INFO] frobbed toml for i2p-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/i2p/0.0.1/Cargo.toml [INFO] started frobbing i2p-0.0.1 [INFO] finished frobbing i2p-0.0.1 [INFO] frobbed toml for i2p-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/i2p/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting i2p-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/i2p/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5b7789a46779d9685da4c64528f20af729fa8ffd928bca7526361b72237f538f [INFO] running `"docker" "start" "-a" "5b7789a46779d9685da4c64528f20af729fa8ffd928bca7526361b72237f538f"` [INFO] [stderr] Checking i2p v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/addr.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | port: port, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/addr.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | dest: dest, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sam.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | sam: sam, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sam` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sam.rs:142:17 [INFO] [stderr] | [INFO] [stderr] 142 | local_dest: local_dest, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `local_dest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sam.rs:190:17 [INFO] [stderr] | [INFO] [stderr] 190 | sam: sam, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sam` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sam.rs:191:17 [INFO] [stderr] | [INFO] [stderr] 191 | session: session, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `session` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sam.rs:192:17 [INFO] [stderr] | [INFO] [stderr] 192 | peer_dest: peer_dest, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `peer_dest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/addr.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | port: port, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/addr.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | dest: dest, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sam.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | sam: sam, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sam` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sam.rs:142:17 [INFO] [stderr] | [INFO] [stderr] 142 | local_dest: local_dest, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `local_dest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sam.rs:190:17 [INFO] [stderr] | [INFO] [stderr] 190 | sam: sam, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sam` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sam.rs:191:17 [INFO] [stderr] | [INFO] [stderr] 191 | session: session, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `session` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sam.rs:192:17 [INFO] [stderr] | [INFO] [stderr] 192 | peer_dest: peer_dest, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `peer_dest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `I2pAddr` [INFO] [stderr] --> src/net/datagram.rs:4:11 [INFO] [stderr] | [INFO] [stderr] 4 | use net::{I2pAddr, I2pSocketAddr, ToI2pSocketAddrs}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `I2pAddr` [INFO] [stderr] --> src/net/datagram.rs:4:11 [INFO] [stderr] | [INFO] [stderr] 4 | use net::{I2pAddr, I2pSocketAddr, ToI2pSocketAddrs}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sam_addr` [INFO] [stderr] --> src/net/datagram.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | fn bind_addr(sam_addr: &SocketAddr, addr: &I2pSocketAddr) -> io::Result { [INFO] [stderr] | ^^^^^^^^ help: consider using `_sam_addr` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/net/datagram.rs:60:41 [INFO] [stderr] | [INFO] [stderr] 60 | fn bind_addr(sam_addr: &SocketAddr, addr: &I2pSocketAddr) -> io::Result { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/net/datagram.rs:77:29 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn recv_from(&self, buf: &mut [u8]) -> io::Result<(usize, I2pSocketAddr)> { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/net/datagram.rs:98:29 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn peek_from(&self, buf: &mut [u8]) -> io::Result<(usize, I2pSocketAddr)> { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/net/datagram.rs:121:18 [INFO] [stderr] | [INFO] [stderr] 121 | Some(addr) => unimplemented!(), [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/net/datagram.rs:118:48 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn send_to(&self, buf: &[u8], addr: A) [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sam_addr` [INFO] [stderr] --> src/net/datagram.rs:177:43 [INFO] [stderr] | [INFO] [stderr] 177 | super::each_addr(sam_addr, addr, |sam_addr, addr| unimplemented!()) [INFO] [stderr] | ^^^^^^^^ help: consider using `_sam_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/net/datagram.rs:177:53 [INFO] [stderr] | [INFO] [stderr] 177 | super::each_addr(sam_addr, addr, |sam_addr, addr| unimplemented!()) [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/net/datagram.rs:196:24 [INFO] [stderr] | [INFO] [stderr] 196 | pub fn send(&self, buf: &[u8]) -> io::Result { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/net/datagram.rs:219:24 [INFO] [stderr] | [INFO] [stderr] 219 | pub fn recv(&self, buf: &mut [u8]) -> io::Result { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/net/datagram.rs:247:24 [INFO] [stderr] | [INFO] [stderr] 247 | pub fn peek(&self, buf: &mut [u8]) -> io::Result { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sam_addr` [INFO] [stderr] --> src/net/streaming.rs:246:18 [INFO] [stderr] | [INFO] [stderr] 246 | fn bind_addr(sam_addr: &SocketAddr, addr: &I2pSocketAddr) -> io::Result { [INFO] [stderr] | ^^^^^^^^ help: consider using `_sam_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/net/streaming.rs:246:41 [INFO] [stderr] | [INFO] [stderr] 246 | fn bind_addr(sam_addr: &SocketAddr, addr: &I2pSocketAddr) -> io::Result { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `f` [INFO] [stderr] --> src/net/streaming.rs:342:19 [INFO] [stderr] | [INFO] [stderr] 342 | fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { [INFO] [stderr] | ^ help: consider using `_f` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sam_addr` [INFO] [stderr] --> src/net/datagram.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | fn bind_addr(sam_addr: &SocketAddr, addr: &I2pSocketAddr) -> io::Result { [INFO] [stderr] | ^^^^^^^^ help: consider using `_sam_addr` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/net/datagram.rs:60:41 [INFO] [stderr] | [INFO] [stderr] 60 | fn bind_addr(sam_addr: &SocketAddr, addr: &I2pSocketAddr) -> io::Result { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/net/datagram.rs:77:29 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn recv_from(&self, buf: &mut [u8]) -> io::Result<(usize, I2pSocketAddr)> { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/net/datagram.rs:98:29 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn peek_from(&self, buf: &mut [u8]) -> io::Result<(usize, I2pSocketAddr)> { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/net/datagram.rs:121:18 [INFO] [stderr] | [INFO] [stderr] 121 | Some(addr) => unimplemented!(), [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/net/datagram.rs:118:48 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn send_to(&self, buf: &[u8], addr: A) [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sam_addr` [INFO] [stderr] --> src/net/datagram.rs:177:43 [INFO] [stderr] | [INFO] [stderr] 177 | super::each_addr(sam_addr, addr, |sam_addr, addr| unimplemented!()) [INFO] [stderr] | ^^^^^^^^ help: consider using `_sam_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/net/datagram.rs:177:53 [INFO] [stderr] | [INFO] [stderr] 177 | super::each_addr(sam_addr, addr, |sam_addr, addr| unimplemented!()) [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/net/datagram.rs:196:24 [INFO] [stderr] | [INFO] [stderr] 196 | pub fn send(&self, buf: &[u8]) -> io::Result { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/net/datagram.rs:219:24 [INFO] [stderr] | [INFO] [stderr] 219 | pub fn recv(&self, buf: &mut [u8]) -> io::Result { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/net/datagram.rs:247:24 [INFO] [stderr] | [INFO] [stderr] 247 | pub fn peek(&self, buf: &mut [u8]) -> io::Result { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sam_addr` [INFO] [stderr] --> src/net/streaming.rs:246:18 [INFO] [stderr] | [INFO] [stderr] 246 | fn bind_addr(sam_addr: &SocketAddr, addr: &I2pSocketAddr) -> io::Result { [INFO] [stderr] | ^^^^^^^^ help: consider using `_sam_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/net/streaming.rs:246:41 [INFO] [stderr] | [INFO] [stderr] 246 | fn bind_addr(sam_addr: &SocketAddr, addr: &I2pSocketAddr) -> io::Result { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `f` [INFO] [stderr] --> src/net/streaming.rs:342:19 [INFO] [stderr] | [INFO] [stderr] 342 | fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { [INFO] [stderr] | ^ help: consider using `_f` instead [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/sam.rs:52:19 [INFO] [stderr] | [INFO] [stderr] 52 | let new_vec = vec.clone(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 52 | let new_vec = &(*vec).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 52 | let new_vec = &[(&str, &str)]::clone(vec); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/sam.rs:54:15 [INFO] [stderr] | [INFO] [stderr] 54 | let res = map.get("RESULT").unwrap_or(&"OK").clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 54 | let res = &(*map.get("RESULT").unwrap_or(&"OK")).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 54 | let res = &str::clone(map.get("RESULT").unwrap_or(&"OK")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/sam.rs:55:15 [INFO] [stderr] | [INFO] [stderr] 55 | let msg = map.get("MESSAGE").unwrap_or(&"").clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 55 | let msg = &(*map.get("MESSAGE").unwrap_or(&"")).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 55 | let msg = &str::clone(map.get("MESSAGE").unwrap_or(&"")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / named!(quoted_value <&str, &str>, [INFO] [stderr] 20 | | do_parse!( [INFO] [stderr] 21 | | tag_s!("\"") >> [INFO] [stderr] 22 | | val: take_till_s!(is_double_quote) >> [INFO] [stderr] ... | [INFO] [stderr] 25 | | ) [INFO] [stderr] 26 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | named!(value <&str, &str>, take_till_s!(is_space_or_next_line)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `i2p`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/sam.rs:52:19 [INFO] [stderr] | [INFO] [stderr] 52 | let new_vec = vec.clone(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 52 | let new_vec = &(*vec).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 52 | let new_vec = &[(&str, &str)]::clone(vec); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/sam.rs:54:15 [INFO] [stderr] | [INFO] [stderr] 54 | let res = map.get("RESULT").unwrap_or(&"OK").clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 54 | let res = &(*map.get("RESULT").unwrap_or(&"OK")).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 54 | let res = &str::clone(map.get("RESULT").unwrap_or(&"OK")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/sam.rs:55:15 [INFO] [stderr] | [INFO] [stderr] 55 | let msg = map.get("MESSAGE").unwrap_or(&"").clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 55 | let msg = &(*map.get("MESSAGE").unwrap_or(&"")).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 55 | let msg = &str::clone(map.get("MESSAGE").unwrap_or(&"")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / named!(quoted_value <&str, &str>, [INFO] [stderr] 20 | | do_parse!( [INFO] [stderr] 21 | | tag_s!("\"") >> [INFO] [stderr] 22 | | val: take_till_s!(is_double_quote) >> [INFO] [stderr] ... | [INFO] [stderr] 25 | | ) [INFO] [stderr] 26 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | named!(value <&str, &str>, take_till_s!(is_space_or_next_line)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `i2p`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5b7789a46779d9685da4c64528f20af729fa8ffd928bca7526361b72237f538f"` [INFO] running `"docker" "rm" "-f" "5b7789a46779d9685da4c64528f20af729fa8ffd928bca7526361b72237f538f"` [INFO] [stdout] 5b7789a46779d9685da4c64528f20af729fa8ffd928bca7526361b72237f538f