[INFO] crate i2c 0.1.0 is already in cache [INFO] extracting crate i2c 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/i2c/0.1.0 [INFO] extracting crate i2c 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/i2c/0.1.0 [INFO] validating manifest of i2c-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of i2c-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing i2c-0.1.0 [INFO] finished frobbing i2c-0.1.0 [INFO] frobbed toml for i2c-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/i2c/0.1.0/Cargo.toml [INFO] started frobbing i2c-0.1.0 [INFO] finished frobbing i2c-0.1.0 [INFO] frobbed toml for i2c-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/i2c/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting i2c-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/i2c/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 36c2daec2d51aeda7f7dbbccf83ce8853f66a956cf1944a32adb51746b793dcb [INFO] running `"docker" "start" "-a" "36c2daec2d51aeda7f7dbbccf83ce8853f66a956cf1944a32adb51746b793dcb"` [INFO] [stderr] Checking i2c v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/smbus.rs:16:54 [INFO] [stderr] | [INFO] [stderr] 16 | value[..len].copy_from_slice(&buffer[1..len + 1]); [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/smbus.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | Ok(buf[0] as u16 | (buf[1] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/smbus.rs:80:36 [INFO] [stderr] | [INFO] [stderr] 80 | Ok(buf[0] as u16 | (buf[1] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/smbus.rs:95:20 [INFO] [stderr] | [INFO] [stderr] 95 | Ok(buf[0] as u16 | (buf[1] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/smbus.rs:95:36 [INFO] [stderr] | [INFO] [stderr] 95 | Ok(buf[0] as u16 | (buf[1] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `Message<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:161:1 [INFO] [stderr] | [INFO] [stderr] 161 | / impl<'a> Message<'a> { [INFO] [stderr] 162 | | /// Byte length of the message data buffer. [INFO] [stderr] 163 | | pub fn len(&self) -> usize { [INFO] [stderr] 164 | | match *self { [INFO] [stderr] ... | [INFO] [stderr] 184 | | } [INFO] [stderr] 185 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/smbus.rs:16:54 [INFO] [stderr] | [INFO] [stderr] 16 | value[..len].copy_from_slice(&buffer[1..len + 1]); [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/smbus.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | Ok(buf[0] as u16 | (buf[1] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/smbus.rs:80:36 [INFO] [stderr] | [INFO] [stderr] 80 | Ok(buf[0] as u16 | (buf[1] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/smbus.rs:95:20 [INFO] [stderr] | [INFO] [stderr] 95 | Ok(buf[0] as u16 | (buf[1] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/smbus.rs:95:36 [INFO] [stderr] | [INFO] [stderr] 95 | Ok(buf[0] as u16 | (buf[1] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `Message<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:161:1 [INFO] [stderr] | [INFO] [stderr] 161 | / impl<'a> Message<'a> { [INFO] [stderr] 162 | | /// Byte length of the message data buffer. [INFO] [stderr] 163 | | pub fn len(&self) -> usize { [INFO] [stderr] 164 | | match *self { [INFO] [stderr] ... | [INFO] [stderr] 184 | | } [INFO] [stderr] 185 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.27s [INFO] running `"docker" "inspect" "36c2daec2d51aeda7f7dbbccf83ce8853f66a956cf1944a32adb51746b793dcb"` [INFO] running `"docker" "rm" "-f" "36c2daec2d51aeda7f7dbbccf83ce8853f66a956cf1944a32adb51746b793dcb"` [INFO] [stdout] 36c2daec2d51aeda7f7dbbccf83ce8853f66a956cf1944a32adb51746b793dcb