[INFO] crate hyperap 0.4.0 is already in cache [INFO] extracting crate hyperap 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/hyperap/0.4.0 [INFO] extracting crate hyperap 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hyperap/0.4.0 [INFO] validating manifest of hyperap-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hyperap-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hyperap-0.4.0 [INFO] finished frobbing hyperap-0.4.0 [INFO] frobbed toml for hyperap-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/hyperap/0.4.0/Cargo.toml [INFO] started frobbing hyperap-0.4.0 [INFO] finished frobbing hyperap-0.4.0 [INFO] frobbed toml for hyperap-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hyperap/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hyperap-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hyperap/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0482d163c07848beab2f4ac900f32c817a9f7e441dd3f8e4f0405e5b9458b94a [INFO] running `"docker" "start" "-a" "0482d163c07848beab2f4ac900f32c817a9f7e441dd3f8e4f0405e5b9458b94a"` [INFO] [stderr] Checking hyperap v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/hyperap.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | method: method, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/hyperap.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | method: method, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/hyperap.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | method: method, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/hyperap.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | method: method, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/server/hyperap.rs:84:28 [INFO] [stderr] | [INFO] [stderr] 84 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 85 | | if let Some(code) = exit_status.code() { [INFO] [stderr] 86 | | println!("Command returned non-zero exit status {}!", code); [INFO] [stderr] 87 | | } else { [INFO] [stderr] 88 | | println!("Command returned with unknown exit status!"); [INFO] [stderr] 89 | | } [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 84 | } else if let Some(code) = exit_status.code() { [INFO] [stderr] 85 | println!("Command returned non-zero exit status {}!", code); [INFO] [stderr] 86 | } else { [INFO] [stderr] 87 | println!("Command returned with unknown exit status!"); [INFO] [stderr] 88 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/server/hyperap.rs:84:28 [INFO] [stderr] | [INFO] [stderr] 84 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 85 | | if let Some(code) = exit_status.code() { [INFO] [stderr] 86 | | println!("Command returned non-zero exit status {}!", code); [INFO] [stderr] 87 | | } else { [INFO] [stderr] 88 | | println!("Command returned with unknown exit status!"); [INFO] [stderr] 89 | | } [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 84 | } else if let Some(code) = exit_status.code() { [INFO] [stderr] 85 | println!("Command returned non-zero exit status {}!", code); [INFO] [stderr] 86 | } else { [INFO] [stderr] 87 | println!("Command returned with unknown exit status!"); [INFO] [stderr] 88 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _server =` [INFO] [stderr] --> src/server/hyperap.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | let _server = server.run().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/server/hyperap.rs:102:24 [INFO] [stderr] | [INFO] [stderr] 102 | fn matched_index(v: &Vec>, i: usize, method: Method, path: String) -> usize where D: HyperapCore + 'static { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Route]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/server/hyperap.rs:128:56 [INFO] [stderr] | [INFO] [stderr] 128 | } else if matched_index >= (self.routes).len() { [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 129 | | self.app.middleware(req, Arc::new(D::default_route).clone(), Arc::new(None)) [INFO] [stderr] 130 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/server/hyperap.rs:126:37 [INFO] [stderr] | [INFO] [stderr] 126 | if (self.routes).len() == 0 { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 127 | | self.app.middleware(req, Arc::new(D::default_route).clone(), Arc::new(None)) [INFO] [stderr] 128 | | } else if matched_index >= (self.routes).len() { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/server/hyperap.rs:126:12 [INFO] [stderr] | [INFO] [stderr] 126 | if (self.routes).len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `(self.routes).is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `hyperap`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _server =` [INFO] [stderr] --> src/server/hyperap.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | let _server = server.run().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/server/hyperap.rs:102:24 [INFO] [stderr] | [INFO] [stderr] 102 | fn matched_index(v: &Vec>, i: usize, method: Method, path: String) -> usize where D: HyperapCore + 'static { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Route]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/server/hyperap.rs:128:56 [INFO] [stderr] | [INFO] [stderr] 128 | } else if matched_index >= (self.routes).len() { [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 129 | | self.app.middleware(req, Arc::new(D::default_route).clone(), Arc::new(None)) [INFO] [stderr] 130 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/server/hyperap.rs:126:37 [INFO] [stderr] | [INFO] [stderr] 126 | if (self.routes).len() == 0 { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 127 | | self.app.middleware(req, Arc::new(D::default_route).clone(), Arc::new(None)) [INFO] [stderr] 128 | | } else if matched_index >= (self.routes).len() { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/server/hyperap.rs:126:12 [INFO] [stderr] | [INFO] [stderr] 126 | if (self.routes).len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `(self.routes).is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `hyperap`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0482d163c07848beab2f4ac900f32c817a9f7e441dd3f8e4f0405e5b9458b94a"` [INFO] running `"docker" "rm" "-f" "0482d163c07848beab2f4ac900f32c817a9f7e441dd3f8e4f0405e5b9458b94a"` [INFO] [stdout] 0482d163c07848beab2f4ac900f32c817a9f7e441dd3f8e4f0405e5b9458b94a